Attention is currently required from: dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34077 )
Change subject: SGSN_Tests: add missing RIM ROUTING ADDRESS field in request
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34077/comment/f8d88b69_bbab…
PS1, Line 13:
AFAIU the spec you are mentioning clearly states the opposite: Those are OPTIONAL.
It even says:
"""
If RIM Routing Address Discriminator IE is not included, the RIM Routing Address shall be processed as an RNC identifier, or as if "RIM Routing Address discriminator = 0001".
"""
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34077
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id944c66f28d787a18c6c6f7c9dc885997d83e94c
Gerrit-Change-Number: 34077
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 04 Aug 2023 15:53:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34076 )
Change subject: GTP_Templates: add function to encode RIM_Routing_Address_GTPC
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
You could add a decode function while at it, I assume we'll also need it?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34076
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I45d1f5b019f3847fd611c38dc19d78d6fe027c5a
Gerrit-Change-Number: 34076
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 04 Aug 2023 15:51:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge, fixeria, daniel.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34057 )
Change subject: stream: Split cli/srv specific code out of stream.c
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> are we sure this re-factoring doesn't clash with ongoing osmo_io work? We should always avoid to do […]
Most of the io work was already merged, at least the initial big commits, so I expect minimal crash now.
In any case, I'm also doing a lot of ongoing work now in order to improve libosmo-sccp Primary Address on top of this commit. I think I already provided a big amount of time (lots of weeks, even months?) to get whatever work there merged.
Furthermore, this split should also make it easier to submit new patches regarding io in the future.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34057
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I22af01bba2040eb320ba48fd1b46c090c98be159
Gerrit-Change-Number: 34057
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 04 Aug 2023 15:48:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-netif/+/34078
to look at the new patch set (#2).
Change subject: stream_srv: Handle ESHUTDOWN and other write() errors destroying the socket
......................................................................
stream_srv: Handle ESHUTDOWN and other write() errors destroying the socket
If internal send() fails with a fatal error, it should destroy the
socket. The user will know about the event through the close_cb() called
during osmo_stream_srv_destroy().
As a result, the socket is not closed when receiving SHUTDOWN by the
peer (through SCTP MSG_NOTIFICATION), but keep it alive since the socket
can still keep receiving data from the peer. Only fail if write() to
that read-only socket is attempted.
Related: OS#6134
Change-Id: I84ddebabdffe47733cb529bcfebec8757e6a172b
---
M src/stream_srv.c
1 file changed, 34 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/78/34078/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34078
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I84ddebabdffe47733cb529bcfebec8757e6a172b
Gerrit-Change-Number: 34078
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset