August 2023 - gerrit-log - lists.osmocom.org

[S] Change in docker-playground[master]: hnbgw: fixup: with-pfcp cfg: missing 'pfcp' section

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34126 ) Change subject: hnbgw: fixup: with-pfcp cfg: missing 'pfcp' section ...................................................................... hnbgw: fixup: with-pfcp cfg: missing 'pfcp' section Change-Id: I02be7c857d7dbf032bcadbea0812af732d27784f --- M ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: neels: Looks good to me, approved; Verified diff --git a/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg b/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg index 9ff6fe7..1d11602 100644 --- a/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg +++ b/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg @@ -73,6 +73,11 @@ mgw remote-ip 172.18.35.203 # don't spam RANAP RESET messages for up to eight CN links across all tests timer hnbgw T4 60 + pfcp + remote-addr 172.18.35.203 + local-addr 172.18.35.20 + # so far HNBGW_Tests.ttcn does not heed the port an Assoc Setup Req came from, it always responds to port 8805 + local-port 8805 # send PFCP Assoc Setup Req more often timer pfcp x26 5 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34126 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I02be7c857d7dbf032bcadbea0812af732d27784f Gerrit-Change-Number: 34126 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: merged

2 years

1
0
0 0

[S] Change in docker-playground[master]: hnbgw: fixup: with-pfcp cfg: missing 'pfcp' section

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34126 ) Change subject: hnbgw: fixup: with-pfcp cfg: missing 'pfcp' section ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34126 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I02be7c857d7dbf032bcadbea0812af732d27784f Gerrit-Change-Number: 34126 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 10 Aug 2023 01:25:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in docker-playground[master]: hnbgw: fixup: with-pfcp cfg: missing 'pfcp' section

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/34126 ) Change subject: hnbgw: fixup: with-pfcp cfg: missing 'pfcp' section ...................................................................... hnbgw: fixup: with-pfcp cfg: missing 'pfcp' section Change-Id: I02be7c857d7dbf032bcadbea0812af732d27784f --- M ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/26/34126/1 diff --git a/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg b/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg index 9ff6fe7..1d11602 100644 --- a/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg +++ b/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg @@ -73,6 +73,11 @@ mgw remote-ip 172.18.35.203 # don't spam RANAP RESET messages for up to eight CN links across all tests timer hnbgw T4 60 + pfcp + remote-addr 172.18.35.203 + local-addr 172.18.35.20 + # so far HNBGW_Tests.ttcn does not heed the port an Assoc Setup Req came from, it always responds to port 8805 + local-port 8805 # send PFCP Assoc Setup Req more often timer pfcp x26 5 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34126 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I02be7c857d7dbf032bcadbea0812af732d27784f Gerrit-Change-Number: 34126 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years

1
0
0 0

[S] Change in docker-playground[master]: hnbgw: fixup: with-pfcp cfg: set missing x26 timer

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34125 ) Change subject: hnbgw: fixup: with-pfcp cfg: set missing x26 timer ...................................................................... hnbgw: fixup: with-pfcp cfg: set missing x26 timer Change-Id: Id9af3f99dedcc04424793560b171e595b88af0d7 --- M ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, approved; Verified diff --git a/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg b/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg index 377fad8..9ff6fe7 100644 --- a/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg +++ b/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg @@ -73,6 +73,8 @@ mgw remote-ip 172.18.35.203 # don't spam RANAP RESET messages for up to eight CN links across all tests timer hnbgw T4 60 + # send PFCP Assoc Setup Req more often + timer pfcp x26 5 msc 0 remote-addr msc-naught -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34125 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id9af3f99dedcc04424793560b171e595b88af0d7 Gerrit-Change-Number: 34125 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

2 years

1
0
0 0

[S] Change in docker-playground[master]: hnbgw: fixup: with-pfcp cfg: set missing x26 timer

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34125 ) Change subject: hnbgw: fixup: with-pfcp cfg: set missing x26 timer ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34125 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id9af3f99dedcc04424793560b171e595b88af0d7 Gerrit-Change-Number: 34125 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Aug 2023 00:45:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in docker-playground[master]: hnbgw: fixup: with-pfcp cfg: set missing x26 timer

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/34125 ) Change subject: hnbgw: fixup: with-pfcp cfg: set missing x26 timer ...................................................................... hnbgw: fixup: with-pfcp cfg: set missing x26 timer Change-Id: Id9af3f99dedcc04424793560b171e595b88af0d7 --- M ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/25/34125/1 diff --git a/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg b/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg index 377fad8..9ff6fe7 100644 --- a/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg +++ b/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg @@ -73,6 +73,8 @@ mgw remote-ip 172.18.35.203 # don't spam RANAP RESET messages for up to eight CN links across all tests timer hnbgw T4 60 + # send PFCP Assoc Setup Req more often + timer pfcp x26 5 msc 0 remote-addr msc-naught -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34125 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id9af3f99dedcc04424793560b171e595b88af0d7 Gerrit-Change-Number: 34125 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years

1
0
0 0

[S] Change in libosmo-gprs[master]: rlcmac: l1ctl_prim: add 'start_rfn' field to cfg_{ul,dl}_tbf_req

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33230 ) Change subject: rlcmac: l1ctl_prim: add 'start_rfn' field to cfg_{ul,dl}_tbf_req ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33230 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I27a7a896fe3839fa4f9b8cd9500c4ab7867bbaa0 Gerrit-Change-Number: 33230 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Wed, 09 Aug 2023 18:31:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in libosmocore[master]: cosmetic: lapdm: Fix typo in comment

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34123 ) Change subject: cosmetic: lapdm: Fix typo in comment ...................................................................... cosmetic: lapdm: Fix typo in comment Change-Id: I5cf9aea6ba072bd1ccb3e894c0a311844bcad8df --- M src/gsm/rsl.c 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/gsm/rsl.c b/src/gsm/rsl.c index 3668cea..fbba982 100644 --- a/src/gsm/rsl.c +++ b/src/gsm/rsl.c @@ -553,7 +553,7 @@ /* construct a RSLms RLL message (DATA INDICATION, UNIT DATA * INDICATION) and send it off via RSLms */ - /* Push the L3 IE tag and lengh */ + /* Push the L3 IE tag and length */ msgb_tv16_push(msg, RSL_IE_L3_INFO, l3_len); /* Then push the RSL header */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5cf9aea6ba072bd1ccb3e894c0a311844bcad8df Gerrit-Change-Number: 34123 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years

1
0
0 0

[S] Change in libosmocore[master]: tlv: Introduce API msgb_tv32_push()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34124 ) Change subject: tlv: Introduce API msgb_tv32_push() ...................................................................... Patch Set 1: (1 comment) File include/osmocom/gsm/tlv.h: https://gerrit.osmocom.org/c/libosmocore/+/34124/comment/22ffc255_35eba5bc PS1, Line 464: 5 > `1 + sizeof(val)` yeah I just wanted to keep it inline with msgb_tv16_push -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34124 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I68d5693a18d55ce8d0647359044157d7e5bfae50 Gerrit-Change-Number: 34124 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Aug 2023 18:30:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in osmocom-bb[master]: l1ctl: Fill ph_data_param fn field

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34115 ) Change subject: l1ctl: Fill ph_data_param fn field ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/34115/comment/60aea3de_86119f98 PS1, Line 7: Fill ph_data_param fn field > Should have been noted in the commit message that the current LAPDm implementation makes no use of t […] that will change soon hopefully, already WIP :D -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34115 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3317296b2bda1088a2af81ba9b135714f8393afd Gerrit-Change-Number: 34115 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 09 Aug 2023 18:29:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2023