August 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: tlv: Introduce API msgb_tv32_push()

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34124 ) Change subject: tlv: Introduce API msgb_tv32_push() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File include/osmocom/gsm/tlv.h: https://gerrit.osmocom.org/c/libosmocore/+/34124/comment/73f6c4d7_336b59c8 PS1, Line 464: 5 `1 + sizeof(val)` -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34124 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I68d5693a18d55ce8d0647359044157d7e5bfae50 Gerrit-Change-Number: 34124 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Aug 2023 18:25:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in libosmocore[master]: cosmetic: lapdm: Fix typo in comment

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34123 ) Change subject: cosmetic: lapdm: Fix typo in comment ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5cf9aea6ba072bd1ccb3e894c0a311844bcad8df Gerrit-Change-Number: 34123 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Aug 2023 18:18:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in osmocom-bb[master]: l1ctl: Fill ph_data_param fn field

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34115 ) Change subject: l1ctl: Fill ph_data_param fn field ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/34115/comment/41f070cc_36dffcfc PS1, Line 7: Fill ph_data_param fn field Should have been noted in the commit message that the current LAPDm implementation makes no use of this field (it's only used for RACH) and the upper layers on top of LAPDm will get no access to the Fn value filled in here. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34115 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3317296b2bda1088a2af81ba9b135714f8393afd Gerrit-Change-Number: 34115 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 09 Aug 2023 18:16:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in libosmocore[master]: cosmetic: lapdm: Fix typo in comment

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/34123 ) Change subject: cosmetic: lapdm: Fix typo in comment ...................................................................... cosmetic: lapdm: Fix typo in comment Change-Id: I5cf9aea6ba072bd1ccb3e894c0a311844bcad8df --- M src/gsm/rsl.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/23/34123/1 diff --git a/src/gsm/rsl.c b/src/gsm/rsl.c index 3668cea..fbba982 100644 --- a/src/gsm/rsl.c +++ b/src/gsm/rsl.c @@ -553,7 +553,7 @@ /* construct a RSLms RLL message (DATA INDICATION, UNIT DATA * INDICATION) and send it off via RSLms */ - /* Push the L3 IE tag and lengh */ + /* Push the L3 IE tag and length */ msgb_tv16_push(msg, RSL_IE_L3_INFO, l3_len); /* Then push the RSL header */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5cf9aea6ba072bd1ccb3e894c0a311844bcad8df Gerrit-Change-Number: 34123 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years

1
0
0 0

[S] Change in libosmocore[master]: tlv: Introduce API msgb_tv32_push()

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/34124 ) Change subject: tlv: Introduce API msgb_tv32_push() ...................................................................... tlv: Introduce API msgb_tv32_push() msgb_tv32_put() already exists, but msgb_tv32_push doesn't. The tv16 counterparts are already present, and having to pass 32bit integers is also quite common, so let's add an API for it. Change-Id: I68d5693a18d55ce8d0647359044157d7e5bfae50 --- M TODO-RELEASE M include/osmocom/gsm/tlv.h 2 files changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/24/34124/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index acd1a61..f78104e 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -17,3 +17,4 @@ libosmogsm MODIFY osmo_auth_impl callback function signature change. No known external users libosmogsm ADD osmo_auth_c2 libosmogsm ADD OSMO_AUTH_ALG_TUAK +libosmogsm ADD new API msgb_tv32_push() \ No newline at end of file diff --git a/include/osmocom/gsm/tlv.h b/include/osmocom/gsm/tlv.h index fd6659c..28e897d 100644 --- a/include/osmocom/gsm/tlv.h +++ b/include/osmocom/gsm/tlv.h @@ -457,6 +457,16 @@ return buf; } +/*! push (prepend) a TV32 field to a \ref msgb + * \returns pointer to first byte of newly-pushed information */ +static inline uint8_t *msgb_tv32_push(struct msgb *msg, uint8_t tag, uint32_t val) +{ + uint8_t *buf = msgb_push(msg, 5); + *buf++ = tag; + osmo_store32be(val, buf); + return buf; +} + /*! push (prepend) a TvLV field to a \ref msgb * \returns pointer to first byte of newly-pushed information */ static inline uint8_t *msgb_tvlv_push(struct msgb *msg, uint8_t tag, uint16_t len, -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34124 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I68d5693a18d55ce8d0647359044157d7e5bfae50 Gerrit-Change-Number: 34124 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years

1
0
0 0

[S] Change in osmo-bts[master]: pcuif_proto: remove unnecessary members from gsm_pcu_if_data_cnf_dt

by pespin

Attention is currently required from: laforge, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34105 ) Change subject: pcuif_proto: remove unnecessary members from gsm_pcu_if_data_cnf_dt ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I'm not sure if the 'msg_id' is really sufficient. […] a msg_id assigned by PCU is certainly enough, since it's the PCU taking care of internally keeping some lookup table between that msg_id and whatever information it may deem necessary, be it a tlli, an fn, a pointer or whatever. The exact point is that the actual implementation matching the PCUIF message ends up in osmo-pcu and can be changed/improved at any point as needed. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34105 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I779605858648e2a1c202c37e197a6e32e6ea3786 Gerrit-Change-Number: 34105 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Aug 2023 16:28:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in osmo-bts[master]: pcu_sock: get rid of fn parameter in pcu_tx_pch_data_cnf

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34104 ) Change subject: pcu_sock: get rid of fn parameter in pcu_tx_pch_data_cnf ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: matching by bts+trx+ts+fn may be an option too, but I think far more complex than osmo-pcu assigning a msg_id (seqnr) to each request and keeping them in a list until confirmation comes back. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34104 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id1c8fa77725129ec2ea7e92e1df493f35a277659 Gerrit-Change-Number: 34104 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Aug 2023 16:26:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in osmo-sgsn[master]: sgsn_rim: get rid of MME check in sgsn_rim_rx_from_gtp:

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/34120 ) Change subject: sgsn_rim: get rid of MME check in sgsn_rim_rx_from_gtp: ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Ok, so after looking at all the patches I find out that actually the reason is because the checks are being done on a src_addr which is inside the container and which shouldn't really be looked at by the SGSN since it shouldn't be decoding the container. ^ That's the real reason AFAIU, so please update the commit description explaining that. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/34120 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I97c89aeb11537ae54d1fbea48c75619d8a92af61 Gerrit-Change-Number: 34120 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Aug 2023 16:24:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years

1
0
0 0

[M] Change in osmo-sgsn[master]: sgsn_rim: forward message based on RIM ROUTING ADDRESS

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/34122 ) Change subject: sgsn_rim: forward message based on RIM ROUTING ADDRESS ...................................................................... Patch Set 1: (3 comments) File src/sgsn/sgsn_libgtp.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/34122/comment/ff780a92_1e87046e PS1, Line 707: if (gtpie_gettlv(ie, GTPIE_RIM_RA_DISCR, 0, &rim_ra_encoded_len, rim_ra_encoded, can you move thisgtpie_gettlv() call to be "rc = ..." before the if? I didn't see it was filling some data first, not only checking presence. https://gerrit.osmocom.org/c/osmo-sgsn/+/34122/comment/a4402f42_7ece8d67 PS1, Line 714: rim_ra_encoded[0] = BSSGP_RIM_ROUTING_INFO_UTRAN; why are you using an array in here? we have no packed struct explaining what is this buffer? https://gerrit.osmocom.org/c/osmo-sgsn/+/34122/comment/e01d6f0e_53938e64 PS1, Line 715: } rim_ra_encoded++; -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/34122 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ifd2b915ed2f05130cff8ee77714b82005c17de3d Gerrit-Change-Number: 34122 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Aug 2023 16:23:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in osmo-sgsn[master]: sgsn_rim: do not check the origin of a RIM message

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/34121 ) Change subject: sgsn_rim: do not check the origin of a RIM message ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I think it is still nice to do checks on stuff being received from an MME. Maybe the point would be to split the paths between stuff coming from MME and from other SGSNs (Inter-SGSN HO), with the MME paths having the specific validations. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/34121 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iea8176dcfe64c25d207bafc0ef61ca9d9ad415be Gerrit-Change-Number: 34121 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Aug 2023 16:12:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2023