Attention is currently required from: dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/34120 )
Change subject: sgsn_rim: get rid of MME check in sgsn_rim_rx_from_gtp:
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
So in here you are basically dropping a feature which is making sure the source addresses are checked or being able to filter them based on source address on the config file.
Why are you dropping this feature?
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/34120
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I97c89aeb11537ae54d1fbea48c75619d8a92af61
Gerrit-Change-Number: 34120
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 09 Aug 2023 16:10:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34113 )
Change subject: socket: Add osmo_sock_init flag to enable SCTP ASCONF features
......................................................................
Patch Set 2:
(1 comment)
File src/core/socket.c:
https://gerrit.osmocom.org/c/libosmocore/+/34113/comment/74d992d9_bbb84424
PS2, Line 709: skip
> skipping ?
I don't see much of a difference there tbh, I can change it if it looks better to you.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34113
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iac07031927b66a9d32d2bb2faab817e4c922a359
Gerrit-Change-Number: 34113
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 09 Aug 2023 16:01:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment
laforge has submitted this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/34011 )
(
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: Flush DAHDI->trunkdev FIFO at open time
......................................................................
Flush DAHDI->trunkdev FIFO at open time
If we don't do this, we always have a full FIFO at the time userspace
opens the trunkdev, adding latency for no good reason.
Change-Id: Ifbda3766309cc7d6be485073e36607bdd6742f3a
---
M drivers/dahdi/trunkdev/frame_fifo.c
M drivers/dahdi/trunkdev/frame_fifo.h
M drivers/dahdi/trunkdev/trunkdev.c
3 files changed, 26 insertions(+), 0 deletions(-)
Approvals:
manawyrm: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/drivers/dahdi/trunkdev/frame_fifo.c b/drivers/dahdi/trunkdev/frame_fifo.c
index 19b6dba..3b7732f 100644
--- a/drivers/dahdi/trunkdev/frame_fifo.c
+++ b/drivers/dahdi/trunkdev/frame_fifo.c
@@ -53,6 +53,15 @@
spin_lock_init(&fifo->lock);
}
+/*! Flush (drop) the entire content of the FIFO */
+void frame_fifo_flush(struct frame_fifo *fifo)
+{
+ unsigned long flags;
+ spin_lock_irqsave(&fifo->lock, flags);
+ fifo->next_out = fifo->next_in;
+ spin_unlock_irqrestore(&fifo->lock, flags);
+}
+
#define FIFO_BUF_END(f) ((f)->buf + sizeof((f)->buf))
/*! put one received frames into the FIFO.
diff --git a/drivers/dahdi/trunkdev/frame_fifo.h b/drivers/dahdi/trunkdev/frame_fifo.h
index af02811..b07cddc 100644
--- a/drivers/dahdi/trunkdev/frame_fifo.h
+++ b/drivers/dahdi/trunkdev/frame_fifo.h
@@ -20,6 +20,8 @@
void (*threshold_cb)(struct frame_fifo *fifo, unsigned int frames, void *priv),
void *priv);
+void frame_fifo_flush(struct frame_fifo *fifo);
+
/* number of frames currently available in FIFO */
static inline unsigned int __frame_fifo_frames(struct frame_fifo *fifo)
{
diff --git a/drivers/dahdi/trunkdev/trunkdev.c b/drivers/dahdi/trunkdev/trunkdev.c
index 5569888..1163849 100644
--- a/drivers/dahdi/trunkdev/trunkdev.c
+++ b/drivers/dahdi/trunkdev/trunkdev.c
@@ -456,6 +456,9 @@
span->alarms &= ~(ALL_RY_ALARMS|DAHDI_ALARM_LOS);
dahdi_alarm_notify(span);
spin_unlock_irqrestore(&span->lock, flags);
+ /* FIFO should be full at this point, let's flush it as now we actually
+ * have a receiver */
+ frame_fifo_flush(&td->to_trunk);
open.spanno = span->spanno;
if (copy_to_user((__user void *) data, &open, sizeof(open)))
--
To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/34011
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: dahdi-linux
Gerrit-Branch: master
Gerrit-Change-Id: Ifbda3766309cc7d6be485073e36607bdd6742f3a
Gerrit-Change-Number: 34011
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: cquirin <christoph.lauter(a)christoph-lauter.org>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-Reviewer: roox <mardnh(a)gmx.de>
Gerrit-MessageType: merged
