August 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sccp[master]: tests/vty: test multiple local/remote IP addresses

by laforge

Attention is currently required from: pespin, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34056 ) Change subject: tests/vty: test multiple local/remote IP addresses ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34056 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I9e8c6499b26edea271ee8d8c4ab86506e765e000 Gerrit-Change-Number: 34056 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Aug 2023 14:53:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in osmo-bts[master]: pcuif_proto: remove unnecessary members from gsm_pcu_if_data_cnf_dt

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34105 ) Change subject: pcuif_proto: remove unnecessary members from gsm_pcu_if_data_cnf_dt ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I'm not sure if the 'msg_id' is really sufficient. AFAIR, Ericsson RBS actually use the TLLI in their confirmation. And if there are situations where the TLLI itself is not unique, the (fn, tlli) tuple is certainly unique? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34105 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I779605858648e2a1c202c37e197a6e32e6ea3786 Gerrit-Change-Number: 34105 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Aug 2023 14:52:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years

1
0
0 0

[M] Change in osmo-bts[master]: pcuif_proto: rename tlli to msg_id

by laforge

Attention is currently required from: pespin, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34103 ) Change subject: pcuif_proto: rename tlli to msg_id ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I think this might be related to how ericsson RBS are doing the confirm in their propretary RSL extension. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34103 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie6b34d5df64f4bed6b14581c7957dcba6af44136 Gerrit-Change-Number: 34103 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Aug 2023 14:50:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in osmo-bts[master]: pcu_sock: get rid of fn parameter in pcu_tx_pch_data_cnf

by laforge

Attention is currently required from: pespin, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34104 ) Change subject: pcu_sock: get rid of fn parameter in pcu_tx_pch_data_cnf ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I think this might be related to how ericsson RBS are doing the confirm in their propretary RSL extension. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34104 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id1c8fa77725129ec2ea7e92e1df493f35a277659 Gerrit-Change-Number: 34104 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Aug 2023 14:50:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in osmo-bts[master]: pcu_sock: get rid of fn parameter in pcu_tx_pch_data_cnf

by laforge

Attention is currently required from: pespin, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34104 ) Change subject: pcu_sock: get rid of fn parameter in pcu_tx_pch_data_cnf ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34104 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id1c8fa77725129ec2ea7e92e1df493f35a277659 Gerrit-Change-Number: 34104 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Aug 2023 14:49:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[M] Change in osmo-bts[master]: pcuif_proto: rename tlli to msg_id

by laforge

Attention is currently required from: pespin, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34103 ) Change subject: pcuif_proto: rename tlli to msg_id ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34103 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie6b34d5df64f4bed6b14581c7957dcba6af44136 Gerrit-Change-Number: 34103 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Aug 2023 14:49:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in libosmocore[master]: osmo_io: Use MSG_NOSIGNAL to avoid SIGPIPE on write

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34099 ) Change subject: osmo_io: Use MSG_NOSIGNAL to avoid SIGPIPE on write ...................................................................... osmo_io: Use MSG_NOSIGNAL to avoid SIGPIPE on write Change-Id: I85433124a8e80fc2aa19b551bdaf2655ef1eea2c --- M src/core/osmo_io.c 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index f9d04fd..db1b5ad 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -321,7 +321,7 @@ if (!msghdr) return -ENOMEM; - msghdr->flags = 0; + msghdr->flags = MSG_NOSIGNAL; msghdr->iov[0].iov_base = msgb_data(msghdr->msg); msghdr->iov[0].iov_len = msgb_length(msghdr->msg); msghdr->hdr.msg_iov = &msghdr->iov[0]; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34099 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I85433124a8e80fc2aa19b551bdaf2655ef1eea2c Gerrit-Change-Number: 34099 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years

1
0
0 0

[S] Change in libosmocore[master]: osmo_io: Use MSG_NOSIGNAL to avoid SIGPIPE on write

by laforge

Attention is currently required from: daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34099 ) Change subject: osmo_io: Use MSG_NOSIGNAL to avoid SIGPIPE on write ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34099 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I85433124a8e80fc2aa19b551bdaf2655ef1eea2c Gerrit-Change-Number: 34099 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Aug 2023 14:48:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in libosmocore[master]: gprs_bssgp_rim: allow sending of encoded RIM messages

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34117 ) Change subject: gprs_bssgp_rim: allow sending of encoded RIM messages ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34117 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id4a793bbaf32d7b9d894dcc5be3faaf2f2d91d82 Gerrit-Change-Number: 34117 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Aug 2023 14:48:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in osmo-sgsn[master]: sgsn_rim: fix typo

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/34118 ) Change subject: sgsn_rim: fix typo ...................................................................... sgsn_rim: fix typo Related: OS#6095 Change-Id: I86f70ea9a1a3e43523ec327165bfeb1737ad300a --- M src/sgsn/sgsn_rim.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/18/34118/1 diff --git a/src/sgsn/sgsn_rim.c b/src/sgsn/sgsn_rim.c index 57f6ea7..07eff6b 100644 --- a/src/sgsn/sgsn_rim.c +++ b/src/sgsn/sgsn_rim.c @@ -89,7 +89,7 @@ return -1; } -/* Receive a RIM PDU from GTPvC1 (EUTRAN) */ +/* Receive a RIM PDU from GTPv1C (EUTRAN) */ int sgsn_rim_rx_from_gtp(struct bssgp_ran_information_pdu *pdu, struct sgsn_mme_ctx *mme) { struct sgsn_mme_ctx *mme_tmp; -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/34118 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I86f70ea9a1a3e43523ec327165bfeb1737ad300a Gerrit-Change-Number: 34118 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2023