July 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-msc[master]: ran_a_channel_type_to_speech_codec_list(): set PI/PT for CSD
by fixeria 25 Jul '23

25 Jul '23

Attention is currently required from: fixeria. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/33915 to look at the new patch set (#2). Change subject: ran_a_channel_type_to_speech_codec_list(): set PI/PT for CSD ...................................................................... ran_a_channel_type_to_speech_codec_list(): set PI/PT for CSD As per 3GPP TS 48.008, section 3.2.2.103, the Codec Type is valid if at least one of FI, PI or PT is set to '1'. Otherwise the Speech Codec Element is considered invalid and shall be ignored. Change-Id: Ibc452d37d4215c961a7946eef3ba2e7efdba078b Related: OS#6110, OS#4394 --- M src/libmsc/ran_msg_a.c 1 file changed, 20 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/15/33915/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33915 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ibc452d37d4215c961a7946eef3ba2e7efdba078b Gerrit-Change-Number: 33915 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in libosmo-netif[master]: stream: Fix osmo_panic log fmts
by arehbein 25 Jul '23

25 Jul '23

Attention is currently required from: arehbein, laforge, daniel. Hello Jenkins Builder, laforge, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/33206 to look at the new patch set (#10). Change subject: stream: Fix osmo_panic log fmts ...................................................................... stream: Fix osmo_panic log fmts Change-Id: Id082a9473b788f8de20cdc2ba4430b3289f4ce5a --- M src/stream.c 1 file changed, 16 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/06/33206/10 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33206 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Id082a9473b788f8de20cdc2ba4430b3289f4ce5a Gerrit-Change-Number: 33206 Gerrit-PatchSet: 10 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in libosmocore[master]: gsm_08_08: define GSM0808_SCT_EXT (separately)
by pespin 25 Jul '23

25 Jul '23

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33911 ) Change subject: gsm_08_08: define GSM0808_SCT_EXT (separately) ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33911 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iafaa25070684d2ba400c75fa33e803651a5ce857 Gerrit-Change-Number: 33911 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jul 2023 11:35:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: gsm_08_08: define GSM0808_SCT_EXT (separately)
by fixeria 25 Jul '23

25 Jul '23

Attention is currently required from: osmith, fixeria. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33911 ) Change subject: gsm_08_08: define GSM0808_SCT_EXT (separately) ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33911 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iafaa25070684d2ba400c75fa33e803651a5ce857 Gerrit-Change-Number: 33911 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jul 2023 11:22:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: ran_a_mgcp_codec_from_sc(): map GSM0808_SCT_CSD to CODEC_CLEARMODE
by fixeria 25 Jul '23

25 Jul '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33914 ) Change subject: ran_a_mgcp_codec_from_sc(): map GSM0808_SCT_CSD to CODEC_CLEARMODE ...................................................................... ran_a_mgcp_codec_from_sc(): map GSM0808_SCT_CSD to CODEC_CLEARMODE Change-Id: I4095124be8ffb293863f35bea440cd465048a9fd Related: OS#6110, OS#4394 --- M src/libmsc/ran_msg_a.c 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved osmith: Looks good to me, approved diff --git a/src/libmsc/ran_msg_a.c b/src/libmsc/ran_msg_a.c index 37acedb..3788805 100644 --- a/src/libmsc/ran_msg_a.c +++ b/src/libmsc/ran_msg_a.c @@ -254,6 +254,8 @@ return CODEC_AMRWB_16000_1; case GSM0808_SCT_HR6: return CODEC_AMRWB_16000_1; + case GSM0808_SCT_CSD: + return CODEC_CLEARMODE; default: return CODEC_PCMU_8000_1; } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33914 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I4095124be8ffb293863f35bea440cd465048a9fd Gerrit-Change-Number: 33914 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-msc[master]: ran_a_mgcp_codec_from_sc(): cosmetic: remove unneeded breaks
by fixeria 25 Jul '23

25 Jul '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33913 ) Change subject: ran_a_mgcp_codec_from_sc(): cosmetic: remove unneeded breaks ...................................................................... ran_a_mgcp_codec_from_sc(): cosmetic: remove unneeded breaks Change-Id: I23d94c2d81c929deb819c02f4ddac3a702a3867d Related: OS#6110, OS#4394 --- M src/libmsc/ran_msg_a.c 1 file changed, 10 insertions(+), 10 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved osmith: Looks good to me, approved diff --git a/src/libmsc/ran_msg_a.c b/src/libmsc/ran_msg_a.c index d2ab09f..37acedb 100644 --- a/src/libmsc/ran_msg_a.c +++ b/src/libmsc/ran_msg_a.c @@ -238,34 +238,24 @@ switch (sc->type) { case GSM0808_SCT_FR1: return CODEC_GSM_8000_1; - break; case GSM0808_SCT_FR2: return CODEC_GSMEFR_8000_1; - break; case GSM0808_SCT_FR3: return CODEC_AMR_8000_1; - break; case GSM0808_SCT_FR4: return CODEC_AMRWB_16000_1; - break; case GSM0808_SCT_FR5: return CODEC_AMRWB_16000_1; - break; case GSM0808_SCT_HR1: return CODEC_GSMHR_8000_1; - break; case GSM0808_SCT_HR3: return CODEC_AMR_8000_1; - break; case GSM0808_SCT_HR4: return CODEC_AMRWB_16000_1; - break; case GSM0808_SCT_HR6: return CODEC_AMRWB_16000_1; - break; default: return CODEC_PCMU_8000_1; - break; } } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33913 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I23d94c2d81c929deb819c02f4ddac3a702a3867d Gerrit-Change-Number: 33913 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-hnodeb[master]: rua: Fix null ptr access in hnb->llsk.srv
by fixeria 25 Jul '23

25 Jul '23

Attention is currently required from: iedemam, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/33917 ) Change subject: rua: Fix null ptr access in hnb->llsk.srv ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/33917 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I32d8f91b2fc5401ace386e1085c248476228cd18 Gerrit-Change-Number: 33917 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jul 2023 11:17:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: debian-bullseye-titan-*/Dockerfile: Replace inetutils-ping with iputi...
by pespin 25 Jul '23

25 Jul '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/33918 ) Change subject: debian-bullseye-titan-*/Dockerfile: Replace inetutils-ping with iputils-ping ...................................................................... debian-bullseye-titan-*/Dockerfile: Replace inetutils-ping with iputils-ping The inetutils-ping ping lacks the -I param required by ttcn3-pgw-test. Change-Id: If11a1c2ae1115b585b6a44a45e9569c16856d8c4 --- M debian-bullseye-titan-master/Dockerfile M debian-bullseye-titan/Dockerfile 2 files changed, 13 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/18/33918/1 diff --git a/debian-bullseye-titan-master/Dockerfile b/debian-bullseye-titan-master/Dockerfile index 1acfb73..a7ec65d 100644 --- a/debian-bullseye-titan-master/Dockerfile +++ b/debian-bullseye-titan-master/Dockerfile @@ -18,7 +18,7 @@ DEBIAN_FRONTEND='noninteractive' apt-get install -y --no-install-recommends --no-install-suggests \ build-essential \ git \ - inetutils-ping \ + iputils-ping \ netcat-openbsd \ procps \ python3-pip \ diff --git a/debian-bullseye-titan/Dockerfile b/debian-bullseye-titan/Dockerfile index 7bf180f..2274cc4 100644 --- a/debian-bullseye-titan/Dockerfile +++ b/debian-bullseye-titan/Dockerfile @@ -23,7 +23,7 @@ DEBIAN_FRONTEND='noninteractive' apt-get install -y --no-install-recommends --no-install-suggests \ build-essential \ git \ - inetutils-ping \ + iputils-ping \ netcat-openbsd \ procps \ python3-pip \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33918 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If11a1c2ae1115b585b6a44a45e9569c16856d8c4 Gerrit-Change-Number: 33918 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-hnodeb[master]: rua: Fix null ptr access in hnb->llsk.srv
by osmith 25 Jul '23

25 Jul '23

Attention is currently required from: iedemam, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/33917 ) Change subject: rua: Fix null ptr access in hnb->llsk.srv ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/33917 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I32d8f91b2fc5401ace386e1085c248476228cd18 Gerrit-Change-Number: 33917 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jul 2023 10:18:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: ran_a_mgcp_codec_from_sc(): map GSM0808_SCT_CSD to CODEC_CLEARMODE
by osmith 25 Jul '23

25 Jul '23

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33914 ) Change subject: ran_a_mgcp_codec_from_sc(): map GSM0808_SCT_CSD to CODEC_CLEARMODE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33914 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I4095124be8ffb293863f35bea440cd465048a9fd Gerrit-Change-Number: 33914 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jul 2023 10:11:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0