July 2023 - gerrit-log - lists.osmocom.org

[S] Change in docker-playground[master]: debian-bullseye-titan-*/Dockerfile: Replace inetutils-ping with iputi...
by pespin 25 Jul '23

25 Jul '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33918 ) Change subject: debian-bullseye-titan-*/Dockerfile: Replace inetutils-ping with iputils-ping ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: ttcn3-pgw-test actually doesn't require it, I confused who was running it. @osmith I still think it makes sense to have the same ping command everywhere anyway? to avoid this kind of behavior difference. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33918 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If11a1c2ae1115b585b6a44a45e9569c16856d8c4 Gerrit-Change-Number: 33918 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jul 2023 12:39:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnodeb[master]: rua: Fix null ptr access in hnb->llsk.srv
by pespin 25 Jul '23

25 Jul '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/33917 ) Change subject: rua: Fix null ptr access in hnb->llsk.srv ...................................................................... rua: Fix null ptr access in hnb->llsk.srv At startup, osmo-hnodeb connects the Iuh socket to the HNBGW, and start the LLSK unix socket link_server waiting for lower layers to connect. If for some reason the lower layers don't connect and an Iuh messages arrives which was to be forwarded to LLSK, it would try to access it without first checking if it was already available. This patch adds a check to avoid a crash when accessing the null pointer. Change-Id: I32d8f91b2fc5401ace386e1085c248476228cd18 --- M src/osmo-hnodeb/rua.c 1 file changed, 22 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/osmo-hnodeb/rua.c b/src/osmo-hnodeb/rua.c index e109ae0..d705c7c 100644 --- a/src/osmo-hnodeb/rua.c +++ b/src/osmo-hnodeb/rua.c @@ -115,6 +115,11 @@ ranap_buf_len = ies.ranaP_Message.size; LOGP(DRUA, LOGL_DEBUG, "Rx RUA UDT ranap_len=%zu\n", ranap_buf_len); + if (!hnb->llsk.srv) { + LOGP(DRUA, LOGL_NOTICE, "Discarding rx RUA UDT ranap_len=%zu due to lower layers not available\n", + ranap_buf_len); + goto free_ret; + } LOGP(DLLSK, LOGL_DEBUG, "Tx IUH-UNITDATA.ind ranap_len=%zu\n", ranap_buf_len); iuh_prim = hnb_iuh_makeprim_unitdata_ind(ranap_buf, ranap_buf_len); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/33917 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I32d8f91b2fc5401ace386e1085c248476228cd18 Gerrit-Change-Number: 33917 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmocore[master]: exec: osmo_system_nowait2(): Improve logging and error checks
by osmith 25 Jul '23

25 Jul '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33920 ) Change subject: exec: osmo_system_nowait2(): Improve logging and error checks ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33920 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9b971dda389fe958627d41fa5ba6f45ee588bf99 Gerrit-Change-Number: 33920 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jul 2023 12:27:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: ran_a_channel_type_to_speech_codec_list(): set PI/PT for CSD
by pespin 25 Jul '23

25 Jul '23

Attention is currently required from: laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33915 ) Change subject: ran_a_channel_type_to_speech_codec_list(): set PI/PT for CSD ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33915 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ibc452d37d4215c961a7946eef3ba2e7efdba078b Gerrit-Change-Number: 33915 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jul 2023 12:27:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: gsm_08_08: define GSM0808_SCT_EXT (separately)
by fixeria 25 Jul '23

25 Jul '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33911 ) Change subject: gsm_08_08: define GSM0808_SCT_EXT (separately) ...................................................................... gsm_08_08: define GSM0808_SCT_EXT (separately) As per 3GPP TS 48.008, section 3.2.2.103, the "Codec Type" field may contain either a certain 3GPP Speech Codec Type directly (4 bit value), or the so called "Codec Extension" = 0xFh, in which case the real Codec Type follows in the next octet as "Extended Codec Type". CSD is such an example, the encoding is defined as follows: 8 7 6 5 4 3 2 1 +----+----+----+----+-------------------+ | -- | PI | PT | -- | 0xFh | +----+----+----+----+-------------------+ | Extended Codec Type (CSData) | +----+----+-----------------------------+ | R2 | R3 | | +----+----+-----------------------------+ CSData is coded with 0xFDh or '1111 1101' (0xfd). Let's have the "Codec Extension" value clearly defined in the header file, but intentionally separate from the other GSM0808_SCT_* values. Change-Id: Iafaa25070684d2ba400c75fa33e803651a5ce857 Related: OS#6110, OS#4393, OS#4394 --- M include/osmocom/gsm/protocol/gsm_08_08.h M src/gsm/gsm0808.c M src/gsm/gsm0808_utils.c 3 files changed, 41 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/include/osmocom/gsm/protocol/gsm_08_08.h b/include/osmocom/gsm/protocol/gsm_08_08.h index 967e4fe..1e211dc 100644 --- a/include/osmocom/gsm/protocol/gsm_08_08.h +++ b/include/osmocom/gsm/protocol/gsm_08_08.h @@ -557,6 +557,12 @@ GSM0808_SCT_CSD = 0xfd, /*!< CSData (see also TS 26.103) */ }; +/* Codec Extension (the real Codec Type follows in the next octet). + * This value is intentionally not included in gsm0808_speech_codec_type, + * because {enc,dec}_speech_codec() functions take care of the extended + * encoding internally. It shall not be used in struct gsm0808_speech_codec. */ +#define GSM0808_SCT_EXT 0x0f + extern const struct value_string gsm0808_speech_codec_type_names[]; static inline const char *gsm0808_speech_codec_type_name(enum gsm0808_speech_codec_type val) { return get_value_string(gsm0808_speech_codec_type_names, val); } diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c index d115888..6ba6ef2 100644 --- a/src/gsm/gsm0808.c +++ b/src/gsm/gsm0808.c @@ -2478,6 +2478,7 @@ { GSM0808_SCT_HR3, "HR3" }, { GSM0808_SCT_HR4, "HR4" }, { GSM0808_SCT_HR6, "HR6" }, + { GSM0808_SCT_EXT, "Codec Extension" }, { GSM0808_SCT_CSD, "CSD" }, { 0, NULL } }; diff --git a/src/gsm/gsm0808_utils.c b/src/gsm/gsm0808_utils.c index b8e1ff0..778630d 100644 --- a/src/gsm/gsm0808_utils.c +++ b/src/gsm/gsm0808_utils.c @@ -255,7 +255,7 @@ header |= (1 << 4); if (type_extended) { - header |= 0x0f; + header |= GSM0808_SCT_EXT; msgb_put_u8(msg, header); msgb_put_u8(msg, sc->type); } else { @@ -347,7 +347,7 @@ /* An extended codec type needs at least two fields, * bail if the input data length is not sufficient. */ - if ((header & 0x0F) == 0x0F && len < 2) + if ((header & 0x0F) == GSM0808_SCT_EXT && len < 2) return -EINVAL; elem++; @@ -362,7 +362,7 @@ if (header & (1 << 4)) sc->tf = true; - if ((header & 0x0F) != 0x0F) { + if ((header & 0x0F) != GSM0808_SCT_EXT) { sc->type = (header & 0x0F); } else { sc->type = *elem; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33911 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iafaa25070684d2ba400c75fa33e803651a5ce857 Gerrit-Change-Number: 33911 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-msc[master]: codec_mapping: codec_map[]: add missing speech codec for CLEARMODE
by pespin 25 Jul '23

25 Jul '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33919 ) Change subject: codec_mapping: codec_map[]: add missing speech codec for CLEARMODE ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33919 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I87b3aedaf7ff7bbbcb381e94158566dc765e3ae6 Gerrit-Change-Number: 33919 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jul 2023 12:26:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: exec: osmo_system_nowait2(): Improve logging and error checks
by pespin 25 Jul '23

25 Jul '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/33920 ) Change subject: exec: osmo_system_nowait2(): Improve logging and error checks ...................................................................... exec: osmo_system_nowait2(): Improve logging and error checks Change-Id: I9b971dda389fe958627d41fa5ba6f45ee588bf99 --- M src/core/exec.c 1 file changed, 22 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/20/33920/1 diff --git a/src/core/exec.c b/src/core/exec.c index 6412270..2e33788 100644 --- a/src/core/exec.c +++ b/src/core/exec.c @@ -213,10 +213,18 @@ int rc; if (user) { + if (getpw_buflen == -1) /* Value was indeterminate */ + getpw_buflen = 16384; /* Should be more than enough */ char buf[getpw_buflen]; - getpwnam_r(user, &_pw, buf, sizeof(buf), &pw); - if (!pw) + rc = getpwnam_r(user, &_pw, buf, sizeof(buf), &pw); + if (rc < 0) { + LOGP(DLGLOBAL, LOGL_ERROR, "getpwnam_r(\"%s\") failed: %s\n", user, strerror(-rc)); + return rc; + } + if (!pw) { + LOGP(DLGLOBAL, LOGL_ERROR, "getpwnam_r(\"%s\"): user not found!\n", user); return -EINVAL; + } } rc = fork(); @@ -264,6 +272,9 @@ return -EIO; } else { /* we are in the parent */ + if (rc == -1) + LOGP(DLGLOBAL, LOGL_ERROR, "fork() error executing command '%s': %s\n", + command, strerror(errno)); return rc; } } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33920 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9b971dda389fe958627d41fa5ba6f45ee588bf99 Gerrit-Change-Number: 33920 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-netif[master]: stream: Fix osmo_panic log fmts
by daniel 25 Jul '23

25 Jul '23

Attention is currently required from: arehbein, laforge. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33206 ) Change subject: stream: Fix osmo_panic log fmts ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33206 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Id082a9473b788f8de20cdc2ba4430b3289f4ce5a Gerrit-Change-Number: 33206 Gerrit-PatchSet: 10 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 25 Jul 2023 12:23:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: ran_a_channel_type_to_speech_codec_list(): set PI/PT for CSD
by fixeria 25 Jul '23

25 Jul '23

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33915 ) Change subject: ran_a_channel_type_to_speech_codec_list(): set PI/PT for CSD ...................................................................... Patch Set 1: (1 comment) File src/libmsc/ran_msg_a.c: https://gerrit.osmocom.org/c/osmo-msc/+/33915/comment/f12a80a8_cac083aa PS1, Line 1354: . > this is false. We don't support CSDoTDM, as we don't have a ciruit-switched A interface. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33915 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ibc452d37d4215c961a7946eef3ba2e7efdba078b Gerrit-Change-Number: 33915 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 25 Jul 2023 12:21:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: codec_mapping: codec_map[]: add missing speech codec for CLEARMODE
by fixeria 25 Jul '23

25 Jul '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/33919 ) Change subject: codec_mapping: codec_map[]: add missing speech codec for CLEARMODE ...................................................................... codec_mapping: codec_map[]: add missing speech codec for CLEARMODE Without the gsm0808_speech_codec functions: * codec_mapping_by_gsm0808_speech_codec_type(), and * codec_mapping_by_gsm0808_speech_codec() fail to find the codec mapping for CLEARMODE. Change-Id: I87b3aedaf7ff7bbbcb381e94158566dc765e3ae6 Related: OS#6110, OS#4394 --- M src/libmsc/codec_mapping.c 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/19/33919/1 diff --git a/src/libmsc/codec_mapping.c b/src/libmsc/codec_mapping.c index b58efd9..918428a 100644 --- a/src/libmsc/codec_mapping.c +++ b/src/libmsc/codec_mapping.c @@ -209,6 +209,13 @@ .subtype_name = "CLEARMODE", .rate = 8000, }, + .has_gsm0808_speech_codec = true, + .gsm0808_speech_codec = { + .pi = true, /* PI indicates CSDoIP is supported */ + .pt = false, /* PT indicates CSDoTDM is not supported */ + .type = GSM0808_SCT_CSD, + .cfg = 0, /* R2/R3 not set (redundancy not supported) */ + }, .mgcp = CODEC_CLEARMODE, }, }; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33919 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I87b3aedaf7ff7bbbcb381e94158566dc765e3ae6 Gerrit-Change-Number: 33919 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0