July 2023 - gerrit-log - lists.osmocom.org

[S] Change in docker-playground[master]: osmo-uecups-master: make osmocom user avilable
by pespin 25 Jul '23

25 Jul '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33921 ) Change subject: osmo-uecups-master: make osmocom user avilable ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33921 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I2b29d7fedcf3e0a4c17bfbad16077098f94c529b Gerrit-Change-Number: 33921 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jul 2023 13:51:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-netif[master]: stream: Fix osmo_panic log fmts
by pespin 25 Jul '23

25 Jul '23

Attention is currently required from: arehbein, laforge, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33206 ) Change subject: stream: Fix osmo_panic log fmts ...................................................................... Patch Set 11: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33206 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Id082a9473b788f8de20cdc2ba4430b3289f4ce5a Gerrit-Change-Number: 33206 Gerrit-PatchSet: 11 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jul 2023 13:50:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: osmo-uecups-master: make osmocom user avilable
by osmith 25 Jul '23

25 Jul '23

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33921 ) Change subject: osmo-uecups-master: make osmocom user avilable ...................................................................... Patch Set 1: Verified+1 (1 comment) Patchset: PS1: https://jenkins.osmocom.org/jenkins/job/osmith-ttcn3-pgw-test/test_results_… -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33921 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I2b29d7fedcf3e0a4c17bfbad16077098f94c529b Gerrit-Change-Number: 33921 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jul 2023 12:50:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: osmo-uecups-master: make osmocom user avilable
by osmith 25 Jul '23

25 Jul '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/33921 ) Change subject: osmo-uecups-master: make osmocom user avilable ...................................................................... osmo-uecups-master: make osmocom user avilable Bring back the osmocom user that was removed earlier to fix a UID conflict with the build user. The osmocom user is being used after all, the TTCN-3 PGW tests use it to start commands as "osmocom" user in osmo-uecups-master. This lead to e.g. PGW_Tests.TC_createSession_ping4 failing. Rename the user instead of adding a new one, so it can write log files to the log dir as the same UID as the user that runs docker. Fixes: 94f8a8 ("osmo-uecups-master: remove useradd") Related: OS#6057 Change-Id: I2b29d7fedcf3e0a4c17bfbad16077098f94c529b --- M osmo-uecups-master/Dockerfile 1 file changed, 23 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/21/33921/1 diff --git a/osmo-uecups-master/Dockerfile b/osmo-uecups-master/Dockerfile index 7f30155..793fe6b 100644 --- a/osmo-uecups-master/Dockerfile +++ b/osmo-uecups-master/Dockerfile @@ -34,6 +34,8 @@ COPY osmo-uecups-daemon.cfg /data/osmo-uecups-daemon.cfg +RUN usermod -l osmocom build + WORKDIR /data CMD ["/bin/sh", "-c", "/usr/local/bin/osmo-uecups-daemon -c /data/osmo-uecups-daemon.cfg >/data/osmo-uecups-daemon.log 2>&1"] -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33921 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I2b29d7fedcf3e0a4c17bfbad16077098f94c529b Gerrit-Change-Number: 33921 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-netif[master]: stream: Fix osmo_panic log fmts
by arehbein 25 Jul '23

25 Jul '23

Attention is currently required from: laforge, pespin, daniel. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33206 ) Change subject: stream: Fix osmo_panic log fmts ...................................................................... Patch Set 11: (4 comments) Patchset: PS1: > I do wonder... […] Edited the commit message, since pespin agreed that this is not cosmetic Patchset: PS8: > Definetly not socmetic. Done File src/stream.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33206/comment/35b28891_f55a46d4 PS8, Line 613: osmo_panic("osmo_stream_cli_write_cb() called with unexpected state %d\n", cli->state); > Agreeing with Harald here, it's exactly the same length as in line 564 above which isn't wrapped. Done https://gerrit.osmocom.org/c/libosmo-netif/+/33206/comment/e0ba1e81_aeed860a PS8, Line 633: } > why the line wrap here ? having this in one line certainly doesn't exceed the permitted line length. Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33206 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Id082a9473b788f8de20cdc2ba4430b3289f4ce5a Gerrit-Change-Number: 33206 Gerrit-PatchSet: 11 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jul 2023 12:44:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: debian-bullseye-titan-*/Dockerfile: Replace inetutils-ping with iputi...
by osmith 25 Jul '23

25 Jul '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33918 ) Change subject: debian-bullseye-titan-*/Dockerfile: Replace inetutils-ping with iputils-ping ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/docker-playground/+/33918/comment/773779d8_2fa… PS1, Line 9: The inetutils-ping ping lacks the -I param required by ttcn3-pgw-test. I'd mention here that this wasn't the cause of ping failing as it's running in osmo-uecups-master instead, this just makes the installed ping implementation consistent -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33918 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If11a1c2ae1115b585b6a44a45e9569c16856d8c4 Gerrit-Change-Number: 33918 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jul 2023 12:44:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: debian-bullseye-titan-*/Dockerfile: Replace inetutils-ping with iputi...
by osmith 25 Jul '23

25 Jul '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33918 ) Change subject: debian-bullseye-titan-*/Dockerfile: Replace inetutils-ping with iputils-ping ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Patchset: PS1: > ttcn3-pgw-test actually doesn't require it, I confused who was running it. […] yes, doesn't hurt to make it consistent PS1: status of debian 12 migration of all the containers is here btw: https://osmocom.org/issues/6057 - the -titan container is not migrated yet as more important things came up. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33918 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If11a1c2ae1115b585b6a44a45e9569c16856d8c4 Gerrit-Change-Number: 33918 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jul 2023 12:43:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmo-netif[master]: stream: Fix osmo_panic log fmts
by arehbein 25 Jul '23

25 Jul '23

Attention is currently required from: arehbein, laforge. Hello Jenkins Builder, laforge, pespin, fixeria, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/33206 to look at the new patch set (#11). Change subject: stream: Fix osmo_panic log fmts ...................................................................... stream: Fix osmo_panic log fmts Change-Id: Id082a9473b788f8de20cdc2ba4430b3289f4ce5a --- M src/stream.c 1 file changed, 14 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/06/33206/11 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33206 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Id082a9473b788f8de20cdc2ba4430b3289f4ce5a Gerrit-Change-Number: 33206 Gerrit-PatchSet: 11 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-msc[master]: codec_mapping: codec_map[]: add missing speech codec for CLEARMODE
by osmith 25 Jul '23

25 Jul '23

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33919 ) Change subject: codec_mapping: codec_map[]: add missing speech codec for CLEARMODE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33919 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I87b3aedaf7ff7bbbcb381e94158566dc765e3ae6 Gerrit-Change-Number: 33919 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jul 2023 12:39:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: ran_a_channel_type_to_speech_codec_list(): set PI/PT for CSD
by osmith 25 Jul '23

25 Jul '23

Attention is currently required from: laforge, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33915 ) Change subject: ran_a_channel_type_to_speech_codec_list(): set PI/PT for CSD ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33915 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ibc452d37d4215c961a7946eef3ba2e7efdba078b Gerrit-Change-Number: 33915 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jul 2023 12:39:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0