Attention is currently required from: laforge, pespin, daniel. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33206 ) Change subject: stream: Fix osmo_panic log fmts ...................................................................... Patch Set 11: (4 comments) Patchset: PS1:

I do wonder... […] Edited the commit message, since pespin agreed that this is not cosmetic

Patchset: PS8:

Definetly not socmetic. Done

File src/stream.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33206/comment/35b28891_f55a46d4 PS8, Line 613: osmo_panic("osmo_stream_cli_write_cb() called with unexpected state %d\n", cli->state);

Agreeing with Harald here, it's exactly the same length as in line 564 above which isn't wrapped. Done

https://gerrit.osmocom.org/c/libosmo-netif/+/33206/comment/e0ba1e81_aeed860a PS8, Line 633: }

why the line wrap here ? having this in one line certainly doesn't exceed the permitted line length. Done

-- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33206 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Id082a9473b788f8de20cdc2ba4430b3289f4ce5a Gerrit-Change-Number: 33206 Gerrit-PatchSet: 11 Gerrit-Owner: arehbein <arehbein@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: daniel <dwillmann@sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jul 2023 12:44:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein@sysmocom.de> Comment-In-Reply-To: laforge <laforge@osmocom.org> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Comment-In-Reply-To: daniel <dwillmann@sysmocom.de> Gerrit-MessageType: comment