July 2023 - gerrit-log - lists.osmocom.org

[XL] Change in osmo-bsc[master]: ASCI: Add processing and FSMs for VGCS/VBS
by pespin 25 Jul '23

25 Jul '23

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33611 ) Change subject: ASCI: Add processing and FSMs for VGCS/VBS ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33611 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id9e94fb4f27bb438b7093c031344a3400bfa34f1 Gerrit-Change-Number: 33611 Gerrit-PatchSet: 8 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 25 Jul 2023 16:12:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: gprs_rlc_ul_window: Make sure V(N) array is cleared during reset_state()
by pespin 25 Jul '23

25 Jul '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33922 ) Change subject: gprs_rlc_ul_window: Make sure V(N) array is cleared during reset_state() ...................................................................... gprs_rlc_ul_window: Make sure V(N) array is cleared during reset_state() Otherwise unit tests (the only real used of that API so far) would end up with v_r and v_q variables reset, but with previous state in v_n array, which is not good. Let's make sure everything is reset in gprs_rlc_ul_window::reset_state(), and simply call that method during constructor time. Change-Id: I007b672527664b05353077b9208722056799f43f --- M src/rlc.h 1 file changed, 19 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/22/33922/1 diff --git a/src/rlc.h b/src/rlc.h index 5c6930c..d4a7a5e 100644 --- a/src/rlc.h +++ b/src/rlc.h @@ -573,10 +573,8 @@ } inline gprs_rlc_ul_window::gprs_rlc_ul_window() - : m_v_r(0) - , m_v_q(0) { - m_v_n.reset(); + reset_state(); } inline bool gprs_rlc_ul_window::is_in_window(uint16_t bsn) const @@ -603,6 +601,7 @@ { m_v_r = 0; m_v_q = 0; + m_v_n.reset(); } inline const void gprs_rlc_ul_window::set_v_r(int v_r) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33922 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I007b672527664b05353077b9208722056799f43f Gerrit-Change-Number: 33922 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-bsc[master]: fix send_assignment_complete(): proper SCE encoding for CSD
by fixeria 25 Jul '23

25 Jul '23

Attention is currently required from: osmith, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33912 ) Change subject: fix send_assignment_complete(): proper SCE encoding for CSD ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33912 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8b94c0292964f6d5f5ffa98ad8da03728f8bf6a0 Gerrit-Change-Number: 33912 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 25 Jul 2023 15:37:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: RLCMAC_Templates: allow any TFI by default in tr_RLCMAC_UL_ACK_NACK_(...
by laforge 25 Jul '23

25 Jul '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33908 ) Change subject: RLCMAC_Templates: allow any TFI by default in tr_RLCMAC_UL_ACK_NACK_(E)GPRS ...................................................................... RLCMAC_Templates: allow any TFI by default in tr_RLCMAC_UL_ACK_NACK_(E)GPRS Change-Id: I5ebf930a11d2c18cd0f2d690145c0da6dc22635e --- M library/RLCMAC_Templates.ttcn 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/library/RLCMAC_Templates.ttcn b/library/RLCMAC_Templates.ttcn index a4cd993..5e27341 100644 --- a/library/RLCMAC_Templates.ttcn +++ b/library/RLCMAC_Templates.ttcn @@ -705,7 +705,7 @@ } }; - template RlcmacDlBlock tr_RLCMAC_UL_ACK_NACK_GPRS(template uint5_t ul_tfi, template UlAckNackGprs gprs := tr_UlAckNackGprs(*)) + template RlcmacDlBlock tr_RLCMAC_UL_ACK_NACK_GPRS(template uint5_t ul_tfi := ?, template UlAckNackGprs gprs := tr_UlAckNackGprs(*)) modifies tr_RLCMAC_UL_ACK_NACK := { ctrl := { payload := { @@ -720,7 +720,7 @@ } }; - template RlcmacDlBlock tr_RLCMAC_UL_ACK_NACK_EGPRS(template uint5_t ul_tfi, template UlAckNackEgprs egprs := tr_UlAckNackEgprs(*)) + template RlcmacDlBlock tr_RLCMAC_UL_ACK_NACK_EGPRS(template uint5_t ul_tfi := ?, template UlAckNackEgprs egprs := tr_UlAckNackEgprs(*)) modifies tr_RLCMAC_UL_ACK_NACK := { ctrl := { payload := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33908 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5ebf930a11d2c18cd0f2d690145c0da6dc22635e Gerrit-Change-Number: 33908 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: RLCMAC_Templates: allow any TFI by default in tr_RLCMAC_UL_ACK_NACK_(...
by laforge 25 Jul '23

25 Jul '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33908 ) Change subject: RLCMAC_Templates: allow any TFI by default in tr_RLCMAC_UL_ACK_NACK_(E)GPRS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33908 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5ebf930a11d2c18cd0f2d690145c0da6dc22635e Gerrit-Change-Number: 33908 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jul 2023 15:29:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-netif[master]: examples: Add extension header octet to example
by laforge 25 Jul '23

25 Jul '23

Attention is currently required from: arehbein, daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33202 ) Change subject: examples: Add extension header octet to example ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33202 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I962b9edcba65cdc98da00d2f8753dc5acd481502 Gerrit-Change-Number: 33202 Gerrit-PatchSet: 12 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jul 2023 15:26:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: debian-bullseye-titan-*/Dockerfile: Replace inetutils-ping with iputi...
by laforge 25 Jul '23

25 Jul '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33918 ) Change subject: debian-bullseye-titan-*/Dockerfile: Replace inetutils-ping with iputils-ping ...................................................................... debian-bullseye-titan-*/Dockerfile: Replace inetutils-ping with iputils-ping iCurrently we install inetutils-ping in some docker images and iputils-ping in others; let's make it more uniform to avoid running different implementations in different images. The iputils-ping provides further linux-specific features, such as the "-I interface" param, which is used by some images, so let's pick that one everywhere. Change-Id: If11a1c2ae1115b585b6a44a45e9569c16856d8c4 --- M debian-bullseye-titan-master/Dockerfile M debian-bullseye-titan/Dockerfile 2 files changed, 18 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/debian-bullseye-titan-master/Dockerfile b/debian-bullseye-titan-master/Dockerfile index 1acfb73..a7ec65d 100644 --- a/debian-bullseye-titan-master/Dockerfile +++ b/debian-bullseye-titan-master/Dockerfile @@ -18,7 +18,7 @@ DEBIAN_FRONTEND='noninteractive' apt-get install -y --no-install-recommends --no-install-suggests \ build-essential \ git \ - inetutils-ping \ + iputils-ping \ netcat-openbsd \ procps \ python3-pip \ diff --git a/debian-bullseye-titan/Dockerfile b/debian-bullseye-titan/Dockerfile index 7bf180f..2274cc4 100644 --- a/debian-bullseye-titan/Dockerfile +++ b/debian-bullseye-titan/Dockerfile @@ -23,7 +23,7 @@ DEBIAN_FRONTEND='noninteractive' apt-get install -y --no-install-recommends --no-install-suggests \ build-essential \ git \ - inetutils-ping \ + iputils-ping \ netcat-openbsd \ procps \ python3-pip \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33918 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If11a1c2ae1115b585b6a44a45e9569c16856d8c4 Gerrit-Change-Number: 33918 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in docker-playground[master]: debian-bullseye-titan-*/Dockerfile: Replace inetutils-ping with iputi...
by laforge 25 Jul '23

25 Jul '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33918 ) Change subject: debian-bullseye-titan-*/Dockerfile: Replace inetutils-ping with iputils-ping ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33918 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If11a1c2ae1115b585b6a44a45e9569c16856d8c4 Gerrit-Change-Number: 33918 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jul 2023 15:22:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: exec: osmo_system_nowait2(): Improve logging and error checks
by laforge 25 Jul '23

25 Jul '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33920 ) Change subject: exec: osmo_system_nowait2(): Improve logging and error checks ...................................................................... exec: osmo_system_nowait2(): Improve logging and error checks Change-Id: I9b971dda389fe958627d41fa5ba6f45ee588bf99 --- M src/core/exec.c 1 file changed, 22 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/core/exec.c b/src/core/exec.c index 6412270..2e33788 100644 --- a/src/core/exec.c +++ b/src/core/exec.c @@ -213,10 +213,18 @@ int rc; if (user) { + if (getpw_buflen == -1) /* Value was indeterminate */ + getpw_buflen = 16384; /* Should be more than enough */ char buf[getpw_buflen]; - getpwnam_r(user, &_pw, buf, sizeof(buf), &pw); - if (!pw) + rc = getpwnam_r(user, &_pw, buf, sizeof(buf), &pw); + if (rc < 0) { + LOGP(DLGLOBAL, LOGL_ERROR, "getpwnam_r(\"%s\") failed: %s\n", user, strerror(-rc)); + return rc; + } + if (!pw) { + LOGP(DLGLOBAL, LOGL_ERROR, "getpwnam_r(\"%s\"): user not found!\n", user); return -EINVAL; + } } rc = fork(); @@ -264,6 +272,9 @@ return -EIO; } else { /* we are in the parent */ + if (rc == -1) + LOGP(DLGLOBAL, LOGL_ERROR, "fork() error executing command '%s': %s\n", + command, strerror(errno)); return rc; } } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33920 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9b971dda389fe958627d41fa5ba6f45ee588bf99 Gerrit-Change-Number: 33920 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmocore[master]: exec: osmo_system_nowait2(): Improve logging and error checks
by laforge 25 Jul '23

25 Jul '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33920 ) Change subject: exec: osmo_system_nowait2(): Improve logging and error checks ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33920 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9b971dda389fe958627d41fa5ba6f45ee588bf99 Gerrit-Change-Number: 33920 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jul 2023 15:22:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0