Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32949 )
Change subject: ms: cache frequency
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32949
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ide9f45130955e1cc66610a50d6fc1cd79f30aca9
Gerrit-Change-Number: 32949
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 05 Jul 2023 13:03:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32948 )
Change subject: ms : rename var
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32948
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ia90a9f73fdb1f96fa5bd7f27b3c191ce0ba6c65d
Gerrit-Change-Number: 32948
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 05 Jul 2023 13:03:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32947 )
Change subject: ms : rename var
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32947
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I44e5d1770b248f107abce5683d5f7641655da764
Gerrit-Change-Number: 32947
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 05 Jul 2023 13:03:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32946 )
Change subject: ms: use single thread pool
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32946
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Id675550f55e8ccbbbe6b0d91fbffd01b6ede15f7
Gerrit-Change-Number: 32946
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 05 Jul 2023 13:03:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32944 )
Change subject: ms: fix startup & shutdown of blade
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32944
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I1cd8790191790f4861a70bc55c8f4c9993fa10c8
Gerrit-Change-Number: 32944
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 05 Jul 2023 13:03:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32942 )
Change subject: ms: fix the gain init for blade
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32942
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ic5a25d6f5606fba599b8144fbec7285047dca3c9
Gerrit-Change-Number: 32942
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 05 Jul 2023 13:03:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32941 )
Change subject: ms : fix the template formatting
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32941
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I891bdf95004accebbbe54916e4472bd381fac545
Gerrit-Change-Number: 32941
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 05 Jul 2023 13:02:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Hoernchen, fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32762 )
Change subject: transceiver: pass cfg struct instead of args
......................................................................
Patch Set 3:
(1 comment)
File Transceiver52M/device/lms/LMSDevice.h:
https://gerrit.osmocom.org/c/osmo-trx/+/32762/comment/906f6421_8d84008d
PS3, Line 110: LMSDevice(InterfaceType iface, const struct trx_cfg *cfg);
> We can either […]
AFAICT, the usual approach we take in such situations is to reformat once in one patch, and then perform the functional changes on top of that. I think we've done this in imported C code and in python, not sure if we did it with C++
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32762
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I48386900d15ff4d770c70a4efc246d32f921904b
Gerrit-Change-Number: 32762
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 05 Jul 2023 13:02:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32763 )
Change subject: devices: unify band handling
......................................................................
Patch Set 9:
(1 comment)
File Transceiver52M/device/common/bandmanager.h:
https://gerrit.osmocom.org/c/osmo-trx/+/32763/comment/e4b04f6c_2d6793bc
PS5, Line 100: void reset()
> ah here it is. band_reset() would be more descriptive imho.
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32763
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I64f5a462451e967d4750d8e4f1d5832cbab41cff
Gerrit-Change-Number: 32763
Gerrit-PatchSet: 9
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 05 Jul 2023 12:57:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment