fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/33565 )
Change subject: ussd: fix GSUP memleaks in rx_proc_ss_{req,error}()
......................................................................
ussd: fix GSUP memleaks in rx_proc_ss_{req,error}()
Also take a chance to use a more suitable error cause value.
Change-Id: I22ba5ad470989b7e8ba8fe2be170eac4adcb48c5
---
M src/hlr_ussd.c
1 file changed, 16 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, but someone else must approve
pespin: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
diff --git a/src/hlr_ussd.c b/src/hlr_ussd.c
index 35b74b6..8d5237f 100644
--- a/src/hlr_ussd.c
+++ b/src/hlr_ussd.c
@@ -631,7 +631,8 @@
if (!ss) {
LOGP(DSS, LOGL_ERROR, "%s/0x%08x: CONTINUE for unknown SS session\n",
gsup->imsi, gsup->session_id);
- osmo_gsup_req_respond_err(gsup_req, GMM_CAUSE_INV_MAND_INFO, "CONTINUE for unknown SS session");
+ osmo_gsup_req_respond_err(gsup_req, GMM_CAUSE_MSGT_INCOMP_P_STATE,
+ "CONTINUE for unknown SS session");
return;
}
@@ -652,6 +653,8 @@
if (!ss) {
LOGP(DSS, LOGL_ERROR, "%s/0x%08x: END for unknown SS session\n",
gsup->imsi, gsup->session_id);
+ osmo_gsup_req_respond_err(gsup_req, GMM_CAUSE_MSGT_INCOMP_P_STATE,
+ "END for unknown SS session");
return;
}
@@ -682,4 +685,5 @@
{
LOGP(DSS, LOGL_NOTICE, "%s/0x%08x: Process SS ERROR (%s)\n", req->gsup.imsi, req->gsup.session_id,
osmo_gsup_session_state_name(req->gsup.session_state));
+ osmo_gsup_req_free(req);
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/33565
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I22ba5ad470989b7e8ba8fe2be170eac4adcb48c5
Gerrit-Change-Number: 33565
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/33567 )
Change subject: gsup_server: fix msgb memleak in osmo_gsup_server_read_cb()
......................................................................
gsup_server: fix msgb memleak in osmo_gsup_server_read_cb()
I noticed that inability to send IPA PONG in response to IPA PING
from osmo-{msc,sgsn} results in an "IPA Multiplex" chunk being leaked.
No matter what's returned from ipa_server_conn_ccm(), we need to free
the msgb containing the incoming IPA message.
Change-Id: I5c5acbffc2913f78db4894ae3633b5eca9c2e8d6
---
M src/gsup_server.c
1 file changed, 17 insertions(+), 4 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
diff --git a/src/gsup_server.c b/src/gsup_server.c
index 097a854..91110eb 100644
--- a/src/gsup_server.c
+++ b/src/gsup_server.c
@@ -179,11 +179,9 @@
if (hh->proto == IPAC_PROTO_IPACCESS) {
rc = ipa_server_conn_ccm(conn, msg);
- if (rc < 0) {
- /* conn is already invalid here! */
- return -1;
- }
msgb_free(msg);
+ if (rc < 0) /* conn is already invalid here! */
+ return -1;
return 0;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/33567
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I5c5acbffc2913f78db4894ae3633b5eca9c2e8d6
Gerrit-Change-Number: 33567
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/33565 )
Change subject: ussd: fix GSUP memleaks in rx_proc_ss_{req,error}()
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I actually see 3 different things in this patch, so 3 patches would be nicer :)
Those are not different things, except using a more suitable cause value. I could split this patch up, but I would prefer to spend paid time on something more useful.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/33565
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I22ba5ad470989b7e8ba8fe2be170eac4adcb48c5
Gerrit-Change-Number: 33565
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 05 Jul 2023 11:36:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33572 )
Change subject: redmine: fix auto-scan of repositories
......................................................................
redmine: fix auto-scan of repositories
While inspecting the running docker container I found that the script
already runs as redmine user. I had assumed that it runs as root
earlier. Running 'su' as redmine user fails, therefore it currently does
not run the fetch_changesets command.
Related: OS#6083
Change-Id: I195311b93868eb5fd73ad6e3c165d48f3b7b53ce
---
M redmine/docker-entrypoint-osmo.sh
1 file changed, 16 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
diff --git a/redmine/docker-entrypoint-osmo.sh b/redmine/docker-entrypoint-osmo.sh
index aff8183..8206d29 100755
--- a/redmine/docker-entrypoint-osmo.sh
+++ b/redmine/docker-entrypoint-osmo.sh
@@ -7,7 +7,7 @@
sleep 10m
echo
echo "=== Fetching git repositories (OS#5331) ==="
- su redmine -c 'rails runner "Repository.fetch_changesets" -e production'
+ rails runner "Repository.fetch_changesets" -e production
echo
done &) &
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33572
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I195311b93868eb5fd73ad6e3c165d48f3b7b53ce
Gerrit-Change-Number: 33572
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: osmith, laforge, dexter.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33571 )
Change subject: MME_Tests: add docker tests for MME
......................................................................
Patch Set 1:
(1 comment)
File debian-bullseye-titan/Dockerfile:
https://gerrit.osmocom.org/c/docker-playground/+/33571/comment/327c9a0e_b3c…
PS1, Line 34: libgnutls28-dev
Could you also clarify why this new dependency is needed (in the commit message)? I am guessing the MME testsuite is doing some crypto and this library is required for compilation. Perhaps we could have this package installed in the `ttcn3-mme-test-ogs/Dockerfile`, given that it's currently the only user of this package?
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33571
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ic1ce1dace47353b0dcf321c923a78567e3ddefb9
Gerrit-Change-Number: 33571
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 05 Jul 2023 11:28:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment