July 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-pcu[master]: gprs_ms: Constify variable in ms_is_reachable_for_dl_ass()
by pespin 05 Jul '23

05 Jul '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33574 ) Change subject: gprs_ms: Constify variable in ms_is_reachable_for_dl_ass() ...................................................................... gprs_ms: Constify variable in ms_is_reachable_for_dl_ass() Change-Id: If37907b2f75b61b3243b9d8499bb0cf5c02c28c1 --- M src/gprs_ms.c 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/74/33574/1 diff --git a/src/gprs_ms.c b/src/gprs_ms.c index 6e6390b..5890d31 100644 --- a/src/gprs_ms.c +++ b/src/gprs_ms.c @@ -1093,7 +1093,7 @@ /* Can we get to send a DL TBF ass to the MS? */ static bool ms_is_reachable_for_dl_ass(const struct GprsMs *ms) { - struct gprs_rlcmac_ul_tbf *ul_tbf = ms_ul_tbf(ms); + const struct gprs_rlcmac_ul_tbf *ul_tbf = ms_ul_tbf(ms); /* This function assumes it is called when no DL TBF is present */ OSMO_ASSERT(!ms_dl_tbf(ms)); @@ -1115,7 +1115,7 @@ return true; if (ul_tbf_contention_resolution_done(ul_tbf) && !tbf_ul_ack_waiting_cnf_final_ack(ul_tbf) && - tbf_state(ul_tbf_as_tbf(ul_tbf)) != TBF_ST_RELEASING) + tbf_state(ul_tbf_as_tbf_const(ul_tbf)) != TBF_ST_RELEASING) return true; return false; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33574 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If37907b2f75b61b3243b9d8499bb0cf5c02c28c1 Gerrit-Change-Number: 33574 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in docker-playground[master]: */osmo-stp.cfg: Explicitly define role & sctp-role
by fixeria 05 Jul '23

05 Jul '23

Attention is currently required from: pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33544 ) Change subject: */osmo-stp.cfg: Explicitly define role & sctp-role ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33544 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ia495bc3c5dd4421e5730c74b2f5dc4e4cdc1a673 Gerrit-Change-Number: 33544 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Jul 2023 12:14:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: pcuif: Log read() error cause
by fixeria 05 Jul '23

05 Jul '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33573 ) Change subject: pcuif: Log read() error cause ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33573 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ifdc46a228752452c8d403f2d49f4bac23c450b4d Gerrit-Change-Number: 33573 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Jul 2023 12:13:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmo-gprs[master]: rlcmac: defer going to pkt_idle_timer after freeing TBF
by fixeria 05 Jul '23

05 Jul '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33553 ) Change subject: rlcmac: defer going to pkt_idle_timer after freeing TBF ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS1: > Posting some of my thoughts from IRC/#osmocom: […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33553 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I563ad2ee6aacd65314e998626dc27adc29221a7d Gerrit-Change-Number: 33553 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Jul 2023 12:11:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: pcuif: Log read() error cause
by pespin 05 Jul '23

05 Jul '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33573 ) Change subject: pcuif: Log read() error cause ...................................................................... pcuif: Log read() error cause Change-Id: Ifdc46a228752452c8d403f2d49f4bac23c450b4d --- M src/osmobts_sock.c 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/73/33573/1 diff --git a/src/osmobts_sock.c b/src/osmobts_sock.c index c4a042f..c77605f 100644 --- a/src/osmobts_sock.c +++ b/src/osmobts_sock.c @@ -138,6 +138,7 @@ if (rc < 0 && errno == EAGAIN) return 0; /* Try again later */ if (rc <= 0) { + LOGP(DL1IF, LOGL_ERROR, "%s: recv() failed with rc=%d errno=%d\n", __func__, rc, errno); pcu_sock_close(1); return -EIO; } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33573 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ifdc46a228752452c8d403f2d49f4bac23c450b4d Gerrit-Change-Number: 33573 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in libosmo-gprs[master]: rlcmac: defer going to pkt_idle_timer after freeing TBF
by pespin 05 Jul '23

05 Jul '23

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33553 to look at the new patch set (#2). Change subject: rlcmac: defer going to pkt_idle_timer after freeing TBF ...................................................................... rlcmac: defer going to pkt_idle_timer after freeing TBF Give some time to pending tx blocks to be transmitted before jumping back to CCCH. Change-Id: I563ad2ee6aacd65314e998626dc27adc29221a7d --- M include/osmocom/gprs/rlcmac/gre.h M src/rlcmac/gre.c M tests/rlcmac/rlcmac_prim_test.c M tests/rlcmac/rlcmac_prim_test.err M tests/rlcmac/rlcmac_prim_test.ok 5 files changed, 66 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/53/33553/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33553 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I563ad2ee6aacd65314e998626dc27adc29221a7d Gerrit-Change-Number: 33553 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[L] Change in osmo-mgw[master]: ASCI: Support conference briding with 1..n connections
by laforge 05 Jul '23

05 Jul '23

Attention is currently required from: jolly, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/33548 ) Change subject: ASCI: Support conference briding with 1..n connections ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > My idea was to use pointers to increase performance. […] mh. but don't we have a per-endpoint list of connections? so we would only be "iterating" a linked list of two entries in the "most cases" scenario you described above? Do you really think that iterating a list with two entries (whcih is three dereferences of the next pointer) is significantly slower than the mechanism you're introducing? I'm somewhat doubtful we should have that level of complexity without knowing for sure that there's an actual performance issue to begin with. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/33548 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic99a55ab5a3a6170e940403fadd52697e99f2f3a Gerrit-Change-Number: 33548 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Jul 2023 11:41:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in docker-playground[master]: */osmo-stp.cfg: Explicitly define role & sctp-role
by osmith 05 Jul '23

05 Jul '23

Attention is currently required from: pespin, dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33544 ) Change subject: */osmo-stp.cfg: Explicitly define role & sctp-role ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33544 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ia495bc3c5dd4421e5730c74b2f5dc4e4cdc1a673 Gerrit-Change-Number: 33544 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Jul 2023 11:38:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in docker-playground[master]: */osmo-stp.cfg: Explicitly define role & sctp-role
by pespin 05 Jul '23

05 Jul '23

Attention is currently required from: pespin, dexter. Hello osmith, Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/33544 to look at the new patch set (#2). Change subject: */osmo-stp.cfg: Explicitly define role & sctp-role ...................................................................... */osmo-stp.cfg: Explicitly define role & sctp-role It was recently decided it's a good practice to always specify the role and sctp-role for all ASPs configured in the VTY, since it's an important configuration providing feedback on the network setup expectancies. Change-Id: Ia495bc3c5dd4421e5730c74b2f5dc4e4cdc1a673 --- M nplab-m3ua-test/osmo-stp.cfg M nplab-sua-test/osmo-stp.cfg M osmo-stp-latest/osmo-stp.cfg M osmo-stp-master/osmo-stp.cfg M ttcn3-bsc-test-vamos/osmo-stp.cfg M ttcn3-bsc-test/osmo-stp.cfg M ttcn3-hnbgw-test/osmo-stp.cfg M ttcn3-msc-test/osmo-stp.cfg M ttcn3-sgsn-test/osmo-stp.cfg M ttcn3-smlc-test/osmo-stp.cfg M ttcn3-stp-test/osmo-stp.cfg 11 files changed, 77 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/44/33544/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33544 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ia495bc3c5dd4421e5730c74b2f5dc4e4cdc1a673 Gerrit-Change-Number: 33544 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-hlr[master]: lu_fsm: fix memleak in lu_fsm_wait_insert_data_result()
by fixeria 05 Jul '23

05 Jul '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/33564 ) Change subject: lu_fsm: fix memleak in lu_fsm_wait_insert_data_result() ...................................................................... lu_fsm: fix memleak in lu_fsm_wait_insert_data_result() Currently osmo-hlr leaks memory (msgb holding 1203 bytes of data and a struct osmo_gsup_req) on receipt of OSMO_GSUP_MSGT_INSERT_DATA_ERROR. Change-Id: I4c70a06169158c869360707a7a62436dbf13b9b3 --- M src/lu_fsm.c 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve dexter: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/lu_fsm.c b/src/lu_fsm.c index e6ed31a..8599f59 100644 --- a/src/lu_fsm.c +++ b/src/lu_fsm.c @@ -275,6 +275,7 @@ case OSMO_GSUP_MSGT_INSERT_DATA_ERROR: lu_failure(lu, GMM_CAUSE_NET_FAIL, "Rx %s", osmo_gsup_message_type_name(req->gsup.message_type)); + osmo_gsup_req_free(req); break; default: -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/33564 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I4c70a06169158c869360707a7a62436dbf13b9b3 Gerrit-Change-Number: 33564 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

1 0