July 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-hlr[master]: ussd: fix GSUP memleaks in rx_proc_ss_{req,error}()
by pespin 05 Jul '23

05 Jul '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/33565 ) Change subject: ussd: fix GSUP memleaks in rx_proc_ss_{req,error}() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: I actually see 3 different things in this patch, so 3 patches would be nicer :) -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/33565 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I22ba5ad470989b7e8ba8fe2be170eac4adcb48c5 Gerrit-Change-Number: 33565 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Jul 2023 11:17:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: ctrl: Add getting si2quater uarfcn neighbor list
by pespin 05 Jul '23

05 Jul '23

Attention is currently required from: matanp. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33570 ) Change subject: ctrl: Add getting si2quater uarfcn neighbor list ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33570 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iab1d2e264c0deb75f03aec6ae38ac406bc7b58cb Gerrit-Change-Number: 33570 Gerrit-PatchSet: 1 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Wed, 05 Jul 2023 11:13:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in docker-playground[master]: MME_Tests: add docker tests for MME
by laforge 05 Jul '23

05 Jul '23

Attention is currently required from: osmith, pespin, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33571 ) Change subject: MME_Tests: add docker tests for MME ...................................................................... Patch Set 1: (1 comment) File ttcn3-mme-test-ogs/jenkins.sh: https://gerrit.osmocom.org/c/docker-playground/+/33571/comment/c36c964d_472… PS1, Line 27: --cap-add=NET_ADMIN \ : --device /dev/net/tun:/dev/net/tun \ : --sysctl net.ipv6.conf.all.disable_ipv6=0 \ > do you need these options, or are they just copied from other Dockerfiles and it works fine without […] the MME is not involved in the user plane, so I don't understand why it would need /dev/net/tun access. the CAP_NET_ADMIN is apparently needed for SO_BINDTODEVICE. However, this is only used by the MME of the ogs_udp_server() is started with "so_bindtodevice" option. So the questions is whether or not our configs use that option, and whether they really need to. I personally currently don't know why the MME would need to hard-bind a socket to a specific net-device. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic1ce1dace47353b0dcf321c923a78567e3ddefb9 Gerrit-Change-Number: 33571 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Jul 2023 11:11:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: ASCI: Add VGCS/VBS call control specific data to gsm_trans
by pespin 05 Jul '23

05 Jul '23

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33507 ) Change subject: ASCI: Add VGCS/VBS call control specific data to gsm_trans ...................................................................... Patch Set 9: Code-Review-1 (1 comment) Patchset: PS9: Again another example: please put this commit together with the commit using those fields. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33507 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I37d68a89a101fa579680fd3cf170cd3dc5a148e4 Gerrit-Change-Number: 33507 Gerrit-PatchSet: 9 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 05 Jul 2023 11:10:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: ASCI: Add callref to assignment command
by pespin 05 Jul '23

05 Jul '23

Attention is currently required from: jolly, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33516 ) Change subject: ASCI: Add callref to assignment command ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33516 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7955c6e0eebc930f85f360dda46be17cbd39e181 Gerrit-Change-Number: 33516 Gerrit-PatchSet: 8 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 05 Jul 2023 11:07:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmo-msc[master]: ASCI: Add functions to transcode VGCS/VBS messages on A-interface
by pespin 05 Jul '23

05 Jul '23

Attention is currently required from: jolly, neels, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33505 ) Change subject: ASCI: Add functions to transcode VGCS/VBS messages on A-interface ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33505 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6b1f088201e7ef4a58762937855a1d358973882c Gerrit-Change-Number: 33505 Gerrit-PatchSet: 8 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 05 Jul 2023 11:04:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmo-mgw[master]: ASCI: Support conference briding with 1..n connections
by dexter 05 Jul '23

05 Jul '23

Attention is currently required from: jolly, laforge, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/33548 ) Change subject: ASCI: Support conference briding with 1..n connections ...................................................................... Patch Set 2: (4 comments) File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/33548/comment/1644c627_12dda9ba PS2, Line 970: if (llist_count(&endp->conns) >= endp->type->max_conns) { It is not immediately obvious for me where you now check endp->type->max_conns. Can you give me a hint? File src/libosmo-mgcp/mgcp_trunk.c: https://gerrit.osmocom.org/c/osmo-mgw/+/33548/comment/f7e2e0e2_2fa37b02 PS2, Line 311: /* Interconnect payload of connections depending on their mode. "Interconnect payload of connections" I wonder what this means. We probably do not interconnect payloads. Maybe you mean "Interconnect connections depending on their mode"? https://gerrit.osmocom.org/c/osmo-mgw/+/33548/comment/f5a80d95_e72dbf3c PS2, Line 352: * For public functions we usually use doxygen syntax. For static functions we just have normal comments. Just have a look at the other C-files. https://gerrit.osmocom.org/c/osmo-mgw/+/33548/comment/15a4c55e_aafe0282 PS2, Line 353: */ maybe the function should be called mgcp_trunk_connect_conn. This may sound a bit strange but as it is now it sounds like if this would refer the to the trunk but we actually connect connections on an endpoint. Maybe moving this function to mgcp_endp.c would make sense. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/33548 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic99a55ab5a3a6170e940403fadd52697e99f2f3a Gerrit-Change-Number: 33548 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Jul 2023 11:02:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in osmo-msc[master]: ASCI: Add simple implementation of Group Call Register
by pespin 05 Jul '23

05 Jul '23

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33510 ) Change subject: ASCI: Add simple implementation of Group Call Register ...................................................................... Patch Set 8: (1 comment) File src/libmsc/asci_gcr.c: https://gerrit.osmocom.org/c/osmo-msc/+/33510/comment/25c5377c_9c75d8cf PS8, Line 165: b = callref % pow10[l]; OSMO_ASSERT(l < ARRAY_SIZE(pow10)); -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33510 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ia74a4a865f943c5fb388cd28f9406005c92e663e Gerrit-Change-Number: 33510 Gerrit-PatchSet: 8 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 05 Jul 2023 11:02:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: ASCI: Allow transaction without subscriber associated
by pespin 05 Jul '23

05 Jul '23

Attention is currently required from: jolly, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33501 ) Change subject: ASCI: Allow transaction without subscriber associated ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33501 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I2b9afe95db4c106c141f4b7bd199ec74e197e523 Gerrit-Change-Number: 33501 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 05 Jul 2023 10:58:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-msc[master]: ASCI: Add two new transaction types for VGCS and VBS
by pespin 05 Jul '23

05 Jul '23

Attention is currently required from: jolly, neels, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33503 ) Change subject: ASCI: Add two new transaction types for VGCS and VBS ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33503 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iddd11f813582ac2ac2bdee91cc3a525986deb514 Gerrit-Change-Number: 33503 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 05 Jul 2023 10:57:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0