Attention is currently required from: jolly, laforge, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/33548 ) Change subject: ASCI: Support conference briding with 1..n connections ...................................................................... Patch Set 2: (4 comments) File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/33548/comment/1644c627_12dda9ba PS2, Line 970: if (llist_count(&endp->conns) >= endp->type->max_conns) { It is not immediately obvious for me where you now check endp->type->max_conns. Can you give me a hint? File src/libosmo-mgcp/mgcp_trunk.c: https://gerrit.osmocom.org/c/osmo-mgw/+/33548/comment/f7e2e0e2_2fa37b02 PS2, Line 311: /* Interconnect payload of connections depending on their mode. "Interconnect payload of connections" I wonder what this means. We probably do not interconnect payloads. Maybe you mean "Interconnect connections depending on their mode"? https://gerrit.osmocom.org/c/osmo-mgw/+/33548/comment/f5a80d95_e72dbf3c PS2, Line 352: * For public functions we usually use doxygen syntax. For static functions we just have normal comments. Just have a look at the other C-files. https://gerrit.osmocom.org/c/osmo-mgw/+/33548/comment/15a4c55e_aafe0282 PS2, Line 353: */ maybe the function should be called mgcp_trunk_connect_conn. This may sound a bit strange but as it is now it sounds like if this would refer the to the trunk but we actually connect connections on an endpoint. Maybe moving this function to mgcp_endp.c would make sense. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/33548 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic99a55ab5a3a6170e940403fadd52697e99f2f3a Gerrit-Change-Number: 33548 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Wed, 05 Jul 2023 11:02:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment