Attention is currently required from: jolly, laforge, pespin.

View Change

4 comments:

• File src/libosmo-mgcp/mgcp_protocol.c:

  • Patch Set #2, Line 970: if (llist_count(&endp->conns) >= endp->type->max_conns) {

    It is not immediately obvious for me where you now check endp->type->max_conns. Can you give me a hint?

• File src/libosmo-mgcp/mgcp_trunk.c:

  • Patch Set #2, Line 311: /* Interconnect payload of connections depending on their mode.

    "Interconnect payload of connections" I wonder what this means. We probably do not interconnect payloads. Maybe you mean "Interconnect connections depending on their mode"?

  • Patch Set #2, Line 352: *

    For public functions we usually use doxygen syntax. For static functions we just have normal comments. Just have a look at the other C-files.

  • Patch Set #2, Line 353: */

    maybe the function should be called mgcp_trunk_connect_conn. This may sound a bit strange but as it is now it sounds like if this would refer the to the trunk but we actually connect connections on an endpoint. Maybe moving this function to mgcp_endp.c would make sense.

To view, visit change 33548. To unsubscribe, or for help writing mail filters, visit settings.