July 2023 - gerrit-log - lists.osmocom.org

[L] Change in osmo-trx[master]: devices: unify band handling
by pespin 07 Jul '23

07 Jul '23

Attention is currently required from: Hoernchen. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32763 ) Change subject: devices: unify band handling ...................................................................... Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32763 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I64f5a462451e967d4750d8e4f1d5832cbab41cff Gerrit-Change-Number: 32763 Gerrit-PatchSet: 10 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Jul 2023 17:10:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmo-trx[master]: devices: unify band handling
by Hoernchen 07 Jul '23

07 Jul '23

Attention is currently required from: pespin. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32763 ) Change subject: devices: unify band handling ...................................................................... Patch Set 9: (1 comment) File Transceiver52M/device/lms/LMSDevice.h: https://gerrit.osmocom.org/c/osmo-trx/+/32763/comment/21b2b074_517a6c2f PS5, Line 97: using dev_band_key = std::tuple<lms_dev_type, gsm_band>; > Still unresolved. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32763 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I64f5a462451e967d4750d8e4f1d5832cbab41cff Gerrit-Change-Number: 32763 Gerrit-PatchSet: 9 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Jul 2023 17:08:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[L] Change in osmo-trx[master]: devices: unify band handling
by Hoernchen 07 Jul '23

07 Jul '23

Attention is currently required from: Hoernchen. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/32763 to look at the new patch set (#10). Change subject: devices: unify band handling ...................................................................... devices: unify band handling This is basically common, but optional code. Change-Id: I64f5a462451e967d4750d8e4f1d5832cbab41cff --- M Transceiver52M/device/bladerf/bladerf.cpp M Transceiver52M/device/bladerf/bladerf.h M Transceiver52M/device/common/Makefile.am A Transceiver52M/device/common/bandmanager.h M Transceiver52M/device/lms/LMSDevice.cpp M Transceiver52M/device/lms/LMSDevice.h M Transceiver52M/device/uhd/UHDDevice.cpp M Transceiver52M/device/uhd/UHDDevice.h 8 files changed, 242 insertions(+), 326 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/63/32763/10 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32763 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I64f5a462451e967d4750d8e4f1d5832cbab41cff Gerrit-Change-Number: 32763 Gerrit-PatchSet: 10 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[L] Change in osmo-trx[master]: transceiver: pass cfg struct instead of args
by Hoernchen 07 Jul '23

07 Jul '23

Attention is currently required from: laforge, fixeria. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32762 ) Change subject: transceiver: pass cfg struct instead of args ...................................................................... Patch Set 3: (1 comment) File Transceiver52M/device/lms/LMSDevice.h: https://gerrit.osmocom.org/c/osmo-trx/+/32762/comment/ca0ff00c_6d94891a PS3, Line 110: LMSDevice(InterfaceType iface, const struct trx_cfg *cfg); > AFAICT, the usual approach we take in such situations is to reformat once in one patch, and then per […] The only part of osmotrx that follow any style is the ms subdirectory, everythting else is 15 years of random baggage. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32762 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I48386900d15ff4d770c70a4efc246d32f921904b Gerrit-Change-Number: 32762 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Jul 2023 16:26:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-trx[master]: ms: block burst q to upper layer
by Hoernchen 07 Jul '23

07 Jul '23

Attention is currently required from: pespin. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32945 ) Change subject: ms: block burst q to upper layer ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > it was masrked as ready to review but I don't see updated commit log as requested? This happened because I changed something in a previous patch and then accidentally recalled the old command that pushed it as wip so I had to unset wip everywhere manually again... -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32945 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Id0aad606a296b2885617013ce6637204357b13d7 Gerrit-Change-Number: 32945 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Jul 2023 16:21:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: ctrl: Add getting si2quater earfcn neighbor list
by matanp 07 Jul '23

07 Jul '23

matanp has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bsc/+/33645 ) Change subject: ctrl: Add getting si2quater earfcn neighbor list ...................................................................... ctrl: Add getting si2quater earfcn neighbor list Change-Id: Ib942bfa95aca2b514ac68f602545b9e7cbed097a --- M src/osmo-bsc/bts_ctrl.c 1 file changed, 49 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/45/33645/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33645 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib942bfa95aca2b514ac68f602545b9e7cbed097a Gerrit-Change-Number: 33645 Gerrit-PatchSet: 2 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-bsc[master]: ctrl: Add getting si2quater earfcn neighbor list
by Jenkins Builder 07 Jul '23

07 Jul '23

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33645 ) Change subject: ctrl: Add getting si2quater earfcn neighbor list ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/bts_ctrl.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-9176): https://gerrit.osmocom.org/c/osmo-bsc/+/33645/comment/5801e684_60b8fd1e PS1, Line 1168: if (neighbors->arfcn[i] == OSMO_EARFCN_INVALID) { braces {} are not necessary for single statement blocks -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33645 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib942bfa95aca2b514ac68f602545b9e7cbed097a Gerrit-Change-Number: 33645 Gerrit-PatchSet: 1 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 07 Jul 2023 15:56:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: ctrl: Add getting si2quater earfcn neighbor list
by matanp 07 Jul '23

07 Jul '23

matanp has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33645 ) Change subject: ctrl: Add getting si2quater earfcn neighbor list ...................................................................... ctrl: Add getting si2quater earfcn neighbor list Change-Id: Ib942bfa95aca2b514ac68f602545b9e7cbed097a --- M src/osmo-bsc/bts_ctrl.c 1 file changed, 50 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/45/33645/1 diff --git a/src/osmo-bsc/bts_ctrl.c b/src/osmo-bsc/bts_ctrl.c index 2589668..3be650f 100644 --- a/src/osmo-bsc/bts_ctrl.c +++ b/src/osmo-bsc/bts_ctrl.c @@ -36,6 +36,8 @@ #include <osmocom/bsc/neighbor_ident.h> #include <osmocom/bsc/system_information.h> +#include <osmocom/gsm/sysinfo.h> + static int location_equal(struct bts_location *a, struct bts_location *b) { return ((a->tstamp == b->tstamp) && (a->valid == b->valid) && (a->lat == b->lat) && @@ -1148,6 +1150,44 @@ CTRL_CMD_DEFINE_RO(bts_neighbor_list_si2quater_uarfcn, "neighbor-list si2quater uarfcns"); +/* Return space concatenated set of tuples <EARFCN>,<thresh-hi>,<thresh-lo>,<prio>,<qrxlv>,<meas> */ +static int get_bts_neighbor_list_si2quater_earfcn(struct ctrl_cmd *cmd, void *data) +{ + int i; + bool first_earfcn = true; + const struct gsm_bts *bts = cmd->node; + const struct osmo_earfcn_si2q *neighbors = &bts->si_common.si2quater_neigh_list; + + cmd->reply = talloc_strdup(cmd, ""); + if (!cmd->reply) { + cmd->reply = "OOM"; + return CTRL_CMD_ERROR; + } + + for (i = 0; i < MAX_EARFCN_LIST; i++) { + if (neighbors->arfcn[i] == OSMO_EARFCN_INVALID) { + continue; + } + cmd->reply = talloc_asprintf_append(cmd->reply, + first_earfcn ? "%u,%u,%u,%u,%u,%u" : " %u,%u,%u,%u,%u,%u", + neighbors->arfcn[i], + neighbors->thresh_hi, + neighbors->thresh_lo_valid ? neighbors->thresh_lo : 32, + neighbors->prio_valid ? neighbors->prio : 8, + neighbors->qrxlm_valid ? neighbors->qrxlm : 32, + (neighbors->meas_bw[i] != OSMO_EARFCN_MEAS_INVALID) ? neighbors->meas_bw[i] : 8); + if (!cmd->reply) { + cmd->reply = "OOM"; + return CTRL_CMD_ERROR; + } + first_earfcn = false; + } + + return CTRL_CMD_REPLY; +} + +CTRL_CMD_DEFINE_RO(bts_neighbor_list_si2quater_earfcn, "neighbor-list si2quater earfcns"); + int bsc_bts_ctrl_cmds_install(void) { int rc = 0; @@ -1184,6 +1224,7 @@ rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_rach_access_control_class_bar); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_rach_access_control_class_allow); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_neighbor_list_si2quater_uarfcn); + rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_neighbor_list_si2quater_earfcn); rc |= neighbor_ident_ctrl_init(); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33645 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib942bfa95aca2b514ac68f602545b9e7cbed097a Gerrit-Change-Number: 33645 Gerrit-PatchSet: 1 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests: print length of received TCH payloads
by fixeria 07 Jul '23

07 Jul '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33643 ) Change subject: BTS_Tests: print length of received TCH payloads ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Is that really needed given that the entire string is printed and hence can be counted? With this patch I don't need to count manually anymore. It's annoying, especially when you get lots of bits/bytes (e.g. 290) on CSD channels. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33643 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5848bd8acd220c1c4d2db01b71bb57e785dc9de7 Gerrit-Change-Number: 33643 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Jul 2023 15:26:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmo-sccp[master]: M3UA/SUA: Don't add empty routing context IE in DUNA/DAVA
by pespin 07 Jul '23

07 Jul '23

Attention is currently required from: iedemam, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/33642 ) Change subject: M3UA/SUA: Don't add empty routing context IE in DUNA/DAVA ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/33642 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I19d0382cd2d428a91ac716182b9d86dcdc2c2ebd Gerrit-Change-Number: 33642 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 07 Jul 2023 15:22:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0