July 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: gsm: Fix comment for TCH/F4.8 code
by pespin 07 Jul '23

07 Jul '23

Attention is currently required from: tnt. pespin has removed a vote from this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33640 ) Change subject: gsm: Fix comment for TCH/F4.8 code ...................................................................... Removed Code-Review+1 by pespin <pespin(a)sysmocom.de> -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I62f6d0e9fec180138be5f37664969d56e79f3c13 Gerrit-Change-Number: 33640 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-MessageType: deleteVote

1 0

[M] Change in libosmocore[master]: gsm: Improve the TCH/H2.4 coding routines
by Jenkins Builder 07 Jul '23

07 Jul '23

Attention is currently required from: tnt. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33641 ) Change subject: gsm: Improve the TCH/H2.4 coding routines ...................................................................... Patch Set 2: (2 comments) File src/coding/gsm0503_coding.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-9162): https://gerrit.osmocom.org/c/libosmocore/+/33641/comment/5ad2a3ea_4727be8c PS2, Line 3485: osmo_conv_encode(&gsm0503_tch_h24, &data[ 0], &cB[ 0]); space prohibited after that open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-9162): https://gerrit.osmocom.org/c/libosmocore/+/33641/comment/d4ef67f0_93d2af2f PS2, Line 3522: osmo_conv_decode_ber(&gsm0503_tch_h24, &cB[ 0], &data[ 0], &n_errors_l[0], &n_bits_total_l[0]); space prohibited after that open square bracket '[' -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33641 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id2551ffe2a0ebfd0a6df0e1d288a6f0af7e1eda7 Gerrit-Change-Number: 33641 Gerrit-PatchSet: 2 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Fri, 07 Jul 2023 14:06:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: S1AP_Emulation: add missing create_cb
by pespin 07 Jul '23

07 Jul '23

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33639 ) Change subject: S1AP_Emulation: add missing create_cb ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33639 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I758e7c8d8cc445cf18acdd7a25dcde8846fd84e5 Gerrit-Change-Number: 33639 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Jul 2023 14:06:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: gsm: Improve the TCH/H2.4 coding routines
by tnt 07 Jul '23

07 Jul '23

Attention is currently required from: tnt. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/33641 to look at the new patch set (#2). Change subject: gsm: Improve the TCH/H2.4 coding routines ...................................................................... gsm: Improve the TCH/H2.4 coding routines The spec isn't super clear, but basically the conv coding is done in two blocks of 72 bits. The way it's currently implemented isn't "wrong" in the sense it will produce correct output given no bit errors, but it's better to do the decoding in two blocks because this then it makes use of the fact we know the state of the encoder after the 72 bits, which improves the corrective ability of the code. Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: Id2551ffe2a0ebfd0a6df0e1d288a6f0af7e1eda7 --- M src/coding/gsm0503_coding.c M src/gsm/libosmogsm.map M tests/conv/conv_gsm0503_test.ok M utils/conv_codes_gsm.py 4 files changed, 58 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/41/33641/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33641 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id2551ffe2a0ebfd0a6df0e1d288a6f0af7e1eda7 Gerrit-Change-Number: 33641 Gerrit-PatchSet: 2 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: S1AP_Emulation: delete UE association on S1AP_UeContextReleaseCmd
by pespin 07 Jul '23

07 Jul '23

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33638 ) Change subject: S1AP_Emulation: delete UE association on S1AP_UeContextReleaseCmd ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33638 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8c6f7a780945ce34dabdc794aabab5d16a3a73aa Gerrit-Change-Number: 33638 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Jul 2023 14:04:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: gsm: Fix comment for TCH/F4.8 code
by fixeria 07 Jul '23

07 Jul '23

Attention is currently required from: tnt. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33640 ) Change subject: gsm: Fix comment for TCH/F4.8 code ...................................................................... Patch Set 1: (1 comment) File utils/conv_codes_gsm.py: https://gerrit.osmocom.org/c/libosmocore/+/33640/comment/27799da6_ba469d94 PS1, Line 80: 148 bits blocks > Hmm, but TS 45.003 section 3.4.3 says 152... Ah, it might be the same case as in Id86d1aa0fd6791a8be431b5547bb723c74c35757. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I62f6d0e9fec180138be5f37664969d56e79f3c13 Gerrit-Change-Number: 33640 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Fri, 07 Jul 2023 14:03:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: S1AP_Emulation: fix f_s1ap_id_table_del
by pespin 07 Jul '23

07 Jul '23

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33637 ) Change subject: S1AP_Emulation: fix f_s1ap_id_table_del ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33637 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8528af4e3fda0bc97f8b14785097434a6163bcc4 Gerrit-Change-Number: 33637 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Jul 2023 14:02:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: S1AP_Emulation: remove stray comment
by pespin 07 Jul '23

07 Jul '23

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33636 ) Change subject: S1AP_Emulation: remove stray comment ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: You mean an IMSI should never be stored there? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33636 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I55bfced12d573081311c55d363bfe7bd02fc816f Gerrit-Change-Number: 33636 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Jul 2023 14:02:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: S1AP_Templates: fix tr_S1AP_InitialCtxSetupResp
by pespin 07 Jul '23

07 Jul '23

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33635 ) Change subject: S1AP_Templates: fix tr_S1AP_InitialCtxSetupResp ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33635 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic28c94093e55db0dc1fa18d36e22d328788cb3fc Gerrit-Change-Number: 33635 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Jul 2023 14:02:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: S1AP_Templates: fix tr_S1AP_SetupResp
by pespin 07 Jul '23

07 Jul '23

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33634 ) Change subject: S1AP_Templates: fix tr_S1AP_SetupResp ...................................................................... Patch Set 1: (1 comment) File library/s1ap/S1AP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33634/comment/deb79382_cc6a… PS1, Line 116: *, { Same, add a new line. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33634 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I07513743142f519481530801d4e1185d55f6ea4b Gerrit-Change-Number: 33634 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Jul 2023 14:01:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0