July 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-trx[master]: ms: prune common sch acq code
by Hoernchen 07 Jul '23

07 Jul '23

Attention is currently required from: Hoernchen. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/32953 to look at the new patch set (#4). Change subject: ms: prune common sch acq code ...................................................................... ms: prune common sch acq code Change-Id: Ife639a78a4463f992247c19e0177f683db2ae0b7 --- M Transceiver52M/ms/ms_rx_lower.cpp 1 file changed, 11 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/53/32953/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32953 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ife639a78a4463f992247c19e0177f683db2ae0b7 Gerrit-Change-Number: 32953 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-trx[master]: ms: rearrange code to allow clean exits
by Hoernchen 07 Jul '23

07 Jul '23

Attention is currently required from: Hoernchen. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/32954 to look at the new patch set (#4). Change subject: ms: rearrange code to allow clean exits ...................................................................... ms: rearrange code to allow clean exits This allows gracefully terminating the application by introducing queue timeouts. Change-Id: I0b8deebc63cf4d936666fd68e1666d1917e89a5d --- M Transceiver52M/ms/bladerf_specific.h M Transceiver52M/ms/itrq.h M Transceiver52M/ms/ms.cpp M Transceiver52M/ms/ms.h M Transceiver52M/ms/ms_rx_lower.cpp M Transceiver52M/ms/ms_upper.cpp M Transceiver52M/ms/ms_upper.h 7 files changed, 97 insertions(+), 39 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/54/32954/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32954 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I0b8deebc63cf4d936666fd68e1666d1917e89a5d Gerrit-Change-Number: 32954 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-trx[master]: ms: flexible template for value_type buffer sum
by Hoernchen 07 Jul '23

07 Jul '23

Attention is currently required from: Hoernchen. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/32955 to look at the new patch set (#5). Change subject: ms: flexible template for value_type buffer sum ...................................................................... ms: flexible template for value_type buffer sum Manual attempts to get the number of complex and single samples right turned out to be a bit error prone at times... Change-Id: I3c9953073555e3a7f70b78b0946dfdf949175a82 --- M Transceiver52M/ms/ms.h M Transceiver52M/ms/ms_rx_lower.cpp 2 files changed, 30 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/55/32955/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32955 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I3c9953073555e3a7f70b78b0946dfdf949175a82 Gerrit-Change-Number: 32955 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-trx[master]: ms: make init call less confusing
by Hoernchen 07 Jul '23

07 Jul '23

Attention is currently required from: Hoernchen. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/32957 to look at the new patch set (#5). Change subject: ms: make init call less confusing ...................................................................... ms: make init call less confusing Change-Id: I122b0c8cf97e5efcbc60cd95e8bd06a50d57eb57 --- M Transceiver52M/ms/ms.cpp M Transceiver52M/ms/ms.h 2 files changed, 10 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/57/32957/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32957 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I122b0c8cf97e5efcbc60cd95e8bd06a50d57eb57 Gerrit-Change-Number: 32957 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-trx[master]: ms: xray
by Hoernchen 07 Jul '23

07 Jul '23

Attention is currently required from: Hoernchen. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/32958 to look at the new patch set (#5). Change subject: ms: xray ...................................................................... ms: xray Only used for development, will be removed later. Change-Id: I2039204860f1d6c4a7f4fe78200f560d75a8b90e --- M Transceiver52M/ms/ms_upper.cpp 1 file changed, 55 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/58/32958/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32958 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I2039204860f1d6c4a7f4fe78200f560d75a8b90e Gerrit-Change-Number: 32958 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-trx[master]: ms: sch: drop intermediate softvector
by Hoernchen 07 Jul '23

07 Jul '23

Attention is currently required from: Hoernchen. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/32956 to look at the new patch set (#5). Change subject: ms: sch: drop intermediate softvector ...................................................................... ms: sch: drop intermediate softvector Change-Id: Iadc8f224f9e43282339197b11f388fc574656299 --- M Transceiver52M/ms/ms.h M Transceiver52M/ms/ms_rx_lower.cpp 2 files changed, 15 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/56/32956/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32956 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Iadc8f224f9e43282339197b11f388fc574656299 Gerrit-Change-Number: 32956 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in libosmocore[master]: core: fix pointer access in msgb_l[1-4] macros
by pespin 07 Jul '23

07 Jul '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33646 ) Change subject: core: fix pointer access in msgb_l[1-4] macros ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33646 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2d19ea3c09ff9499314255d408fb71c07148fe25 Gerrit-Change-Number: 33646 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Jul 2023 17:12:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: ctrl: Add getting si2quater earfcn neighbor list
by pespin 07 Jul '23

07 Jul '23

Attention is currently required from: matanp. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33645 ) Change subject: ctrl: Add getting si2quater earfcn neighbor list ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33645 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib942bfa95aca2b514ac68f602545b9e7cbed097a Gerrit-Change-Number: 33645 Gerrit-PatchSet: 2 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Fri, 07 Jul 2023 17:12:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: core: fix pointer access in msgb_l[1-4] macros
by fixeria 07 Jul '23

07 Jul '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/33646 ) Change subject: core: fix pointer access in msgb_l[1-4] macros ...................................................................... core: fix pointer access in msgb_l[1-4] macros Put the 'm' pointer into braces, so that it's possible to pass an expression to these macros, e.g. a pointer-to-pointer dereference. This patch makes the following example compile: struct msgb **msg = /* ... */; return msgb_l2(*msg); /* <-- currently this fails */ Currently it fails with the following error: error: ‘msg’ is a pointer to pointer; did you mean to dereference it before applying ‘->’ to it? Change-Id: I2d19ea3c09ff9499314255d408fb71c07148fe25 --- M include/osmocom/core/msgb.h 1 file changed, 26 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/46/33646/1 diff --git a/include/osmocom/core/msgb.h b/include/osmocom/core/msgb.h index 2529c0e..5c58c84 100644 --- a/include/osmocom/core/msgb.h +++ b/include/osmocom/core/msgb.h @@ -127,13 +127,13 @@ #endif /*! obtain L1 header of msgb */ -#define msgb_l1(m) ((void *)(m->l1h)) +#define msgb_l1(m) ((void *)((m)->l1h)) /*! obtain L2 header of msgb */ -#define msgb_l2(m) ((void *)(m->l2h)) +#define msgb_l2(m) ((void *)((m)->l2h)) /*! obtain L3 header of msgb */ -#define msgb_l3(m) ((void *)(m->l3h)) +#define msgb_l3(m) ((void *)((m)->l3h)) /*! obtain L4 header of msgb */ -#define msgb_l4(m) ((void *)(m->l4h)) +#define msgb_l4(m) ((void *)((m)->l4h)) /*! obtain SMS header of msgb */ #define msgb_sms(m) msgb_l4(m) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33646 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2d19ea3c09ff9499314255d408fb71c07148fe25 Gerrit-Change-Number: 33646 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in libosmocore[master]: gsm: Improve the TCH/H2.4 coding routines
by pespin 07 Jul '23

07 Jul '23

Attention is currently required from: tnt. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33641 ) Change subject: gsm: Improve the TCH/H2.4 coding routines ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33641 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id2551ffe2a0ebfd0a6df0e1d288a6f0af7e1eda7 Gerrit-Change-Number: 33641 Gerrit-PatchSet: 2 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Fri, 07 Jul 2023 17:11:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0