July 2023 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-sccp[master]: sccp: Use tdef to implement osmo_sccp_timers
by pespin 11 Jul '23

11 Jul '23

Attention is currently required from: osmith, pespin. Hello osmith, Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/33644 to look at the new patch set (#4). Change subject: sccp: Use tdef to implement osmo_sccp_timers ...................................................................... sccp: Use tdef to implement osmo_sccp_timers Related: OS#4372 Change-Id: I1dbe49a83a1bcddf074d5e638babd065834a0ebd --- M src/sccp_internal.h M src/sccp_scoc.c M src/sccp_user.c M src/sccp_vty.c 4 files changed, 66 insertions(+), 121 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/44/33644/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/33644 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I1dbe49a83a1bcddf074d5e638babd065834a0ebd Gerrit-Change-Number: 33644 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts/expected-results.xml: expect TC_t200_n200 to pass
by fixeria 11 Jul '23

11 Jul '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33683 ) Change subject: bts/expected-results.xml: expect TC_t200_n200 to pass ...................................................................... bts/expected-results.xml: expect TC_t200_n200 to pass This testcase has been fixed in [1] and is currently passing. Change-Id: I9bc81629a9baaf922a87ac95c8f69af343aacdf1 Related: [1] I2c328219b1a37d0f4623c5728143cd91976000a0 Related: OS#5972 --- M bts/expected-results.xml 1 file changed, 14 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/83/33683/1 diff --git a/bts/expected-results.xml b/bts/expected-results.xml index f559132..a78755c 100644 --- a/bts/expected-results.xml +++ b/bts/expected-results.xml @@ -250,12 +250,7 @@ <testcase classname='BTS_Tests_LAPDm' name='TC_rec_invalid_frame' time='MASKED'/> <testcase classname='BTS_Tests_LAPDm' name='TC_segm_concat_dcch' time='MASKED'/> <testcase classname='BTS_Tests_LAPDm' name='TC_segm_concat_sacch' time='MASKED'/> - <testcase classname='BTS_Tests_LAPDm' name='TC_t200_n200' time='MASKED'> - <failure type='fail-verdict'>"BTS_Tests.ttcn:MASKED : Tguard timeout" - BTS_Tests_LAPDm.ttcn:MASKED BTS_Tests_LAPDm control part - BTS_Tests_LAPDm.ttcn:MASKED TC_t200_n200 testcase - </failure> - </testcase> + <testcase classname='BTS_Tests_LAPDm' name='TC_t200_n200' time='MASKED'/> <testcase classname='BTS_Tests_LAPDm' name='TC_rr_response_frame_loss' time='MASKED'/> <testcase classname='BTS_Tests_LAPDm' name='TC_incorrect_cr' time='MASKED'/> <testcase classname='BTS_Tests_LAPDm' name='TC_sabm_incorrect_c' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33683 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9bc81629a9baaf922a87ac95c8f69af343aacdf1 Gerrit-Change-Number: 33683 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bsc[master]: contrib/jenkins.sh: deduplicate configure flags
by osmith 11 Jul '23

11 Jul '23

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/33680 to look at the new patch set (#2). Change subject: contrib/jenkins.sh: deduplicate configure flags ...................................................................... contrib/jenkins.sh: deduplicate configure flags Prepare to add meas-related flags to CONFIG in future patches. Related: OS#5173 Change-Id: I5685aa0bcb77286d1cd89cc9c8fee58991597446 --- M contrib/jenkins.sh 1 file changed, 16 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/80/33680/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33680 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5685aa0bcb77286d1cd89cc9c8fee58991597446 Gerrit-Change-Number: 33680 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-bsc[master]: configure: add --enable-meas-udp2db/pcap2db/vis
by osmith 11 Jul '23

11 Jul '23

Attention is currently required from: osmith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/33681 to look at the new patch set (#3). Change subject: configure: add --enable-meas-udp2db/pcap2db/vis ...................................................................... configure: add --enable-meas-udp2db/pcap2db/vis Do not build these utils implicitly if libsqlite3/libpcap/libcdk are installed. Add configure flags for explicit building and fail if dependencies are missing. Keep behavior in deb and rpm packaging: * deb: build meas_vis * rpm: build none of these (libcdk dependency for meas_vis is not available in most rpm-based distributions we build for) Fixes: OS#5173 Depends: docker-playground I015b6d7cb834e99ea5d04206ba5f8c519c4e6af1 Change-Id: I8b3d5efb769437a5d3036e1e627b8d477275d93e --- M configure.ac M contrib/jenkins.sh M debian/rules M src/utils/Makefile.am 4 files changed, 64 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/81/33681/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33681 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8b3d5efb769437a5d3036e1e627b8d477275d93e Gerrit-Change-Number: 33681 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[L] Change in osmo-msc[master]: ASCI: Add simple implementation of Group Call Register
by pespin 11 Jul '23

11 Jul '23

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33510 ) Change subject: ASCI: Add simple implementation of Group Call Register ...................................................................... Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33510 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ia74a4a865f943c5fb388cd28f9406005c92e663e Gerrit-Change-Number: 33510 Gerrit-PatchSet: 11 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 11 Jul 2023 12:52:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmo-msc[master]: ASCI: Add simple implementation of Group Call Register
by pespin 11 Jul '23

11 Jul '23

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33510 ) Change subject: ASCI: Add simple implementation of Group Call Register ...................................................................... Patch Set 11: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33510 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ia74a4a865f943c5fb388cd28f9406005c92e663e Gerrit-Change-Number: 33510 Gerrit-PatchSet: 11 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 11 Jul 2023 12:51:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: Install liburing-dev in jenkins and build containers
by daniel 11 Jul '23

11 Jul '23

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/33682 ) Change subject: Install liburing-dev in jenkins and build containers ...................................................................... Install liburing-dev in jenkins and build containers Change-Id: I048c43d3bcbecfdfd26e087109fb99315e1629ec --- M centos8-build/Dockerfile M debian-bullseye-build/Dockerfile M debian-bullseye-jenkins-arm/Dockerfile M debian-bullseye-jenkins/Dockerfile 4 files changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/82/33682/1 diff --git a/centos8-build/Dockerfile b/centos8-build/Dockerfile index 19593c1..4480be7 100644 --- a/centos8-build/Dockerfile +++ b/centos8-build/Dockerfile @@ -45,6 +45,7 @@ libsofia-sip-ua-glib3 \ libtalloc-devel \ libtool \ + liburing-devel \ libusb1-devel \ lksctp-tools-devel \ make \ diff --git a/debian-bullseye-build/Dockerfile b/debian-bullseye-build/Dockerfile index 4f09929..2d7a238 100644 --- a/debian-bullseye-build/Dockerfile +++ b/debian-bullseye-build/Dockerfile @@ -51,6 +51,7 @@ libsofia-sip-ua-glib-dev \ libsqlite3-dev \ libssl-dev \ + liburing-dev \ libusb-dev \ libusb-1.0-0-dev \ make \ diff --git a/debian-bullseye-jenkins-arm/Dockerfile b/debian-bullseye-jenkins-arm/Dockerfile index 8ba9c49..31958ab 100644 --- a/debian-bullseye-jenkins-arm/Dockerfile +++ b/debian-bullseye-jenkins-arm/Dockerfile @@ -33,6 +33,7 @@ libsctp-dev \ libtalloc-dev \ libtool \ + liburing-dev \ libusb-1.0-0-dev \ make \ pkg-config \ diff --git a/debian-bullseye-jenkins/Dockerfile b/debian-bullseye-jenkins/Dockerfile index 2edd3f6..0083e63 100644 --- a/debian-bullseye-jenkins/Dockerfile +++ b/debian-bullseye-jenkins/Dockerfile @@ -91,6 +91,7 @@ libtalloc-dev \ libtinfo5 \ libtool \ + liburing-dev \ libusb-1.0-0-dev \ libusb-dev \ libxml2-utils \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33682 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I048c43d3bcbecfdfd26e087109fb99315e1629ec Gerrit-Change-Number: 33682 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-bsc[master]: configure: add --enable-meas-udp2db/pcap2db/vis
by osmith 11 Jul '23

11 Jul '23

Attention is currently required from: osmith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/33681 to look at the new patch set (#2). Change subject: configure: add --enable-meas-udp2db/pcap2db/vis ...................................................................... configure: add --enable-meas-udp2db/pcap2db/vis Do not build these utils implicitly if libsqlite3/libpcap/libcdk are installed. Add configure flags for explicit building and fail if dependencies are missing. Keep behavior in deb and rpm packaging: * deb: build meas_vis * rpm: build none of these (libcdk dependency for meas_vis is not available in most rpm-based distributions we build for) Fixes: OS#5173 Depends: docker-playground I015b6d7cb834e99ea5d04206ba5f8c519c4e6af1 Change-Id: I8b3d5efb769437a5d3036e1e627b8d477275d93e --- M configure.ac M contrib/jenkins.sh M debian/rules M src/utils/Makefile.am 4 files changed, 64 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/81/33681/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33681 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8b3d5efb769437a5d3036e1e627b8d477275d93e Gerrit-Change-Number: 33681 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-bsc[master]: ASCI: Prepare bssmap_handle_ass_req_ct_speech() for VGCS/VBS
by jolly 11 Jul '23

11 Jul '23

Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/33603 to look at the new patch set (#4). Change subject: ASCI: Prepare bssmap_handle_ass_req_ct_speech() for VGCS/VBS ...................................................................... ASCI: Prepare bssmap_handle_ass_req_ct_speech() for VGCS/VBS bssmap_handle_ass_req_ct_speech() calls select_codecs(), which requires a bts pointer. An extra bts pointer is added to both function and used instead of deiving it from the conn->lchan pointer. This funcion can then be called if no channel is assigned (yet). (conn->lchan is NULL) This function will be used by the VGCS/VBS call control also. (Chg-Id: Id9e94fb4f27bb438b7093c031344a3400bfa34f1) Change-Id: Ifc1e315d5282f01f8d1bd600d62476c2ae74eca9 Related: OS#4852 --- M src/osmo-bsc/osmo_bsc_bssap.c 1 file changed, 26 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/03/33603/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33603 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifc1e315d5282f01f8d1bd600d62476c2ae74eca9 Gerrit-Change-Number: 33603 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ci[master]: ansible: Install liburing as osmocom build dep
by daniel 11 Jul '23

11 Jul '23

daniel has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/33671 ) Change subject: ansible: Install liburing as osmocom build dep ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/33671 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2535672959e307ef2fa184e2eaf54f883f5c78dc Gerrit-Change-Number: 33671 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: abandon

1 0