July 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: ansible: Install liburing as osmocom build dep
by osmith 11 Jul '23

11 Jul '23

Attention is currently required from: daniel. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/33671 ) Change subject: ansible: Install liburing as osmocom build dep ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > We build everything in docker containers, not directly on the host. […] The above is for jenkins + master build jobs. To have the dependency available in ttcn3, also add it here: * debian-bullseye-build * centos8-build (It would probably make sense to combine debian-bullseye-jenkins with debian-bullseye-build at some point.) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/33671 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2535672959e307ef2fa184e2eaf54f883f5c78dc Gerrit-Change-Number: 33671 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Jul 2023 12:29:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[L] Change in osmo-msc[master]: ASCI: Add VTY to configure GCR (Group Call Register)
by jolly 11 Jul '23

11 Jul '23

Attention is currently required from: jolly. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/33512 to look at the new patch set (#15). Change subject: ASCI: Add VTY to configure GCR (Group Call Register) ...................................................................... ASCI: Add VTY to configure GCR (Group Call Register) Change-Id: I5bd034a62fc8b483f550d29103c2f7587198f590 Related: OS#4854 --- M include/osmocom/msc/Makefile.am A include/osmocom/msc/asci_vty.h M include/osmocom/msc/vty.h M src/libmsc/Makefile.am A src/libmsc/asci_vty.c M src/libmsc/msc_vty.c M src/osmo-msc/msc_main.c M tests/test_nodes.vty 8 files changed, 489 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/12/33512/15 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33512 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I5bd034a62fc8b483f550d29103c2f7587198f590 Gerrit-Change-Number: 33512 Gerrit-PatchSet: 15 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 0

[XL] Change in osmo-msc[master]: ASCI: Add call control for VGCS/VBS
by jolly 11 Jul '23

11 Jul '23

Attention is currently required from: jolly, dexter. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/33511 to look at the new patch set (#13). Change subject: ASCI: Add call control for VGCS/VBS ...................................................................... ASCI: Add call control for VGCS/VBS Change-Id: I9947403fde8212b66758104443c60aaacc8b1e7b Related: OS#4854 --- M include/osmocom/msc/Makefile.am A include/osmocom/msc/msc_vgcs.h M include/osmocom/msc/ran_conn.h M include/osmocom/msc/transaction.h M src/libmsc/Makefile.am M src/libmsc/gsm_04_11_gsup.c A src/libmsc/msc_vgcs.c M src/libmsc/transaction.c 8 files changed, 3,037 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/11/33511/13 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9947403fde8212b66758104443c60aaacc8b1e7b Gerrit-Change-Number: 33511 Gerrit-PatchSet: 13 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[L] Change in osmo-msc[master]: ASCI: Add simple implementation of Group Call Register
by jolly 11 Jul '23

11 Jul '23

Attention is currently required from: jolly. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/33510 to look at the new patch set (#11). Change subject: ASCI: Add simple implementation of Group Call Register ...................................................................... ASCI: Add simple implementation of Group Call Register This is a built-in data structure to store and handle voice group calls. The GCR will be used by VGCS/VBS call control. (Chg-Id: I9947403fde8212b66758104443c60aaacc8b1e7b) The GCR will be used by VTY code. (Chg-Id: I5bd034a62fc8b483f550d29103c2f7587198f590) Change-Id: Ia74a4a865f943c5fb388cd28f9406005c92e663e Related: OS#4854 --- M include/osmocom/msc/Makefile.am A include/osmocom/msc/asci_gcr.h M include/osmocom/msc/gsm_data.h M src/libmsc/Makefile.am A src/libmsc/asci_gcr.c M src/libmsc/msc_net_init.c 6 files changed, 256 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/10/33510/11 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33510 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ia74a4a865f943c5fb388cd28f9406005c92e663e Gerrit-Change-Number: 33510 Gerrit-PatchSet: 11 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-msc[master]: ASCI: Clear VGCS call and channel on BSSMAP reset message
by jolly 11 Jul '23

11 Jul '23

Attention is currently required from: laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/33514 to look at the new patch set (#15). Change subject: ASCI: Clear VGCS call and channel on BSSMAP reset message ...................................................................... ASCI: Clear VGCS call and channel on BSSMAP reset message When sending or receiving BSSMAP reset msg, the ongoing VGCS/VBS SCCP connections are cleared. E.g. this happens if the BSC is reastarted and there is an ongoing VGCS/VBS call at this BSC. Change-Id: Ib0b309150b82148098d05cfb1fb18767283e654e Related: OS#4854 --- M src/libmsc/ran_peer.c 1 file changed, 20 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/14/33514/15 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33514 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib0b309150b82148098d05cfb1fb18767283e654e Gerrit-Change-Number: 33514 Gerrit-PatchSet: 15 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-msc[master]: ASCI: Add option to switch on or off ASCI support
by jolly 11 Jul '23

11 Jul '23

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/33674 ) Change subject: ASCI: Add option to switch on or off ASCI support ...................................................................... ASCI: Add option to switch on or off ASCI support Switching ASCI support is controled via VTY. This added in a later patch. (Chg-Id: I5bd034a62fc8b483f550d29103c2f7587198f590) Change-Id: Id68deb69f7395f0f8f50b3820e9d51052a34f753 Related: OS#4854 --- M include/osmocom/msc/gsm_data.h M include/osmocom/msc/msc_a.h M src/libmsc/gsm_04_08.c M src/libmsc/msc_a.c 4 files changed, 29 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/74/33674/1 diff --git a/include/osmocom/msc/gsm_data.h b/include/osmocom/msc/gsm_data.h index 6c0dac9..119f093 100644 --- a/include/osmocom/msc/gsm_data.h +++ b/include/osmocom/msc/gsm_data.h @@ -272,6 +272,7 @@ /* ASCI feature support */ struct { + bool enable; struct llist_head gcr_lists; } asci; }; diff --git a/include/osmocom/msc/msc_a.h b/include/osmocom/msc/msc_a.h index bef7417..0276d62 100644 --- a/include/osmocom/msc/msc_a.h +++ b/include/osmocom/msc/msc_a.h @@ -217,7 +217,7 @@ int msc_a_ensure_cn_local_rtp(struct msc_a *msc_a, struct gsm_trans *cc_trans); int msc_a_try_call_assignment(struct gsm_trans *cc_trans); -const char *msc_a_cm_service_type_to_use(enum osmo_cm_service_type cm_service_type); +const char *msc_a_cm_service_type_to_use(struct msc_a *msc_a, enum osmo_cm_service_type cm_service_type); void msc_a_release_cn(struct msc_a *msc_a); void msc_a_release_mo(struct msc_a *msc_a, enum gsm48_gsm_cause gsm_cause); diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c index bd7cfe0..10c4a57 100644 --- a/src/libmsc/gsm_04_08.c +++ b/src/libmsc/gsm_04_08.c @@ -798,13 +798,13 @@ return msc_gsm48_tx_mm_serv_rej(msc_a, GSM48_REJECT_INCORRECT_MESSAGE); } - if (!msc_a_cm_service_type_to_use(req->cm_service_type)) + if (!msc_a_cm_service_type_to_use(msc_a, req->cm_service_type)) return msc_gsm48_tx_mm_serv_rej(msc_a, GSM48_REJECT_SRV_OPT_NOT_SUPPORTED); /* At this point, the CM Service Request message is being accepted. * Increment the matching use token, and from here on use msc_vlr_tx_cm_serv_rej() to respond in case of * failure. */ - msc_a_get(msc_a, msc_a_cm_service_type_to_use(req->cm_service_type)); + msc_a_get(msc_a, msc_a_cm_service_type_to_use(msc_a, req->cm_service_type)); if (msc_a_is_accepted(msc_a)) return cm_serv_reuse_conn(msc_a, &mi, req->cm_service_type); @@ -1531,7 +1531,7 @@ { struct msc_a *msc_a = msc_conn_ref; msc_gsm48_tx_mm_serv_rej(msc_a, cause); - msc_a_put(msc_a, msc_a_cm_service_type_to_use(cm_service_type)); + msc_a_put(msc_a, msc_a_cm_service_type_to_use(msc_a, cm_service_type)); return 0; } diff --git a/src/libmsc/msc_a.c b/src/libmsc/msc_a.c index 7013176..9f2420e 100644 --- a/src/libmsc/msc_a.c +++ b/src/libmsc/msc_a.c @@ -2085,8 +2085,10 @@ * Given a CM Service type, return a matching token intended for osmo_use_count. * For unknown service type, return NULL. */ -const char *msc_a_cm_service_type_to_use(enum osmo_cm_service_type cm_service_type) +const char *msc_a_cm_service_type_to_use(struct msc_a *msc_a, enum osmo_cm_service_type cm_service_type) { + struct gsm_network *net = msc_a_net(msc_a); + switch (cm_service_type) { case GSM48_CMSERV_MO_CALL_PACKET: case GSM48_CMSERV_EMERGENCY: @@ -2099,10 +2101,16 @@ return MSC_A_USE_CM_SERVICE_SS; case GSM48_CMSERV_VGCS: - return MSC_A_USE_CM_SERVICE_GCC; + if (net->asci.enable) + return MSC_A_USE_CM_SERVICE_GCC; + else + return NULL; case GSM48_CMSERV_VBS: - return MSC_A_USE_CM_SERVICE_BCC; + if (net->asci.enable) + return MSC_A_USE_CM_SERVICE_BCC; + else + return NULL; default: return NULL; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33674 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Id68deb69f7395f0f8f50b3820e9d51052a34f753 Gerrit-Change-Number: 33674 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-mgw[master]: ASCI: Add new mode for voice group/broadcast call
by jolly 11 Jul '23

11 Jul '23

jolly has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/33546 ) Change subject: ASCI: Add new mode for voice group/broadcast call ...................................................................... ASCI: Add new mode for voice group/broadcast call The new mode "confecho" is similar to "sendrecv", except that it also echoes back RTP towards the sender. This is required for voice group or broadcast calls. Talker and listeners use the same timeslot, so that audio must be echoed from the talker to the listeners. It is different from "loopback", because a loopback only echoes back RTP towards the sender, but does not forward audio through the endpoint to the other connections. Also it does not forward RTP from senders of other connections. The current implementation of MGW does not support transcoding and mixing. This means that a sending connection must not send RTP that has been received by multiple receiving connections. The application that uses the MGW has to set the connection modes, so that only one connection receives RTP in case of a conference. Change-Id: I0639c663e119d85bef1010c7aa45e2f133a9daf0 Related: OS#4853 --- M include/osmocom/mgcp/mgcp_common.h M src/libosmo-mgcp-client/mgcp_client.c M src/libosmo-mgcp/mgcp_msg.c 3 files changed, 31 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/include/osmocom/mgcp/mgcp_common.h b/include/osmocom/mgcp/mgcp_common.h index 07d8d37..7de45f9 100644 --- a/include/osmocom/mgcp/mgcp_common.h +++ b/include/osmocom/mgcp/mgcp_common.h @@ -47,6 +47,7 @@ MGCP_CONN_SEND_ONLY = 2, MGCP_CONN_RECV_SEND = MGCP_CONN_RECV_ONLY | MGCP_CONN_SEND_ONLY, MGCP_CONN_LOOPBACK = 4 | MGCP_CONN_RECV_SEND, + MGCP_CONN_CONFECHO = 8 | MGCP_CONN_RECV_SEND, }; #define MGCP_X_OSMO_IGN_HEADER "X-Osmo-IGN:" diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c index 78652a1..5df4560 100644 --- a/src/libosmo-mgcp-client/mgcp_client.c +++ b/src/libosmo-mgcp-client/mgcp_client.c @@ -1548,6 +1548,7 @@ { MGCP_CONN_RECV_SEND, "sendrecv" }, { MGCP_CONN_SEND_ONLY, "sendonly" }, { MGCP_CONN_RECV_ONLY, "recvonly" }, + { MGCP_CONN_CONFECHO, "confecho" }, { MGCP_CONN_LOOPBACK, "loopback" }, { 0, NULL } }; diff --git a/src/libosmo-mgcp/mgcp_msg.c b/src/libosmo-mgcp/mgcp_msg.c index 26a44c6..a46ffc2 100644 --- a/src/libosmo-mgcp/mgcp_msg.c +++ b/src/libosmo-mgcp/mgcp_msg.c @@ -75,7 +75,7 @@ } /*! Parse connection mode. - * \param[in] mode as string (recvonly, sendrecv, sendonly or loopback) + * \param[in] mode as string (recvonly, sendrecv, sendonly confecho or loopback) * \param[in] endp pointer to endpoint (only used for log output) * \param[out] associated connection to be modified accordingly * \returns 0 on success, -1 on error */ @@ -100,6 +100,8 @@ conn->mode = MGCP_CONN_RECV_SEND; else if (strcasecmp(mode, "sendonly") == 0) conn->mode = MGCP_CONN_SEND_ONLY; + else if (strcasecmp(mode, "confecho") == 0) + conn->mode = MGCP_CONN_CONFECHO; else if (strcasecmp(mode, "loopback") == 0) conn->mode = MGCP_CONN_LOOPBACK; else { -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/33546 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I0639c663e119d85bef1010c7aa45e2f133a9daf0 Gerrit-Change-Number: 33546 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-mgw[master]: ASCI: Add new mode for voice group/broadcast call
by jolly 11 Jul '23

11 Jul '23

Attention is currently required from: dexter. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/33546 ) Change subject: ASCI: Add new mode for voice group/broadcast call ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-mgw/+/33546/comment/2f26ee38_806130b3 PS3, Line 23: connection receives RTP in case of a conference. > Sending and receiving is from the MGW point of view. This is how the modes are named. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/33546 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I0639c663e119d85bef1010c7aa45e2f133a9daf0 Gerrit-Change-Number: 33546 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Jul 2023 12:26:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in libosmo-sccp[master]: ss7: Refactor osmo_ss7_asp_find_or_create()
by fixeria 11 Jul '23

11 Jul '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/33647 ) Change subject: ss7: Refactor osmo_ss7_asp_find_or_create() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/33647 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ibbf20c63fc1d2b22a7c5d750002f94795ee31f26 Gerrit-Change-Number: 33647 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Jul 2023 12:24:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmo-sccp[master]: sccp: Use tdef to implement osmo_sccp_timers
by fixeria 11 Jul '23

11 Jul '23

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/33644 ) Change subject: sccp: Use tdef to implement osmo_sccp_timers ...................................................................... Patch Set 3: Code-Review+2 (1 comment) File src/sccp_user.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/33644/comment/278a1b6c_8b86071b PS3, Line 241: talloc_size Not critical: you could use `talloc_memdup()`, which is equivalent to calling `talloc_size()` and `memcpy()`: ``` inst->tdefs = talloc_memdup(inst, osmo_sccp_timer_defaults, sizeof(osmo_sccp_timer_defaults)); ``` -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/33644 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I1dbe49a83a1bcddf074d5e638babd065834a0ebd Gerrit-Change-Number: 33644 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Jul 2023 12:22:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0