July 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: */osmo-stp.cfg: Explicitly define role & sctp-role
by pespin 11 Jul '23

11 Jul '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33576 ) Change subject: */osmo-stp.cfg: Explicitly define role & sctp-role ...................................................................... */osmo-stp.cfg: Explicitly define role & sctp-role It was recently decided it's a good practice to always specify the role and sctp-role for all ASPs configured in the VTY, since it's an important configuration providing feedback on the network setup expectancies. Change-Id: If48ca06f2cc3c0986daa5f6264d80138d468332a --- M bsc/osmo-stp.cfg M hnbgw/osmo-stp.cfg M msc/osmo-stp.cfg M sgsn/osmo-stp.cfg M smlc/osmo-stp.cfg M stp/osmo-stp.cfg 6 files changed, 53 insertions(+), 4 deletions(-) Approvals: pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bsc/osmo-stp.cfg b/bsc/osmo-stp.cfg index 21952dc..d936d4f 100644 --- a/bsc/osmo-stp.cfg +++ b/bsc/osmo-stp.cfg @@ -26,6 +26,8 @@ asp virt-msc0-0 23905 2905 m3ua local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server as mahlzeit ipa routing-key 0 0.23.4 point-code override dpc 0.23.1 @@ -36,6 +38,8 @@ asp virt-msc1-0 23906 2905 m3ua local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server as virt-msc1 m3ua asp virt-msc1-0 routing-key 2 0.0.2 @@ -43,6 +47,8 @@ asp virt-msc2-0 23907 2905 m3ua local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server as virt-msc2 m3ua asp virt-msc2-0 routing-key 3 0.0.3 diff --git a/hnbgw/osmo-stp.cfg b/hnbgw/osmo-stp.cfg index 85d60e9..651975b 100644 --- a/hnbgw/osmo-stp.cfg +++ b/hnbgw/osmo-stp.cfg @@ -34,17 +34,20 @@ asp virt-msc0-0 23905 2905 m3ua local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server as virt-msc0 m3ua asp virt-msc0-0 routing-key 1 0.23.4 asp virt-sgsn0-0 23906 2905 m3ua local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server as virt-sgsn0 m3ua asp virt-sgsn0-0 routing-key 2 0.23.1 - route-table system update route 0.23.4 7.255.7 linkset virt-msc0 update route 0.23.1 7.255.7 linkset virt-sgsn0 diff --git a/msc/osmo-stp.cfg b/msc/osmo-stp.cfg index fc3cf54..772b6d1 100644 --- a/msc/osmo-stp.cfg +++ b/msc/osmo-stp.cfg @@ -26,18 +26,24 @@ asp virt-bsc0-0 23906 2905 m3ua local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server as virt-bsc0 m3ua asp virt-bsc0-0 routing-key 0 0.24.1 asp virt-bsc1-0 23907 2905 m3ua local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server as virt-bsc1 m3ua asp virt-bsc1-0 routing-key 1 0.24.2 asp virt-rnc0-0 23908 2905 m3ua local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server as virt-rnc0 m3ua asp virt-rnc0-0 routing-key 2 0.24.3 diff --git a/sgsn/osmo-stp.cfg b/sgsn/osmo-stp.cfg index bf1148f..7823f2a 100644 --- a/sgsn/osmo-stp.cfg +++ b/sgsn/osmo-stp.cfg @@ -39,6 +39,8 @@ asp virt-rnc0-0 23908 2905 m3ua local-ip 127.0.0.200 remote-ip 127.0.0.103 + role sg + sctp-role server as virt-rnc0 m3ua asp virt-rnc0-0 routing-key 2 0.24.3 diff --git a/smlc/osmo-stp.cfg b/smlc/osmo-stp.cfg index 062bea5..e2568e2 100644 --- a/smlc/osmo-stp.cfg +++ b/smlc/osmo-stp.cfg @@ -34,6 +34,8 @@ asp virt-bsc0-0 23905 2905 m3ua local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server as virt-bsc0 m3ua asp virt-bsc0-0 routing-key 1 0.23.3 diff --git a/stp/osmo-stp.cfg b/stp/osmo-stp.cfg index 427eb34..5f67dff 100644 --- a/stp/osmo-stp.cfg +++ b/stp/osmo-stp.cfg @@ -42,27 +42,33 @@ asp asp-sender 9999 2905 m3ua local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server asp asp-receiver0 10000 2905 m3ua local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server asp asp-receiver1 10001 2905 m3ua local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server asp asp-client0 10002 2906 m3ua local-ip 127.0.0.1 remote-ip 127.0.0.1 - sctp-role client role asp + sctp-role client asp asp-client60-norctx0 11060 2907 m3ua local-ip 127.0.0.1 remote-ip 127.0.0.1 - sctp-role client role asp + sctp-role client asp asp-client61-norctx0 11061 2907 m3ua local-ip 127.0.0.1 remote-ip 127.0.0.1 - sctp-role client role asp + sctp-role client as as-sender m3ua asp asp-sender routing-key 1023 23 @@ -85,6 +91,8 @@ asp ipa-asp-loadshare-sender 20000 5000 ipa local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server as ipa-as-loadshare-sender ipa routing-key 0 6 point-code override dpc 31 @@ -92,9 +100,13 @@ asp ipa-asp-loadshare-receiver0 20001 5000 ipa local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server asp ipa-asp-loadshare-receiver1 20002 5000 ipa local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server as ipa-as-loadshare-receiver ipa traffic-mode loadshare routing-key 0 7 @@ -105,6 +117,8 @@ asp ipa-asp-override-sender 20004 5000 ipa local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server as ipa-as-override-sender ipa routing-key 0 6 point-code override dpc 33 @@ -112,6 +126,8 @@ asp ipa-asp-override-receiver0 20005 5000 ipa local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server asp ipa-asp-override-receiver1 20006 5000 ipa local-ip 127.0.0.1 remote-ip 127.0.0.1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33576 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If48ca06f2cc3c0986daa5f6264d80138d468332a Gerrit-Change-Number: 33576 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-ttcn3-hacks[master]: */osmo-stp.cfg: Explicitly define role & sctp-role
by pespin 11 Jul '23

11 Jul '23

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33576 ) Change subject: */osmo-stp.cfg: Explicitly define role & sctp-role ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33576 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If48ca06f2cc3c0986daa5f6264d80138d468332a Gerrit-Change-Number: 33576 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Jul 2023 11:48:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: osmo-bts-trx: implement TCH/F2.4 support for CSD
by pespin 11 Jul '23

11 Jul '23

Attention is currently required from: laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33651 ) Change subject: osmo-bts-trx: implement TCH/F2.4 support for CSD ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33651 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I31c59a78a362986b0cd1bc6650c325ee9f206519 Gerrit-Change-Number: 33651 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Jul 2023 11:47:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-gprs[master]: doc: add PDCH timing diagram illustrating UL/DL delay
by pespin 11 Jul '23

11 Jul '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33673 ) Change subject: doc: add PDCH timing diagram illustrating UL/DL delay ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33673 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I7d01c833b6b746d74e6ecd8c65c929a320a95d17 Gerrit-Change-Number: 33673 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Jul 2023 11:38:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-gprs[master]: doc: add PDCH timing diagram illustrating UL/DL delay
by fixeria 11 Jul '23

11 Jul '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33673 ) Change subject: doc: add PDCH timing diagram illustrating UL/DL delay ...................................................................... doc: add PDCH timing diagram illustrating UL/DL delay Change-Id: I7d01c833b6b746d74e6ecd8c65c929a320a95d17 --- A doc/pdch_timing.txt 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/73/33673/1 diff --git a/doc/pdch_timing.txt b/doc/pdch_timing.txt new file mode 100644 index 0000000..ade646a --- /dev/null +++ b/doc/pdch_timing.txt @@ -0,0 +1,15 @@ +Assuming that PDCH is on TS1 + + | DL burst 1/4 | DL burst 2/4 | DL burst 3/4 | DL burst 4/4, our USF! + | | | | + |<----@------(Fn=0)------------>|<----@------(Fn=1)------------>|<----@------(Fn=2)------------>|<----@------(Fn=3)------------>| +DL | 0 | 1 | 2 | 3 | 4 | 5 | 6 | 7 | 0 | 1 | 2 | 3 | 4 | 5 | 6 | 7 | 0 | 1 | 2 | 3 | 4 | 5 | 6 | 7 | 0 | 1 | 2 | 3 | 4 | 5 | 6 | 7 | +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +UL | 0 | 1 | 2 | 3 | 4 | 5 | 6 | 7 | 0 | 1 | 2 | 3 | 4 | 5 | 6 | 7 | 0 | 1 | 2 | 3 | 4 | 5 | 6 | 7 | 0 | 1 | 2 | 3 | 4 | 5 | 6 | 7 | 0 | 1 | 2 | 3 | 4 | 5 | 6 | 7 | + |<----@------(Fn=0)------------>|<----@------(Fn=1)------------>|<----@------(Fn=2)------------>|<----@------(Fn=3)------------>|<----@------(Fn=4)------------>| + | | | | | | | + | UL burst 1/4 | UL burst 2/4 | UL burst 3/4 | | UL burst 4/4 | | UL burst 1/4, Tx time! + | | + | | + |<------------------------------------->| + 10 * 0.577 ms = 5.77 ms -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33673 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I7d01c833b6b746d74e6ecd8c65c929a320a95d17 Gerrit-Change-Number: 33673 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-bts[master]: osmo-bts-trx: visualize rx_tch[fh]_fn() functions
by pespin 11 Jul '23

11 Jul '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33076 ) Change subject: osmo-bts-trx: visualize rx_tch[fh]_fn() functions ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33076 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I373dbbc3d427858f76d07ff85633e07fe2600770 Gerrit-Change-Number: 33076 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Jul 2023 11:28:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-mgw[master]: ASCI: Add new mode for voice group/broadcast call
by pespin 11 Jul '23

11 Jul '23

Attention is currently required from: jolly, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/33546 ) Change subject: ASCI: Add new mode for voice group/broadcast call ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/33546 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I0639c663e119d85bef1010c7aa45e2f133a9daf0 Gerrit-Change-Number: 33546 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Jul 2023 11:24:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in osmo-bsc[master]: ASCI: Add processing and FSMs for VGCS/VBS
by pespin 11 Jul '23

11 Jul '23

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33611 ) Change subject: ASCI: Add processing and FSMs for VGCS/VBS ...................................................................... Patch Set 4: -Code-Review -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33611 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id9e94fb4f27bb438b7093c031344a3400bfa34f1 Gerrit-Change-Number: 33611 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 11 Jul 2023 11:17:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: ASCI: Add support for Group/Broadcast channel activation
by pespin 11 Jul '23

11 Jul '23

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33599 ) Change subject: ASCI: Add support for Group/Broadcast channel activation ...................................................................... Patch Set 3: -Code-Review -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33599 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic0c0597d149d0758d6766937d99660fa02e0e139 Gerrit-Change-Number: 33599 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 11 Jul 2023 11:14:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: osmo-bts-trx: implement FACCH/[FH] support for CSD
by pespin 11 Jul '23

11 Jul '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33586 ) Change subject: osmo-bts-trx: implement FACCH/[FH] support for CSD ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I4c6736e84c271240d457998de688c0baf59fe578 Gerrit-Change-Number: 33586 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Jul 2023 11:06:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0