July 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bsc[master]: contrib/jenkins.sh: deduplicate configure flags
by osmith 11 Jul '23

11 Jul '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33680 ) Change subject: contrib/jenkins.sh: deduplicate configure flags ...................................................................... contrib/jenkins.sh: deduplicate configure flags Prepare to add meas-related flags to CONFIG in future patches. Related: OS#5173 Change-Id: I5685aa0bcb77286d1cd89cc9c8fee58991597446 --- M contrib/jenkins.sh 1 file changed, 16 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 695af3a..a89f7d5 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -60,9 +60,9 @@ osmo-build-dep.sh osmo-mgw # Additional configure options and depends -CONFIG="" +CONFIG="--enable-external-tests --enable-werror" if [ "$WITH_MANUALS" = "1" ]; then - CONFIG="--enable-manuals" + CONFIG="$CONFIG --enable-manuals" fi set +x @@ -75,12 +75,12 @@ cd "$base" autoreconf --install --force -./configure --enable-sanitize --enable-external-tests --enable-werror $CONFIG +./configure --enable-sanitize $CONFIG $MAKE $PARALLEL_MAKE LD_LIBRARY_PATH="$inst/lib" $MAKE check \ || exit_tar_workspace LD_LIBRARY_PATH="$inst/lib" \ - DISTCHECK_CONFIGURE_FLAGS="--enable-external-tests --enable-werror $CONFIG" \ + DISTCHECK_CONFIGURE_FLAGS="$CONFIG" \ $MAKE $PARALLEL_MAKE distcheck \ || exit_tar_workspace -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33680 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5685aa0bcb77286d1cd89cc9c8fee58991597446 Gerrit-Change-Number: 33680 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-bsc[master]: configure: ipa utils: add default=yes to arg help
by osmith 11 Jul '23

11 Jul '23

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33678 ) Change subject: configure: ipa utils: add default=yes to arg help ...................................................................... Patch Set 1: (1 comment) File configure.ac: https://gerrit.osmocom.org/c/osmo-bsc/+/33678/comment/1fe50240_63933987 PS1, Line 40: [ > Don't we need to escape square brackets? […] It is written like that a few times in this configure.ac already, and it works as expected (configure --help output, tab completion). I'm not sure why it would be escaped like that in other projects, maybe there is a good reason for it... but it seems to work fine here. ``` $ grep default= configure.ac AC_ARG_ENABLE([ipaccess-utils], [AS_HELP_STRING([--enable-ipaccess-utils], [Build ipaccess utils: abisip-find, ipaccess-config, ... [default=yes]])], AC_ARG_ENABLE([meas-udp2db], [AS_HELP_STRING([--enable-meas-udp2db], [Build osmo-meas-udp2db: listen to meas_feed on UDP and write it to an sqlite3 database [default=no]])], AC_ARG_ENABLE([meas-pcap2db], [AS_HELP_STRING([--enable-meas-pcap2db], [Build osmo-meas-pcap2db: read PCAP file with meas_feed data and write it to an sqlite3 database [default=no]])], AC_ARG_ENABLE([meas-vis], [AS_HELP_STRING([--enable-meas-vis], [Build meas_vis: curses-visualization of measurements [default=no]])], [enable code coverage support [default=no]]), [Include the VTY/CTRL tests in make check [default=no]]), [Generate manual PDFs [default=no]], ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33678 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie8c22f5103857b317add5f7d9d9f951665a6103a Gerrit-Change-Number: 33678 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Jul 2023 13:15:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: contrib/jenkins.sh: deduplicate configure flags
by fixeria 11 Jul '23

11 Jul '23

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33680 ) Change subject: contrib/jenkins.sh: deduplicate configure flags ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33680 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5685aa0bcb77286d1cd89cc9c8fee58991597446 Gerrit-Change-Number: 33680 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Jul 2023 13:13:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: configure: ipa utils: add default=yes to arg help
by fixeria 11 Jul '23

11 Jul '23

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33678 ) Change subject: configure: ipa utils: add default=yes to arg help ...................................................................... Patch Set 1: (1 comment) File configure.ac: https://gerrit.osmocom.org/c/osmo-bsc/+/33678/comment/0680c4a5_c5c64f1c PS1, Line 40: [ Don't we need to escape square brackets? I saw something like this in other `configure.ac` files: `@<:@default=yes@:>@`. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33678 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie8c22f5103857b317add5f7d9d9f951665a6103a Gerrit-Change-Number: 33678 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Jul 2023 13:12:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in osmo-msc[master]: ASCI: Add VTY to configure GCR (Group Call Register)
by Jenkins Builder 11 Jul '23

11 Jul '23

Attention is currently required from: jolly. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33512 ) Change subject: ASCI: Add VTY to configure GCR (Group Call Register) ...................................................................... Patch Set 16: Verified-1 (1 comment) File src/libmsc/asci_vty.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-9425): https://gerrit.osmocom.org/c/osmo-msc/+/33512/comment/45b0b7e1_827a6674 PS16, Line 38: static void asci_disabled(struct vty *vty) { open brace '{' following function definitions go on the next line -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33512 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I5bd034a62fc8b483f550d29103c2f7587198f590 Gerrit-Change-Number: 33512 Gerrit-PatchSet: 16 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 11 Jul 2023 13:11:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-msc[master]: ASCI: Add decoder for VGCS/VBS messages to msc_a.c
by jolly 11 Jul '23

11 Jul '23

Attention is currently required from: jolly. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/33506 to look at the new patch set (#14). Change subject: ASCI: Add decoder for VGCS/VBS messages to msc_a.c ...................................................................... ASCI: Add decoder for VGCS/VBS messages to msc_a.c VGCS/VBS messages from BSS are decoded and a receiver funktion for the GCC/BCC (VGCS/VBS call control) is selected. Change-Id: Ief6259ba3914eeaceb063b562a0bcbc48349ce60 Related: OS#4854 --- M src/libmsc/msc_a.c 1 file changed, 144 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/06/33506/14 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33506 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ief6259ba3914eeaceb063b562a0bcbc48349ce60 Gerrit-Change-Number: 33506 Gerrit-PatchSet: 14 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 0

[XL] Change in osmo-msc[master]: ASCI: Add call control for VGCS/VBS
by jolly 11 Jul '23

11 Jul '23

Attention is currently required from: jolly, dexter. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/33511 to look at the new patch set (#14). Change subject: ASCI: Add call control for VGCS/VBS ...................................................................... ASCI: Add call control for VGCS/VBS Change-Id: I9947403fde8212b66758104443c60aaacc8b1e7b Related: OS#4854 --- M include/osmocom/msc/Makefile.am A include/osmocom/msc/msc_vgcs.h M include/osmocom/msc/ran_conn.h M include/osmocom/msc/transaction.h M src/libmsc/Makefile.am M src/libmsc/gsm_04_11_gsup.c A src/libmsc/msc_vgcs.c M src/libmsc/transaction.c 8 files changed, 3,037 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/11/33511/14 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9947403fde8212b66758104443c60aaacc8b1e7b Gerrit-Change-Number: 33511 Gerrit-PatchSet: 14 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-msc[master]: ASCI: Add function to receive VGCS/VBS messages from BSS
by jolly 11 Jul '23

11 Jul '23

Attention is currently required from: jolly. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/33504 to look at the new patch set (#14). Change subject: ASCI: Add function to receive VGCS/VBS messages from BSS ...................................................................... ASCI: Add function to receive VGCS/VBS messages from BSS A voice group/broadcast call has no SCCP connection that is related 1:1 to a calling or called subscriber. Instead there are multiple connections between MSC and BSS. Some of them control the uplink for each BSS and some of them assign the channels for each BTS. SCCP connections are maintained by the VGCS call control. Message from the RAN are directly forwarded to the VGCS call control. Change-Id: Ie4a2f19ba75140a6f2de02b709597239c01f02a2 Related: OS#4854 --- M include/osmocom/msc/msc_a.h M src/libmsc/ran_peer.c 2 files changed, 38 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/04/33504/14 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33504 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie4a2f19ba75140a6f2de02b709597239c01f02a2 Gerrit-Change-Number: 33504 Gerrit-PatchSet: 14 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-msc[master]: ASCI: Add option to switch on or off ASCI support
by jolly 11 Jul '23

11 Jul '23

Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/33674 to look at the new patch set (#2). Change subject: ASCI: Add option to switch on or off ASCI support ...................................................................... ASCI: Add option to switch on or off ASCI support Switching ASCI support is controled via VTY. This added in a later patch. (Chg-Id: I5bd034a62fc8b483f550d29103c2f7587198f590) Change-Id: Id68deb69f7395f0f8f50b3820e9d51052a34f753 Related: OS#4854 --- M include/osmocom/msc/gsm_data.h M include/osmocom/msc/msc_a.h M src/libmsc/gsm_04_08.c M src/libmsc/msc_a.c 4 files changed, 29 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/74/33674/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33674 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Id68deb69f7395f0f8f50b3820e9d51052a34f753 Gerrit-Change-Number: 33674 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 0

[L] Change in osmo-msc[master]: ASCI: Add VTY to configure GCR (Group Call Register)
by jolly 11 Jul '23

11 Jul '23

Attention is currently required from: jolly. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/33512 to look at the new patch set (#16). Change subject: ASCI: Add VTY to configure GCR (Group Call Register) ...................................................................... ASCI: Add VTY to configure GCR (Group Call Register) Change-Id: I5bd034a62fc8b483f550d29103c2f7587198f590 Related: OS#4854 --- M include/osmocom/msc/Makefile.am A include/osmocom/msc/asci_vty.h M include/osmocom/msc/vty.h M src/libmsc/Makefile.am A src/libmsc/asci_vty.c M src/libmsc/msc_vty.c M src/osmo-msc/msc_main.c M tests/test_nodes.vty 8 files changed, 489 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/12/33512/16 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33512 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I5bd034a62fc8b483f550d29103c2f7587198f590 Gerrit-Change-Number: 33512 Gerrit-PatchSet: 16 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 0