Attention is currently required from: laforge.
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33611 )
Change subject: ASCI: Add processing and FSMs for VGCS/VBS
......................................................................
Patch Set 6:
(2 comments)
File src/osmo-bsc/vgcs_fsm.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-9609):
https://gerrit.osmocom.org/c/osmo-bsc/+/33611/comment/ca6456f3_796e7b3e
PS6, Line 74: string[sizeof(string) - 1] = '\0';
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-9609):
https://gerrit.osmocom.org/c/osmo-bsc/+/33611/comment/10881bae_4f5b0e27
PS6, Line 74: string[sizeof(string) - 1] = '\0';
please, no spaces at the start of a line
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33611
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id9e94fb4f27bb438b7093c031344a3400bfa34f1
Gerrit-Change-Number: 33611
Gerrit-PatchSet: 6
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 13 Jul 2023 10:45:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: jolly.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33736 )
Change subject: Select channel type by enum instead of three boolean
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33736
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I21167eb4192c02cd7b5e1574cddb382a3feaebe0
Gerrit-Change-Number: 33736
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Thu, 13 Jul 2023 10:37:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge.
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33599 )
Change subject: ASCI: Add support for Group/Broadcast channel activation
......................................................................
Patch Set 4:
(2 comments)
File include/osmocom/bsc/lchan.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/33599/comment/468512aa_e9bab40f
PS3, Line 142:
> see also my comment below. […]
Done
File src/osmo-bsc/abis_rsl.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/33599/comment/3403d49e_3156ebe1
PS3, Line 408: bool vamos, bool vgcs, bool vbs)
> I will provide it as another patch, because this would affect existing code.
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33599
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic0c0597d149d0758d6766937d99660fa02e0e139
Gerrit-Change-Number: 33599
Gerrit-PatchSet: 4
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 13 Jul 2023 10:24:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly <andreas(a)eversberg.eu>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment
Attention is currently required from: laforge.
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33602 )
Change subject: ASCI: Make function to add OSMUX IE public
......................................................................
Patch Set 5:
(1 comment)
File include/osmocom/bsc/assignment_fsm.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/33602/comment/3d00d5b6_549afee8
PS3, Line 43: gsm0808_extend_osmux
> we don't usually have non-static (exported) symbol names that might clash with the prefixes used by […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33602
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I1452cabb142f9e7a169f4ddfeac85908abaf8dfc
Gerrit-Change-Number: 33602
Gerrit-PatchSet: 5
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 13 Jul 2023 10:24:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment