July 2023 - gerrit-log - lists.osmocom.org

[L] Change in osmo-msc[master]: ASCI: Add simple implementation of Group Call Register
by jolly 13 Jul '23

13 Jul '23

Attention is currently required from: neels. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33510 ) Change subject: ASCI: Add simple implementation of Group Call Register ...................................................................... Patch Set 11: (1 comment) File src/libmsc/asci_gcr.c: https://gerrit.osmocom.org/c/osmo-msc/+/33510/comment/fbd43fb6_3ea47147 PS11, Line 163: OSMO_ASSERT(l < ARRAY_SIZE(pow10)); > can this assertion abort the program based on user input? No, the group ID must be 1..8 digits: see valid_group_id() in asci_vty.c -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33510 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ia74a4a865f943c5fb388cd28f9406005c92e663e Gerrit-Change-Number: 33510 Gerrit-PatchSet: 11 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Jul 2023 12:39:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-trx[master]: USRPDevice:updateAlignment: remove byteswap code
by osmith 13 Jul '23

13 Jul '23

Attention is currently required from: osmith. Hello Jenkins Builder, Hoernchen, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/33737 to look at the new patch set (#2). Change subject: USRPDevice:updateAlignment: remove byteswap code ...................................................................... USRPDevice:updateAlignment: remove byteswap code After upgrading our CI environment to use Debian 12 with GCC 12, the byteswap code fails the build with the following. I've talked to Eric about this and he recommended to just remove the code as practically nobody will use osmo-trx with a big endian system. USRPDevice.cpp:591:30: error: 'data' is used uninitialized [-Werror=uninitialized] 591 | *wordPtr = host_to_usrp_u32(*wordPtr); | ~~~~~~~~~~~~~~~~^~~~~~~~~~ Related: OS#6057 Change-Id: I806d8c1432cb20efca1830a2752a4cbc70384b54 --- M Transceiver52M/device/usrp1/USRPDevice.cpp 1 file changed, 20 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/37/33737/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/33737 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I806d8c1432cb20efca1830a2752a4cbc70384b54 Gerrit-Change-Number: 33737 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-ttcn3-hacks[master]: MGW_Tests: Add test for "confecho" connection.
by jolly 13 Jul '23

13 Jul '23

Attention is currently required from: dexter. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33720 ) Change subject: MGW_Tests: Add test for "confecho" connection. ...................................................................... Patch Set 2: (2 comments) File mgw/MGCP_Test.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33720/comment/d56c68d3_df2b… PS1, Line 2309: f_flow_delete(RTPEM[1]); > In TC_two_crcx_and_one_mdcx_rtp_ho we do this the other way around, I don't remember where the catch […] I moved "ep, call_id" to second command. I stop the talker's RTP flow (0) before stopping the listener's flow (1), so that there is no race condition in missing a packet. The listener must receive as many packets as the talker transmits. (I hope I got that right.) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33720/comment/1dc9d6a0_4e97… PS1, Line 2317: setverdict(fail); > the setverdict also supports a string to explain what failed. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33720 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7df4a58ad9287a564b2daf7548b882c03787f7f2 Gerrit-Change-Number: 33720 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Jul 2023 12:15:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: MGW_Tests: Add test for "confecho" connection.
by jolly 13 Jul '23

13 Jul '23

Attention is currently required from: jolly. Hello Jenkins Builder, pespin, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33720 to look at the new patch set (#3). Change subject: MGW_Tests: Add test for "confecho" connection. ...................................................................... MGW_Tests: Add test for "confecho" connection. The test uses two connections: "confecho" and "sendonly". It is expected that "confecho" connection receives as many RTP packets as it sends, because it echoes back its packets. It is also expected that "sendonly" connection receives the same amount of RTP packets. Change-Id: I7df4a58ad9287a564b2daf7548b882c03787f7f2 --- M mgw/MGCP_Test.ttcn 1 file changed, 67 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/20/33720/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33720 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7df4a58ad9287a564b2daf7548b882c03787f7f2 Gerrit-Change-Number: 33720 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 0

[XL] Change in osmo-bsc[master]: ASCI: Add processing and FSMs for VGCS/VBS
by pespin 13 Jul '23

13 Jul '23

Attention is currently required from: jolly, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33611 ) Change subject: ASCI: Add processing and FSMs for VGCS/VBS ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33611 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id9e94fb4f27bb438b7093c031344a3400bfa34f1 Gerrit-Change-Number: 33611 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 13 Jul 2023 11:54:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in osmo-bsc[master]: ASCI: Add processing and FSMs for VGCS/VBS
by jolly 13 Jul '23

13 Jul '23

Attention is currently required from: jolly, laforge. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/33611 to look at the new patch set (#7). Change subject: ASCI: Add processing and FSMs for VGCS/VBS ...................................................................... ASCI: Add processing and FSMs for VGCS/VBS Change-Id: Id9e94fb4f27bb438b7093c031344a3400bfa34f1 Related: OS#4852 --- M include/osmocom/bsc/Makefile.am M include/osmocom/bsc/gsm_data.h A include/osmocom/bsc/vgcs_fsm.h M src/osmo-bsc/Makefile.am M src/osmo-bsc/bsc_subscr_conn_fsm.c M src/osmo-bsc/osmo_bsc_bssap.c A src/osmo-bsc/vgcs_fsm.c 7 files changed, 1,463 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/11/33611/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33611 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id9e94fb4f27bb438b7093c031344a3400bfa34f1 Gerrit-Change-Number: 33611 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in libasn1c[master]: INTEGER: ignore warning for all GCC versions
by osmith 13 Jul '23

13 Jul '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libasn1c/+/33739 ) Change subject: INTEGER: ignore warning for all GCC versions ...................................................................... INTEGER: ignore warning for all GCC versions The warning appears again with GCC 12 in Debian 12, causing the build to fail with --enable-werror. GCC 11 did not complain about it. As there are numerous bug reports about this in GCC's bug tracker, just disable it for all GCC versions. Related: adaa1c62e13a9ee8e7b978e6e9f67624f1ea7307 Related: OS#6057 Change-Id: I48d9d423df47f23a0ef3ea727a40b53d70aec48b --- M src/INTEGER.c 1 file changed, 16 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libasn1c refs/changes/39/33739/1 diff --git a/src/INTEGER.c b/src/INTEGER.c index 0da24ad..1e62b2c 100644 --- a/src/INTEGER.c +++ b/src/INTEGER.c @@ -1336,16 +1336,12 @@ } break; } -#if __GNUC__ == 10 #pragma GCC diagnostic push #pragma GCC diagnostic ignored "-Warray-bounds" -#endif /* Copy the integer body */ for(pstart = p, bp = buf, pend1 += add; p != pend1; p += add) *bp++ = *p; -#if __GNUC__ == 10 #pragma GCC diagnostic pop -#endif if(st->buf) FREEMEM(st->buf); st->buf = buf; @@ -1398,16 +1394,12 @@ } break; } -#if __GNUC__ == 10 #pragma GCC diagnostic push #pragma GCC diagnostic ignored "-Warray-bounds" -#endif /* Copy the integer body */ for(pstart = p, bp = buf, pend1 += add; p != pend1; p += add) *bp++ = *p; -#if __GNUC__ == 10 #pragma GCC diagnostic pop -#endif if(st->buf) FREEMEM(st->buf); st->buf = buf; -- To view, visit https://gerrit.osmocom.org/c/libasn1c/+/33739 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libasn1c Gerrit-Branch: master Gerrit-Change-Id: I48d9d423df47f23a0ef3ea727a40b53d70aec48b Gerrit-Change-Number: 33739 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-trx[master]: USRPDevice: fix cast of short to uint32_t
by Hoernchen 13 Jul '23

13 Jul '23

Attention is currently required from: osmith. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/33737 ) Change subject: USRPDevice: fix cast of short to uint32_t ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: the original byteswaps the first two shorts casted to uint32, your change byteswaps the first short which is all 0.. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/33737 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I806d8c1432cb20efca1830a2752a4cbc70384b54 Gerrit-Change-Number: 33737 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Jul 2023 11:47:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-gbproxy[master]: gbprox_rx_ptp_from_bss: fix dangling pointer
by osmith 13 Jul '23

13 Jul '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/33738 ) Change subject: gbprox_rx_ptp_from_bss: fix dangling pointer ...................................................................... gbprox_rx_ptp_from_bss: fix dangling pointer Building with GCC 12 and --enable-werror fails without this. There is already a "hack to get both msg + tlv_parsed passed via osmo_fsm_inst_dispatch" comment, make the variable global until this is implemented properly. ../../../src/gb_proxy.c:450:24: error: storing the address of local variable 'tp' in '((struct libgb_msgb_cb *)msg)[2].bssgp_cell_id' [-Werror=dangling-pointer=] 450 | msgb_bcid(msg) = (void *)&tp; Related: OS#6057 Change-Id: Ie51e37572993cb5dc24ecf13bc300225f09cb744 --- M src/gb_proxy.c 1 file changed, 33 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/38/33738/1 diff --git a/src/gb_proxy.c b/src/gb_proxy.c index a7554a6..f91d431 100644 --- a/src/gb_proxy.c +++ b/src/gb_proxy.c @@ -80,6 +80,9 @@ .class_id = OSMO_STATS_CLASS_GLOBAL, }; +/* Hack for gbprox_rx_ptp_from_bss */ +struct tlv_parsed g_tp; + int tx_status(struct gbproxy_nse *nse, uint16_t ns_bvci, enum gprs_bssgp_cause cause, const uint16_t *bvci, const struct msgb *old_msg) { int rc; @@ -410,7 +413,6 @@ struct bssgp_normal_hdr *bgph = (struct bssgp_normal_hdr *) msgb_bssgph(msg); const char *pdut_name = osmo_tlv_prot_msg_name(&osmo_pdef_bssgp, bgph->pdu_type); struct gbproxy_bvc *bss_bvc; - struct tlv_parsed tp; char log_pfx[32]; uint32_t tlli; int rc; @@ -441,13 +443,13 @@ return tx_status(nse, ns_bvci, BSSGP_CAUSE_UNKNOWN_BVCI, &ns_bvci, msg); } - rc = gbproxy_decode_bssgp(bgph, msgb_bssgp_len(msg), &tp, log_pfx); + rc = gbproxy_decode_bssgp(bgph, msgb_bssgp_len(msg), &g_tp, log_pfx); if (rc < 0) { rate_ctr_inc(rate_ctr_group_get_ctr(nse->cfg->ctrg, GBPROX_GLOB_CTR_PROTO_ERR_BSS)); return tx_status_from_tlvp(nse, rc, msg); } /* hack to get both msg + tlv_parsed passed via osmo_fsm_inst_dispatch */ - msgb_bcid(msg) = (void *)&tp; + msgb_bcid(msg) = (void *)&g_tp; switch (bgph->pdu_type) { case BSSGP_PDUT_UL_UNITDATA: @@ -466,20 +468,20 @@ case BSSGP_PDUT_PS_HO_COMPLETE: case BSSGP_PDUT_PS_HO_CANCEL: /* We can route based on TLLI-NRI */ - tlli = osmo_load32be(TLVP_VAL(&tp, BSSGP_IE_TLLI)); + tlli = osmo_load32be(TLVP_VAL(&g_tp, BSSGP_IE_TLLI)); rc = gbprox_bss2sgsn_tlli(bss_bvc->cell, msg, &tlli, false); break; case BSSGP_PDUT_RADIO_STATUS: - if (TLVP_PRESENT(&tp, BSSGP_IE_TLLI)) { - tlli = osmo_load32be(TLVP_VAL(&tp, BSSGP_IE_TLLI)); + if (TLVP_PRESENT(&g_tp, BSSGP_IE_TLLI)) { + tlli = osmo_load32be(TLVP_VAL(&g_tp, BSSGP_IE_TLLI)); rc = gbprox_bss2sgsn_tlli(bss_bvc->cell, msg, &tlli, false); - } else if (TLVP_PRESENT(&tp, BSSGP_IE_TMSI)) { + } else if (TLVP_PRESENT(&g_tp, BSSGP_IE_TMSI)) { /* we treat the TMSI like a TLLI and extract the NRI from it */ - tlli = osmo_load32be(TLVP_VAL(&tp, BSSGP_IE_TMSI)); + tlli = osmo_load32be(TLVP_VAL(&g_tp, BSSGP_IE_TMSI)); /* Convert the TMSI into a FOREIGN TLLI so it is routed appropriately */ tlli = gprs_tmsi2tlli(tlli, TLLI_FOREIGN); rc = gbprox_bss2sgsn_tlli(bss_bvc->cell, msg, &tlli, false); - } else if (TLVP_PRESENT(&tp, BSSGP_IE_IMSI)) { + } else if (TLVP_PRESENT(&g_tp, BSSGP_IE_IMSI)) { /* FIXME: Use the IMSI as selector? */ rc = gbprox_bss2sgsn_tlli(bss_bvc->cell, msg, NULL, false); } else @@ -490,8 +492,8 @@ { /* Route according to IMSI<->NSE cache entry */ struct osmo_mobile_identity mi; - const uint8_t *mi_data = TLVP_VAL(&tp, BSSGP_IE_IMSI); - uint8_t mi_len = TLVP_LEN(&tp, BSSGP_IE_IMSI); + const uint8_t *mi_data = TLVP_VAL(&g_tp, BSSGP_IE_IMSI); + uint8_t mi_len = TLVP_LEN(&g_tp, BSSGP_IE_IMSI); osmo_mobile_identity_decode(&mi, mi_data, mi_len, false); nse = gbproxy_nse_by_imsi(nse->cfg, mi.imsi, CACHE_USAGE_PAGING); if (nse) { @@ -509,12 +511,12 @@ { struct gbproxy_sgsn *sgsn; /* Check if the status needs to be terminated locally */ - uint8_t cause = *TLVP_VAL(&tp, BSSGP_IE_CAUSE); + uint8_t cause = *TLVP_VAL(&g_tp, BSSGP_IE_CAUSE); LOGPNSE(nse, LOGL_NOTICE, "Rx STATUS cause=0x%02x(%s)\n", cause, bssgp_cause_str(cause)); - if (gbproxy_tlli_from_status_pdu(&tp, &tlli, log_pfx) == 0) + if (gbproxy_tlli_from_status_pdu(&g_tp, &tlli, log_pfx) == 0) sgsn = gbproxy_select_sgsn(nse->cfg, &tlli); else sgsn = gbproxy_select_sgsn(nse->cfg, NULL); -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/33738 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: Ie51e37572993cb5dc24ecf13bc300225f09cb744 Gerrit-Change-Number: 33738 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-trx[master]: USRPDevice: fix cast of short to uint32_t
by osmith 13 Jul '23

13 Jul '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/33737 ) Change subject: USRPDevice: fix cast of short to uint32_t ...................................................................... USRPDevice: fix cast of short to uint32_t Fix building with --enable-werror and GCC 12: USRPDevice.cpp:591:30: error: 'data' is used uninitialized [-Werror=uninitialized] 591 | *wordPtr = host_to_usrp_u32(*wordPtr); | ~~~~~~~~~~~~~~~~^~~~~~~~~~ Related: OS#6057 Change-Id: I806d8c1432cb20efca1830a2752a4cbc70384b54 --- M Transceiver52M/device/usrp1/USRPDevice.cpp 1 file changed, 17 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/37/33737/1 diff --git a/Transceiver52M/device/usrp1/USRPDevice.cpp b/Transceiver52M/device/usrp1/USRPDevice.cpp index 5c40aa8..bf114b6 100644 --- a/Transceiver52M/device/usrp1/USRPDevice.cpp +++ b/Transceiver52M/device/usrp1/USRPDevice.cpp @@ -587,8 +587,7 @@ { #ifndef SWLOOPBACK short data[] = {0x00,0x02,0x00,0x00}; - uint32_t *wordPtr = (uint32_t *) data; - *wordPtr = host_to_usrp_u32(*wordPtr); + *data = host_to_usrp_short(*data); bool tmpUnderrun; std::vector<short *> buf(1, data); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/33737 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I806d8c1432cb20efca1830a2752a4cbc70384b54 Gerrit-Change-Number: 33737 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0