July 2023 - gerrit-log - lists.osmocom.org

[XL] Change in osmo-bsc[master]: ASCI: Add processing and FSMs for VGCS/VBS
by jolly 13 Jul '23

13 Jul '23

Attention is currently required from: jolly. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/33611 to look at the new patch set (#6). Change subject: ASCI: Add processing and FSMs for VGCS/VBS ...................................................................... ASCI: Add processing and FSMs for VGCS/VBS Change-Id: Id9e94fb4f27bb438b7093c031344a3400bfa34f1 Related: OS#4852 --- M include/osmocom/bsc/Makefile.am M include/osmocom/bsc/gsm_data.h A include/osmocom/bsc/vgcs_fsm.h M src/osmo-bsc/Makefile.am M src/osmo-bsc/bsc_subscr_conn_fsm.c M src/osmo-bsc/osmo_bsc_bssap.c A src/osmo-bsc/vgcs_fsm.c 7 files changed, 1,463 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/11/33611/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33611 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id9e94fb4f27bb438b7093c031344a3400bfa34f1 Gerrit-Change-Number: 33611 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-dev[master]: all.deps: add osmo-remsim and simtrace2
by pespin 13 Jul '23

13 Jul '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/33734 ) Change subject: all.deps: add osmo-remsim and simtrace2 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/33734 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I58324ad5ed6c77a53e697d5b4b07ff9353859556 Gerrit-Change-Number: 33734 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Jul 2023 10:21:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-remsim[master]: src/rspro: fix misleading indentations
by pespin 13 Jul '23

13 Jul '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/33733 ) Change subject: src/rspro: fix misleading indentations ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/33733 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Icc2e8da7232a93b04ac8f23800380ca9317bd60f Gerrit-Change-Number: 33733 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Jul 2023 10:20:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: trans_lcls_compose(): Set PLMN fron cell currently in use
by pespin 13 Jul '23

13 Jul '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/33735 ) Change subject: trans_lcls_compose(): Set PLMN fron cell currently in use ...................................................................... trans_lcls_compose(): Set PLMN fron cell currently in use Change-Id: Ibad0005a1d7cef64dd8fefa3e554ba99a06c3666 --- M src/libmsc/transaction.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/35/33735/1 diff --git a/src/libmsc/transaction.c b/src/libmsc/transaction.c index a3a9ef1..7c36739 100644 --- a/src/libmsc/transaction.c +++ b/src/libmsc/transaction.c @@ -152,7 +152,7 @@ lcls->gcr.node = ss7->cfg.primary_pc; /* net id from Q.1902.3 3-5 bytes, this function gives 3 bytes exactly */ - osmo_plmn_to_bcd(lcls->gcr.net, &trans->net->plmn); + osmo_plmn_to_bcd(lcls->gcr.net, &trans->msc_a->via_cell.lai.plmn); /* TS 29.205 Table B.2.1.9.2 Call Reference ID -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33735 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ibad0005a1d7cef64dd8fefa3e554ba99a06c3666 Gerrit-Change-Number: 33735 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-dev[master]: all.deps: add osmo-remsim and simtrace2
by osmith 13 Jul '23

13 Jul '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/33734 ) Change subject: all.deps: add osmo-remsim and simtrace2 ...................................................................... all.deps: add osmo-remsim and simtrace2 Change-Id: I58324ad5ed6c77a53e697d5b4b07ff9353859556 --- M all.deps M gen_makefile.py M werror.opts 3 files changed, 22 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/34/33734/1 diff --git a/all.deps b/all.deps index d9359bd..4769d02 100644 --- a/all.deps +++ b/all.deps @@ -34,12 +34,15 @@ osmo-hnodeb osmo-iuh osmo-hnbgw osmo-iuh osmo-mgw libosmo-pfcp osmo-e1d libosmocore +osmo-remsim simtrace2_host libosmo-netif # can only clone these docker-playground osmo-ttcn3-hacks osmocom-bb +simtrace2 # configure.ac not in topdir of repository osmocom-bb_layer23 libosmocore osmocom-bb_virtphy libosmocore +simtrace2_host libosmocore diff --git a/gen_makefile.py b/gen_makefile.py index d45e5e8..34f8c96 100755 --- a/gen_makefile.py +++ b/gen_makefile.py @@ -171,6 +171,14 @@ touch $@ ''' + if proj == "simtrace2_host": + return f''' +.make.{proj}.clone: .make.simtrace2.clone + @echo -e "\\n\\n\\n===== $@\\n" + test -L {src_proj} || ln -s simtrace2/host {src_proj} + touch $@ + ''' + if proj in ("libgtpnl", "libnftnl", "nftables"): url = "git://git.netfilter.org" diff --git a/werror.opts b/werror.opts index 7252af9..312b97b 100644 --- a/werror.opts +++ b/werror.opts @@ -19,3 +19,5 @@ osmo-cbc --enable-werror osmo-hnodeb --enable-werror osmo-hnbgw --enable-werror +simtrace2_host --enable-werror +osmo-remsim --enable-werror -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/33734 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I58324ad5ed6c77a53e697d5b4b07ff9353859556 Gerrit-Change-Number: 33734 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-remsim[master]: src/rspro: fix misleading indentations
by osmith 13 Jul '23

13 Jul '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/33733 ) Change subject: src/rspro: fix misleading indentations ...................................................................... src/rspro: fix misleading indentations After upgrading our CI environment to use Debian 12 with GCC 12, it complains about the following misleading indentations. Fix it to be able to compile with --enable-werror again. ../../../../src/osmo-remsim/src/rspro/INTEGER.c: In function ‘INTEGER_decode_aper’: ../../../../src/osmo-remsim/src/rspro/INTEGER.c:774:33: error: this ‘if’ clause does not guard... [-Werror=misleading-indentation] 774 | if((specs && specs->field_unsigned) | ^~ ../../../../src/osmo-remsim/src/rspro/INTEGER.c:778:41: note: ...this statement, but the latter is misleadingly indented as if it were guarded by t he ‘if’ 778 | ASN_DEBUG("Got value %ld + low %lld", | ^~~~~~~~~ cc1: all warnings being treated as errors ../../../../src/osmo-remsim/src/rspro/constr_CHOICE.c: In function ‘CHOICE_encode_aper’: ../../../../src/osmo-remsim/src/rspro/constr_CHOICE.c:1134:17: error: this ‘if’ clause does not guard... [-Werror=misleading-indentation] 1134 | if(per_put_few_bits(po, present, ct->range_bits)) | ^~ ../../../../src/osmo-remsim/src/rspro/constr_CHOICE.c:1137:25: note: ...this statement, but the latter is misleadingly indented as if it were guard ed by the ‘if’ 1137 | return elm->type->aper_encoder(elm->type, elm->per_constraints, | ^~~~~~ cc1: all warnings being treated as errors ../../../../src/osmo-remsim/src/rspro/per_decoder.c: In function ‘aper_decode’: ../../../../src/osmo-remsim/src/rspro/per_decoder.c:161:9: error: this ‘if’ clause does not guard... [-Werror=misleading-indentation] 161 | if(!td->aper_decoder) | ^~ ../../../../src/osmo-remsim/src/rspro/per_decoder.c:163:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’ 163 | rval = td->aper_decoder(opt_codec_ctx, td, 0, sptr, &pd); | ^~~~ Related: OS#6057 Change-Id: Icc2e8da7232a93b04ac8f23800380ca9317bd60f --- M src/rspro/INTEGER.c M src/rspro/constr_CHOICE.c M src/rspro/per_decoder.c 3 files changed, 44 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/33/33733/1 diff --git a/src/rspro/INTEGER.c b/src/rspro/INTEGER.c index b3f0da1..a621aca 100644 --- a/src/rspro/INTEGER.c +++ b/src/rspro/INTEGER.c @@ -775,7 +775,7 @@ ? asn_ulong2INTEGER(st, value) : asn_long2INTEGER(st, value)) _ASN_DECODE_FAILED; - ASN_DEBUG("Got value %ld + low %lld", + ASN_DEBUG("Got value %ld + low %lld", value, ct->lower_bound); } return rval; diff --git a/src/rspro/constr_CHOICE.c b/src/rspro/constr_CHOICE.c index 6a88b29..d00d416 100644 --- a/src/rspro/constr_CHOICE.c +++ b/src/rspro/constr_CHOICE.c @@ -1134,8 +1134,7 @@ if(per_put_few_bits(po, present, ct->range_bits)) _ASN_ENCODE_FAILED; - return elm->type->aper_encoder(elm->type, elm->per_constraints, - memb_ptr, po); + return elm->type->aper_encoder(elm->type, elm->per_constraints, memb_ptr, po); } else { asn_enc_rval_t rval; if(specs->ext_start == -1) diff --git a/src/rspro/per_decoder.c b/src/rspro/per_decoder.c index 20fe1a1..b5056b5 100644 --- a/src/rspro/per_decoder.c +++ b/src/rspro/per_decoder.c @@ -160,7 +160,7 @@ */ if(!td->aper_decoder) _ASN_DECODE_FAILED; /* PER is not compiled in */ - rval = td->aper_decoder(opt_codec_ctx, td, 0, sptr, &pd); + rval = td->aper_decoder(opt_codec_ctx, td, 0, sptr, &pd); if(rval.code == RC_OK) { /* Return the number of consumed bits */ rval.consumed = ((pd.buffer - (const uint8_t *)buffer) << 3) -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/33733 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Icc2e8da7232a93b04ac8f23800380ca9317bd60f Gerrit-Change-Number: 33733 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-msc[master]: Tx Loc UPD ACC: Use PLMN provided by subscr
by osmith 13 Jul '23

13 Jul '23

Attention is currently required from: neels, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33732 ) Change subject: Tx Loc UPD ACC: Use PLMN provided by subscr ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33732 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I421bd63a264db2bf6e1c4a4eea976f389e87b332 Gerrit-Change-Number: 33732 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Jul 2023 09:54:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: Tx Loc UPD ACC: Use PLMN provided by subscr
by pespin 13 Jul '23

13 Jul '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/33732 ) Change subject: Tx Loc UPD ACC: Use PLMN provided by subscr ...................................................................... Tx Loc UPD ACC: Use PLMN provided by subscr Change-Id: I421bd63a264db2bf6e1c4a4eea976f389e87b332 --- M src/libmsc/gsm_04_08.c 1 file changed, 10 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/32/33732/1 diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c index bd7cfe0..287cffc 100644 --- a/src/libmsc/gsm_04_08.c +++ b/src/libmsc/gsm_04_08.c @@ -119,12 +119,7 @@ struct msgb *msg = gsm48_msgb_alloc_name("GSM 04.08 LOC UPD ACC"); struct gsm48_hdr *gh; struct gsm48_loc_area_id *lai; - struct gsm_network *net = msc_a_net(msc_a); struct vlr_subscr *vsub = msc_a_vsub(msc_a); - struct osmo_location_area_id laid = { - .plmn = net->plmn, - .lac = vsub->cgi.lai.lac, - }; uint8_t *l; int rc; struct osmo_mobile_identity mi = {}; @@ -134,7 +129,7 @@ gh->msg_type = GSM48_MT_MM_LOC_UPD_ACCEPT; lai = (struct gsm48_loc_area_id *) msgb_put(msg, sizeof(*lai)); - gsm48_generate_lai2(lai, &laid); + gsm48_generate_lai2(lai, &vsub->cgi.lai); if (send_tmsi == GSM_RESERVED_TMSI) { /* we did not allocate a TMSI to the MS, so we need to -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33732 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I421bd63a264db2bf6e1c4a4eea976f389e87b332 Gerrit-Change-Number: 33732 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ci[master]: jobs/ttcn3: add ttcn3-mme-test-ogs
by pespin 13 Jul '23

13 Jul '23

Attention is currently required from: osmith, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/33688 ) Change subject: jobs/ttcn3: add ttcn3-mme-test-ogs ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/33688 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I503815ce4e244a0db0106b9c651f06ab2406c331 Gerrit-Change-Number: 33688 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Jul 2023 08:54:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: osmo-bts-trx: rx_tchf_fn(): move compute_ber10k() above
by pespin 13 Jul '23

13 Jul '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33730 ) Change subject: osmo-bts-trx: rx_tchf_fn(): move compute_ber10k() above ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33730 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie331da78eb3831e35d255583466e0d09b093b132 Gerrit-Change-Number: 33730 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 13 Jul 2023 08:36:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0