July 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-remsim[master]: src/rspro: regenerate to fix misleading indents
by laforge 17 Jul '23

17 Jul '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/33733 ) Change subject: src/rspro: regenerate to fix misleading indents ...................................................................... src/rspro: regenerate to fix misleading indents After upgrading our CI environment to use Debian 12 with GCC 12, it complains about the following misleading indentations. Regenerate the rspro code with asn1c I2260df8f8ab8eaf5c2aac3c330f87dba4691c01e to be able to compile with --enable-werror again. The asn_internal.h file is left unchanged to preserve changes from I14fff863449971024002e0d5465fb7a964d67095. Related: OS#6057 Change-Id: Icc2e8da7232a93b04ac8f23800380ca9317bd60f --- M src/rspro/INTEGER.c M src/rspro/ResetStateReq.c M src/rspro/ResetStateRes.c M src/rspro/constr_CHOICE.c M src/rspro/per_decoder.c 5 files changed, 26 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/rspro/INTEGER.c b/src/rspro/INTEGER.c index b3f0da1..042fd75 100644 --- a/src/rspro/INTEGER.c +++ b/src/rspro/INTEGER.c @@ -775,8 +775,8 @@ ? asn_ulong2INTEGER(st, value) : asn_long2INTEGER(st, value)) _ASN_DECODE_FAILED; - ASN_DEBUG("Got value %ld + low %lld", - value, ct->lower_bound); + ASN_DEBUG("Got value %ld + low %lld", + value, ct->lower_bound); } return rval; } else { diff --git a/src/rspro/ResetStateReq.c b/src/rspro/ResetStateReq.c index 538a18c..e7774df 100644 --- a/src/rspro/ResetStateReq.c +++ b/src/rspro/ResetStateReq.c @@ -4,7 +4,7 @@ * found in "../../asn1/RSPRO.asn" */ -#include "ResetStateReq.h" +#include <osmocom/rspro/ResetStateReq.h> static const ber_tlv_tag_t asn_DEF_ResetStateReq_tags_1[] = { (ASN_TAG_CLASS_UNIVERSAL | (16 << 2)) diff --git a/src/rspro/ResetStateRes.c b/src/rspro/ResetStateRes.c index 551dcc4..92909df 100644 --- a/src/rspro/ResetStateRes.c +++ b/src/rspro/ResetStateRes.c @@ -4,7 +4,7 @@ * found in "../../asn1/RSPRO.asn" */ -#include "ResetStateRes.h" +#include <osmocom/rspro/ResetStateRes.h> static asn_TYPE_member_t asn_MBR_ResetStateRes_1[] = { { ATF_NOFLAGS, 0, offsetof(struct ResetStateRes, result), diff --git a/src/rspro/constr_CHOICE.c b/src/rspro/constr_CHOICE.c index 6a88b29..4e95e1d 100644 --- a/src/rspro/constr_CHOICE.c +++ b/src/rspro/constr_CHOICE.c @@ -1134,8 +1134,8 @@ if(per_put_few_bits(po, present, ct->range_bits)) _ASN_ENCODE_FAILED; - return elm->type->aper_encoder(elm->type, elm->per_constraints, - memb_ptr, po); + return elm->type->aper_encoder(elm->type, elm->per_constraints, + memb_ptr, po); } else { asn_enc_rval_t rval; if(specs->ext_start == -1) diff --git a/src/rspro/per_decoder.c b/src/rspro/per_decoder.c index 20fe1a1..b5056b5 100644 --- a/src/rspro/per_decoder.c +++ b/src/rspro/per_decoder.c @@ -160,7 +160,7 @@ */ if(!td->aper_decoder) _ASN_DECODE_FAILED; /* PER is not compiled in */ - rval = td->aper_decoder(opt_codec_ctx, td, 0, sptr, &pd); + rval = td->aper_decoder(opt_codec_ctx, td, 0, sptr, &pd); if(rval.code == RC_OK) { /* Return the number of consumed bits */ rval.consumed = ((pd.buffer - (const uint8_t *)buffer) << 3) -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/33733 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Icc2e8da7232a93b04ac8f23800380ca9317bd60f Gerrit-Change-Number: 33733 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-remsim[master]: checkpatch.conf: ignore rspro generated files
by laforge 17 Jul '23

17 Jul '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/33763 ) Change subject: checkpatch.conf: ignore rspro generated files ...................................................................... checkpatch.conf: ignore rspro generated files Change-Id: I6e5d57f6669f7d1aff00898f1375843b53cd9b9f --- A .checkpatch.conf 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/.checkpatch.conf b/.checkpatch.conf new file mode 100644 index 0000000..b060a3b --- /dev/null +++ b/.checkpatch.conf @@ -0,0 +1,2 @@ +--exclude ^src/rspro/.*\.c$ +--exclude ^include/osmocom/rspro/.*\.h$ -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/33763 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I6e5d57f6669f7d1aff00898f1375843b53cd9b9f Gerrit-Change-Number: 33763 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-remsim[master]: checkpatch.conf: ignore rspro generated files
by laforge 17 Jul '23

17 Jul '23

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/33763 ) Change subject: checkpatch.conf: ignore rspro generated files ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/33763 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I6e5d57f6669f7d1aff00898f1375843b53cd9b9f Gerrit-Change-Number: 33763 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Jul 2023 12:28:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-remsim[master]: src/rspro: regenerate to fix misleading indents
by laforge 17 Jul '23

17 Jul '23

Attention is currently required from: osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/33733 ) Change subject: src/rspro: regenerate to fix misleading indents ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/33733 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Icc2e8da7232a93b04ac8f23800380ca9317bd60f Gerrit-Change-Number: 33733 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Jul 2023 12:28:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in dahdi-linux[master]: contrib/jenkins: set -Wno-error=address
by laforge 17 Jul '23

17 Jul '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/33767 ) Change subject: contrib/jenkins: set -Wno-error=address ...................................................................... contrib/jenkins: set -Wno-error=address After changing our CI environment to build with Debian 12, GCC 12.2.0-14 fails to build linux-dahdi with Werror (default since linux 5.15). Set -Wno-error=address to not fail the build. /build/drivers/dahdi/xpp/xbus-core.c:116:13: error: the comparison will always evaluate as 'true' for the address of 'label' will never be NULL [-Werror=address] /build/drivers/dahdi/dahdi_dynamic_ethmf.c:538:34: error: the comparison will always evaluate as 'true' for the address of 'name' will never be NULL [-Werror=address] /build/drivers/dahdi/wcte13xp-base.c:2704:13: error: the comparison will always evaluate as 'true' for the address of 'xb' will never be NULL [-Werror=address] Fixes: OS#6098 Change-Id: Ifc8fb605cb8e0de70e5556b127e22533cbe24c37 --- M contrib/jenkins.sh 1 file changed, 28 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 6a39daf..5044602 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -29,4 +29,11 @@ git log -1 --pretty="%t - %s" make -j "$JOBS" modules_prepare -make -j "$JOBS" -C "$TOPDIR" KSRC="$KSRC" KBUILD_MODPOST_WARN=1 + +# Wno-error=address: OS#6098 +make \ + -j "$JOBS" \ + -C "$TOPDIR" \ + KSRC="$KSRC" \ + KBUILD_MODPOST_WARN=1 \ + KCFLAGS="-Wno-error=address" -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/33767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Ifc8fb605cb8e0de70e5556b127e22533cbe24c37 Gerrit-Change-Number: 33767 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in dahdi-linux[master]: contrib/jenkins: set -Wno-error=address
by laforge 17 Jul '23

17 Jul '23

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/33767 ) Change subject: contrib/jenkins: set -Wno-error=address ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/33767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Ifc8fb605cb8e0de70e5556b127e22533cbe24c37 Gerrit-Change-Number: 33767 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Jul 2023 12:27:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: paging: also accept zero length IMSI strings 3
by laforge 17 Jul '23

17 Jul '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33766 ) Change subject: paging: also accept zero length IMSI strings 3 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33766 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iab1c3f1c39dd59bb53aa74b2c9e9e135e3985e0b Gerrit-Change-Number: 33766 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Jul 2023 12:26:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: paging: also accept zero length IMSI strings 3
by pespin 17 Jul '23

17 Jul '23

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33766 ) Change subject: paging: also accept zero length IMSI strings 3 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33766 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iab1c3f1c39dd59bb53aa74b2c9e9e135e3985e0b Gerrit-Change-Number: 33766 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Jul 2023 12:25:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: paging: also accept zero length IMSI strings 3
by pespin 17 Jul '23

17 Jul '23

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33766 ) Change subject: paging: also accept zero length IMSI strings 3 ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Done I'd say it's not convenient because it's never used that way, and it only creates confusion to the reader. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33766 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iab1c3f1c39dd59bb53aa74b2c9e9e135e3985e0b Gerrit-Change-Number: 33766 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Jul 2023 12:24:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: gsm0502.h: Document spec number
by pespin 17 Jul '23

17 Jul '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33752 ) Change subject: gsm0502.h: Document spec number ...................................................................... gsm0502.h: Document spec number Change-Id: I3a3fdde39a4f3927516b9c160c04144764800fda --- M include/osmocom/gsm/gsm0502.h 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/include/osmocom/gsm/gsm0502.h b/include/osmocom/gsm/gsm0502.h index 43ab0b8..ffd6e20 100644 --- a/include/osmocom/gsm/gsm0502.h +++ b/include/osmocom/gsm/gsm0502.h @@ -1,4 +1,7 @@ -/*! \file gsm0502.h */ +/*! \defgroup gsm0502 GSM 05.02 / 3GPP TS 45.002 + * @{ + * \file gsm0502.h + */ #pragma once @@ -107,3 +110,5 @@ size_t n, const uint16_t *ma); int gsm0502_fn2ccch_block(uint32_t fn); + +/*! @} */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33752 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3a3fdde39a4f3927516b9c160c04144764800fda Gerrit-Change-Number: 33752 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0