July 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bts[master]: paging: also accept zero length IMSI strings 3
by dexter 17 Jul '23

17 Jul '23

Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33766 ) Change subject: paging: also accept zero length IMSI strings 3 ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Its more or less a convenience thing, but ok, I will just change it. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33766 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iab1c3f1c39dd59bb53aa74b2c9e9e135e3985e0b Gerrit-Change-Number: 33766 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Jul 2023 12:17:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: paging: also accept zero length IMSI strings 3
by dexter 17 Jul '23

17 Jul '23

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/33766 to look at the new patch set (#2). Change subject: paging: also accept zero length IMSI strings 3 ...................................................................... paging: also accept zero length IMSI strings 3 When an IMMEDIATE ASSIGNMENT MAC block (from PCUIF) is added to the paging queue, then also an IMSI is required. The paging queue uses the last three digits of the IMSI to calculate the paging group. In case no IMSI is given, the MAC block is rejected. This was handeled differently before. Even an IMSI of length 0 would still be interpreted as "000" and not rejected. See also: I9f3799916e8102bf1ce0f21891f2d24f43091f01 Let's restore the behaviour we had before and accept short IMSI strings again. Change-Id: Iab1c3f1c39dd59bb53aa74b2c9e9e135e3985e0b Related: OS#6099 --- M src/common/paging.c 1 file changed, 44 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/66/33766/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33766 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iab1c3f1c39dd59bb53aa74b2c9e9e135e3985e0b Gerrit-Change-Number: 33766 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-bts[master]: paging: also accept zero length IMSI strings 3
by dexter 17 Jul '23

17 Jul '23

Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33766 ) Change subject: paging: also accept zero length IMSI strings 3 ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Why should we ever receive short IMSIs with strlen()<3? can you share an expected case? I don't see […] Its more or less a convenience thing, but ok, I will just change it. I will now have a look at the PCU side. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33766 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iab1c3f1c39dd59bb53aa74b2c9e9e135e3985e0b Gerrit-Change-Number: 33766 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Jul 2023 12:17:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in dahdi-linux[master]: contrib/jenkins: set -Wno-error=address
by osmith 17 Jul '23

17 Jul '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/33767 ) Change subject: contrib/jenkins: set -Wno-error=address ...................................................................... contrib/jenkins: set -Wno-error=address After changing our CI environment to build with Debian 12, GCC 12.2.0-14 fails to build linux-dahdi with Werror (default since linux 5.15). Set -Wno-error=address to not fail the build. /build/drivers/dahdi/xpp/xbus-core.c:116:13: error: the comparison will always evaluate as 'true' for the address of 'label' will never be NULL [-Werror=address] /build/drivers/dahdi/dahdi_dynamic_ethmf.c:538:34: error: the comparison will always evaluate as 'true' for the address of 'name' will never be NULL [-Werror=address] /build/drivers/dahdi/wcte13xp-base.c:2704:13: error: the comparison will always evaluate as 'true' for the address of 'xb' will never be NULL [-Werror=address] Fixes: OS#6098 Change-Id: Ifc8fb605cb8e0de70e5556b127e22533cbe24c37 --- M contrib/jenkins.sh 1 file changed, 28 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/67/33767/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 6a39daf..5044602 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -29,4 +29,11 @@ git log -1 --pretty="%t - %s" make -j "$JOBS" modules_prepare -make -j "$JOBS" -C "$TOPDIR" KSRC="$KSRC" KBUILD_MODPOST_WARN=1 + +# Wno-error=address: OS#6098 +make \ + -j "$JOBS" \ + -C "$TOPDIR" \ + KSRC="$KSRC" \ + KBUILD_MODPOST_WARN=1 \ + KCFLAGS="-Wno-error=address" -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/33767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Ifc8fb605cb8e0de70e5556b127e22533cbe24c37 Gerrit-Change-Number: 33767 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmocore[master]: gsm0502.h: Document spec number
by fixeria 17 Jul '23

17 Jul '23

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33752 ) Change subject: gsm0502.h: Document spec number ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File include/osmocom/gsm/gsm0502.h: https://gerrit.osmocom.org/c/libosmocore/+/33752/comment/d0a33328_d87861f2 PS1, Line 1: /*! \defgroup gsm0502 GSM 05.02 / 3GPP TS 45.002 A > it's a typo, sorry, I'll fix it. Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33752 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3a3fdde39a4f3927516b9c160c04144764800fda Gerrit-Change-Number: 33752 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Jul 2023 11:38:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: paging: also accept IMSI strings shorter than 3
by pespin 17 Jul '23

17 Jul '23

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33766 ) Change subject: paging: also accept IMSI strings shorter than 3 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Why should we ever receive short IMSIs with strlen()<3? can you share an expected case? I don't see any. > I agree that if no IMSI is provided we should use SAPI PCU_IF_SAPI_AGCH. That is something that should be corrected in osmo-pcu. However, I guess if we do that, we still require a confirmation from osmo-bts? (I can take care of that if you want.) Yes it's probably good in general to receive .cnf from AGCH too, since this allows also estimating time(rs) better in osmo-pcu for UL TBF assignment. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33766 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iab1c3f1c39dd59bb53aa74b2c9e9e135e3985e0b Gerrit-Change-Number: 33766 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Jul 2023 10:53:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: paging: also accept IMSI strings shorter than 3
by dexter 17 Jul '23

17 Jul '23

Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33766 ) Change subject: paging: also accept IMSI strings shorter than 3 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I think handling the case strlen(imsi)==0 is enough, other cases should contain full imsi (or at lea […] I think we should also accept IMSIs shorter than 3, this is most convenient. If we don't, we still would need a check and we would have to log an error message. So I would prefer to just silently accept short IMSI strings. I agree that if no IMSI is provided we should use SAPI PCU_IF_SAPI_AGCH. That is something that should be corrected in osmo-pcu. However, I guess if we do that, we still require a confirmation from osmo-bts? (I can take care of that if you want.) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33766 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iab1c3f1c39dd59bb53aa74b2c9e9e135e3985e0b Gerrit-Change-Number: 33766 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Jul 2023 10:50:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-remsim[master]: checkpatch.conf: ignore rspro generated files
by fixeria 17 Jul '23

17 Jul '23

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/33763 ) Change subject: checkpatch.conf: ignore rspro generated files ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/33763 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I6e5d57f6669f7d1aff00898f1375843b53cd9b9f Gerrit-Change-Number: 33763 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Jul 2023 10:44:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-remsim[master]: src/rspro: regenerate to fix misleading indents
by fixeria 17 Jul '23

17 Jul '23

Attention is currently required from: osmith, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/33733 ) Change subject: src/rspro: regenerate to fix misleading indents ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS1: > Isn't it automatically generated code? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/33733 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Icc2e8da7232a93b04ac8f23800380ca9317bd60f Gerrit-Change-Number: 33733 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Jul 2023 10:44:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: paging: also accept IMSI strings shorter than 3
by pespin 17 Jul '23

17 Jul '23

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33766 ) Change subject: paging: also accept IMSI strings shorter than 3 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I think handling the case strlen(imsi)==0 is enough, other cases should contain full imsi (or at least 3-char prefix). Also bear in mind this commit simply fixes the bug. Ideally, the behavior would be to submit the Ass on AGCH if no IMSI is provided, since using prgroup in that case is not really the good thing to do. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33766 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iab1c3f1c39dd59bb53aa74b2c9e9e135e3985e0b Gerrit-Change-Number: 33766 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Jul 2023 10:30:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0