July 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bsc[master]: ctrl: Support adding si2quater earfcn neighbor
by pespin 17 Jul '23

17 Jul '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33750 ) Change subject: ctrl: Support adding si2quater earfcn neighbor ...................................................................... ctrl: Support adding si2quater earfcn neighbor Change-Id: Ifd2740ee54db66742785437a278cb9244e1f76d0 --- M src/osmo-bsc/bts_ctrl.c 1 file changed, 154 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/bts_ctrl.c b/src/osmo-bsc/bts_ctrl.c index 9415b89..fdb4638 100644 --- a/src/osmo-bsc/bts_ctrl.c +++ b/src/osmo-bsc/bts_ctrl.c @@ -778,7 +778,150 @@ CTRL_CMD_DEFINE_WO_NOVRF(bts_si2quater_neighbor_list_del_uarfcn, "si2quater-neighbor-list del uarfcn"); -/* TODO: si2quater neighbor management: add EARFCN */ +static int verify_bts_si2quater_neighbor_list_add_earfcn(struct ctrl_cmd *cmd, const char *value, void *_data) +{ + char *earfcn_str, *thresh_hi_str, *thresh_lo_str, *prio_str, *qrxlv_str, *meas_str, *saveptr, *tmp; + int earfcn, thresh_hi, thresh_lo, prio, qrxlv, meas; + + tmp = talloc_strdup(cmd, value); + if (!tmp) + return 1; + + earfcn_str = strtok_r(tmp, ",", &saveptr); + thresh_hi_str = strtok_r(NULL, ",", &saveptr); + thresh_lo_str = strtok_r(NULL, ",", &saveptr); + prio_str = strtok_r(NULL, ",", &saveptr); + qrxlv_str = strtok_r(NULL, ",", &saveptr); + meas_str = strtok_r(NULL, "\0", &saveptr); + + + if (!earfcn_str || osmo_str_to_int(&earfcn, earfcn_str, 10, 0, 65535) < 0) { + cmd->reply = "Failed to parse neighbor EARFCN value"; + return 1; + } + + if (!thresh_hi_str || osmo_str_to_int(&thresh_hi, thresh_hi_str, 10, 0, 31) < 0) { + cmd->reply = "Failed to parse neighbor threshold high bits value"; + return 1; + } + + if (!thresh_lo_str || osmo_str_to_int(&thresh_lo, thresh_lo_str, 10, 0, 32) < 0) { + cmd->reply = "Failed to parse neighbor threshold low bits value"; + return 1; + } + + if (!prio_str || osmo_str_to_int(&prio, prio_str, 10, 0, 8) < 0) { + cmd->reply = "Failed to parse neighbor priority value"; + return 1; + } + + if (!qrxlv_str || osmo_str_to_int(&qrxlv, qrxlv_str, 10, 0, 32) < 0) { + cmd->reply = "Failed to parse neighbor QRXLEVMIN value"; + return 1; + } + + if (!meas_str || osmo_str_to_int(&meas, meas_str, 10, 0, 8) < 0) { + cmd->reply = "Failed to parse neighbor measurement bandwidth"; + return 1; + } + + return 0; +} + +/* si2quater neighbor management: add an EARFCN + * Format: bts.<0-255>.si2quater-neighbor-list.add.earfcn <EARFCN>,<thresh-hi>,<thresh-lo>,<priority>,<QRXLEVMIN>,<measurement bandwidth> + * EARFCN is in range 0..65535, thresh-hi is in range 0..31, thresh-hi is in range 0..32, + * priority is in range 0..8, QRXLEVMIN is in range 0..32, measurement bandwidth is in range 0..8 */ +static int set_bts_si2quater_neighbor_list_add_earfcn(struct ctrl_cmd *cmd, void *data) +{ + struct gsm_bts *bts = (struct gsm_bts *)cmd->node; + struct osmo_earfcn_si2q *neighbors = &bts->si_common.si2quater_neigh_list; + char *earfcn_str, *thresh_hi_str, *thresh_lo_str, *prio_str, *qrxlv_str, *meas_str, *saveptr, *tmp; + int earfcn, thresh_hi, thresh_lo, prio, qrxlv, meas, result; + + tmp = talloc_strdup(cmd, cmd->value); + if (!tmp) { + cmd->reply = "OOM"; + return CTRL_CMD_ERROR; + } + + earfcn_str = strtok_r(tmp, ",", &saveptr); + thresh_hi_str = strtok_r(NULL, ",", &saveptr); + thresh_lo_str = strtok_r(NULL, ",", &saveptr); + prio_str = strtok_r(NULL, ",", &saveptr); + qrxlv_str = strtok_r(NULL, ",", &saveptr); + meas_str = strtok_r(NULL, "\0", &saveptr); + + + if (!earfcn_str || osmo_str_to_int(&earfcn, earfcn_str, 10, 0, 65535) < 0) { + cmd->reply = "Failed to parse neighbor EARFCN value"; + return CTRL_CMD_ERROR; + } + + if (!thresh_hi_str || osmo_str_to_int(&thresh_hi, thresh_hi_str, 10, 0, 31) < 0) { + cmd->reply = "Failed to parse neighbor threshold high bits value"; + return CTRL_CMD_ERROR; + } + + if (!thresh_lo_str || osmo_str_to_int(&thresh_lo, thresh_lo_str, 10, 0, 32) < 0) { + cmd->reply = "Failed to parse neighbor threshold low bits value"; + return CTRL_CMD_ERROR; + } + + if (!prio_str || osmo_str_to_int(&prio, prio_str, 10, 0, 8) < 0) { + cmd->reply = "Failed to parse neighbor priority value"; + return CTRL_CMD_ERROR; + } + + if (!qrxlv_str || osmo_str_to_int(&qrxlv, qrxlv_str, 10, 0, 32) < 0) { + cmd->reply = "Failed to parse neighbor QRXLEVMIN value"; + return CTRL_CMD_ERROR; + } + + if (!meas_str || osmo_str_to_int(&meas, meas_str, 10, 0, 8) < 0) { + cmd->reply = "Failed to parse neighbor measurement bandwidth"; + return CTRL_CMD_ERROR; + } + + result = bts_earfcn_add(bts, earfcn, thresh_hi, thresh_lo, prio, qrxlv, meas); + + if ((result == 0) && (si2q_num(bts) <= SI2Q_MAX_NUM)) { + cmd->reply = "OK"; + return CTRL_CMD_REPLY; + } + + switch (result) { + case 0: + cmd->reply = talloc_asprintf(cmd, "Not enough space in SI2quater (%u/%u used)", bts->si2q_count, SI2Q_MAX_NUM); + if (!cmd->reply) + cmd->reply = "OOM"; + break; + case 1: + cmd->reply = "Multiple threshold-high are not supported"; + break; + case EARFCN_THRESH_LOW_INVALID: + cmd->reply = "Multiple threshold-low are not supported"; + break; + case EARFCN_QRXLV_INVALID + 1: + cmd->reply = "Multiple QRXLEVMIN are not supported"; + break; + case EARFCN_PRIO_INVALID: + cmd->reply = "Multiple priorities are not supported"; + break; + default: + cmd->reply = talloc_asprintf(cmd, "Unable to add EARFCN: %s", strerror(-result)); + if (!cmd->reply) + cmd->reply = "OOM"; + } + + if (osmo_earfcn_del(neighbors, earfcn) != 0) + cmd->reply = "Failed to roll-back adding EARFCN"; + + return CTRL_CMD_ERROR; +} + +CTRL_CMD_DEFINE_WO(bts_si2quater_neighbor_list_add_earfcn, + "si2quater-neighbor-list add earfcn"); static int verify_bts_si2quater_neighbor_list_add_uarfcn(struct ctrl_cmd *cmd, const char *value, void *_data) { @@ -1215,6 +1358,7 @@ rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_neighbor_list_mode); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_si2quater_neighbor_list_del_earfcn); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_si2quater_neighbor_list_del_uarfcn); + rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_si2quater_neighbor_list_add_earfcn); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_si2quater_neighbor_list_add_uarfcn); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_cell_reselection_offset); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_cell_reselection_penalty_time); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33750 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifd2740ee54db66742785437a278cb9244e1f76d0 Gerrit-Change-Number: 33750 Gerrit-PatchSet: 5 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-bsc[master]: ctrl: Support adding si2quater uarfcn neighbor
by pespin 17 Jul '23

17 Jul '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33587 ) Change subject: ctrl: Support adding si2quater uarfcn neighbor ...................................................................... ctrl: Support adding si2quater uarfcn neighbor Change-Id: I8116175b5dff1ee4bbff0dc3b4f93890ce4c975b --- M src/osmo-bsc/bts_ctrl.c 1 file changed, 90 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/bts_ctrl.c b/src/osmo-bsc/bts_ctrl.c index ad287fe..2589668 100644 --- a/src/osmo-bsc/bts_ctrl.c +++ b/src/osmo-bsc/bts_ctrl.c @@ -777,7 +777,86 @@ "si2quater-neighbor-list del uarfcn"); /* TODO: si2quater neighbor management: add EARFCN */ -/* TODO: si2quater neighbor management: add UARFCN */ + +static int verify_bts_si2quater_neighbor_list_add_uarfcn(struct ctrl_cmd *cmd, const char *value, void *_data) +{ + char *uarfcn_str, *scramble_str, *diversity_str, *saveptr, *tmp; + int uarfcn, scramble; + + tmp = talloc_strdup(cmd, value); + if (!tmp) + return 1; + + uarfcn_str = strtok_r(tmp, ",", &saveptr); + scramble_str = strtok_r(NULL, ",", &saveptr); + diversity_str = strtok_r(NULL, "\0", &saveptr); + + if (!uarfcn_str || osmo_str_to_int(&uarfcn, uarfcn_str, 10, 0, 16383) < 0) { + cmd->reply = "Failed to parse neighbor UARFCN value"; + return 1; + } + + if (!scramble_str || osmo_str_to_int(&scramble, scramble_str, 10, 0, 511) < 0) { + cmd->reply = "Failed to parse neighbor scrambling code"; + return 1; + } + + if (!diversity_str || ((strcmp(diversity_str, "1") != 0) && (strcmp(diversity_str, "0") != 0))) { + cmd->reply = "Failed to parse neighbor diversity bit"; + return 1; + } + + return 0; +} + +/* si2quater neighbor management: add an UARFCN + * Format: bts.<0-255>.si2quater-neighbor-list.add.uarfcn <UARFCN>,<scrambling code>,<diversity bit> + * UARFCN is in range 0..16383, scrambling code is in range 0..511 */ +static int set_bts_si2quater_neighbor_list_add_uarfcn(struct ctrl_cmd *cmd, void *data) +{ + struct gsm_bts *bts = (struct gsm_bts *)cmd->node; + char *uarfcn_str, *scramble_str, *diversity_str, *saveptr, *tmp; + int uarfcn, scramble; + bool diversity; + + tmp = talloc_strdup(cmd, cmd->value); + if (!tmp) { + cmd->reply = "OOM"; + return CTRL_CMD_ERROR; + } + + uarfcn_str = strtok_r(tmp, ",", &saveptr); + scramble_str = strtok_r(NULL, ",", &saveptr); + diversity_str = strtok_r(NULL, "\0", &saveptr); + + + if (!uarfcn_str || osmo_str_to_int(&uarfcn, uarfcn_str, 10, 0, 16383) < 0) { + cmd->reply = "Failed to parse neighbor UARFCN value"; + return CTRL_CMD_ERROR; + } + + if (!scramble_str || osmo_str_to_int(&scramble, scramble_str, 10, 0, 511) < 0) { + cmd->reply = "Failed to parse neighbor scrambling code"; + return CTRL_CMD_ERROR; + } + + diversity = strcmp(diversity_str, "1") == 0; + + switch (bts_uarfcn_add(bts, uarfcn, scramble, diversity)) { + case -ENOMEM: + cmd->reply = "max number of UARFCNs reached"; + return CTRL_CMD_ERROR; + case -ENOSPC: + cmd->reply = "not enough space in SI2quater"; + return CTRL_CMD_ERROR; + } + + cmd->reply = "OK"; + return CTRL_CMD_REPLY; +} + +CTRL_CMD_DEFINE_WO(bts_si2quater_neighbor_list_add_uarfcn, + "si2quater-neighbor-list add uarfcn"); static int verify_bts_cell_reselection_offset(struct ctrl_cmd *cmd, const char *value, void *_data) { @@ -1097,6 +1176,7 @@ rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_neighbor_list_mode); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_si2quater_neighbor_list_del_earfcn); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_si2quater_neighbor_list_del_uarfcn); + rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_si2quater_neighbor_list_add_uarfcn); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_cell_reselection_offset); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_cell_reselection_penalty_time); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_cell_reselection_hysteresis); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33587 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8116175b5dff1ee4bbff0dc3b4f93890ce4c975b Gerrit-Change-Number: 33587 Gerrit-PatchSet: 2 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-bsc[master]: ctrl: Add getting si2quater earfcn neighbor list
by pespin 17 Jul '23

17 Jul '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33645 ) Change subject: ctrl: Add getting si2quater earfcn neighbor list ...................................................................... ctrl: Add getting si2quater earfcn neighbor list Change-Id: Ib942bfa95aca2b514ac68f602545b9e7cbed097a --- M src/osmo-bsc/bts_ctrl.c 1 file changed, 49 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/bts_ctrl.c b/src/osmo-bsc/bts_ctrl.c index 2589668..9415b89 100644 --- a/src/osmo-bsc/bts_ctrl.c +++ b/src/osmo-bsc/bts_ctrl.c @@ -36,6 +36,8 @@ #include <osmocom/bsc/neighbor_ident.h> #include <osmocom/bsc/system_information.h> +#include <osmocom/gsm/sysinfo.h> + static int location_equal(struct bts_location *a, struct bts_location *b) { return ((a->tstamp == b->tstamp) && (a->valid == b->valid) && (a->lat == b->lat) && @@ -1148,6 +1150,43 @@ CTRL_CMD_DEFINE_RO(bts_neighbor_list_si2quater_uarfcn, "neighbor-list si2quater uarfcns"); +/* Return space concatenated set of tuples <EARFCN>,<thresh-hi>,<thresh-lo>,<prio>,<qrxlv>,<meas> */ +static int get_bts_neighbor_list_si2quater_earfcn(struct ctrl_cmd *cmd, void *data) +{ + int i; + bool first_earfcn = true; + const struct gsm_bts *bts = cmd->node; + const struct osmo_earfcn_si2q *neighbors = &bts->si_common.si2quater_neigh_list; + + cmd->reply = talloc_strdup(cmd, ""); + if (!cmd->reply) { + cmd->reply = "OOM"; + return CTRL_CMD_ERROR; + } + + for (i = 0; i < MAX_EARFCN_LIST; i++) { + if (neighbors->arfcn[i] == OSMO_EARFCN_INVALID) + continue; + cmd->reply = talloc_asprintf_append(cmd->reply, + first_earfcn ? "%u,%u,%u,%u,%u,%u" : " %u,%u,%u,%u,%u,%u", + neighbors->arfcn[i], + neighbors->thresh_hi, + neighbors->thresh_lo_valid ? neighbors->thresh_lo : 32, + neighbors->prio_valid ? neighbors->prio : 8, + neighbors->qrxlm_valid ? neighbors->qrxlm : 32, + (neighbors->meas_bw[i] != OSMO_EARFCN_MEAS_INVALID) ? neighbors->meas_bw[i] : 8); + if (!cmd->reply) { + cmd->reply = "OOM"; + return CTRL_CMD_ERROR; + } + first_earfcn = false; + } + + return CTRL_CMD_REPLY; +} + +CTRL_CMD_DEFINE_RO(bts_neighbor_list_si2quater_earfcn, "neighbor-list si2quater earfcns"); + int bsc_bts_ctrl_cmds_install(void) { int rc = 0; @@ -1184,6 +1223,7 @@ rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_rach_access_control_class_bar); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_rach_access_control_class_allow); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_neighbor_list_si2quater_uarfcn); + rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_neighbor_list_si2quater_earfcn); rc |= neighbor_ident_ctrl_init(); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33645 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib942bfa95aca2b514ac68f602545b9e7cbed097a Gerrit-Change-Number: 33645 Gerrit-PatchSet: 3 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-bsc[master]: ctrl: Add getting si2quater uarfcn neighbor list
by pespin 17 Jul '23

17 Jul '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33570 ) Change subject: ctrl: Add getting si2quater uarfcn neighbor list ...................................................................... ctrl: Add getting si2quater uarfcn neighbor list Change-Id: Iab1d2e264c0deb75f03aec6ae38ac406bc7b58cb --- M src/osmo-bsc/bts_ctrl.c 1 file changed, 39 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/bts_ctrl.c b/src/osmo-bsc/bts_ctrl.c index 77daa75..ad287fe 100644 --- a/src/osmo-bsc/bts_ctrl.c +++ b/src/osmo-bsc/bts_ctrl.c @@ -1040,6 +1040,35 @@ CTRL_CMD_DEFINE_WO(bts_rach_access_control_class_allow, "rach-access-control-class allow"); +/* Return space concatenated set of tuples <UARFCN>,<scrambling code>,<diversity bit> */ +static int get_bts_neighbor_list_si2quater_uarfcn(struct ctrl_cmd *cmd, void *data) +{ + int i; + const struct gsm_bts *bts = cmd->node; + + cmd->reply = talloc_strdup(cmd, ""); + if (!cmd->reply) { + cmd->reply = "OOM"; + return CTRL_CMD_ERROR; + } + + for (i = 0; i < bts->si_common.uarfcn_length; i++) { + cmd->reply = talloc_asprintf_append(cmd->reply, + i == 0 ? "%u,%u,%u" : " %u,%u,%u", + bts->si_common.data.uarfcn_list[i], + bts->si_common.data.scramble_list[i] & ~(1 << 9), + (bts->si_common.data.scramble_list[i] >> 9) & 1); + if (!cmd->reply) { + cmd->reply = "OOM"; + return CTRL_CMD_ERROR; + } + } + + return CTRL_CMD_REPLY; +} + +CTRL_CMD_DEFINE_RO(bts_neighbor_list_si2quater_uarfcn, "neighbor-list si2quater uarfcns"); + int bsc_bts_ctrl_cmds_install(void) { int rc = 0; @@ -1074,6 +1103,7 @@ rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_rach_access_control_class); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_rach_access_control_class_bar); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_rach_access_control_class_allow); + rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_neighbor_list_si2quater_uarfcn); rc |= neighbor_ident_ctrl_init(); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33570 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iab1d2e264c0deb75f03aec6ae38ac406bc7b58cb Gerrit-Change-Number: 33570 Gerrit-PatchSet: 2 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-bsc[master]: ctrl: Support adding si2quater earfcn neighbor
by pespin 17 Jul '23

17 Jul '23

Attention is currently required from: matanp. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33750 ) Change subject: ctrl: Support adding si2quater earfcn neighbor ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33750 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifd2740ee54db66742785437a278cb9244e1f76d0 Gerrit-Change-Number: 33750 Gerrit-PatchSet: 4 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Mon, 17 Jul 2023 09:00:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: ctrl: Add getting si2quater earfcn neighbor list
by pespin 17 Jul '23

17 Jul '23

Attention is currently required from: matanp. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33645 ) Change subject: ctrl: Add getting si2quater earfcn neighbor list ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33645 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib942bfa95aca2b514ac68f602545b9e7cbed097a Gerrit-Change-Number: 33645 Gerrit-PatchSet: 2 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Mon, 17 Jul 2023 09:00:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: ctrl: Support adding si2quater uarfcn neighbor
by pespin 17 Jul '23

17 Jul '23

Attention is currently required from: matanp. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33587 ) Change subject: ctrl: Support adding si2quater uarfcn neighbor ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33587 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8116175b5dff1ee4bbff0dc3b4f93890ce4c975b Gerrit-Change-Number: 33587 Gerrit-PatchSet: 1 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Mon, 17 Jul 2023 09:00:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: ctrl: Add getting si2quater uarfcn neighbor list
by pespin 17 Jul '23

17 Jul '23

Attention is currently required from: matanp. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33570 ) Change subject: ctrl: Add getting si2quater uarfcn neighbor list ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33570 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iab1d2e264c0deb75f03aec6ae38ac406bc7b58cb Gerrit-Change-Number: 33570 Gerrit-PatchSet: 1 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Mon, 17 Jul 2023 09:00:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: jobs/update-osmo-ci: add branch parameters
by osmith 17 Jul '23

17 Jul '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/33745 ) Change subject: jobs/update-osmo-ci: add branch parameters ...................................................................... jobs/update-osmo-ci: add branch parameters Add parameters to set the osmo-ci and docker-playground branch. I'm using this to test the debian 12 based containers before merging the changes to master. Related: OS#6057 Change-Id: I62265300048031cbb65e997b921373894500233f --- M jobs/update-osmo-ci-on-slaves.yml 1 file changed, 27 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved laforge: Looks good to me, approved diff --git a/jobs/update-osmo-ci-on-slaves.yml b/jobs/update-osmo-ci-on-slaves.yml index 8ab1e12..2d3cf07 100644 --- a/jobs/update-osmo-ci-on-slaves.yml +++ b/jobs/update-osmo-ci-on-slaves.yml @@ -19,6 +19,18 @@ - build-discarder: days-to-keep: 30 num-to-keep: 120 + parameters: + - string: + name: OSMO_BRANCH_CI + description: | + osmo-ci.git branch + default: 'master' + - string: + # Used in scripts/common.sh:docker_images_require() + name: OSMO_BRANCH_DOCKER_PLAYGROUND + description: | + docker-playground.git branch + default: 'master' scm: - git: url: https://gerrit.osmocom.org/osmo-ci @@ -26,7 +38,7 @@ git-config-email: 'jenkins(a)osmocom.org' skip-tag: true branches: - - 'origin/master' + - '$OSMO_BRANCH_CI' wipe-workspace: true triggers: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/33745 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I62265300048031cbb65e997b921373894500233f Gerrit-Change-Number: 33745 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ci[master]: jobs/update-osmo-ci: add ansicolor wrapper
by osmith 17 Jul '23

17 Jul '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/33746 ) Change subject: jobs/update-osmo-ci: add ansicolor wrapper ...................................................................... jobs/update-osmo-ci: add ansicolor wrapper Change-Id: Ic94f2cc14b2af3a3711ac3eadec8c92b62006587 --- M jobs/update-osmo-ci-on-slaves.yml 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved laforge: Looks good to me, approved diff --git a/jobs/update-osmo-ci-on-slaves.yml b/jobs/update-osmo-ci-on-slaves.yml index 2d3cf07..e9f80b1 100644 --- a/jobs/update-osmo-ci-on-slaves.yml +++ b/jobs/update-osmo-ci-on-slaves.yml @@ -49,6 +49,11 @@ builders: - shell: './contrib/jenkins.sh' + + wrappers: + - ansicolor: + colormap: xterm + description: | <b>Auto-generated using Jenkins Job Builder. DO NOT EDIT MANUALLY!</b> -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/33746 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic94f2cc14b2af3a3711ac3eadec8c92b62006587 Gerrit-Change-Number: 33746 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0