Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33766 ) Change subject: paging: also accept IMSI strings shorter than 3 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1:

I think handling the case strlen(imsi)==0 is enough, other cases should contain full imsi (or at lea […] I think we should also accept IMSIs shorter than 3, this is most convenient. If we don't, we still would need a check and we would have to log an error message. So I would prefer to just silently accept short IMSI strings.

I agree that if no IMSI is provided we should use SAPI PCU_IF_SAPI_AGCH. That is something that should be corrected in osmo-pcu. However, I guess if we do that, we still require a confirmation from osmo-bts? (I can take care of that if you want.) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33766 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iab1c3f1c39dd59bb53aa74b2c9e9e135e3985e0b Gerrit-Change-Number: 33766 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Mon, 17 Jul 2023 10:50:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment