Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33768 )
Change subject: bts: send IMMEDIATE ASSIGNMENT via AGCH when no IMSI is available
......................................................................
Patch Set 1:
(1 comment)
File src/bts.cpp:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-9695):
https://gerrit.osmocom.org/c/osmo-pcu/+/33768/comment/f1bbf929_977ecf9f
PS1, Line 1129: * for tranmission on PCH. Therefore we assume that the MS is in non-DRX mode (see also:
'tranmission' may be misspelled - perhaps 'transmission'?
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33768
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Iae1dd5d6be9ee8813a9c0b092926e8eda63f1e8e
Gerrit-Change-Number: 33768
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Mon, 17 Jul 2023 13:20:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33768 )
Change subject: bts: send IMMEDIATE ASSIGNMENT via AGCH when no IMSI is available
......................................................................
bts: send IMMEDIATE ASSIGNMENT via AGCH when no IMSI is available
There may be situations where a downlink TBF has to be assigned but the
IMSI is not yet known to the PCU. In this case we should not just send
the IMMEDIATE ASSIGNMENT via the PCH anyway. Instead, the AGCH should be
used.
Related: OS#6097
Change-Id: Iae1dd5d6be9ee8813a9c0b092926e8eda63f1e8e
---
M src/bts.cpp
M src/pcu_l1_if.cpp
2 files changed, 29 insertions(+), 18 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/68/33768/1
diff --git a/src/bts.cpp b/src/bts.cpp
index 177544a..f416ea7 100644
--- a/src/bts.cpp
+++ b/src/bts.cpp
@@ -1122,10 +1122,20 @@
GSM_L1_BURST_TYPE_ACCESS_0);
if (plen >= 0) {
bts_do_rate_ctr_inc(bts, CTR_IMMEDIATE_ASSIGN_DL_TBF);
- if (the_pcu->pcu_if_version >= 0x0b)
- pcu_l1if_tx_pch_dt(bts, immediate_assignment, plen, tbf->imsi(), tbf->tlli());
- else
- pcu_l1if_tx_pch(bts, immediate_assignment, plen, tbf->imsi());
+
+ if (strlen(tbf->imsi()) < 3) {
+ /* In case the IMSI is not yet known, the IMMEDIATE ASSIGNMENT is sent on the AGCH. The reason
+ * for this is that without IMSI we can not calculate the paging group, which would be necessary
+ * for tranmission on PCH. Therefore we assume that the MS is in non-DRX mode (see also:
+ * 3gpp TS 44.060, section 5.5.1.5) and hence it is listening on all CCCH blocks, including
+ * AGCH (see also: 3gpp TS 45.002, section 6.5.3, 6.5.6, and also OS#6097). */
+ pcu_l1if_tx_agch(bts, immediate_assignment, plen);
+ } else {
+ if (the_pcu->pcu_if_version >= 0x0b)
+ pcu_l1if_tx_pch_dt(bts, immediate_assignment, plen, tbf->imsi(), tbf->tlli());
+ else
+ pcu_l1if_tx_pch(bts, immediate_assignment, plen, tbf->imsi());
+ }
}
bitvec_free(immediate_assignment);
diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp
index f42a3d4..a256962 100644
--- a/src/pcu_l1_if.cpp
+++ b/src/pcu_l1_if.cpp
@@ -275,16 +275,6 @@
else
memset(data, '0', IMSI_DIGITS_FOR_PAGING);
- /* OS#6097: if strlen(imsi) == 0: We assume the MS is in non-DRX
- * mode (TS 44.060 5.5.1.5) and hence it is listening on all CCCH blocks
- * (TS 45.002 6.5.3, 6.5.6).
- * Hence, pgroup 000 is taken "randomly" to send it over it. This of
- * course not optimal since it can actually be sent on any CCCH blocks,
- * so we are delaying the ImmAss for no good reason. But anyway,
- * pcu_l1if_tx_pch() is deprecated and pcu_l1if_tx_pch_dt() should be
- * used instead, which doesn't suffer from this problem.
- */
-
/* block provided by upper layer comes without first byte (plen), prepend it manually: */
OSMO_ASSERT(sizeof(data) >= IMSI_DIGITS_FOR_PAGING + 1 + block->data_len);
data[IMSI_DIGITS_FOR_PAGING] = (plen << 2) | 0x01;
@@ -307,10 +297,6 @@
pch_dt.tlli = tlli;
if (imsi)
OSMO_STRLCPY_ARRAY(pch_dt.imsi, imsi);
- /* OS#6097: if strlen(pch_dt.imsi) == 0: We assume the MS is in non-DRX
- * mode (TS 44.060 5.5.1.5) and hence it is listening on all CCCH blocks
- * (TS 45.002 6.5.3, 6.5.6).
- */
pch_dt.data[0] = (plen << 2) | 0x01;
bitvec_pack(block, pch_dt.data + 1);
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33768
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Iae1dd5d6be9ee8813a9c0b092926e8eda63f1e8e
Gerrit-Change-Number: 33768
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: jolly, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33292 )
Change subject: ASCI: VGCS/VBS RACH -> RSL TALKER/LISTENER DETECT
......................................................................
Patch Set 6: Code-Review+1
(3 comments)
Patchset:
PS6:
Looks good to me in general!
File src/common/asci.c:
https://gerrit.osmocom.org/c/osmo-bts/+/33292/comment/ed403d71_cf39eddc
PS6, Line 79: is in not active
This looks weird, maybe just "is not active"?
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/33292/comment/248c2b69_9baf1802
PS6, Line 1988: handover
Change to "DCCH"? The function actually expects a channel type name, not type of access.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33292
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1bd07ab6802341b09a06e89df356665ffaf6d2bf
Gerrit-Change-Number: 33292
Gerrit-PatchSet: 6
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 17 Jul 2023 13:17:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33714 )
Change subject: GTP_Emulation: make GTPU optional
......................................................................
GTP_Emulation: make GTPU optional
When using the GTP_Emulation connection handler one has to configure a
GTPC and a GTPU link. However in some situations (e.g. when testing the
Gn interface of an 5g MME) only GTPC may be required. So lets make the
GTPU link optional.
Related: OS#5760
Change-Id: I509a229fcaf02ea5149df42816af27bba46d3bff
---
M library/GTP_Emulation.ttcn
1 file changed, 23 insertions(+), 6 deletions(-)
Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/library/GTP_Emulation.ttcn b/library/GTP_Emulation.ttcn
index b67e828..4ea293c 100644
--- a/library/GTP_Emulation.ttcn
+++ b/library/GTP_Emulation.ttcn
@@ -30,8 +30,8 @@
type record GtpEmulationCfg {
HostName gtpc_bind_ip,
PortNumber gtpc_bind_port,
- HostName gtpu_bind_ip,
- PortNumber gtpu_bind_port,
+ HostName gtpu_bind_ip optional,
+ PortNumber gtpu_bind_port optional,
boolean sgsn_role
};
@@ -168,10 +168,12 @@
cfg.gtpc_bind_port, {udp:={}});
g_gtpc_id := res.connId;
- map(self:GTPU, system:GTPU);
- res := GTP_CodecPort_CtrlFunct.f_GTPU_listen(GTPU, cfg.gtpu_bind_ip,
- cfg.gtpu_bind_port, {udp:={}});
- g_gtpu_id := res.connId;
+ if (isvalue(cfg.gtpu_bind_ip) and isvalue(cfg.gtpu_bind_port)) {
+ map(self:GTPU, system:GTPU);
+ res := GTP_CodecPort_CtrlFunct.f_GTPU_listen(GTPU, cfg.gtpu_bind_ip,
+ cfg.gtpu_bind_port, {udp:={}});
+ g_gtpu_id := res.connId;
+ }
g_restart_ctr := f_rnd_octstring(1);
g_c_seq_nr := f_rnd_int(65535);
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33714
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I509a229fcaf02ea5149df42816af27bba46d3bff
Gerrit-Change-Number: 33714
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged