July 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-e1d[master]: octoi: Fix missing check of osmo_fsm_register() return value
by laforge 18 Jul '23

18 Jul '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/33784 ) Change subject: octoi: Fix missing check of osmo_fsm_register() return value ...................................................................... octoi: Fix missing check of osmo_fsm_register() return value Fixes: CID#307511: Unchecked return value (CHECKED_RETURN) Change-Id: Ia474a6c078f1aec3d04be494a888ffe87b199f5a --- M src/octoi/octoi.c 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve tnt: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/octoi/octoi.c b/src/octoi/octoi.c index 6e4b8f9..1c0a6e7 100644 --- a/src/octoi/octoi.c +++ b/src/octoi/octoi.c @@ -75,8 +75,8 @@ { OSMO_ASSERT(!g_octoi); - osmo_fsm_register(&octoi_server_fsm); - osmo_fsm_register(&octoi_client_fsm); + OSMO_ASSERT(osmo_fsm_register(&octoi_server_fsm) == 0); + OSMO_ASSERT(osmo_fsm_register(&octoi_client_fsm) == 0); g_octoi = talloc_zero(ctx, struct octoi_daemon); OSMO_ASSERT(g_octoi); -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/33784 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ia474a6c078f1aec3d04be494a888ffe87b199f5a Gerrit-Change-Number: 33784 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-MessageType: merged

1 0

[S] Change in osmo-e1d[master]: proto_srv: Fix file descriptor and memory leak in error paths
by laforge 18 Jul '23

18 Jul '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/33783 ) Change subject: proto_srv: Fix file descriptor and memory leak in error paths ...................................................................... proto_srv: Fix file descriptor and memory leak in error paths Fixes: CID#307517 Change-Id: I44e349eee5b0b54843762db8cadd6b9b1758faa4 --- M src/proto_srv.c 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve tnt: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/proto_srv.c b/src/proto_srv.c index d6d3d17..2b85ac6 100644 --- a/src/proto_srv.c +++ b/src/proto_srv.c @@ -185,6 +185,7 @@ conn = talloc_zero(srv->ctx, struct osmo_e1dp_server_conn); if (!conn) { LOGP(DE1D, LOGL_ERROR, "Failed to create incoming connection.\n"); + close(rc); return -1; } @@ -197,6 +198,8 @@ if (osmo_fd_register(&conn->fd) != 0) { LOGP(DE1D, LOGL_ERROR, "Failed to register incoming fd.\n"); + close(conn->fd.fd); + talloc_free(conn); return -1; } -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/33783 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I44e349eee5b0b54843762db8cadd6b9b1758faa4 Gerrit-Change-Number: 33783 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-MessageType: merged

1 0

[S] Change in osmo-e1d[master]: e1d-ts-pipe: Assert that osmo_fd_register() succeeds
by laforge 18 Jul '23

18 Jul '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/33785 ) Change subject: e1d-ts-pipe: Assert that osmo_fd_register() succeeds ...................................................................... e1d-ts-pipe: Assert that osmo_fd_register() succeeds Fixes: CID#307497: Unchecked return value (CHECKED_RETURN) Change-Id: Ie2abd580e37d7d58c507d12105ec2130fb533ed9 --- M src/e1d-ts-pipe.c 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve tnt: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/e1d-ts-pipe.c b/src/e1d-ts-pipe.c index 99b7c55..45cafb8 100644 --- a/src/e1d-ts-pipe.c +++ b/src/e1d-ts-pipe.c @@ -219,7 +219,7 @@ exit(2); osmo_fd_setup(&ts_ofd, tsfd, OSMO_FD_READ|OSMO_FD_WRITE, ts_fd_cb, NULL, 0); - osmo_fd_register(&ts_ofd); + OSMO_ASSERT(osmo_fd_register(&ts_ofd) == 0); set_nonblock(infd); set_nonblock(outfd); -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/33785 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ie2abd580e37d7d58c507d12105ec2130fb533ed9 Gerrit-Change-Number: 33785 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-MessageType: merged

1 0

[S] Change in osmo-e1d[master]: Check return code of fcntl() in several plaaces
by laforge 18 Jul '23

18 Jul '23

Attention is currently required from: tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/33782 ) Change subject: Check return code of fcntl() in several plaaces ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/33782 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I46843174eb4699a59421dc3f3b900a3894c67081 Gerrit-Change-Number: 33782 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Tue, 18 Jul 2023 15:18:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-e1d[master]: e1d-ts-pipe: Assert that osmo_fd_register() succeeds
by laforge 18 Jul '23

18 Jul '23

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/33785 ) Change subject: e1d-ts-pipe: Assert that osmo_fd_register() succeeds ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/33785 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ie2abd580e37d7d58c507d12105ec2130fb533ed9 Gerrit-Change-Number: 33785 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Tue, 18 Jul 2023 15:18:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-e1d[master]: octoi: Fix missing check of osmo_fsm_register() return value
by laforge 18 Jul '23

18 Jul '23

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/33784 ) Change subject: octoi: Fix missing check of osmo_fsm_register() return value ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/33784 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ia474a6c078f1aec3d04be494a888ffe87b199f5a Gerrit-Change-Number: 33784 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Tue, 18 Jul 2023 15:18:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-e1d[master]: proto_srv: Fix file descriptor and memory leak in error paths
by laforge 18 Jul '23

18 Jul '23

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/33783 ) Change subject: proto_srv: Fix file descriptor and memory leak in error paths ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/33783 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I44e349eee5b0b54843762db8cadd6b9b1758faa4 Gerrit-Change-Number: 33783 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Tue, 18 Jul 2023 15:18:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-uecups[master]: gtp_daemon: Fix error paths in gtp_daemon_alloc()
by laforge 18 Jul '23

18 Jul '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-uecups/+/33787 ) Change subject: gtp_daemon: Fix error paths in gtp_daemon_alloc() ...................................................................... gtp_daemon: Fix error paths in gtp_daemon_alloc() Fixes: CID#307527: Unchecked return value (CHECKED_RETURN) Change-Id: I690b24671567aac4dca24389309ebaa3e76e272c --- M daemon/gtp_daemon.c 1 file changed, 23 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/daemon/gtp_daemon.c b/daemon/gtp_daemon.c index b5b7ac8..31ae39f 100644 --- a/daemon/gtp_daemon.c +++ b/daemon/gtp_daemon.c @@ -54,6 +54,7 @@ struct gtp_daemon *gtp_daemon_alloc(void *ctx) { + int rc; struct gtp_daemon *d = talloc_zero(ctx, struct gtp_daemon); if (!d) return NULL; @@ -66,7 +67,12 @@ d->main_thread = pthread_self(); d->itq = osmo_it_q_alloc(d, "itq", 4096, gtp_daemon_itq_read_cb, d); - osmo_fd_register(&d->itq->event_ofd); + if (!d->itq) + goto out_free; + + rc = osmo_fd_register(&d->itq->event_ofd); + if (rc < 0) + goto out_free_q; INIT_LLIST_HEAD(&d->cups_clients); @@ -74,4 +80,10 @@ d->cfg.cups_local_port = UECUPS_SCTP_PORT; return d; + +out_free_q: + osmo_it_q_destroy(d->itq); +out_free: + talloc_free(d); + return NULL; } -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/33787 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I690b24671567aac4dca24389309ebaa3e76e272c Gerrit-Change-Number: 33787 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in docker-playground[master]: ttcn3-ggsn-test: kernel-gtp: add ipv6
by osmith 18 Jul '23

18 Jul '23

Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33802 ) Change subject: ttcn3-ggsn-test: kernel-gtp: add ipv6 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: See the commit message description: > I've also tried to add extra inet6 and inet46 blocks to the config, as > in osmo-ggsn.cfg. But configuring multiple APNs with kernel GTP is not > supported in osmo-ggsn: > cannot create GTP tunnel device: Device or resource busy Should I change osmo-ggsn, so it can handle multiple APNs with kernel GTP? I wasn't sure if this was in scope of the issue. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33802 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If3549db216ff89bdb963744bb38015ad68d4cf6a Gerrit-Change-Number: 33802 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 18 Jul 2023 15:17:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[S] Change in osmo-uecups[master]: daemon_vty: avoid null-dereference in argc < 0 case
by laforge 18 Jul '23

18 Jul '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-uecups/+/33788 ) Change subject: daemon_vty: avoid null-dereference in argc < 0 case ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-uecups/+/33788/comment/38cc67b5_79bea1b0 PS1, Line 10: which means in theory argc could be negative and the second clause > I think it's fine changing it to "argc > 0" to use same condition as above, but I doubt argc can be […] I'm not saying it is a realistic scenario. I'm saying it might happen theoretically. After all, it is a signed integer... -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/33788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I4149b0b191a34168ba6649338d3cdf6c6af6cfe7 Gerrit-Change-Number: 33788 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jul 2023 15:17:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0