July 2023 - gerrit-log - lists.osmocom.org

[L] Change in docker-playground[master]: hnbgw: adjust cfg for cnpool tests
by neels 18 Jul '23

18 Jul '23

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33668 ) Change subject: hnbgw: adjust cfg for cnpool tests ...................................................................... Patch Set 4: (1 comment) Patchset: PS3: > Can you explain in the commit message why do you need to have 2 sets of cfg files now? i wish i didn't need two sets -- the reason is, osmo-hnbgw master has config options that osmo-hnbgw latest does not support, so i keep a copy of the current cfg version to not break 'latest' tests... If there's a better way I'm all ears (I still think our test suite should correlate test suite version with SUT version implicitly to make our lives easier) -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33668 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I94aa0b2adfc48b98cb4b1efe595c2432fc603d6c Gerrit-Change-Number: 33668 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jul 2023 21:51:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: configure: add --enable-meas-udp2db/pcap2db/vis
by laforge 18 Jul '23

18 Jul '23

Attention is currently required from: osmith, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33681 ) Change subject: configure: add --enable-meas-udp2db/pcap2db/vis ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Patchset: PS4: > I can't find it right now, but I'm pretty sure Harald said some years ago on a mailing list post / i […] the automagic-ness is indeed not the best approach, as documented in many places. All that can be argued about is whether or not the default should be enabled or disabled. I'm fine with disabling them by default in the configure script but build them in the debian package. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33681 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8b3d5efb769437a5d3036e1e627b8d477275d93e Gerrit-Change-Number: 33681 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jul 2023 18:50:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: gsm: Add missing IE definition for GMM Receive N-PDU Number list
by laforge 18 Jul '23

18 Jul '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33806 ) Change subject: gsm: Add missing IE definition for GMM Receive N-PDU Number list ...................................................................... gsm: Add missing IE definition for GMM Receive N-PDU Number list Change-Id: Ifac09653141758af345efe2eb9cef25ebf4dcff9 --- M include/osmocom/gsm/protocol/gsm_04_08_gprs.h 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/gsm/protocol/gsm_04_08_gprs.h b/include/osmocom/gsm/protocol/gsm_04_08_gprs.h index 65dc233..8799d65 100644 --- a/include/osmocom/gsm/protocol/gsm_04_08_gprs.h +++ b/include/osmocom/gsm/protocol/gsm_04_08_gprs.h @@ -91,6 +91,7 @@ GSM48_IE_GMM_AUTH_SRES = 0x22, /* 10.5.3.2 */ GSM48_IE_GMM_IMEISV = 0x23, /* 10.5.1.4 */ GSM48_IE_GMM_CAUSE = 0x25, /* 10.5.5.14 */ + GSM48_IE_GMM_RX_NPDU_NUM_LIST = 0x26, /* 10.5.5.11 */ GSM48_IE_GMM_DRX_PARAM = 0x27, /* 10.5.5.6 */ GSM48_IE_GMM_AUTN = 0x28, /* 10.5.3.1.1 */ GSM48_IE_GMM_AUTH_RES_EXT = 0x29, /* 10.5.3.2.1 */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33806 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ifac09653141758af345efe2eb9cef25ebf4dcff9 Gerrit-Change-Number: 33806 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in libosmocore[master]: gsm: Add missing IE definition for GMM Receive N-PDU Number list
by laforge 18 Jul '23

18 Jul '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33806 ) Change subject: gsm: Add missing IE definition for GMM Receive N-PDU Number list ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33806 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ifac09653141758af345efe2eb9cef25ebf4dcff9 Gerrit-Change-Number: 33806 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jul 2023 18:02:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-remsim[master]: user_simtrace2: Fix uninitialized ifm->path
by laforge 18 Jul '23

18 Jul '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/33790 ) Change subject: user_simtrace2: Fix uninitialized ifm->path ...................................................................... Patch Set 1: (1 comment) File src/client/user_simtrace2.c: https://gerrit.osmocom.org/c/osmo-remsim/+/33790/comment/e13f7564_4eed8875 PS1, Line 414: memset(&ifm, 0, sizeof(ifm)); > this looks wrong, ifm is already a pointer? indeed. thanks. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/33790 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I2bd0dac76b6d028d10f12f3f58a2aee123ca8562 Gerrit-Change-Number: 33790 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jul 2023 18:01:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-remsim[master]: log at NOTICE level if somebody uses loopback addresses.
by laforge 18 Jul '23

18 Jul '23

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/33812 to look at the new patch set (#2). Change subject: log at NOTICE level if somebody uses loopback addresses. ...................................................................... log at NOTICE level if somebody uses loopback addresses. It appears a common mistake is to e.g. run remsim-server + remsim-bankd on one machine and then instruct them to use localhost or other loopback-routed addresses. This won't work as that address is then sent to a [remote] remsim-client that attempts to reach the bankd at localhost. Change-Id: I3b4eda10e81a705aef8d647a860890a74cba8f13 --- M src/client/main_fsm.c M src/server/rspro_server.c 2 files changed, 25 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/12/33812/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/33812 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I3b4eda10e81a705aef8d647a860890a74cba8f13 Gerrit-Change-Number: 33812 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-remsim[master]: user_simtrace2: Fix uninitialized ifm->path
by laforge 18 Jul '23

18 Jul '23

Attention is currently required from: laforge. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/33790 to look at the new patch set (#2). Change subject: user_simtrace2: Fix uninitialized ifm->path ...................................................................... user_simtrace2: Fix uninitialized ifm->path Let's memset the entire ifm before calling osmo_libusb_open_claim_interface() Fixes: CID#307510: Uninitialized scalar variable (UNINIT) Change-Id: I2bd0dac76b6d028d10f12f3f58a2aee123ca8562 --- M src/client/user_simtrace2.c 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/90/33790/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/33790 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I2bd0dac76b6d028d10f12f3f58a2aee123ca8562 Gerrit-Change-Number: 33790 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-remsim[master]: bankd: Don't use 127.0.0.1 as default IP address for the server
by laforge 18 Jul '23

18 Jul '23

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/33813 ) Change subject: bankd: Don't use 127.0.0.1 as default IP address for the server ...................................................................... bankd: Don't use 127.0.0.1 as default IP address for the server If remsim-bankd connects via 127.0.0.1 or any other loopback-routed IP address to the remsim-server, then the getpername() of remsim-server for the bankd will also render 127.0.0.1, and subsequently that IP address will be provided to remsim-client as address to connect to. In almost all setups, remsim-client will be running on a remote node and hence not able to reach remsim-bankd at 127.0.0.1. Let's turn the server-IP into a mandatory command line argument of remsim-bankd and not use a problematic default value. Change-Id: I3deb05e31cdf35232cf9a118d5a5fcdb5d0ab601 --- M doc/manuals/chapters/remsim-bankd.adoc M src/bankd/bankd_main.c 2 files changed, 36 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/13/33813/1 diff --git a/doc/manuals/chapters/remsim-bankd.adoc b/doc/manuals/chapters/remsim-bankd.adoc index 4df0844..e87de52 100644 --- a/doc/manuals/chapters/remsim-bankd.adoc +++ b/doc/manuals/chapters/remsim-bankd.adoc @@ -61,7 +61,7 @@ ==== SYNOPSIS -*osmo-remsim-bankd* [-h] [-V] [-d LOGOPT] [-i A.B.C.D] [-p <1-65535>] [-b <1-1023>] [-n <1-1023>] [-I A.B.C.D] [-P <1-65535> ] +*osmo-remsim-bankd* [-h] [-V] [-d LOGOPT] -i A.B.C.D [-p <1-65535>] [-b <1-1023>] [-n <1-1023>] [-I A.B.C.D] [-P <1-65535> ] ==== OPTIONS @@ -73,7 +73,9 @@ Configure the logging verbosity, see <<remsim_logging>>. *-i, --server-host A.B.C.D*:: Specify the remote IP address/hostname of the `osmo-remsim-server` to - which this bankd shall establish its RSPRO control connection + which this bankd shall establish its RSPRO control connection. Do not specify a loopback + address or localhost, as this would in most cases result in a broken configuration where + a [usually remote] remsim-client attempts to reach the bankd via loopback, which doesn't work. *-p, --server-port <1-65535>*:: Specify the remote TCP port number of the `osmo-remsim-server` to which this bankd shall establish its RSPRO control connection diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index e002b94..212e606 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -284,13 +284,13 @@ return 0; } -static void printf_help() +static void printf_help(FILE *out) { - printf( + fprintf(out, " -h --help Print this help message\n" " -V --version Print the version of the program\n" " -d --debug option Enable debug logging (e.g. DMAIN:DST2)\n" -" -i --server-host A.B.C.D remsim-server IP address (default: 127.0.0.1)\n" +" -i --server-host A.B.C.D remsim-server IP address (mandatory)\n" " -p --server-port <1-65535> remsim-server TCP port (default: 9998)\n" " -b --bank-id <1-1023> Bank Identifier of this SIM bank (default: 1)\n" " -n --num-slots <1-1023> Number of Slots in this SIM bank (default: 8)\n" @@ -336,7 +336,7 @@ switch (c) { case 'h': - printf_help(); + printf_help(stdout); exit(0); break; case 'V': @@ -397,7 +397,7 @@ bankd_init(g_bankd); srvc = &g_bankd->srvc; - srvc->server_host = "localhost"; + srvc->server_host = NULL; srvc->server_port = 9998; srvc->handle_rx = bankd_srvc_handle_rx; srvc->own_comp_id.type = ComponentType_remsimBankd; @@ -407,6 +407,13 @@ handle_options(argc, argv); + if (!srvc->server_host) { + fprintf(stderr, "ERROR: You must specify the host name / IP of the remsim-server to which " + "the bankd shall connect to\n\n"); + printf_help(stderr); + exit(2); + } + g_bankd->main = pthread_self(); signal(SIGMAPDEL, handle_sig_mapdel); signal(SIGMAPADD, handle_sig_mapadd); -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/33813 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I3deb05e31cdf35232cf9a118d5a5fcdb5d0ab601 Gerrit-Change-Number: 33813 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-remsim[master]: log at NOTICE level if somebody uses loopback addresses.
by laforge 18 Jul '23

18 Jul '23

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/33812 ) Change subject: log at NOTICE level if somebody uses loopback addresses. ...................................................................... log at NOTICE level if somebody uses loopback addresses. It appears a common mistake is to e.g. run remsim-server + remsim-bankd on one machine and then instruct them to use localhost or other loopback-routed addresses. This won't work as that address is then sent to a [remote] remsim-client that attempts to reach the bankd at localhost. Change-Id: I3b4eda10e81a705aef8d647a860890a74cba8f13 --- M src/client/main_fsm.c M src/server/rspro_server.c 2 files changed, 25 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/12/33812/1 diff --git a/src/client/main_fsm.c b/src/client/main_fsm.c index 18798d3..dcdd239 100644 --- a/src/client/main_fsm.c +++ b/src/client/main_fsm.c @@ -248,6 +248,11 @@ rspro2bank_slot(&bc->bankd_slot, &pdu_rx->msg.choice.configClientBankReq.bankSlot); LOGPFSML(fi, LOGL_INFO, "Rx configClientBankReq(%s:%u / B%u:%u)\n", bc->bankd_conn.server_host, bc->bankd_conn.server_port, bc->bankd_slot.bank_id, bc->bankd_slot.slot_nr); + if (!strncmp(bc->bankd_conn.server_host, "127.", 4) || !strcmp(bc->bankd_conn.server_host, "::1")) { + LOGPFSML(fi, LOGL_NOTICE, "we were instructed to connect to a bankd on a loopback address " + "%s. This is most likely a BROKEN CONFIGURATION, unless this client runs on the " + "same host as remsim-bankd\n", bc->bankd_conn.server_host); + } /* bankd port 0 is a magic value to indicate "no bankd" */ if (bc->bankd_conn.server_port == 0) osmo_fsm_inst_state_chg(fi, MF_ST_UNCONFIGURED, 0, 0); diff --git a/src/server/rspro_server.c b/src/server/rspro_server.c index da27a2d..9f01273 100644 --- a/src/server/rspro_server.c +++ b/src/server/rspro_server.c @@ -314,6 +314,11 @@ return; } bankd_ip = ntohl(inet_addr(ip_str)); + if ((bankd_ip >> 24) == 127) { + LOGPFSML(bankd_conn->fi, LOGL_NOTICE, "bankd operating on loopback address %s, ", + "this is very likely a BROKEN CONFIGURATION, unless remsim-client runs " + "on the same machine as remsim-bankd and remsim-server\n", ip_str); + } bankd_port = 9999; /* TODO: configurable */ } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/33812 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I3b4eda10e81a705aef8d647a860890a74cba8f13 Gerrit-Change-Number: 33812 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-gprs[master]: WIP: sm: Handle GMMSM-MODIFY.ind primitive
by pespin 18 Jul '23

18 Jul '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33811 ) Change subject: WIP: sm: Handle GMMSM-MODIFY.ind primitive ...................................................................... WIP: sm: Handle GMMSM-MODIFY.ind primitive Change-Id: Ic765b7a565cac4abcf34d8c6868e103971d17822 --- M src/sm/sm_prim.c 1 file changed, 43 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/11/33811/1 diff --git a/src/sm/sm_prim.c b/src/sm/sm_prim.c index b513aa7..41fd0ec 100644 --- a/src/sm/sm_prim.c +++ b/src/sm/sm_prim.c @@ -530,6 +530,37 @@ return rc; } +/* Osmocom specific, GMMSM-MODIFY-IND */ +static int gprs_sm_prim_handle_gmmsm_modify_ind(struct osmo_gprs_gmm_prim *gmm_prim) +{ + struct osmo_gprs_gmm_gmmsm_prim *gmmsm = &gmm_prim->gmmsm; + struct gprs_sm_entity *sme; + struct gprs_sm_ms *ms; + int rc; + + sme = gprs_sm_find_sme_by_sess_id(gmmsm->sess_id); + if (!sme) { + LOGSM(LOGL_ERROR, "Rx GMMSM-MODIFY.ind for non existing SM Entity\n"); + return -EINVAL; + } + + ms = sme->ms; + + /* Update allocated PTMSI: */ + if (gmm_prim->gmmsm.modify_ind.allocated_ptmsi != GSM_RESERVED_TMSI) + ms->gmm.ptmsi = gmm_prim->gmmsm.modify_ind.allocated_ptmsi; + ms->gmm.ptmsi_sig = gmm_prim->gmmsm.modify_ind.allocated_ptmsi_sig; + /* Update allocated TLLI: */ + ms->gmm.tlli = gmm_prim->gmmsm.modify_ind.allocated_tlli; + /* Update the current RAI: */ + memcpy(&ms->gmm.ra, &gmm_prim->gmmsm.modify_ind.rai, sizeof(ms->gmm.ra)); + + /* TODO: Handle gmm_prim->gmmsm.modify_ind.pdp_ctx_status */ + /* TODO: Handle gmm_prim->gmmsm.modify_ind.rx_npdu_numbers_list */ + + return rc; +} + static int gprs_sm_prim_handle_gmmsm(struct osmo_gprs_gmm_prim *gmm_prim) { int rc = 0; @@ -543,6 +574,9 @@ case OSMO_PRIM(OSMO_GPRS_GMM_GMMSM_UNITDATA, PRIM_OP_INDICATION): rc = gprs_sm_prim_handle_gmmsm_unitdata_ind(gmm_prim); break; + case OSMO_PRIM(OSMO_GPRS_GMM_GMMSM_MODIFY, PRIM_OP_INDICATION): + rc = gprs_sm_prim_handle_gmmsm_modify_ind(gmm_prim); + break; default: rc = gprs_sm_prim_handle_gmm_unsupported(gmm_prim); rc = 1; -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33811 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ic765b7a565cac4abcf34d8c6868e103971d17822 Gerrit-Change-Number: 33811 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0