July 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-msc[master]: ASCI: Point to correct state machien when calling ran_encode_and_send()
by jolly 19 Jul '23

19 Jul '23

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/33827 ) Change subject: ASCI: Point to correct state machien when calling ran_encode_and_send() ...................................................................... ASCI: Point to correct state machien when calling ran_encode_and_send() Fixes: CID#322139 Change-Id: I8de1fce76ba36a06384581e3a1af706b41cad1fe --- M src/libmsc/msc_vgcs.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/27/33827/1 diff --git a/src/libmsc/msc_vgcs.c b/src/libmsc/msc_vgcs.c index 3970308..f50753b 100644 --- a/src/libmsc/msc_vgcs.c +++ b/src/libmsc/msc_vgcs.c @@ -2508,7 +2508,7 @@ .gsm0808_cause = GSM0808_CAUSE_PROTOCOL_ERROR_BETWEEN_BSS_AND_MSC, }, }; - ran_encode_and_send(bss->fi, &tx_ran_msg, cell->conn, false); + ran_encode_and_send(fi, &tx_ran_msg, cell->conn, false); cell_clear(cell, GSM0808_CAUSE_PROTOCOL_ERROR_BETWEEN_BSS_AND_MSC); /* Notify BSS FSM about channel failure. */ if (bss) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33827 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8de1fce76ba36a06384581e3a1af706b41cad1fe Gerrit-Change-Number: 33827 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-ttcn3-hacks[master]: GPRS_Components: use more suitable SAPI for DL TBF assignment
by laforge 19 Jul '23

19 Jul '23

Attention is currently required from: pespin, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33794 ) Change subject: GPRS_Components: use more suitable SAPI for DL TBF assignment ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33794 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I49c59bad0162cb303669f6108201f154918b1db3 Gerrit-Change-Number: 33794 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Jul 2023 08:14:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: PCUIF_Types: add decoder for PCUIF_pch_dt
by laforge 19 Jul '23

19 Jul '23

Attention is currently required from: pespin, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33793 ) Change subject: PCUIF_Types: add decoder for PCUIF_pch_dt ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33793 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I535aa45a676b87a8912e99bdb802bf29a23f1c89 Gerrit-Change-Number: 33793 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Jul 2023 08:14:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: BTS_Test_ASCI: Add Listener detection test
by laforge 19 Jul '23

19 Jul '23

Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33820 ) Change subject: BTS_Test_ASCI: Add Listener detection test ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33820 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I544f492a32751d17f998a2143081c3763ba1dd29 Gerrit-Change-Number: 33820 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 19 Jul 2023 08:13:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: BTS_Test_ASCI: Add Talker establishment/release test
by laforge 19 Jul '23

19 Jul '23

Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33819 ) Change subject: BTS_Test_ASCI: Add Talker establishment/release test ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33819 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic86bc34890c7d1e6e0b255c3d40eda3dfaa59285 Gerrit-Change-Number: 33819 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 19 Jul 2023 08:13:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: BTS_Test_ASCI: Add Talker detect and link fail test
by laforge 19 Jul '23

19 Jul '23

Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33818 ) Change subject: BTS_Test_ASCI: Add Talker detect and link fail test ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33818 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3b292f6a5f47298195bd942a5ca73d9d63f921b5 Gerrit-Change-Number: 33818 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 19 Jul 2023 08:13:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: BTS_Test_ASCI: Add UPLINK FREE / UPLINK BUSY test
by laforge 19 Jul '23

19 Jul '23

Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33817 ) Change subject: BTS_Test_ASCI: Add UPLINK FREE / UPLINK BUSY test ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File bts/BTS_Tests_ASCI.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33817/comment/4f5e55a1_6e5e… PS3, Line 158: RSL.send(ts_RSL_UNITDATA_REQ(g_chan_nr, ts_RslLinkID_DCCH(0), uplink_free)); : for (var integer i := 0; i < 20; i := i + 1) { : f_l1_exp_lapdm(tr_LAPDm_Bter_UI(uplink_free)); : log("Received UPLINK FREE."); : } : : /* Send one UPLINK BUSY message and expect it to be received. */ : log("Send UPLINK BUSY."); : RSL.send(ts_RSL_UNITDATA_REQ(g_chan_nr, ts_RslLinkID_DCCH(0), uplink_busy)); : f_l1_exp_lapdm(tr_LAPDm_UI(0, cr_MT_CMD, uplink_busy)); > again here I smell the potential for race conditions. […] nevermind. this is unit-data and there are no re-transmissions at BTS level, so this should be safe here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2f70adb4a6f71eb8972feccf9dda0f77e7a942b9 Gerrit-Change-Number: 33817 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 19 Jul 2023 08:12:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: BTS_Test_ASCI: Add UPLINK FREE / UPLINK BUSY test
by laforge 19 Jul '23

19 Jul '23

Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33817 ) Change subject: BTS_Test_ASCI: Add UPLINK FREE / UPLINK BUSY test ...................................................................... Patch Set 3: (1 comment) File bts/BTS_Tests_ASCI.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33817/comment/ed116d0b_efb5… PS3, Line 158: RSL.send(ts_RSL_UNITDATA_REQ(g_chan_nr, ts_RslLinkID_DCCH(0), uplink_free)); : for (var integer i := 0; i < 20; i := i + 1) { : f_l1_exp_lapdm(tr_LAPDm_Bter_UI(uplink_free)); : log("Received UPLINK FREE."); : } : : /* Send one UPLINK BUSY message and expect it to be received. */ : log("Send UPLINK BUSY."); : RSL.send(ts_RSL_UNITDATA_REQ(g_chan_nr, ts_RslLinkID_DCCH(0), uplink_busy)); : f_l1_exp_lapdm(tr_LAPDm_UI(0, cr_MT_CMD, uplink_busy)); again here I smell the potential for race conditions. Things don't happen synchronously and there are many queues involved. So you cannot reliably guarantee there's no old uplink_free still receiveda this point here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2f70adb4a6f71eb8972feccf9dda0f77e7a942b9 Gerrit-Change-Number: 33817 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 19 Jul 2023 08:11:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-remsim[master]: log at NOTICE level if somebody uses loopback addresses.
by laforge 19 Jul '23

19 Jul '23

Attention is currently required from: mschramm, roh. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/33812 ) Change subject: log at NOTICE level if somebody uses loopback addresses. ...................................................................... Patch Set 2: Code-Review-1 (1 comment) File src/client/main_fsm.c: https://gerrit.osmocom.org/c/osmo-remsim/+/33812/comment/62e55518_1f10ce37 PS2, Line 252: LOGPFSML(fi, LOGL_NOTICE, "we were instructed to connect to a bankd on a loopback address " : "%s. This is most likely a BROKEN CONFIGURATION, unless this client runs on the " : "same host as remsim-bankd\n", bc->bankd_conn.server_host); we can actually be smarter about this message (on the client side): Only log this message if we ourselves are also using a loopback address. This way no NOTICE messages are printed when somebody actually does run bankd+client on localhost (which works). you just cannot run one on non-localhost and the other on it. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/33812 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I3b4eda10e81a705aef8d647a860890a74cba8f13 Gerrit-Change-Number: 33812 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: mschramm <mschramm(a)sysmocom.de> Gerrit-Reviewer: roh <jsteiger(a)sysmocom.de> Gerrit-Attention: mschramm <mschramm(a)sysmocom.de> Gerrit-Attention: roh <jsteiger(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Jul 2023 08:09:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: BTS_Test_ASCI: Add first ASCI test to check NCH support
by laforge 19 Jul '23

19 Jul '23

Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33816 ) Change subject: BTS_Test_ASCI: Add first ASCI test to check NCH support ...................................................................... Patch Set 3: (2 comments) Patchset: PS3: a File bts/BTS_Tests_ASCI.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33816/comment/600c512b_9222… PS3, Line 107: RSL_CCHAN.send(ts_ASP_RSL_UD(ts_RSL_NOTIF_CMD_STOP(gcr))); : : /* NCH must not be received. */ there is a potential race condition here between the last L1CTL.receive above, and the time you send the NOTIF_CMD_STOP. Another NCH message might be stored in any of the buffers of osmo-bts, the kernel, trxcon, or a TITAN component, and then magically appear below when you no longer expect them. This is the kind of race condition which makes tests fail occasionally and reuslts in ustable test results in jenkins. If there is no confirmation message to the CMD_STOP from the BTS you cannot make assumptions when it will actually arrive and execute. Hence, as a work-around it might be prudent to wait for somehing like 0.5s and then flush any pending L1CTL messages before executing the below code. There might be other solutions, just think about the problem in general and see what you can come up with. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33816 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3727c471663b731117a264f60d2f1ba5fd16928e Gerrit-Change-Number: 33816 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 19 Jul 2023 08:03:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0