July 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ggsn[master]: apn_start: allow kernel GTP with ipv6/ipv4v6
by laforge 18 Jul '23

18 Jul '23

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/33797 ) Change subject: apn_start: allow kernel GTP with ipv6/ipv4v6 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I'm not entirely sure if v4v6 can be supported with the proposed kernel changes pablo implemented. Are you sure about removing that part? -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/33797 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I3df47b6c209f1e2f8254ba139581d6e622c6b35f Gerrit-Change-Number: 33797 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jul 2023 15:16:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: ttcn3-ggsn-test: kernel-gtp: add ipv6
by laforge 18 Jul '23

18 Jul '23

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33802 ) Change subject: ttcn3-ggsn-test: kernel-gtp: add ipv6 ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: Why is this config different than the config we have for userspace? In the userspace config (osmo-ggsn.cfg) we have three separate APNs. "internet" is v4, "inet6" is v6 and "inet46" is "v46". Now as the kernel GTP is catching up in terms of v6 support, the difference between the "userspace gtp config" and the "kernel gtp config" should shrink, not increase. In the end, it should only be the gtpu-mode that changes, right? -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33802 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If3549db216ff89bdb963744bb38015ad68d4cf6a Gerrit-Change-Number: 33802 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jul 2023 15:15:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: kernel_test_prepare: use $DOCKER_ARGS
by laforge 18 Jul '23

18 Jul '23

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33801 ) Change subject: kernel_test_prepare: use $DOCKER_ARGS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33801 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie2500fa1bd9d57e2531463ce93fdd9930ad829d3 Gerrit-Change-Number: 33801 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jul 2023 15:13:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: Cosmetic: ttcn3-ggsn-test: env vars -> README
by osmith 18 Jul '23

18 Jul '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33798 ) Change subject: Cosmetic: ttcn3-ggsn-test: env vars -> README ...................................................................... Cosmetic: ttcn3-ggsn-test: env vars -> README Prepare to add more kernel related env vars. Instead of duplicating the descriptions here, point to the README file. Change-Id: I324f12930c5521e29312b309d6344ed5ffbd2581 --- M ttcn3-ggsn-test/jenkins.sh 1 file changed, 13 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/ttcn3-ggsn-test/jenkins.sh b/ttcn3-ggsn-test/jenkins.sh index 00995bf..3909036 100755 --- a/ttcn3-ggsn-test/jenkins.sh +++ b/ttcn3-ggsn-test/jenkins.sh @@ -1,11 +1,5 @@ #!/bin/sh -# Environment variables: -# * KERNEL_TEST: set to 1 to run osmo-ggsn with the kernel module in QEMU -# * KERNEL_BUILD: set to 1 to build the kernel instead of using a pre-built one -# * KERNEL_REMOTE_NAME: git remote name (to add multiple repos in the same local linux clone) -# * KERNEL_URL: git remote url -# * KERNEL_BRANCH: branch to checkout - +# Environment variables: see "Kernel test" section in README.md . ../jenkins-common.sh KERNEL_TEST="${KERNEL_TEST:-0}" -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33798 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I324f12930c5521e29312b309d6344ed5ffbd2581 Gerrit-Change-Number: 33798 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in docker-playground[master]: scripts/kernel-test: add KERNEL_SKIP_REBUILD
by laforge 18 Jul '23

18 Jul '23

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33799 ) Change subject: scripts/kernel-test: add KERNEL_SKIP_REBUILD ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33799 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iaa401918d7c09ec92ec546071d8961e99a4cbb47 Gerrit-Change-Number: 33799 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jul 2023 15:13:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: Cosmetic: ttcn3-ggsn-test: env vars -> README
by laforge 18 Jul '23

18 Jul '23

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33798 ) Change subject: Cosmetic: ttcn3-ggsn-test: env vars -> README ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33798 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I324f12930c5521e29312b309d6344ed5ffbd2581 Gerrit-Change-Number: 33798 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jul 2023 15:12:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: scripts/kernel-test: add KERNEL_SKIP_SMOKE_TEST
by laforge 18 Jul '23

18 Jul '23

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33800 ) Change subject: scripts/kernel-test: add KERNEL_SKIP_SMOKE_TEST ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33800 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I505b74e8c9b221655a97c5464f6fe4f21204a894 Gerrit-Change-Number: 33800 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jul 2023 15:12:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-dev[master]: ttcn3: build osmo-ggsn with --enable-gtp-linux
by osmith 18 Jul '23

18 Jul '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/33804 ) Change subject: ttcn3: build osmo-ggsn with --enable-gtp-linux ...................................................................... ttcn3: build osmo-ggsn with --enable-gtp-linux Order the opts files alphabetically while at it. Change-Id: I40c197fc0dc2199dd5a7b0d1d820dee1338c1703 --- A gtp_linux.opts M ttcn3/ttcn3.sh 2 files changed, 36 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/04/33804/1 diff --git a/gtp_linux.opts b/gtp_linux.opts new file mode 100644 index 0000000..67f0840 --- /dev/null +++ b/gtp_linux.opts @@ -0,0 +1 @@ +osmo-ggsn --enable-gtp-linux diff --git a/ttcn3/ttcn3.sh b/ttcn3/ttcn3.sh index b87d28d..99500cf 100755 --- a/ttcn3/ttcn3.sh +++ b/ttcn3/ttcn3.sh @@ -81,6 +81,13 @@ esac } +# Dependencies not mentioned in all.deps +get_extra_libraries() { + case "$PROJECT" in + ggsn) echo "libgtpnl" ;; # needed for --enable-gtp-linux + esac +} + # Programs that need to be built get_programs() { case "$PROJECT" in @@ -123,11 +130,12 @@ ./gen_makefile.py \ default.opts \ + gtp_linux.opts \ iu.opts \ - no_systemd.opts \ - no_doxygen.opts \ no_dahdi.opts \ + no_doxygen.opts \ no_optimization.opts \ + no_systemd.opts \ ttcn3/ttcn3.opts \ werror.opts \ --docker-cmd "$docker_cmd" \ @@ -223,6 +231,19 @@ make -C "$testsuite_dir" } +# Use osmo-dev to build libraries not mentioned in all.deps, for example the +# libgtpnl dependency of osmo-ggsn that is only needed with --enable-gtp-linux. +build_extra_libraries() { + local library + local libraries="$(get_extra_libraries)" + + for library in $libraries; do + set -x + make -C "$DIR_MAKE" "$library" + set +x + done +} + # Use osmo-dev to build one Osmocom program and its dependencies build_osmo_programs() { local program @@ -346,6 +367,7 @@ check_dir_testsuite prepare_local_bin prepare_docker_build_container +build_extra_libraries build_osmo_programs prepare_docker_testsuite_container build_testsuite -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/33804 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I40c197fc0dc2199dd5a7b0d1d820dee1338c1703 Gerrit-Change-Number: 33804 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-dev[master]: ttcn3/ttcn3.sh: add osmo-ggsn
by osmith 18 Jul '23

18 Jul '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/33803 ) Change subject: ttcn3/ttcn3.sh: add osmo-ggsn ...................................................................... ttcn3/ttcn3.sh: add osmo-ggsn Order the list alphabetically while at it. Change-Id: Ibdf30a0f87a4cc19c37c6337edff42fd4e56342a --- M ttcn3/ttcn3.sh 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/03/33803/1 diff --git a/ttcn3/ttcn3.sh b/ttcn3/ttcn3.sh index 2a95027..b87d28d 100755 --- a/ttcn3/ttcn3.sh +++ b/ttcn3/ttcn3.sh @@ -40,8 +40,9 @@ local hacks="${DIR_OSMODEV}/src/osmo-ttcn3-hacks" case "$PROJECT" in - bts-*) echo "$hacks/bts" ;; bsc-*) echo "$hacks/bsc" ;; + bts-*) echo "$hacks/bts" ;; + ggsn) echo "$hacks/ggsn_tests" ;; pcu-sns) echo "$hacks/pcu" ;; *) echo "$hacks/$PROJECT" ;; esac -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/33803 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ibdf30a0f87a4cc19c37c6337edff42fd4e56342a Gerrit-Change-Number: 33803 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in docker-playground[master]: Cosmetic: ttcn3-ggsn-test: env vars -> README
by osmith 18 Jul '23

18 Jul '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/33798 ) Change subject: Cosmetic: ttcn3-ggsn-test: env vars -> README ...................................................................... Cosmetic: ttcn3-ggsn-test: env vars -> README Prepare to add more kernel related env vars. Instead of duplicating the descriptions here, point to the README file. Change-Id: I324f12930c5521e29312b309d6344ed5ffbd2581 --- M ttcn3-ggsn-test/jenkins.sh 1 file changed, 13 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/98/33798/1 diff --git a/ttcn3-ggsn-test/jenkins.sh b/ttcn3-ggsn-test/jenkins.sh index 00995bf..3909036 100755 --- a/ttcn3-ggsn-test/jenkins.sh +++ b/ttcn3-ggsn-test/jenkins.sh @@ -1,11 +1,5 @@ #!/bin/sh -# Environment variables: -# * KERNEL_TEST: set to 1 to run osmo-ggsn with the kernel module in QEMU -# * KERNEL_BUILD: set to 1 to build the kernel instead of using a pre-built one -# * KERNEL_REMOTE_NAME: git remote name (to add multiple repos in the same local linux clone) -# * KERNEL_URL: git remote url -# * KERNEL_BRANCH: branch to checkout - +# Environment variables: see "Kernel test" section in README.md . ../jenkins-common.sh KERNEL_TEST="${KERNEL_TEST:-0}" -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33798 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I324f12930c5521e29312b309d6344ed5ffbd2581 Gerrit-Change-Number: 33798 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0