July 2023 - gerrit-log - lists.osmocom.org

[L] Change in docker-playground[master]: hnbgw: adjust cfg for cnpool tests
by pespin 19 Jul '23

19 Jul '23

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33668 ) Change subject: hnbgw: adjust cfg for cnpool tests ...................................................................... Patch Set 5: (1 comment) Patchset: PS3: > i wish i didn't need two sets -- the reason is, osmo-hnbgw master has config options that osmo-hnbgw […] In those cases what we usually do is using "sed" in docker-playground.git/*/jenkins.sh to modify the file on the fly if image_suffix is master or latest. Can this be done here? Having to maintaing several copies of cfg files is not really nice. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33668 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I94aa0b2adfc48b98cb4b1efe595c2432fc603d6c Gerrit-Change-Number: 33668 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Jul 2023 14:15:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: Fixed `mnc` encoding
by Farhad H. P. Shirvan 19 Jul '23

19 Jul '23

Farhad H. P. Shirvan has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/33835 ) Change subject: Fixed `mnc` encoding ...................................................................... Fixed `mnc` encoding According to 3GPP TS 24.008 section 10.5.5.36 PLMN identity of the CN operator Change-Id: I400435abfa8b67da886fc39c801e1abba39725bf --- M pySim/utils.py 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/35/33835/1 diff --git a/pySim/utils.py b/pySim/utils.py index c25560c..735468e 100644 --- a/pySim/utils.py +++ b/pySim/utils.py @@ -413,7 +413,7 @@ if len(mnc) == 0: mnc = "FFF" elif len(mnc) == 1: - mnc = "F0" + mnc + mnc = "0" + mnc + "F" elif len(mnc) == 2: mnc += "F" -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33835 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I400435abfa8b67da886fc39c801e1abba39725bf Gerrit-Change-Number: 33835 Gerrit-PatchSet: 1 Gerrit-Owner: Farhad H. P. Shirvan <farhad.21.7(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-bsc[master]: configure: add --enable-meas-udp2db/pcap2db/vis
by pespin 19 Jul '23

19 Jul '23

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33681 ) Change subject: configure: add --enable-meas-udp2db/pcap2db/vis ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33681 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8b3d5efb769437a5d3036e1e627b8d477275d93e Gerrit-Change-Number: 33681 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Jul 2023 14:13:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-remsim[master]: bankd: Don't use 127.0.0.1 as default IP address for the server
by pespin 19 Jul '23

19 Jul '23

Attention is currently required from: mschramm, laforge, roh. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/33813 ) Change subject: bankd: Don't use 127.0.0.1 as default IP address for the server ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/33813 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I3deb05e31cdf35232cf9a118d5a5fcdb5d0ab601 Gerrit-Change-Number: 33813 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: mschramm <mschramm(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: roh <jsteiger(a)sysmocom.de> Gerrit-Attention: mschramm <mschramm(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: roh <jsteiger(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Jul 2023 14:10:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: open5gs-master: use DISTRO variable
by pespin 19 Jul '23

19 Jul '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33805 ) Change subject: open5gs-master: use DISTRO variable ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33805 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ia392de80ee1f0844563f08a6dc775678ef6b263f Gerrit-Change-Number: 33805 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Jul 2023 14:07:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-uecups[master]: daemon_vty: avoid null-dereference in argc < 0 case
by pespin 19 Jul '23

19 Jul '23

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-uecups/+/33788 ) Change subject: daemon_vty: avoid null-dereference in argc < 0 case ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-uecups/+/33788/comment/af376754_0a12619d PS1, Line 10: which means in theory argc could be negative and the second clause > I'm not saying it is a realistic scenario. I'm saying it might happen theoretically. […] Then I wonder why argc is a signed integer :D -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/33788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I4149b0b191a34168ba6649338d3cdf6c6af6cfe7 Gerrit-Change-Number: 33788 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 19 Jul 2023 14:05:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: kernel_test_prepare: use $DOCKER_ARGS
by pespin 19 Jul '23

19 Jul '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33801 ) Change subject: kernel_test_prepare: use $DOCKER_ARGS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33801 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie2500fa1bd9d57e2531463ce93fdd9930ad829d3 Gerrit-Change-Number: 33801 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Jul 2023 13:59:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: scripts/kernel-test: add KERNEL_SKIP_SMOKE_TEST
by pespin 19 Jul '23

19 Jul '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33800 ) Change subject: scripts/kernel-test: add KERNEL_SKIP_SMOKE_TEST ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33800 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I505b74e8c9b221655a97c5464f6fe4f21204a894 Gerrit-Change-Number: 33800 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Jul 2023 13:59:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-dev[master]: ttcn3/ttcn3.sh: add osmo-ggsn
by pespin 19 Jul '23

19 Jul '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/33803 ) Change subject: ttcn3/ttcn3.sh: add osmo-ggsn ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/33803 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ibdf30a0f87a4cc19c37c6337edff42fd4e56342a Gerrit-Change-Number: 33803 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Jul 2023 13:57:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-dev[master]: ttcn3: build osmo-ggsn with --enable-gtp-linux
by pespin 19 Jul '23

19 Jul '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/33804 ) Change subject: ttcn3: build osmo-ggsn with --enable-gtp-linux ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/33804 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I40c197fc0dc2199dd5a7b0d1d820dee1338c1703 Gerrit-Change-Number: 33804 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Jul 2023 13:56:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0