Attention is currently required from: neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33668 )
Change subject: hnbgw: adjust cfg for cnpool tests
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS3:
> i wish i didn't need two sets -- the reason is, osmo-hnbgw master has config options that osmo-hnbgw […]
In those cases what we usually do is using "sed" in docker-playground.git/*/jenkins.sh to modify the file on the fly if image_suffix is master or latest. Can this be done here? Having to maintaing several copies of cfg files is not really nice.
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33668
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I94aa0b2adfc48b98cb4b1efe595c2432fc603d6c
Gerrit-Change-Number: 33668
Gerrit-PatchSet: 5
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 19 Jul 2023 14:15:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-uecups/+/33788 )
Change subject: daemon_vty: avoid null-dereference in argc < 0 case
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-uecups/+/33788/comment/af376754_0a12619d
PS1, Line 10: which means in theory argc could be negative and the second clause
> I'm not saying it is a realistic scenario. I'm saying it might happen theoretically. […]
Then I wonder why argc is a signed integer :D
--
To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/33788
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-uecups
Gerrit-Branch: master
Gerrit-Change-Id: I4149b0b191a34168ba6649338d3cdf6c6af6cfe7
Gerrit-Change-Number: 33788
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 19 Jul 2023 14:05:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment