July 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: BTS_Test_ASCI: Add first ASCI test to check NCH support
by jolly 19 Jul '23

19 Jul '23

Attention is currently required from: laforge, fixeria. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33816 ) Change subject: BTS_Test_ASCI: Add first ASCI test to check NCH support ...................................................................... Patch Set 5: (2 comments) Patchset: PS4: > Since you're adding a new testcase module, please update `bts/BTS_Tests.cfg`: add `BTS_Tests_ASCI. […] Done File bts/BTS_Tests_ASCI.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33816/comment/84226f86_e08f… PS4, Line 109: /* Flush pending messages and be sure that the sending of notifications has stopped. */ > Alternatively, you could do it this way: […] f_sleep.. but it work, thanx. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33816 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3727c471663b731117a264f60d2f1ba5fd16928e Gerrit-Change-Number: 33816 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Jul 2023 13:32:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: BTS_Test_ASCI: Add first ASCI test to check NCH support
by jolly 19 Jul '23

19 Jul '23

Attention is currently required from: jolly, laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33816 to look at the new patch set (#5). Change subject: BTS_Test_ASCI: Add first ASCI test to check NCH support ...................................................................... BTS_Test_ASCI: Add first ASCI test to check NCH support Send Notification command to start and stop notifying an ASCI call. When it starts, it is expected that NCH is received. Also it is expected that NCH is received again. When it stops, it is expected that NCH is not received anymore. Change-Id: I3727c471663b731117a264f60d2f1ba5fd16928e Related: OS#4851 --- M bts/BTS_Tests.cfg M bts/BTS_Tests.ttcn A bts/BTS_Tests_ASCI.ttcn 3 files changed, 152 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/16/33816/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33816 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3727c471663b731117a264f60d2f1ba5fd16928e Gerrit-Change-Number: 33816 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-ttcn3-hacks[master]: BTS_Test_ASCI: Add Listener detection test
by jolly 19 Jul '23

19 Jul '23

Attention is currently required from: jolly. Hello Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33820 to look at the new patch set (#5). Change subject: BTS_Test_ASCI: Add Listener detection test ...................................................................... BTS_Test_ASCI: Add Listener detection test The MS sends UPLINK ACCESS. The BTS send RSL Listener DET message. Another MS send UPLINK ACCESS. The BTS does not send another RSL Listener DET message. Change-Id: I544f492a32751d17f998a2143081c3763ba1dd29 Related: OS#4851 --- M bts/BTS_Tests_ASCI.ttcn 1 file changed, 93 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/20/33820/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33820 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I544f492a32751d17f998a2143081c3763ba1dd29 Gerrit-Change-Number: 33820 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-ttcn3-hacks[master]: BTS_Test_ASCI: Add Talker detect and link fail test
by jolly 19 Jul '23

19 Jul '23

Attention is currently required from: jolly. Hello Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33818 to look at the new patch set (#5). Change subject: BTS_Test_ASCI: Add Talker detect and link fail test ...................................................................... BTS_Test_ASCI: Add Talker detect and link fail test A VGCS channel is activated. The BSC sends UPLINK FREE message. The MS sends RACH on VGCS channel. The MS receives VGCS UPLINK GRAND, but does not respond to it. It is expeced that the BSC receivce RSL CONN FAIL. Change-Id: I3b292f6a5f47298195bd942a5ca73d9d63f921b5 Related: OS#4851 --- M bts/BTS_Tests_ASCI.ttcn 1 file changed, 115 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/18/33818/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33818 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3b292f6a5f47298195bd942a5ca73d9d63f921b5 Gerrit-Change-Number: 33818 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 0

[S] Change in pysim[master]: README.md: add tshark to required debian packages
by dexter 19 Jul '23

19 Jul '23

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/33834 ) Change subject: README.md: add tshark to required debian packages ...................................................................... README.md: add tshark to required debian packages pySim-trace requires tshark to be installed. Let's mention the package in README.md Change-Id: Ibe5b3cc3647e00307229efcb1c437492488d6fba --- M README.md 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/34/33834/1 diff --git a/README.md b/README.md index 2a79fb3..9d6fb04 100644 --- a/README.md +++ b/README.md @@ -96,7 +96,8 @@ python3-setuptools \ python3-pycryptodome \ python3-pyscard \ - python3-pip + python3-pip \ + tshark pip3 install --user -r requirements.txt ``` -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33834 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibe5b3cc3647e00307229efcb1c437492488d6fba Gerrit-Change-Number: 33834 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bts[master]: ASCI: Retrieve NCH position from System Information 1
by fixeria 19 Jul '23

19 Jul '23

Attention is currently required from: osmith, jolly, pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33296 ) Change subject: ASCI: Retrieve NCH position from System Information 1 ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33296 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I799a27179d478d4ff577d8bc47ae524834851e85 Gerrit-Change-Number: 33296 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Jul 2023 13:05:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmo-bts[master]: ASCI: VGCS/VBS RACH -> RSL TALKER/LISTENER DETECT
by fixeria 19 Jul '23

19 Jul '23

Attention is currently required from: osmith, jolly, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33292 ) Change subject: ASCI: VGCS/VBS RACH -> RSL TALKER/LISTENER DETECT ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33292 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1bd07ab6802341b09a06e89df356665ffaf6d2bf Gerrit-Change-Number: 33292 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Jul 2023 13:04:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmo-bts[master]: ASCI: VGCS/VBS RACH -> RSL TALKER/LISTENER DETECT
by jolly 19 Jul '23

19 Jul '23

Attention is currently required from: osmith, fixeria, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33292 ) Change subject: ASCI: VGCS/VBS RACH -> RSL TALKER/LISTENER DETECT ...................................................................... Patch Set 7: (3 comments) File src/common/asci.c: https://gerrit.osmocom.org/c/osmo-bts/+/33292/comment/ccf74bcd_651d5aa9 PS6, Line 79: is in not active > This looks weird, maybe just "is not active"? Done https://gerrit.osmocom.org/c/osmo-bts/+/33292/comment/1be5c0b6_5e98b6b0 PS6, Line 154: v > c Done File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/33292/comment/cae8919b_fc906312 PS6, Line 1988: handover > Change to "DCCH"? The function actually expects a channel type name, not type of access. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33292 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1bd07ab6802341b09a06e89df356665ffaf6d2bf Gerrit-Change-Number: 33292 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Jul 2023 12:59:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: ASCI: Retrieve NCH position from System Information 1
by jolly 19 Jul '23

19 Jul '23

Attention is currently required from: osmith, fixeria, pespin, dexter. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33296 ) Change subject: ASCI: Retrieve NCH position from System Information 1 ...................................................................... Patch Set 7: (2 comments) File src/common/sysinfo.c: https://gerrit.osmocom.org/c/osmo-bts/+/33296/comment/d7e2b2eb_eda4740d PS6, Line 177: /* H <NCH Position : bit (5)> */ > This is CSN. […] Done https://gerrit.osmocom.org/c/osmo-bts/+/33296/comment/58314759_bee0df0d PS6, Line 180: return -EINVAL; > maybe ENOTSUP? I think also important would be a comment to explain that this is not an error. An error message makes no sense, because having no NCH support is not an error. I changed it to -ENOTSUP. This makes more sense. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33296 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I799a27179d478d4ff577d8bc47ae524834851e85 Gerrit-Change-Number: 33296 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Jul 2023 12:59:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: ASCI: Add Notification CHannel (NCH) support
by jolly 19 Jul '23

19 Jul '23

Attention is currently required from: fixeria, pespin, dexter. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33297 ) Change subject: ASCI: Add Notification CHannel (NCH) support ...................................................................... Patch Set 7: (1 comment) File src/common/bts.c: https://gerrit.osmocom.org/c/osmo-bts/+/33297/comment/c377ddd0_50812d2f PS6, Line 726: int is_nch_res, int is_ag_res > Do we expect/permit any combinations of these two flags? […] If is_nch_res is set, the message to be sent is an NCH message on NCH. If not, is_ag_res indicates if the channel is PCH or AGCH. If there is no paging, PCH can be used as AGCH, if there is an AGCH message in the queue. In case of is_nch_res beeing, the function must return after getting the message with nch_gen_msg(). I fixed that. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33297 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I82fdaba3faaced76267a99ae14a5458a1b41fdaa Gerrit-Change-Number: 33297 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Jul 2023 12:59:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0