July 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmocom-bb[master]: trxcon/l1sched: emit DATA.cnf early (on bid=0)
by fixeria 20 Jul '23

20 Jul '23

Attention is currently required from: osmith, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33749 ) Change subject: trxcon/l1sched: emit DATA.cnf early (on bid=0) ...................................................................... Patch Set 2: (1 comment) File src/host/trxcon/src/sched_lchan_tchf.c: https://gerrit.osmocom.org/c/osmocom-bb/+/33749/comment/1a1bfa38_45a00954 PS2, Line 296: l1sched_lchan_emit_data_cnf(lchan, msg, br->fn); > No, only for `bid=0`. If `bid>0`, we jump to `send_burst` in the beginning (see above). Done -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33749 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie09a24cd950a93edd871a9fbc5b47ec96c24cceb Gerrit-Change-Number: 33749 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Jul 2023 07:11:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: requirements: add pyshark to requirements lists
by fixeria 19 Jul '23

19 Jul '23

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33831 ) Change subject: requirements: add pyshark to requirements lists ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I am starting to worry about the amount of dependencies we require. `pySim-trace` is a nice tool, but IMO in the most cases a user just needs a tool to program some files on a (U)SIM card, and for that [s]he needs to install a zoo of packages: `termcolor`, `colorlog`, now also `pyshark`, which additionally depends on `tshark`/`wireshark`... Can we somehow make it an optional dependency? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33831 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I885c7210aac3774a5f1f5201903ad2bff94c3120 Gerrit-Change-Number: 33831 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Jul 2023 18:06:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in libosmo-gprs[master]: sm: Handle GMMSM-MODIFY.ind primitive
by pespin 19 Jul '23

19 Jul '23

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33811 to look at the new patch set (#5). Change subject: sm: Handle GMMSM-MODIFY.ind primitive ...................................................................... sm: Handle GMMSM-MODIFY.ind primitive Change-Id: Ic765b7a565cac4abcf34d8c6868e103971d17822 --- M include/osmocom/gprs/sm/sm_private.h M src/sm/sm.c M src/sm/sm_prim.c 3 files changed, 153 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/11/33811/5 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33811 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ic765b7a565cac4abcf34d8c6868e103971d17822 Gerrit-Change-Number: 33811 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in libosmo-gprs[master]: sm: Handle GMMSM-MODIFY.ind primitive
by pespin 19 Jul '23

19 Jul '23

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33811 to look at the new patch set (#4). Change subject: sm: Handle GMMSM-MODIFY.ind primitive ...................................................................... sm: Handle GMMSM-MODIFY.ind primitive Change-Id: Ic765b7a565cac4abcf34d8c6868e103971d17822 --- M include/osmocom/gprs/sm/sm_private.h M src/sm/sm.c M src/sm/sm_prim.c 3 files changed, 154 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/11/33811/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33811 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ic765b7a565cac4abcf34d8c6868e103971d17822 Gerrit-Change-Number: 33811 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-msc[master]: ASCI: Check return code of osmo_mobile_identity_decode()
by pespin 19 Jul '23

19 Jul '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33822 ) Change subject: ASCI: Check return code of osmo_mobile_identity_decode() ...................................................................... ASCI: Check return code of osmo_mobile_identity_decode() Fixes: CID#322146 Change-Id: I15a6cf97a901cbb6c99ec2269051a351b504d338 --- M src/libmsc/ran_msg_a.c 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libmsc/ran_msg_a.c b/src/libmsc/ran_msg_a.c index 2533045..d2ab09f 100644 --- a/src/libmsc/ran_msg_a.c +++ b/src/libmsc/ran_msg_a.c @@ -976,7 +976,8 @@ /* Mobile Identity, 3.2.2.41 */ if (ie_mi) { - if (osmo_mobile_identity_decode(&r->mi, ie_mi->val, ie_mi->len, false)) { + rc = osmo_mobile_identity_decode(&r->mi, ie_mi->val, ie_mi->len, false); + if (rc < 0) { LOG_RAN_A_DEC_MSG(LOGL_ERROR, "Decoding Mobile Identity gave rc=%d\n", rc); return -EINVAL; } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33822 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I15a6cf97a901cbb6c99ec2269051a351b504d338 Gerrit-Change-Number: 33822 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-msc[master]: ASCI: Remove check for trans->msc_a to be set in _assign_complete()
by pespin 19 Jul '23

19 Jul '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33824 ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: ASCI: Remove check for trans->msc_a to be set in _assign_complete() ...................................................................... ASCI: Remove check for trans->msc_a to be set in _assign_complete() trans->msc_a is always set when ASSIGNMENT COMPLETE is received. Fixes: CID#322144 Change-Id: I0fe16e59959b48d08d95aefa6d4415f78dcf1eb4 --- M src/libmsc/msc_vgcs.c 1 file changed, 15 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libmsc/msc_vgcs.c b/src/libmsc/msc_vgcs.c index 1af9aae..52cc25d 100644 --- a/src/libmsc/msc_vgcs.c +++ b/src/libmsc/msc_vgcs.c @@ -967,13 +967,12 @@ { uint16_t cell_id; + OSMO_ASSERT(trans->msc_a); + /* Change state. */ osmo_fsm_inst_state_chg(trans->gcc.fi, VGCS_GCC_ST_N2_CALL_ACTIVE, 0, 0); /* Get cell ID. */ - if (trans->msc_a) - cell_id = trans->msc_a->via_cell.cell_identity; - else - LOG_GCC(trans, LOGL_ERROR, "Missing msc_a, please fix!\n"); + cell_id = trans->msc_a->via_cell.cell_identity; /* Releasing dedicated channel. */ release_msc_a(trans); /* Send CONNECT to the calling subscriber. */ -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33824 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I0fe16e59959b48d08d95aefa6d4415f78dcf1eb4 Gerrit-Change-Number: 33824 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in libosmo-gprs[master]: sm: Handle GMMSM-MODIFY.ind primitive
by pespin 19 Jul '23

19 Jul '23

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33811 to look at the new patch set (#3). Change subject: sm: Handle GMMSM-MODIFY.ind primitive ...................................................................... sm: Handle GMMSM-MODIFY.ind primitive Change-Id: Ic765b7a565cac4abcf34d8c6868e103971d17822 --- M include/osmocom/gprs/sm/sm_private.h M src/sm/sm.c M src/sm/sm_prim.c 3 files changed, 154 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/11/33811/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33811 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ic765b7a565cac4abcf34d8c6868e103971d17822 Gerrit-Change-Number: 33811 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in libosmo-gprs[master]: sndcp: Answer SNSM-DEACTIVATE.ind with .resp
by pespin 19 Jul '23

19 Jul '23

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33839 ) Change subject: sndcp: Answer SNSM-DEACTIVATE.ind with .resp ...................................................................... sndcp: Answer SNSM-DEACTIVATE.ind with .resp Change-Id: I8ddebf93d3150cc952f9e5fc5d6f3cfc99e912a5 --- M include/osmocom/gprs/sndcp/sndcp_private.h M src/sndcp/sndcp_prim.c M tests/sndcp/sndcp_prim_test.c M tests/sndcp/sndcp_prim_test.ok 4 files changed, 31 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/39/33839/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33839 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I8ddebf93d3150cc952f9e5fc5d6f3cfc99e912a5 Gerrit-Change-Number: 33839 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[M] Change in libosmo-gprs[master]: gmm: Introduce GMMSM-Modify.ind primitive
by pespin 19 Jul '23

19 Jul '23

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33810 to look at the new patch set (#2). Change subject: gmm: Introduce GMMSM-Modify.ind primitive ...................................................................... gmm: Introduce GMMSM-Modify.ind primitive TS 24.007 and TS 24.008 seem to lack providing an explicit way to pass information between GMM and SM (GMMSM interface) when a RAU process happens in GMM (rx RAU Accept). This lack of primitive can easily be spotted by looking at TS 24.007 Appending C.15, or even better, at the 3rd page of "C.16(cont’d)" around the "STOP Trams" timer, where the info is magically available in SM when being received at GMM. Change-Id: I81e207d44d88f18f0ee13fb413827606a6f830bc --- M include/osmocom/gprs/gmm/gmm_prim.h M include/osmocom/gprs/gmm/gmm_private.h M src/gmm/gmm.c M src/gmm/gmm_prim.c M tests/gmm/gmm_prim_test.c M tests/gmm/gmm_prim_test.err M tests/gmm/gmm_prim_test.ok 7 files changed, 144 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/10/33810/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33810 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I81e207d44d88f18f0ee13fb413827606a6f830bc Gerrit-Change-Number: 33810 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in libosmo-gprs[master]: gmm: Document spec ref regarding Receive N-PDU Numbers IE in RAU Compl
by pespin 19 Jul '23

19 Jul '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33838 ) Change subject: gmm: Document spec ref regarding Receive N-PDU Numbers IE in RAU Compl ...................................................................... gmm: Document spec ref regarding Receive N-PDU Numbers IE in RAU Compl Change-Id: I8b4c5a6c4c4da3648160aa32f7586c74942c7734 --- M src/gmm/gmm_pdu.c 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/38/33838/1 diff --git a/src/gmm/gmm_pdu.c b/src/gmm/gmm_pdu.c index 27c06fd..1c3cc8c 100644 --- a/src/gmm/gmm_pdu.c +++ b/src/gmm/gmm_pdu.c @@ -515,6 +515,11 @@ gh->proto_discr = GSM48_PDISC_MM_GPRS; gh->msg_type = GSM48_MT_GMM_RA_UPD_COMPL; + /* TODO: 3GPP TS 24.008 4.7.5.1.3 "If Receive N-PDU Numbers were + * included, the Receive N-PDU Numbers values valid in the MS, shall be included in + * the ROUTING AREA UPDATE COMPLETE message." + */ + /* TODO: Add optional IEs */ return 0; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33838 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I8b4c5a6c4c4da3648160aa32f7586c74942c7734 Gerrit-Change-Number: 33838 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0