July 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: GPRS_Components: use more suitable SAPI for DL TBF assignment
by dexter 20 Jul '23

20 Jul '23

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33794 ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: GPRS_Components: use more suitable SAPI for DL TBF assignment ...................................................................... GPRS_Components: use more suitable SAPI for DL TBF assignment The function that assigns the downlink TBF f_ms_exp_dl_tbf_ass_ccch() uses SAPI PCU_IF_SAPI_AGCH as default but actually downlink TBFs are assigned via the PCH. This means we have to put PCU_IF_SAPI_PCH into the parameter list on every function call, so it makes sense to change the default to PCU_IF_SAPI_PCH and omit the SAPI when calling the function Related: OS#5927 Change-Id: I49c59bad0162cb303669f6108201f154918b1db3 --- M pcu/GPRS_Components.ttcn M pcu/PCU_Tests.ttcn 2 files changed, 47 insertions(+), 31 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn index 59c99d8..64a39dd 100644 --- a/pcu/GPRS_Components.ttcn +++ b/pcu/GPRS_Components.ttcn @@ -628,7 +628,7 @@ ms.ul_tbf := f_ultbf_new_from_rr_imm_ass(rr_imm_ass); } -function f_ms_exp_dl_tbf_ass_ccch(inout GprsMS ms, template PCUIF_Sapi sapi := PCU_IF_SAPI_AGCH, +function f_ms_exp_dl_tbf_ass_ccch(inout GprsMS ms, template PCUIF_Sapi sapi := PCU_IF_SAPI_PCH, template GsmRrMessage t_imm_ass := tr_IMM_TBF_ASS(true, ?, ?), template (present) TsTrxBtsNum nr := tr_TsTrxBtsNum) runs on MS_BTS_IFACE_CT { diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 76926ae..2598e7b 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -447,7 +447,7 @@ /* Now SGSN sends some DL data, PCU will page on CCCH (PCH) */ BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data)); - f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + f_ms_exp_dl_tbf_ass_ccch(ms); /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); @@ -480,7 +480,7 @@ /* New data arrives, PCU should page the MS since no TBF active exists: */ /* Send some more data, it will never reach the MS */ BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data)); - f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + f_ms_exp_dl_tbf_ass_ccch(ms); f_shutdown(__BFILE__, __LINE__, final := true); } @@ -593,7 +593,7 @@ /* SGSN sends some DL data, PCU will initiate Packet Downlink * Assignment on CCCH (PCH). We don't care about the payload. */ BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, f_rnd_octstring(10))); - f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + f_ms_exp_dl_tbf_ass_ccch(ms); /* Make sure that Timing Advance is 0 (the actual value is not known yet). * As per 3GPP S 44.018, section 3.5.3.1.2, the network *shall* initiate @@ -1060,7 +1060,7 @@ /* SGSN sends some DL data, PCU will page on CCCH (PCH) */ BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data)); - f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + f_ms_exp_dl_tbf_ass_ccch(ms); /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); @@ -1103,7 +1103,7 @@ /* SGSN sends some DL data, PCU will page on CCCH (PCH) */ BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data, ms_racap)); - f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + f_ms_exp_dl_tbf_ass_ccch(ms); /* Wait timer X2002 and DL block is available after CCCH IMM ASS */ f_sleep(X2002); @@ -1333,7 +1333,7 @@ /* SGSN sends some DL data, PCU will page on CCCH (PCH) */ BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data, bssgp_ms_racap_egprs_def)); - f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + f_ms_exp_dl_tbf_ass_ccch(ms); /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); @@ -1727,7 +1727,7 @@ /* SGSN sends some DL data, PCU will page on CCCH (PCH) */ BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data1)); - f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + f_ms_exp_dl_tbf_ass_ccch(ms); /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); @@ -1786,7 +1786,7 @@ /* The TBF should be freed now, so new data should trigger an Assignment: */ BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data2)); - f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + f_ms_exp_dl_tbf_ass_ccch(ms); /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); @@ -1828,7 +1828,7 @@ /* SGSN sends some DL data, PCU will page on CCCH (PCH) */ BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data1)); - f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + f_ms_exp_dl_tbf_ass_ccch(ms); /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); @@ -1861,7 +1861,7 @@ /* The TBF should be freed now, so new data should trigger an Assignment: */ BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data2)); - f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + f_ms_exp_dl_tbf_ass_ccch(ms); /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); @@ -1907,7 +1907,7 @@ /* SGSN sends some DL data, PCU will page on CCCH (PCH) */ BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data)); - f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + f_ms_exp_dl_tbf_ass_ccch(ms); /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); @@ -1981,7 +1981,7 @@ /* SGSN sends some DL data, PCU will page on CCCH (PCH) */ BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data1)); - f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + f_ms_exp_dl_tbf_ass_ccch(ms); /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); @@ -2054,7 +2054,7 @@ /* after T_3195 timeout, TBF is released */ BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data2)); - f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + f_ms_exp_dl_tbf_ass_ccch(ms); /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); @@ -2119,7 +2119,7 @@ /* SGSN sends some DL data, PCU will page on CCCH (PCH) */ BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data)); - f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + f_ms_exp_dl_tbf_ass_ccch(ms); /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); @@ -2435,7 +2435,7 @@ /* Now SGSN sends some DL data, PCU will page on CCCH (PCH) */ BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data)); - f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + f_ms_exp_dl_tbf_ass_ccch(ms); /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); @@ -2625,7 +2625,7 @@ /* SGSN sends some DL data, PCU will page on CCCH (PCH) */ BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data, ms_racap)); - f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + f_ms_exp_dl_tbf_ass_ccch(ms); /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); @@ -2780,7 +2780,7 @@ /* SGSN sends some DL data, PCU will page on CCCH (PCH) */ BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data)); - f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + f_ms_exp_dl_tbf_ass_ccch(ms); /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); @@ -2789,7 +2789,7 @@ /* Now we don't ack the dl block (emulate MS failed receiveing IMM ASS * or GPRS DL, or DL ACK was lost for some reason). As a result, PCU * should retrigger IMM ASS + GPRS DL procedure after poll timeout. */ - f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + f_ms_exp_dl_tbf_ass_ccch(ms); /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); @@ -2831,7 +2831,7 @@ /* SGSN sends some DL data, PCU will page on CCCH (PCH) */ BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data)); - f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + f_ms_exp_dl_tbf_ass_ccch(ms); /* Wait timer X2002 and DL block is available after CCCH IMM ASS */ f_sleep(X2002); @@ -3028,7 +3028,7 @@ /* SGSN sends some DL data, PCU will page on CCCH (PCH) */ BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data1)); - f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + f_ms_exp_dl_tbf_ass_ccch(ms); /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); @@ -3047,7 +3047,7 @@ } /* PCU starts whole process again */ - f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + f_ms_exp_dl_tbf_ass_ccch(ms); /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); @@ -3132,7 +3132,7 @@ BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data_sapi7)); BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data_sapi8)); BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data_sapi1)); - f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + f_ms_exp_dl_tbf_ass_ccch(ms); /* Wait timer X2002 and DL block is available after CCCH IMM ASS */ f_sleep(X2002); @@ -3574,7 +3574,7 @@ /* SGSN sends some DL data, PCU will page on CCCH (PCH) */ BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data, racap_tmpl)); - f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + f_ms_exp_dl_tbf_ass_ccch(ms); /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); @@ -3853,7 +3853,7 @@ /* Now SGSN sends some DL data, PCU will page on CCCH (PCH) */ BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data, imsi := ts_BSSGP_IMSI(ms.imsi))); - f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + f_ms_exp_dl_tbf_ass_ccch(ms); /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); @@ -3945,7 +3945,7 @@ /* SGSN sends some DL data, PCU will page on CCCH (PCH) */ BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data, ms_racap)); - f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + f_ms_exp_dl_tbf_ass_ccch(ms); /* Wait timer X2002 and DL block is available after CCCH IMM ASS */ f_sleep(X2002); @@ -4040,7 +4040,7 @@ /* UL ACK/NACK sets poll+rrbp requesting PACKET CONTROL ACK */ f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), sched_fn); - f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + f_ms_exp_dl_tbf_ass_ccch(ms); /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); f_rx_rlcmac_dl_block_exp_data(dl_block, dl_fn, data, 0); @@ -4107,7 +4107,7 @@ /* UL ACK/NACK sets poll+rrbp requesting PACKET CONTROL ACK */ f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), sched_fn); - f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + f_ms_exp_dl_tbf_ass_ccch(ms); /* Now the PCU is waiting for the MS to move to PDCH in order to send data to it (timer X2002). * The MS decides it want to send new Ul TBF so it send RACH req to ask for it: */ @@ -4187,7 +4187,7 @@ /* UL ACK/NACK sets poll+rrbp requesting PACKET CONTROL ACK */ f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), sched_fn); - f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + f_ms_exp_dl_tbf_ass_ccch(ms); /* Now the PCU is waiting for the MS to move to PDCH in order to send data to it (timer X2002). * The MS decides it want to send new Ul TBF so it send RACH req to ask for it: */ @@ -4652,7 +4652,7 @@ /* SGSN sends some DL data, PCU will page on CCCH (PCH) */ BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, f_rnd_octstring(12))); - f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + f_ms_exp_dl_tbf_ass_ccch(ms); f_TC_pcuif_fh_check_imm_ass(valueof(info_ind), ms.dl_tbf.rr_imm_ass); f_shutdown(__BFILE__, __LINE__, final := true); @@ -7137,7 +7137,7 @@ } else { BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data, bssgp_ms_racap_gprs)); } - f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + f_ms_exp_dl_tbf_ass_ccch(ms); /* Wait timer X2002 and DL block is available after CCCH IMM ASS */ f_sleep(X2002); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33794 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I49c59bad0162cb303669f6108201f154918b1db3 Gerrit-Change-Number: 33794 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: PCUIF_Types: add decoder for PCUIF_pch_dt
by dexter 20 Jul '23

20 Jul '23

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33793 ) Change subject: PCUIF_Types: add decoder for PCUIF_pch_dt ...................................................................... PCUIF_Types: add decoder for PCUIF_pch_dt An encoder function enc_PCUIF_pch_dt exists, but we do not have a decoder yet. Related: OS#5927 Change-Id: I535aa45a676b87a8912e99bdb802bf29a23f1c89 --- M library/PCUIF_Types.ttcn 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved diff --git a/library/PCUIF_Types.ttcn b/library/PCUIF_Types.ttcn index 65d0c41..94056b9 100644 --- a/library/PCUIF_Types.ttcn +++ b/library/PCUIF_Types.ttcn @@ -326,6 +326,8 @@ external function enc_PCUIF_pch_dt(in PCUIF_pch_dt pdu) return octetstring with { extension "prototype(convert) encode(RAW)" }; +external function dec_PCUIF_pch_dt(in octetstring stream) return PCUIF_pch_dt + with { extension "prototype(convert) decode(RAW)" }; type union PCUIF_MsgUnion { PCUIF_data data_req, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33793 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I535aa45a676b87a8912e99bdb802bf29a23f1c89 Gerrit-Change-Number: 33793 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: PCUIF_Types: add decoder for PCUIF_pch_dt
by dexter 20 Jul '23

20 Jul '23

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33793 ) Change subject: PCUIF_Types: add decoder for PCUIF_pch_dt ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS3: re-adding +2, just fixed a typo in the commit message -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33793 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I535aa45a676b87a8912e99bdb802bf29a23f1c89 Gerrit-Change-Number: 33793 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Jul 2023 08:44:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: PCUIF_Components: add compatibility for PCU_IF_SAPI_PCH_DT
by dexter 20 Jul '23

20 Jul '23

Attention is currently required from: dexter. Hello Jenkins Builder, laforge, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33795 to look at the new patch set (#3). Change subject: PCUIF_Components: add compatibility for PCU_IF_SAPI_PCH_DT ...................................................................... PCUIF_Components: add compatibility for PCU_IF_SAPI_PCH_DT When we receive a PCUIF_DATA_REQ, f_BTS_CT_handler will mangle the incoming message for us. The resulting BTS_CCCH_Block that is sent up to the component not only contains the PCUIF message, but will also have the already parsed MAC block attached. This currently only works for PCU_IF_SAPI_PCH, but not for PCU_IF_SAPI_PCH_DT. Let's add compatibility for PCU_IF_SAPI_PCH_DT. Related: OS#5927 Change-Id: Ibaa6d170ef0f1f61b708a872a3c2364585063503 --- M pcu/PCUIF_Components.ttcn 1 file changed, 39 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/95/33795/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33795 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibaa6d170ef0f1f61b708a872a3c2364585063503 Gerrit-Change-Number: 33795 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: PCUIF_Types: add decoder for PCUIF_pch_dt
by dexter 20 Jul '23

20 Jul '23

Attention is currently required from: dexter. Hello Jenkins Builder, laforge, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33793 to look at the new patch set (#3). Change subject: PCUIF_Types: add decoder for PCUIF_pch_dt ...................................................................... PCUIF_Types: add decoder for PCUIF_pch_dt An encoder function enc_PCUIF_pch_dt exists, but we do not have a decoder yet. Related: OS#5927 Change-Id: I535aa45a676b87a8912e99bdb802bf29a23f1c89 --- M library/PCUIF_Types.ttcn 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/93/33793/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33793 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I535aa45a676b87a8912e99bdb802bf29a23f1c89 Gerrit-Change-Number: 33793 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-ttcn3-hacks[master]: GPRS_Components: use more suitable SAPI for DL TBF assignment
by dexter 20 Jul '23

20 Jul '23

Attention is currently required from: dexter. Hello Jenkins Builder, laforge, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33794 to look at the new patch set (#3). Change subject: GPRS_Components: use more suitable SAPI for DL TBF assignment ...................................................................... GPRS_Components: use more suitable SAPI for DL TBF assignment The function that assigns the downlink TBF f_ms_exp_dl_tbf_ass_ccch() uses SAPI PCU_IF_SAPI_AGCH as default but actually downlink TBFs are assigned via the PCH. This means we have to put PCU_IF_SAPI_PCH into the parameter list on every function call, so it makes sense to change the default to PCU_IF_SAPI_PCH and omit the SAPI when calling the function Related: OS#5927 Change-Id: I49c59bad0162cb303669f6108201f154918b1db3 --- M pcu/GPRS_Components.ttcn M pcu/PCU_Tests.ttcn 2 files changed, 47 insertions(+), 31 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/94/33794/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33794 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I49c59bad0162cb303669f6108201f154918b1db3 Gerrit-Change-Number: 33794 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-pcu[master]: bts: send IMMEDIATE ASSIGNMENT via AGCH when no IMSI is available
by dexter 20 Jul '23

20 Jul '23

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33768 ) Change subject: bts: send IMMEDIATE ASSIGNMENT via AGCH when no IMSI is available ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Unfortunately we came across a problem here. The SAPI PCU_IF_SAPI_AGCH does not support attaching of a TLLI, which we would need to send the confirmation back. Basically we need a struct gsm_pcu_if_agch_dt. This of course requires changes on both sides again. It should be simple enough to add this before the next release. For now we fixed this differently: Iaa3e5cdcf86578821e149b3e23482a0bcee19f7b So I switch this back to WIP until I have patches that provide a complete fix for osmo-pcu, osmo-bts and osmo-bsc. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33768 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iae1dd5d6be9ee8813a9c0b092926e8eda63f1e8e Gerrit-Change-Number: 33768 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Jul 2023 08:25:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in osmocom-bb[master]: trxcon/l1sched: implement CSD scheduling support
by osmith 20 Jul '23

20 Jul '23

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32922 ) Change subject: trxcon/l1sched: implement CSD scheduling support ...................................................................... Patch Set 11: Code-Review+1 (1 comment) File src/host/trxcon/src/sched_lchan_tchf.c: https://gerrit.osmocom.org/c/osmocom-bb/+/32922/comment/4fe39a9c_715192ab PS11, Line 136: l1sched_lchan_meas_avg(lchan, 8); // XXX did you intentionally leave this in? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32922 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0d7389a9a5f7019b9316ab1c0115797ff54a0e41 Gerrit-Change-Number: 32922 Gerrit-PatchSet: 11 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Jul 2023 08:21:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: pcu_sock: forward downlink IMMEDAITE ASSIGNMENT with no IMSI to AGCH
by pespin 20 Jul '23

20 Jul '23

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33829 ) Change subject: pcu_sock: forward downlink IMMEDAITE ASSIGNMENT with no IMSI to AGCH ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33829 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iaa3e5cdcf86578821e149b3e23482a0bcee19f7b Gerrit-Change-Number: 33829 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Jul 2023 08:18:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: pcu_sock: forward downlink IMMEDAITE ASSIGNMENT with no IMSI to AGCH
by dexter 20 Jul '23

20 Jul '23

Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33829 ) Change subject: pcu_sock: forward downlink IMMEDAITE ASSIGNMENT with no IMSI to AGCH ...................................................................... Patch Set 3: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/33829/comment/de95a3a4_c52493cf PS2, Line 7: pcu_sock: forward downlink IMMEDAITE ASSIGNMENT to AGCH > pcu_sock: forward downlink IMMEDAITE ASSIGNMENT with no IMSI to AGCH Done https://gerrit.osmocom.org/c/osmo-bts/+/33829/comment/1a97c15b_2cbc5700 PS2, Line 14: ASSIGNMENT through the AGCH then. > Please explain *why* it is more appropriate to do so. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33829 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iaa3e5cdcf86578821e149b3e23482a0bcee19f7b Gerrit-Change-Number: 33829 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Jul 2023 08:17:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0