June 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-hnbgw[master]: ranap_rab_ass: be sure to initialize memory with 0
by fixeria 21 Jun '23

21 Jun '23

Attention is currently required from: neels, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33391 ) Change subject: ranap_rab_ass: be sure to initialize memory with 0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33391 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I7a8a951ccd8c9ae3923261468c0755192894a84b Gerrit-Change-Number: 33391 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Jun 2023 16:07:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-hnbgw[master]: ranap_rab_ass: do not free never allocated FieldItems
by fixeria 21 Jun '23

21 Jun '23

Attention is currently required from: neels, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33390 ) Change subject: ranap_rab_ass: do not free never allocated FieldItems ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33390 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I755ba6599079810a048bf5b6d8947b5a9ffa622d Gerrit-Change-Number: 33390 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Jun 2023 16:06:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: ranap_rab_ass: be sure to initialize memory with 0
by pespin 21 Jun '23

21 Jun '23

Attention is currently required from: neels, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33391 ) Change subject: ranap_rab_ass: be sure to initialize memory with 0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33391 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I7a8a951ccd8c9ae3923261468c0755192894a84b Gerrit-Change-Number: 33391 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Jun 2023 16:01:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-hnbgw[master]: ranap_rab_ass: do not free never allocated FieldItems
by pespin 21 Jun '23

21 Jun '23

Attention is currently required from: neels, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33390 ) Change subject: ranap_rab_ass: do not free never allocated FieldItems ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33390 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I755ba6599079810a048bf5b6d8947b5a9ffa622d Gerrit-Change-Number: 33390 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Jun 2023 16:00:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: ranap_rab_ass: be sure to initialize memory with 0
by laforge 21 Jun '23

21 Jun '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33391 ) Change subject: ranap_rab_ass: be sure to initialize memory with 0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33391 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I7a8a951ccd8c9ae3923261468c0755192894a84b Gerrit-Change-Number: 33391 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Jun 2023 15:46:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-hnbgw[master]: ranap_rab_ass: do not free never allocated FieldItems
by laforge 21 Jun '23

21 Jun '23

Attention is currently required from: neels, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33390 ) Change subject: ranap_rab_ass: do not free never allocated FieldItems ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33390 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I755ba6599079810a048bf5b6d8947b5a9ffa622d Gerrit-Change-Number: 33390 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Jun 2023 15:35:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-hnbgw[master]: ranap_rab_ass: do not free never allocated FieldItems
by dexter 21 Jun '23

21 Jun '23

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33390 ) Change subject: ranap_rab_ass: do not free never allocated FieldItems ...................................................................... ranap_rab_ass: do not free never allocated FieldItems When we check for an assignment failure in a RAB AssignmnetResponse, we use decode_rab_flitms_from_resp_ies to search through the list of RAB FailedItemsIEs for the RAB id we want to check. In case of failure, we get a positive index back from this function. We then know that the RAB that we checked for has failed bcause it was in the FailedItemsList. In that case, we also must free the RAB FailedItemsIEs that decode_rab_flitms_from_resp_ies has decoded. At the moment we also free the RAB FailedItemsIEs also when decode_rab_flitms_from_resp_ies returns with a negative return code, which may mean that the RAB was not found or some other error occured. In this case we must not free since then no valid RAB FailedItemsIEs are allocated. Related: OS#6062 Change-Id: I755ba6599079810a048bf5b6d8947b5a9ffa622d --- M src/osmo-hnbgw/ranap_rab_ass.c M tests/ranap_rab_ass/ranap_rab_ass_test.c 2 files changed, 55 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/90/33390/1 diff --git a/src/osmo-hnbgw/ranap_rab_ass.c b/src/osmo-hnbgw/ranap_rab_ass.c index cd8e625..e8addcd 100644 --- a/src/osmo-hnbgw/ranap_rab_ass.c +++ b/src/osmo-hnbgw/ranap_rab_ass.c @@ -176,7 +176,9 @@ return ies->raB_FailedList.raB_FailedList_ies.list.array[index]; } -/* find the RAB specified by rab_id in ies and when found, decode the result into items_ies */ +/* Find the RAB specified by rab_id in ies, decode the result into items_ies and return a positive index. + * The caller is responsible for freeing the contents in items_ies. In case of failure, the return code + * will be negative. */ static int decode_rab_smditms_from_resp_ies(RANAP_RAB_SetupOrModifiedItemIEs_t *items_ies, RANAP_RAB_AssignmentResponseIEs_t *ies, uint8_t rab_id) { @@ -576,17 +578,16 @@ RANAP_RAB_FailedItemIEs_t _rab_failed_items_ies; RANAP_RAB_FailedItemIEs_t *rab_failed_items_ies = &_rab_failed_items_ies; int rc; - bool result = true; - /* If we can get a failed item for the specified RAB ID, then we know that the + /* If we can get a failed item (rc >= 0) for the specified RAB ID, then we know that the * HNB reported the RAB Assignment as failed */ rc = decode_rab_flitms_from_resp_ies(rab_failed_items_ies, ies, rab_id); if (rc < 0) - result = false; + return false; ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_RANAP_RAB_FailedItem, rab_failed_items_ies); - return result; + return true; } /*! Check if a specific RAB is present in an RAB-ReleaseList inside RANAP_RAB_AssignmentRequestIEs. diff --git a/tests/ranap_rab_ass/ranap_rab_ass_test.c b/tests/ranap_rab_ass/ranap_rab_ass_test.c index fc2992d..fbdfa77 100644 --- a/tests/ranap_rab_ass/ranap_rab_ass_test.c +++ b/tests/ranap_rab_ass/ranap_rab_ass_test.c @@ -299,6 +299,31 @@ ranap_cn_rx_co_free(&message); } +/* Same as above but with a message that does not even contain a FailedItemsIEs list */ +void test_ranap_rab_ass_resp_ies_check_failure_no_faileditemies(void) +{ + int rc; + ranap_message message; + bool rab_failed_at_hnb; + uint8_t testvec[] = { + 0x60, 0x00, 0x00, 0x2a, 0x00, 0x00, 0x01, 0x00, + 0x34, 0x40, 0x23, 0x00, 0x00, 0x01, 0x00, 0x33, + 0x40, 0x1c, 0x60, 0x3a, 0x7c, 0x35, 0x00, 0x01, + 0x0a, 0x09, 0x01, 0xa4, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x40, 0x04, 0x0a, 0x00, 0x00 + }; + + rc = ranap_cn_rx_co_decode2(&message, testvec, sizeof(testvec)); + + OSMO_ASSERT(rc == 0); + rab_failed_at_hnb = + ranap_rab_ass_resp_ies_check_failure(&message.msg.raB_AssignmentResponseIEs, 23); + OSMO_ASSERT(rab_failed_at_hnb == 0) + + ranap_cn_rx_co_free(&message); +} + void test_ranap_rab_ass_req_ies_check_release(void) { int rc; @@ -413,6 +438,7 @@ test_ranap_rab_ass_req_ies_replace_inet_addr(); test_ranap_rab_ass_resp_ies_replace_inet_addr(); test_ranap_rab_ass_resp_ies_check_failure(); + test_ranap_rab_ass_resp_ies_check_failure_no_faileditemies(); test_ranap_rab_ass_req_ies_check_release(); test_ranap_rab_ass_req_ies_get_count(); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33390 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I755ba6599079810a048bf5b6d8947b5a9ffa622d Gerrit-Change-Number: 33390 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-hnbgw[master]: ranap_rab_ass: be sure to initialize memory with 0
by dexter 21 Jun '23

21 Jun '23

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33391 ) Change subject: ranap_rab_ass: be sure to initialize memory with 0 ...................................................................... ranap_rab_ass: be sure to initialize memory with 0 When we use the ASN.1 decoder functions, we often reserve some memory on the stack to store the results. (e.g. RANAP_RAB_xy_t _RANAP_RAB_xy;). Then we assign the memory location to a pointer variable (e.g. RANAP_RAB_xy = &_RANAP_RAB_xy). We do this for cosmetic reasons but we may end up with an uninitialized buffer, which may cause trouble lateron. Let's be consistent and make sure that those buffers are initialized with zeros. Change-Id: I7a8a951ccd8c9ae3923261468c0755192894a84b --- M src/osmo-hnbgw/ranap_rab_ass.c 1 file changed, 25 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/91/33391/1 diff --git a/src/osmo-hnbgw/ranap_rab_ass.c b/src/osmo-hnbgw/ranap_rab_ass.c index e8addcd..fe42803 100644 --- a/src/osmo-hnbgw/ranap_rab_ass.c +++ b/src/osmo-hnbgw/ranap_rab_ass.c @@ -41,11 +41,9 @@ { int rc; struct msgb *msg; - RANAP_RAB_AssignmentRequest_t _rab_assignment_request; + RANAP_RAB_AssignmentRequest_t _rab_assignment_request = { 0 }; RANAP_RAB_AssignmentRequest_t *rab_assignment_request = &_rab_assignment_request; - memset(rab_assignment_request, 0, sizeof(*rab_assignment_request)); - rc = ranap_encode_rab_assignmentrequesties(rab_assignment_request, rab_assignment_request_ies); if (rc < 0) return NULL; @@ -72,11 +70,10 @@ int rc; struct msgb *msg; - RANAP_RAB_AssignmentResponse_t _rab_assignment_response; + RANAP_RAB_AssignmentResponse_t _rab_assignment_response = { 0 }; RANAP_RAB_AssignmentResponse_t *rab_assignment_response = &_rab_assignment_response; memset(data, 0, len); - memset(rab_assignment_response, 0, sizeof(*rab_assignment_response)); rc = ranap_encode_rab_assignmentresponseies(rab_assignment_response, rab_assignment_response_ies); if (rc < 0) @@ -315,7 +312,7 @@ RANAP_RAB_AssignmentRequestIEs_t *ies, unsigned int index) { RANAP_ProtocolIE_FieldPair_t *protocol_ie_field_pair; - RANAP_RAB_SetupOrModifyItemFirst_t _rab_setup_or_modify_item_first; + RANAP_RAB_SetupOrModifyItemFirst_t _rab_setup_or_modify_item_first = { 0 }; RANAP_RAB_SetupOrModifyItemFirst_t *rab_setup_or_modify_item_first = &_rab_setup_or_modify_item_first; RANAP_TransportLayerAddress_t *trasp_layer_addr; RANAP_IuTransportAssociation_t *transp_assoc; @@ -384,7 +381,7 @@ * \returns 0 on success; negative on error. */ int ranap_rab_ass_resp_ies_extract_inet_addr(struct osmo_sockaddr *addr, RANAP_RAB_AssignmentResponseIEs_t *ies, uint8_t rab_id) { - RANAP_RAB_SetupOrModifiedItemIEs_t _rab_setup_or_modified_items_ies; + RANAP_RAB_SetupOrModifiedItemIEs_t _rab_setup_or_modified_items_ies = { 0 }; RANAP_RAB_SetupOrModifiedItemIEs_t *rab_setup_or_modified_items_ies = &_rab_setup_or_modified_items_ies; RANAP_RAB_SetupOrModifiedItem_t *rab_setup_or_modified_item; uint16_t port; @@ -436,7 +433,7 @@ int ranap_rab_ass_req_ies_replace_inet_addr(RANAP_RAB_AssignmentRequestIEs_t *ies, struct osmo_sockaddr *addr, uint8_t rab_id) { RANAP_ProtocolIE_FieldPair_t *protocol_ie_field_pair; - RANAP_RAB_SetupOrModifyItemFirst_t _rab_setup_or_modify_item_first; + RANAP_RAB_SetupOrModifyItemFirst_t _rab_setup_or_modify_item_first = { 0 }; RANAP_RAB_SetupOrModifyItemFirst_t *rab_setup_or_modify_item_first = &_rab_setup_or_modify_item_first; RANAP_TransportLayerInformation_t *old_transport_layer_information = NULL; RANAP_TransportLayerInformation_t *new_transport_layer_information = NULL; @@ -506,7 +503,7 @@ int ranap_rab_ass_resp_ies_replace_inet_addr(RANAP_RAB_AssignmentResponseIEs_t *ies, struct osmo_sockaddr *addr, uint8_t rab_id) { RANAP_IE_t *setup_or_modified_list_ie; - RANAP_RAB_SetupOrModifiedItemIEs_t _rab_setup_or_modified_items_ies; + RANAP_RAB_SetupOrModifiedItemIEs_t _rab_setup_or_modified_items_ies = { 0 }; RANAP_RAB_SetupOrModifiedItemIEs_t *rab_setup_or_modified_items_ies = &_rab_setup_or_modified_items_ies; RANAP_RAB_SetupOrModifiedItem_t *rab_setup_or_modified_item; RANAP_TransportLayerInformation_t *temp_transport_layer_information = NULL; @@ -575,7 +572,7 @@ * \returns true when RAB could be identified as failed; false otherwise */ bool ranap_rab_ass_resp_ies_check_failure(RANAP_RAB_AssignmentResponseIEs_t *ies, uint8_t rab_id) { - RANAP_RAB_FailedItemIEs_t _rab_failed_items_ies; + RANAP_RAB_FailedItemIEs_t _rab_failed_items_ies = { 0 }; RANAP_RAB_FailedItemIEs_t *rab_failed_items_ies = &_rab_failed_items_ies; int rc; @@ -596,7 +593,7 @@ * \returns true when RAB is intended for release; false otherwise */ bool ranap_rab_ass_req_ies_check_release(RANAP_RAB_AssignmentRequestIEs_t *ies, uint8_t rab_id) { - RANAP_RAB_ReleaseItemIEs_t _rab_release_items_ies; + RANAP_RAB_ReleaseItemIEs_t _rab_release_items_ies = { 0 }; RANAP_RAB_ReleaseItemIEs_t *rab_release_items_ies = &_rab_release_items_ies; int rc; bool result = true; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33391 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I7a8a951ccd8c9ae3923261468c0755192894a84b Gerrit-Change-Number: 33391 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-gsm-tester[master]: templates: osmo-bsc.cfg.tmpl: migrate to separate 'mgw' node
by pespin 21 Jun '23

21 Jun '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/33388 ) Change subject: templates: osmo-bsc.cfg.tmpl: migrate to separate 'mgw' node ...................................................................... templates: osmo-bsc.cfg.tmpl: migrate to separate 'mgw' node This commit fixes the following deprecation warnings: % MGCP commands outside of 'mgw' nodes are deprecated. You should consider reading the User Manual and migrating to 'mgw' node. Change-Id: Ic2b3c8a6775b6a34bfc03e0643a34772ae789139 --- M src/osmo_gsm_tester/templates/osmo-bsc.cfg.tmpl 1 file changed, 18 insertions(+), 3 deletions(-) Approvals: pespin: Looks good to me, approved; Verified diff --git a/src/osmo_gsm_tester/templates/osmo-bsc.cfg.tmpl b/src/osmo_gsm_tester/templates/osmo-bsc.cfg.tmpl index b40b6f4..64adffe 100644 --- a/src/osmo_gsm_tester/templates/osmo-bsc.cfg.tmpl +++ b/src/osmo_gsm_tester/templates/osmo-bsc.cfg.tmpl @@ -112,13 +112,14 @@ % endfor % endfor %endfor + mgw 0 + local-ip ${bsc.ip_address.addr} + remote-ip ${mgw.ip_address.addr} + remote-port 2427 msc core-mobile-country-code ${bsc.net.mcc} core-mobile-network-code ${bsc.net.mnc} allow-emergency allow - mgw remote-ip ${mgw.ip_address.addr} - mgw remote-port 2427 - mgw local-ip ${bsc.ip_address.addr} codec-list ${' '.join(bsc.net.codec_list)} amr-config 12_2k forbidden amr-config 10_2k forbidden -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/33388 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Ic2b3c8a6775b6a34bfc03e0643a34772ae789139 Gerrit-Change-Number: 33388 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-gsm-tester[master]: templates: osmo-bsc.cfg.tmpl: remove deprecated no-op params
by pespin 21 Jun '23

21 Jun '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/33386 ) Change subject: templates: osmo-bsc.cfg.tmpl: remove deprecated no-op params ...................................................................... templates: osmo-bsc.cfg.tmpl: remove deprecated no-op params This patch eliminates the following deprecation warnings: % deprecated: 'ip.access rtp-base' has no effect, RTP is handled by the MGW Please do not use legacy config 'mgw endpoint-range' (the range can no longer be defined by the MGCP client) Change-Id: I64f6a26a3ae347083968c12855357de10baabc59 --- M src/osmo_gsm_tester/templates/osmo-bsc.cfg.tmpl 1 file changed, 14 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, approved; Verified diff --git a/src/osmo_gsm_tester/templates/osmo-bsc.cfg.tmpl b/src/osmo_gsm_tester/templates/osmo-bsc.cfg.tmpl index 60f04cc..b40b6f4 100644 --- a/src/osmo_gsm_tester/templates/osmo-bsc.cfg.tmpl +++ b/src/osmo_gsm_tester/templates/osmo-bsc.cfg.tmpl @@ -116,11 +116,9 @@ core-mobile-country-code ${bsc.net.mcc} core-mobile-network-code ${bsc.net.mnc} allow-emergency allow - ip.access rtp-base 25000 mgw remote-ip ${mgw.ip_address.addr} mgw remote-port 2427 mgw local-ip ${bsc.ip_address.addr} - mgw endpoint-range 1 31 codec-list ${' '.join(bsc.net.codec_list)} amr-config 12_2k forbidden amr-config 10_2k forbidden -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/33386 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I64f6a26a3ae347083968c12855357de10baabc59 Gerrit-Change-Number: 33386 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0