June 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-msc[master]: msc_ho_send_handover_request: fix check_after_deref
by osmith 22 Jun '23

22 Jun '23

Attention is currently required from: osmith. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/33398 to look at the new patch set (#2). Change subject: msc_ho_send_handover_request: fix check_after_deref ...................................................................... msc_ho_send_handover_request: fix check_after_deref Fixes: CID#211073 Change-Id: I9389cc9c4af987c11652c6fe9a0ff4289a7781c9 --- M src/libmsc/msc_ho.c 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/98/33398/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33398 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9389cc9c4af987c11652c6fe9a0ff4289a7781c9 Gerrit-Change-Number: 33398 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ci[master]: obs: make limesuite build with debian 12
by pespin 22 Jun '23

22 Jun '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/33399 ) Change subject: obs: make limesuite build with debian 12 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/33399 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic81dfbfa232b92e3fd9af9c5d7d0f2aca4b9879c Gerrit-Change-Number: 33399 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Jun 2023 12:48:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: msc_ho_send_handover_request: fix check_after_deref
by pespin 22 Jun '23

22 Jun '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33398 ) Change subject: msc_ho_send_handover_request: fix check_after_deref ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/libmsc/msc_ho.c: https://gerrit.osmocom.org/c/osmo-msc/+/33398/comment/c9f9d7da_d118903a PS1, Line 424: ran_enc_msg.handover_request.geran.channel_type = &channel_type; imho you should move setting those 2 fields to here (or in line 418). -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33398 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9389cc9c4af987c11652c6fe9a0ff4289a7781c9 Gerrit-Change-Number: 33398 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Jun 2023 12:47:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: Fix various uninitialized value errors
by osmith 22 Jun '23

22 Jun '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/33400 ) Change subject: Fix various uninitialized value errors ...................................................................... Fix various uninitialized value errors Fixes: CID#272949, CID#272951, CID#272974, CID#274685 Change-Id: Icaf53fda8752e9d2bd2cfe8c7b89bb31b90f684f --- M src/coding/gsm0503_coding.c M src/gsm/gsm23236.c M tests/codec/codec_ecu_fr_test.c 3 files changed, 14 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/00/33400/1 diff --git a/src/coding/gsm0503_coding.c b/src/coding/gsm0503_coding.c index 80286f7..97f5c97 100644 --- a/src/coding/gsm0503_coding.c +++ b/src/coding/gsm0503_coding.c @@ -2194,7 +2194,7 @@ uint8_t *cmr, int *n_errors, int *n_bits_total, uint8_t *dtx) { sbit_t iB[912], cB[456], h; - ubit_t d[244], p[6], conv[250]; + ubit_t d[244], p[6], conv[250] = {}; int i, rv, len, steal = 0, id = -1; *n_errors = 0; *n_bits_total = 0; static ubit_t sid_first_dummy[64] = { 0 }; diff --git a/src/gsm/gsm23236.c b/src/gsm/gsm23236.c index 4a83ec8..a80ecf4 100644 --- a/src/gsm/gsm23236.c +++ b/src/gsm/gsm23236.c @@ -487,7 +487,7 @@ int osmo_nri_ranges_vty_add(const char **message, struct osmo_nri_range *added_range, struct osmo_nri_ranges *nri_ranges, int argc, const char **argv, uint8_t nri_bitlen) { - struct osmo_nri_range add_range; + struct osmo_nri_range add_range = {}; if (osmo_nri_parse_range(&add_range, argv[0], argc > 1 ? argv[1] : NULL)) { *message = "Error: cannot parse NRI range"; return -1; @@ -523,7 +523,7 @@ int osmo_nri_ranges_vty_del(const char **message, struct osmo_nri_range *removed_range, struct osmo_nri_ranges *nri_ranges, int argc, const char **argv) { - struct osmo_nri_range del_range; + struct osmo_nri_range del_range = {}; if (osmo_nri_parse_range(&del_range, argv[0], argc > 1 ? argv[1] : NULL)) { *message = "Error: cannot parse NRI range"; return -1; diff --git a/tests/codec/codec_ecu_fr_test.c b/tests/codec/codec_ecu_fr_test.c index 4e5b71d..fe64685 100644 --- a/tests/codec/codec_ecu_fr_test.c +++ b/tests/codec/codec_ecu_fr_test.c @@ -107,7 +107,7 @@ */ void test_fr_concealment(void) { - struct osmo_ecu_fr_state state; + struct osmo_ecu_fr_state state = {}; uint8_t frame[GSM_FR_BYTES]; uint64_t xmaxc[4]; int i, rc; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icaf53fda8752e9d2bd2cfe8c7b89bb31b90f684f Gerrit-Change-Number: 33400 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-msc[master]: smpp_msc: submit_to_sms: check ud_len > sms_msg_len
by pespin 22 Jun '23

22 Jun '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33397 ) Change subject: smpp_msc: submit_to_sms: check ud_len > sms_msg_len ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33397 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie01ac84816f6ac3ba5631a643d486fb0dfb05eb2 Gerrit-Change-Number: 33397 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Jun 2023 12:45:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: sdp_msg_test: fix dereference after null check
by pespin 22 Jun '23

22 Jun '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33396 ) Change subject: sdp_msg_test: fix dereference after null check ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33396 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic59252e4f1d4daf5f86c6b73ec951e02109df9bc Gerrit-Change-Number: 33396 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Jun 2023 12:45:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: smpp_handle_bind_tx: initialize tlv
by pespin 22 Jun '23

22 Jun '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33395 ) Change subject: smpp_handle_bind_tx: initialize tlv ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33395 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I22da1aa95bf19a9bb1d8e0875f3b68356d801c70 Gerrit-Change-Number: 33395 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Jun 2023 12:44:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: gsm48_cc_tx_alerting: check rc of sdp_msg_from_sdp_str
by pespin 22 Jun '23

22 Jun '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33394 ) Change subject: gsm48_cc_tx_alerting: check rc of sdp_msg_from_sdp_str ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33394 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Id372d2d844446d6667a00dae22bdf8ed36c599ba Gerrit-Change-Number: 33394 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Jun 2023 12:44:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: csd_bs_list_to_gsm0808_channel_type: fix rc check
by pespin 22 Jun '23

22 Jun '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33393 ) Change subject: csd_bs_list_to_gsm0808_channel_type: fix rc check ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33393 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I5d77da71b60748818ba631229126c1bf061a9c7d Gerrit-Change-Number: 33393 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Jun 2023 12:43:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: obs: make limesuite build with debian 12
by osmith 22 Jun '23

22 Jun '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/33399 ) Change subject: obs: make limesuite build with debian 12 ...................................................................... obs: make limesuite build with debian 12 Related: OS#6057 Change-Id: Ic81dfbfa232b92e3fd9af9c5d7d0f2aca4b9879c --- M scripts/obs/lib/srcpkg.py 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/99/33399/1 diff --git a/scripts/obs/lib/srcpkg.py b/scripts/obs/lib/srcpkg.py index 2751005..b97bbf8 100644 --- a/scripts/obs/lib/srcpkg.py +++ b/scripts/obs/lib/srcpkg.py @@ -114,6 +114,13 @@ cwd=lib.git.get_repo_path("open5gs")) +def prepare_project_limesuite(): + """ Fix Debian 12 compat, until this is merged and in the next release: + https://github.com/myriadrf/LimeSuite/pull/381 """ + lib.run_cmd(["sed", "s/libwxgtk3.0-gtk3-dev,$/libwxgtk3.0-gtk3-dev | libwxgtk3.2-dev,/g", + "-i", "debian/control"], cwd=lib.git.get_repo_path("limesuite")) + + def write_tarball_version(project, version): repo_path = lib.git.get_repo_path(project) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/33399 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic81dfbfa232b92e3fd9af9c5d7d0f2aca4b9879c Gerrit-Change-Number: 33399 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0