Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33398 ) Change subject: msc_ho_send_handover_request: fix check_after_deref ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/libmsc/msc_ho.c: https://gerrit.osmocom.org/c/osmo-msc/+/33398/comment/c9f9d7da_d118903a PS1, Line 424: ran_enc_msg.handover_request.geran.channel_type = &channel_type; imho you should move setting those 2 fields to here (or in line 418). -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33398 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9389cc9c4af987c11652c6fe9a0ff4289a7781c9 Gerrit-Change-Number: 33398 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Comment-Date: Thu, 22 Jun 2023 12:47:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment