June 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-gsm-tester[master]: templates: osmo-bsc.cfg.tmpl: remove deprecated no-op params
by pespin 21 Jun '23

21 Jun '23

Attention is currently required from: fixeria. pespin has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/33386 ) Change subject: templates: osmo-bsc.cfg.tmpl: remove deprecated no-op params ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/33386 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I64f6a26a3ae347083968c12855357de10baabc59 Gerrit-Change-Number: 33386 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: deleteVote

1 0

[S] Change in osmo-gsm-tester[master]: templates: osmo-bsc.cfg.tmpl: remove deprecated no-op params
by pespin 21 Jun '23

21 Jun '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/33386 ) Change subject: templates: osmo-bsc.cfg.tmpl: remove deprecated no-op params ...................................................................... Patch Set 1: Verified+1 Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/33386 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I64f6a26a3ae347083968c12855357de10baabc59 Gerrit-Change-Number: 33386 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Jun 2023 14:48:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-gsm-tester[master]: templates: osmo-bsc.cfg.tmpl: remove deprecated no-op params
by fixeria 21 Jun '23

21 Jun '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/33386 ) Change subject: templates: osmo-bsc.cfg.tmpl: remove deprecated no-op params ...................................................................... templates: osmo-bsc.cfg.tmpl: remove deprecated no-op params This patch eliminates the following deprecation warnings: % deprecated: 'ip.access rtp-base' has no effect, RTP is handled by the MGW Please do not use legacy config 'mgw endpoint-range' (the range can no longer be defined by the MGCP client) Change-Id: I64f6a26a3ae347083968c12855357de10baabc59 --- M src/osmo_gsm_tester/templates/osmo-bsc.cfg.tmpl 1 file changed, 14 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/86/33386/1 diff --git a/src/osmo_gsm_tester/templates/osmo-bsc.cfg.tmpl b/src/osmo_gsm_tester/templates/osmo-bsc.cfg.tmpl index 60f04cc..b40b6f4 100644 --- a/src/osmo_gsm_tester/templates/osmo-bsc.cfg.tmpl +++ b/src/osmo_gsm_tester/templates/osmo-bsc.cfg.tmpl @@ -116,11 +116,9 @@ core-mobile-country-code ${bsc.net.mcc} core-mobile-network-code ${bsc.net.mnc} allow-emergency allow - ip.access rtp-base 25000 mgw remote-ip ${mgw.ip_address.addr} mgw remote-port 2427 mgw local-ip ${bsc.ip_address.addr} - mgw endpoint-range 1 31 codec-list ${' '.join(bsc.net.codec_list)} amr-config 12_2k forbidden amr-config 10_2k forbidden -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/33386 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I64f6a26a3ae347083968c12855357de10baabc59 Gerrit-Change-Number: 33386 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-gsm-tester[master]: templates: osmo-bsc.cfg.tmpl: migrate to separate 'mgw' node
by fixeria 21 Jun '23

21 Jun '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/33388 ) Change subject: templates: osmo-bsc.cfg.tmpl: migrate to separate 'mgw' node ...................................................................... templates: osmo-bsc.cfg.tmpl: migrate to separate 'mgw' node This commit fixes the following deprecation warnings: % MGCP commands outside of 'mgw' nodes are deprecated. You should consider reading the User Manual and migrating to 'mgw' node. Change-Id: Ic2b3c8a6775b6a34bfc03e0643a34772ae789139 --- M src/osmo_gsm_tester/templates/osmo-bsc.cfg.tmpl 1 file changed, 18 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/88/33388/1 diff --git a/src/osmo_gsm_tester/templates/osmo-bsc.cfg.tmpl b/src/osmo_gsm_tester/templates/osmo-bsc.cfg.tmpl index b40b6f4..64adffe 100644 --- a/src/osmo_gsm_tester/templates/osmo-bsc.cfg.tmpl +++ b/src/osmo_gsm_tester/templates/osmo-bsc.cfg.tmpl @@ -112,13 +112,14 @@ % endfor % endfor %endfor + mgw 0 + local-ip ${bsc.ip_address.addr} + remote-ip ${mgw.ip_address.addr} + remote-port 2427 msc core-mobile-country-code ${bsc.net.mcc} core-mobile-network-code ${bsc.net.mnc} allow-emergency allow - mgw remote-ip ${mgw.ip_address.addr} - mgw remote-port 2427 - mgw local-ip ${bsc.ip_address.addr} codec-list ${' '.join(bsc.net.codec_list)} amr-config 12_2k forbidden amr-config 10_2k forbidden -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/33388 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Ic2b3c8a6775b6a34bfc03e0643a34772ae789139 Gerrit-Change-Number: 33388 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-gsm-tester[master]: templates: osmo-mgw.cfg.tmpl: address deprecation warnings
by fixeria 21 Jun '23

21 Jun '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/33389 ) Change subject: templates: osmo-mgw.cfg.tmpl: address deprecation warnings ...................................................................... templates: osmo-mgw.cfg.tmpl: address deprecation warnings This commit fixes the following deprecation warnings: range must end at an odd port number, autocorrecting port (16000) to: 16001 % Deprecated 'sdp audio-payload number <0-255>' config no longer has any effect % Deprecated 'sdp audio-payload name NAME' config no longer has any effect Change-Id: I98549abf8dd726fcc67a1de6a5f8bee64558883d --- M src/osmo_gsm_tester/templates/osmo-mgw.cfg.tmpl 1 file changed, 16 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/89/33389/1 diff --git a/src/osmo_gsm_tester/templates/osmo-mgw.cfg.tmpl b/src/osmo_gsm_tester/templates/osmo-mgw.cfg.tmpl index 5f351a4..ffdf9d3 100644 --- a/src/osmo_gsm_tester/templates/osmo-mgw.cfg.tmpl +++ b/src/osmo_gsm_tester/templates/osmo-mgw.cfg.tmpl @@ -7,10 +7,8 @@ mgcp bind ip ${mgw.ip_address.addr} bind port 2427 - rtp net-range 4002 16000 + rtp net-range 4002 16001 rtp force-ptime 20 - sdp audio payload number 98 - sdp audio payload name AMR/8000 number endpoints 31 rtcp-omit rtp-accept-all 1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/33389 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I98549abf8dd726fcc67a1de6a5f8bee64558883d Gerrit-Change-Number: 33389 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-gsm-tester[master]: templates: fix deprecated BTS type: s/sysmobts/osmo-bts/
by fixeria 21 Jun '23

21 Jun '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/33387 ) Change subject: templates: fix deprecated BTS type: s/sysmobts/osmo-bts/ ...................................................................... templates: fix deprecated BTS type: s/sysmobts/osmo-bts/ This change fixes the following deprecation warning: % BTS type 'sysmobts' is deprecated, use 'type osmo-bts' instead. Change-Id: Iab1a0d14de5349438e73edfb57be4f7271afbfef --- M doc/examples/2g_osmocom/defaults.conf M doc/manuals/chapters/config.adoc M sysmocom/defaults.conf 3 files changed, 16 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/87/33387/1 diff --git a/doc/examples/2g_osmocom/defaults.conf b/doc/examples/2g_osmocom/defaults.conf index 06d596a..73ca685 100644 --- a/doc/examples/2g_osmocom/defaults.conf +++ b/doc/examples/2g_osmocom/defaults.conf @@ -20,7 +20,7 @@ bsc_bts: base_station_id_code: 63 stream_id: 255 - osmobsc_bts_type: sysmobts + osmobsc_bts_type: osmo-bts channel_allocator: ascending gprs_mode: gprs num_trx: 1 diff --git a/doc/manuals/chapters/config.adoc b/doc/manuals/chapters/config.adoc index f4e08b3..6bc899c 100644 --- a/doc/manuals/chapters/config.adoc +++ b/doc/manuals/chapters/config.adoc @@ -431,7 +431,7 @@ location_area_code: 23 base_station_id_code: 63 stream_id: 255 - osmobsc_bts_type: sysmobts + osmobsc_bts_type: osmo-bts trx_list: - nominal_power: 23 max_power_red: 0 diff --git a/sysmocom/defaults.conf b/sysmocom/defaults.conf index af5c52c..1501273 100644 --- a/sysmocom/defaults.conf +++ b/sysmocom/defaults.conf @@ -29,7 +29,7 @@ bsc_bts: base_station_id_code: 63 stream_id: 255 - osmobsc_bts_type: sysmobts + osmobsc_bts_type: osmo-bts channel_allocator: ascending gprs_mode: gprs num_trx: 1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/33387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Iab1a0d14de5349438e73edfb57be4f7271afbfef Gerrit-Change-Number: 33387 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-gsm-manuals[master]: mgwpool: Document keepalive feature
by pespin 21 Jun '23

21 Jun '23

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310 ) Change subject: mgwpool: Document keepalive feature ...................................................................... Patch Set 5: (2 comments) Patchset: PS4: > self note: I'll have to update the vty examples here once I change the "show mgw-pool" output. Done File common/chapters/mgwpool.adoc: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310/comment/2a0d3e3e_4065… PS4, Line 11: the pool will automatically assign the call to the available MGW with the lowest load. > parenthesis there may be misleading, since it may be understood as "perhaps done that way". […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I2cb4e2098b71b386278eb6026271a6d786a34c2a Gerrit-Change-Number: 33310 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Jun 2023 11:41:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-gsm-tester[master]: templates: also fix asp config in osmo-{bsc,sgsn}.cfg.tmpl
by pespin 21 Jun '23

21 Jun '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/33385 ) Change subject: templates: also fix asp config in osmo-{bsc,sgsn}.cfg.tmpl ...................................................................... templates: also fix asp config in osmo-{bsc,sgsn}.cfg.tmpl In change [1] I attempted to fix osmo-gsm-tester_virtual, but I did not notice that the same problem also was in osmo-bsc.cfg.tmpl. Also add the missing params to osmo-sgsn.cfg.tmpl. Change-Id: I7b3adfa131a9dbb867b9ae68615da27191b021e5 Related: [1] Ie29589b46c65707089ff2b22c3b139b7b435cc95 --- M src/osmo_gsm_tester/templates/osmo-bsc.cfg.tmpl M src/osmo_gsm_tester/templates/osmo-sgsn.cfg.tmpl 2 files changed, 19 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved; Verified diff --git a/src/osmo_gsm_tester/templates/osmo-bsc.cfg.tmpl b/src/osmo_gsm_tester/templates/osmo-bsc.cfg.tmpl index dd27da0..60f04cc 100644 --- a/src/osmo_gsm_tester/templates/osmo-bsc.cfg.tmpl +++ b/src/osmo_gsm_tester/templates/osmo-bsc.cfg.tmpl @@ -21,6 +21,8 @@ asp asp0 2905 0 m3ua local-ip ${bsc.ip_address.addr} remote-ip ${stp.ip_address.addr} + role asp + sctp-role client as as0 m3ua asp asp0 routing-key 2 0.0.2 diff --git a/src/osmo_gsm_tester/templates/osmo-sgsn.cfg.tmpl b/src/osmo_gsm_tester/templates/osmo-sgsn.cfg.tmpl index 5d8ba90..825298d 100644 --- a/src/osmo_gsm_tester/templates/osmo-sgsn.cfg.tmpl +++ b/src/osmo_gsm_tester/templates/osmo-sgsn.cfg.tmpl @@ -18,6 +18,8 @@ ! asp asp-clnt-OsmoSGSN-A 2905 0 m3ua ! local-ip ${sgsn.ip_address.addr} ! remote-ip stp.ip_address.addr +! role asp +! sctp-role client ! as as-clnt-OsmoSGSN-A m3ua ! asp asp-clnt-OsmoSGSN-A ! routing-key 3 0.23.4 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/33385 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I7b3adfa131a9dbb867b9ae68615da27191b021e5 Gerrit-Change-Number: 33385 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: merged

1 0

[S] Change in osmo-gsm-tester[master]: templates: also fix asp config in osmo-{bsc,sgsn}.cfg.tmpl
by pespin 21 Jun '23

21 Jun '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/33385 ) Change subject: templates: also fix asp config in osmo-{bsc,sgsn}.cfg.tmpl ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/33385 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I7b3adfa131a9dbb867b9ae68615da27191b021e5 Gerrit-Change-Number: 33385 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Jun 2023 11:40:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-gsm-tester[master]: templates: also fix asp config in osmo-{bsc,sgsn}.cfg.tmpl
by pespin 21 Jun '23

21 Jun '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/33385 ) Change subject: templates: also fix asp config in osmo-{bsc,sgsn}.cfg.tmpl ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/33385 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I7b3adfa131a9dbb867b9ae68615da27191b021e5 Gerrit-Change-Number: 33385 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Jun 2023 11:40:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0