June 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-dev[master]: net/templates/osmo-bsc: modernize
by osmith 26 Jun '23

26 Jun '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/33462 ) Change subject: net/templates/osmo-bsc: modernize ...................................................................... net/templates/osmo-bsc: modernize * Write explicit role & sctp-role fields in ASP * Use new mgw node Change-Id: I0051ba7f8116ea29380d3f438fd3a0af15d9d12f --- M net/templates/osmo-bsc-0.cfg M net/templates/osmo-bsc-1.cfg 2 files changed, 26 insertions(+), 6 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved osmith: Verified diff --git a/net/templates/osmo-bsc-0.cfg b/net/templates/osmo-bsc-0.cfg index 8150307..7f0d6d6 100644 --- a/net/templates/osmo-bsc-0.cfg +++ b/net/templates/osmo-bsc-0.cfg @@ -8,9 +8,14 @@ point-code ${BSC0_PC} asp asp-clnt-bsc-0 2905 0 m3ua remote-ip ${STP_RAN_IP} + role asp + sctp-role client msc 0 - mgw remote-ip ${MGW4BSC0_IP} - mgw remote-port ${MGW4BSC0_PORT} - mgw endpoint-domain bsc0 codec-list ${BSC0_CODEC_LIST} + +network + mgw 0 + remote-ip ${MGW4BSC0_IP} + remote-port ${MGW4BSC0_PORT} + endpoint-domain bsc0 diff --git a/net/templates/osmo-bsc-1.cfg b/net/templates/osmo-bsc-1.cfg index d559571..2ee1c6e 100644 --- a/net/templates/osmo-bsc-1.cfg +++ b/net/templates/osmo-bsc-1.cfg @@ -8,16 +8,19 @@ point-code ${BSC1_PC} asp asp-clnt-bsc-1 2905 0 m3ua remote-ip ${STP_RAN_IP} + role asp + sctp-role client msc 0 - mgw remote-ip ${MGW4BSC1_IP} - mgw remote-port ${MGW4BSC1_PORT} - mgw endpoint-domain bsc1 codec-list ${BSC1_CODEC_LIST} network bts 1 gprs mode none + mgw 0 + remote-ip ${MGW4BSC1_IP} + remote-port ${MGW4BSC1_PORT} + endpoint-domain bsc1 ctrl bind ${BSC1_IP} -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/33462 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I0051ba7f8116ea29380d3f438fd3a0af15d9d12f Gerrit-Change-Number: 33462 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-dev[master]: net/templates/run: fix prompts not working
by osmith 26 Jun '23

26 Jun '23

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/33458 ) Change subject: net/templates/run: fix prompts not working ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/33458 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I7f14c364637f82699a5b935637222d5da977d67d Gerrit-Change-Number: 33458 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jun 2023 15:08:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-dev[master]: net/templates/osmo-msc.conf: modernize
by osmith 26 Jun '23

26 Jun '23

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/33459 ) Change subject: net/templates/osmo-msc.conf: modernize ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/33459 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Id77a579ff9315f2c6bf9d7f6d80b4b022e8d4963 Gerrit-Change-Number: 33459 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jun 2023 15:08:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-dev[master]: net/templates/run.sh: fix BSC_COUNT check
by osmith 26 Jun '23

26 Jun '23

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/33460 ) Change subject: net/templates/run.sh: fix BSC_COUNT check ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/33460 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I2b880a8da51f96c16fb56d9d6e3994ecc1b47ae7 Gerrit-Change-Number: 33460 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jun 2023 15:08:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-dev[master]: net/config_2g3g: set a valid BTS1_ARFCN
by osmith 26 Jun '23

26 Jun '23

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/33461 ) Change subject: net/config_2g3g: set a valid BTS1_ARFCN ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/33461 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I569b407736713cefd46a1c927d9ee85f91332553 Gerrit-Change-Number: 33461 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jun 2023 15:08:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-dev[master]: net/templates/osmo-bsc: modernize
by osmith 26 Jun '23

26 Jun '23

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/33462 ) Change subject: net/templates/osmo-bsc: modernize ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/33462 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I0051ba7f8116ea29380d3f438fd3a0af15d9d12f Gerrit-Change-Number: 33462 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jun 2023 15:08:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: lint: typedefs_osmo: add l1if_compl_cb
by osmith 26 Jun '23

26 Jun '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/33464 ) Change subject: lint: typedefs_osmo: add l1if_compl_cb ...................................................................... lint: typedefs_osmo: add l1if_compl_cb Change-Id: If045d1734e918af9ce1e5c37cbd305deab848b56 --- M lint/checkpatch/typedefs_osmo.txt 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/64/33464/1 diff --git a/lint/checkpatch/typedefs_osmo.txt b/lint/checkpatch/typedefs_osmo.txt index 48b42bc..1dae49a 100644 --- a/lint/checkpatch/typedefs_osmo.txt +++ b/lint/checkpatch/typedefs_osmo.txt @@ -1,3 +1,4 @@ A_SEQUENCE_OF A_SET_OF +l1if_compl_cb ranap_message -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/33464 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If045d1734e918af9ce1e5c37cbd305deab848b56 Gerrit-Change-Number: 33464 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bts[master]: osmo-bts-sysmo: mute PHY until OML is ready
by Jenkins Builder 26 Jun '23

26 Jun '23

Attention is currently required from: pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33457 ) Change subject: osmo-bts-sysmo: mute PHY until OML is ready ...................................................................... Patch Set 6: (1 comment) File src/osmo-bts-sysmo/l1_if.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-8603): https://gerrit.osmocom.org/c/osmo-bts/+/33457/comment/70dfff40_55a78881 PS6, Line 1305: int trx_rf_lock(struct gsm_bts_trx *trx, int locked, l1if_compl_cb *cb); need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33457 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia1769f952fa787202a442a33db5ed4a1f7cbe9c3 Gerrit-Change-Number: 33457 Gerrit-PatchSet: 6 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jun 2023 15:07:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: osmo-bts-sysmo: activate_rf: no dispatch on fail
by osmith 26 Jun '23

26 Jun '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33456 ) Change subject: osmo-bts-sysmo: activate_rf: no dispatch on fail ...................................................................... osmo-bts-sysmo: activate_rf: no dispatch on fail Do not dispatch NM_EV_SW_ACT to trx->mo.fi and trx->bb_transc.mo.fi when RF-ACT.conf was not successful. Running this code path anyway looks like a leftover from when bts_shutdown used to exit osmo-bts. Change-Id: I342187604f4c72303e393ce6925b94d610bfa8fa --- M src/osmo-bts-sysmo/l1_if.c 1 file changed, 18 insertions(+), 4 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bts-sysmo/l1_if.c b/src/osmo-bts-sysmo/l1_if.c index 9a0b19f..0a1bbf3 100644 --- a/src/osmo-bts-sysmo/l1_if.c +++ b/src/osmo-bts-sysmo/l1_if.c @@ -1252,12 +1252,13 @@ LOGP(DL1C, LOGL_FATAL, "RF-ACT.conf with status %s\n", get_value_string(femtobts_l1status_names, status)); bts_shutdown(trx->bts, "RF-ACT failure"); - } else + } else { bts_update_status(BTS_STATUS_RF_ACTIVE, 1); - /* signal availability */ - osmo_fsm_inst_dispatch(trx->mo.fi, NM_EV_SW_ACT, NULL); - osmo_fsm_inst_dispatch(trx->bb_transc.mo.fi, NM_EV_SW_ACT, NULL); + /* signal availability */ + osmo_fsm_inst_dispatch(trx->mo.fi, NM_EV_SW_ACT, NULL); + osmo_fsm_inst_dispatch(trx->bb_transc.mo.fi, NM_EV_SW_ACT, NULL); + } } else { bts_update_status(BTS_STATUS_RF_ACTIVE, 0); osmo_fsm_inst_dispatch(trx->mo.fi, NM_EV_DISABLE, NULL); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33456 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I342187604f4c72303e393ce6925b94d610bfa8fa Gerrit-Change-Number: 33456 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-bts[master]: osmo-bts-sysmo: mute PHY until OML is ready
by Jenkins Builder 26 Jun '23

26 Jun '23

Attention is currently required from: pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33457 ) Change subject: osmo-bts-sysmo: mute PHY until OML is ready ...................................................................... Patch Set 5: (1 comment) File src/osmo-bts-sysmo/l1_if.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-8601): https://gerrit.osmocom.org/c/osmo-bts/+/33457/comment/c9b598e5_059e459a PS5, Line 1305: int trx_rf_lock(struct gsm_bts_trx *trx, int locked, l1if_compl_cb *cb); need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33457 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia1769f952fa787202a442a33db5ed4a1f7cbe9c3 Gerrit-Change-Number: 33457 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jun 2023 15:05:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0