June 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: WIP: sgsn: Fix TC_attach_timeout_after_pdp_act failing
by fixeria 26 Jun '23

26 Jun '23

Attention is currently required from: arehbein. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33465 ) Change subject: WIP: sgsn: Fix TC_attach_timeout_after_pdp_act failing ...................................................................... Patch Set 2: (1 comment) File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33465/comment/3f2f2c1b_2ef0… PS2, Line 1078: vc_conn.done > I gave this patch a try, and it fails due to `Tguard timeout` on my machine :/ AFAICS, osmo-sgsn is sending `GMM IDENTITY REQUEST: mi_type=IMEI`, but the testsuite does not respond. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33465 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibaf2134247153471bd45d7a7f91155294c6c6de5 Gerrit-Change-Number: 33465 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jun 2023 16:44:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: WIP: sgsn: Fix TC_attach_timeout_after_pdp_act failing
by fixeria 26 Jun '23

26 Jun '23

Attention is currently required from: arehbein. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33465 ) Change subject: WIP: sgsn: Fix TC_attach_timeout_after_pdp_act failing ...................................................................... Patch Set 2: (1 comment) File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33465/comment/a2f682ed_55af… PS2, Line 1078: vc_conn.done > Oh, this indeed looks like a bug. I gave this patch a try, and it fails due to `Tguard timeout` on my machine :/ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33465 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibaf2134247153471bd45d7a7f91155294c6c6de5 Gerrit-Change-Number: 33465 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jun 2023 16:42:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: pcu: Wait for USF before start using UL TBF
by pespin 26 Jun '23

26 Jun '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33466 ) Change subject: pcu: Wait for USF before start using UL TBF ...................................................................... pcu: Wait for USF before start using UL TBF Change-Id: Ibe8f8c24b239715c0a43d52e59475011e78cb4eb --- M pcu/GPRS_Components.ttcn M pcu/PCU_Tests.ttcn 2 files changed, 113 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/66/33466/1 diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn index a3e8c94..b4c6a6c 100644 --- a/pcu/GPRS_Components.ttcn +++ b/pcu/GPRS_Components.ttcn @@ -992,6 +992,36 @@ return; } +/* Handle groups of PKT NEIGHBOUR CELL DATA packets */ +function f_ms_wait_usf(inout GprsMS ms, template (value) TsTrxBtsNum nr := ts_TsTrxBtsNum) +runs on MS_BTS_IFACE_CT { + var BTS_PDTCH_Block data_msg; + + BTS.send(ts_PCUIF_RTS_REQ(nr.bts_nr, nr.trx_nr, nr.ts_nr, + sapi := PCU_IF_SAPI_PDTCH, fn := 0, + arfcn := f_trxnr2arfcn(valueof(nr.trx_nr)), + block_nr := nr.blk_nr)); + alt { + [] as_pcuif_rx_ignore_empty(nr); + [] BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr, + tr_PCUIF_DATA(nr.trx_nr, nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH), + ?)) -> value data_msg { + var uint3_t rx_usf := f_rlcmac_dl_block_get_usf(data_msg.dl_block); + var uint3_t exp_usf := ms.ul_tbf.usf[valueof(nr.ts_nr)]; + log("Rx DL block USF ", rx_usf, " vs exp USF ", exp_usf); + if (rx_usf != exp_usf) { + BTS.send(ts_PCUIF_RTS_REQ(nr.bts_nr, nr.trx_nr, nr.ts_nr, + sapi := PCU_IF_SAPI_PDTCH, fn := 0, + arfcn := f_trxnr2arfcn(valueof(nr.trx_nr)), + block_nr := nr.blk_nr)); + repeat; + } + } + }; + + return; +} + //////////////////////// // Low level APIs //////////////////////// diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index e485868..24f0efe 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -326,6 +326,9 @@ var RlcmacDlBlock dl_block; var uint32_t poll_fn; + /* Wait until PCU starts requesting for UL block on this TBF: */ + f_ms_wait_usf(g_ms[i]); + f_ms_tx_ul_data_block(g_ms[i], dummy, with_tlli := true, fn := g_ms[i].ul_tbf.start_time_fn, nr := nr); f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, poll_fn, nr := nr); } @@ -429,6 +432,9 @@ /* Establish an Uplink TBF */ f_ms_establish_ul_tbf(ms); + /* Wait until PCU starts requesting for UL block on this TBF: */ + f_ms_wait_usf(ms); + /* Send one UL block (with TLLI since we are in One-Phase Access contention resolution) and make sure it is ACKED fine */ f_ms_tx_ul_data_block_multi(ms, 1, with_tlli := true, fn := ms.ul_tbf.start_time_fn); @@ -531,6 +537,9 @@ /* Establish an Uplink TBF */ f_ms_establish_ul_tbf(ms); + /* Wait until PCU starts requesting for UL block on this TBF: */ + f_ms_wait_usf(ms); + /* In a busy network, there can be a significant delay between resource * allocation (Packet Uplink Assignment above) and the actual time when * the MS is allowed to transmit the first Uplink data block. */ @@ -825,6 +834,8 @@ /* Establish an Uplink TBF */ f_ms_establish_ul_tbf(ms); + /* Wait until PCU starts requesting for UL block on this TBF: */ + f_ms_wait_usf(ms); /* The actual / old link quality values. We need to keep track of the old * (basically previous) link quality value, because OsmoPCU actually @@ -917,6 +928,9 @@ /* Establish an Uplink TBF */ f_ms_establish_ul_tbf(ms); + /* Wait until PCU starts requesting for UL block on this TBF: */ + f_ms_wait_usf(ms); + /* Send one UL block (with TLLI since we are in One-Phase Access contention resolution) and make sure it is ACKED fine. */ /* 16 bytes fills the llc block (because TLLI takes 4 bytes) */ @@ -989,6 +1003,9 @@ /* Establish an Uplink TBF */ f_ms_establish_ul_tbf(ms); + /* Wait until PCU starts requesting for UL block on this TBF: */ + f_ms_wait_usf(ms); + /* Send one UL block (with TLLI since we are in One-Phase Access contention resolution) and make sure it is ACKED fine. */ /* 16 bytes fills the llc block (because TLLI takes 4 bytes) */ @@ -1602,6 +1619,9 @@ /* Establish an Uplink TBF */ f_ms_establish_ul_tbf(ms); + /* Wait until PCU starts requesting for UL block on this TBF: */ + f_ms_wait_usf(ms); + f_ms_tx_ul_data_block_multi(ms, 5, with_tlli := true); exp_ul_ack_sub := tr_UlAckNackGprs(*, tr_AckNackDescription('1'B), *); exp_ul_ack := tr_RLCMAC_UL_ACK_NACK_GPRS(ms.ul_tbf.tfi, exp_ul_ack_sub); @@ -2172,6 +2192,9 @@ /* Establish an Uplink TBF */ f_ms_establish_ul_tbf(ms); + /* Wait until PCU starts requesting for UL block on this TBF: */ + f_ms_wait_usf(ms); + /* Send one UL block (with TLLI since we are in One-Phase Access contention resolution) and make sure it is ACKED fine. */ total_payload := f_rnd_octstring(f_ultbf_payload_fill_length(ms.ul_tbf, true)); @@ -2223,6 +2246,9 @@ /* Establish an Uplink TBF */ f_ms_establish_ul_tbf(ms); + /* Wait until PCU starts requesting for UL block on this TBF: */ + f_ms_wait_usf(ms); + /* Send one UL block (with TLLI since we are in One-Phase Access contention resolution) and make sure it is ACKED fine. */ payload := f_rnd_octstring(16); /* 16 bytes fills the llc block (because TLLI takes 4 bytes) */ @@ -2358,6 +2384,9 @@ /* Establish an Uplink TBF */ f_ms_establish_ul_tbf(ms); + /* Wait until PCU starts requesting for UL block on this TBF: */ + f_ms_wait_usf(ms); + f_TC_ul_data_toolong_fills_padding_cs(ms, CS_2, 2); f_TC_ul_data_toolong_fills_padding_cs(ms, CS_3, 1); f_TC_ul_data_toolong_fills_padding_cs(ms, CS_4, 0); @@ -2391,6 +2420,9 @@ /* Establish an Uplink TBF */ f_ms_establish_ul_tbf(ms); + /* Wait until PCU starts requesting for UL block on this TBF: */ + f_ms_wait_usf(ms); + /* Send one UL block (with TLLI since we are in One-Phase Access contention resolution) and make sure it is ACKED fine */ f_ms_tx_ul_data_block_multi(ms, 1, with_tlli := true, fn := ms.ul_tbf.start_time_fn); @@ -2668,6 +2700,9 @@ f_ms_establish_ul_tbf(ms); tfi := ms.ul_tbf.tfi; + /* Wait until PCU starts requesting for UL block on this TBF: */ + f_ms_wait_usf(ms); + /* Send one UL block (with TLLI since we are in One-Phase Access contention resolution) and make sure it is ACKED fine. */ payload := f_rnd_octstring(f_ultbf_payload_fill_length(ms.ul_tbf, true)); /* 16 bytes fills the llc block (because TLLI takes 4 bytes) */ @@ -2884,6 +2919,9 @@ /* Establish an Uplink TBF */ f_ms_establish_ul_tbf(ms); + /* Wait until PCU starts requesting for UL block on this TBF: */ + f_ms_wait_usf(ms); + /* Summary of what's transmitted: * 1- UL RlcDataBlock(dataA) [BSN=0, CV=3] * 2- UL RlcDataBlock(dataA finished, dataB starts) [BSN=1, CV=2] @@ -3185,6 +3223,9 @@ through PDCH (no multiblock assignment possible through PCH) */ f_ms_establish_ul_tbf(ms); + /* Wait until PCU starts requesting for UL block on this TBF: */ + f_ms_wait_usf(ms); + /* Send one UL block (with TLLI since we are in One-Phase Access contention resolution) and make sure it is ACKED fine */ f_ms_tx_ul_data_block(ms, data, with_tlli := true, fn := ms.ul_tbf.start_time_fn, @@ -3330,6 +3371,9 @@ /* Establish an Uplink TBF */ f_ms_establish_ul_tbf(ms); + /* Wait until PCU starts requesting for UL block on this TBF: */ + f_ms_wait_usf(ms); + /* Send one UL block (with TLLI since we are in One-Phase Access contention resolution) and make sure it is ACKED fine */ f_ms_tx_ul_data_block_multi(ms, 1, with_tlli := true, fn := ms.ul_tbf.start_time_fn); @@ -3416,6 +3460,9 @@ /* Establish an Uplink TBF */ f_ms_establish_ul_tbf(ms); + /* Wait until PCU starts requesting for UL block on this TBF: */ + f_ms_wait_usf(ms); + /* Send one UL block (with TLLI since we are in One-Phase Access contention resolution) and make sure it is ACKED fine */ f_ms_tx_ul_data_block_multi(ms, 1, with_tlli := true, fn := ms.ul_tbf.start_time_fn); @@ -3580,6 +3627,9 @@ /* Establish an Uplink TBF */ f_ms_establish_ul_tbf(ms); + /* Wait until PCU starts requesting for UL block on this TBF: */ + f_ms_wait_usf(ms); + /* build mobile Identity */ mi := valueof(ts_MI_IMSI_LV(imsi)); mi_enc_lv := enc_MobileIdentityLV(mi); @@ -3624,6 +3674,9 @@ /* Establish an Uplink TBF */ f_ms_establish_ul_tbf(ms); + /* Wait until PCU starts requesting for UL block on this TBF: */ + f_ms_wait_usf(ms); + /* Send paging request with or without TMSI */ if (use_ptmsi) { tmsi := oct2int(f_rnd_octstring(4)); /* Random P-TMSI */ @@ -3786,6 +3839,9 @@ /* Establish an Uplink TBF */ f_ms_establish_ul_tbf(ms); + /* Wait until PCU starts requesting for UL block on this TBF: */ + f_ms_wait_usf(ms); + /* Fake GMM GPRS Attach or similar, PCU doesn't care about upper layers here */ f_ms_tx_ul_data_block_multi(ms, 1, with_tlli := true, fn := ms.ul_tbf.start_time_fn); f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, sched_fn); @@ -3845,6 +3901,9 @@ /* Establish an Uplink TBF */ f_ms_establish_ul_tbf(ms); + /* Wait until PCU starts requesting for UL block on this TBF: */ + f_ms_wait_usf(ms); + /* Fake GMM GPRS Attach or similar, PCU doesn't care about upper layers here */ f_ms_tx_ul_data_block_multi(ms, 1, with_tlli := true, fn := ms.ul_tbf.start_time_fn); f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, sched_fn); @@ -3960,6 +4019,9 @@ /* Establish an Uplink TBF */ f_ms_establish_ul_tbf(ms); + /* Wait until PCU starts requesting for UL block on this TBF: */ + f_ms_wait_usf(ms); + /* Send one UL block (with TLLI since we are in One-Phase Access contention resolution) and make sure it is ACKED fine. */ payload := f_rnd_octstring(f_ultbf_payload_fill_length(ms.ul_tbf, true)); @@ -4024,6 +4086,9 @@ /* Establish an Uplink TBF */ f_ms_establish_ul_tbf(ms); + /* Wait until PCU starts requesting for UL block on this TBF: */ + f_ms_wait_usf(ms); + /* Send one UL block (with TLLI since we are in One-Phase Access contention resolution) and make sure it is ACKED fine. */ payload := f_rnd_octstring(f_ultbf_payload_fill_length(ms.ul_tbf, true)); @@ -4048,6 +4113,9 @@ * The MS decides it want to send new Ul TBF so it send RACH req to ask for it: */ f_ms_establish_ul_tbf(ms); + /* Wait until PCU starts requesting for UL block on this TBF: */ + f_ms_wait_usf(ms); + /* Send one UL block (with TLLI since we are in One-Phase Access * contention resolution) and make sure it is ACKED fine. */ payload := f_rnd_octstring(f_ultbf_payload_fill_length(ms.ul_tbf, true)); @@ -4099,6 +4167,9 @@ /* Establish an Uplink TBF */ f_ms_establish_ul_tbf(ms); + /* Wait until PCU starts requesting for UL block on this TBF: */ + f_ms_wait_usf(ms); + /* Send one UL block (with TLLI since we are in One-Phase Access contention resolution) and make sure it is ACKED fine. */ payload := f_rnd_octstring(f_ultbf_payload_fill_length(ms.ul_tbf, true)); @@ -4692,6 +4763,9 @@ /* Establish an Uplink TBF */ f_ms_establish_ul_tbf(ms); + /* Wait until PCU starts requesting for UL block on this TBF: */ + f_ms_wait_usf(ms); + /* Send an Uplink block, so this TBF becomes "active" */ f_ms_tx_ul_data_block(ms, data, with_tlli := true, fn := ms.ul_tbf.start_time_fn); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33466 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibe8f8c24b239715c0a43d52e59475011e78cb4eb Gerrit-Change-Number: 33466 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bts[master]: osmo-bts-sysmo: mute PHY until OML is ready
by pespin 26 Jun '23

26 Jun '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33457 ) Change subject: osmo-bts-sysmo: mute PHY until OML is ready ...................................................................... Patch Set 8: (1 comment) File src/osmo-bts-sysmo/l1_if.c: https://gerrit.osmocom.org/c/osmo-bts/+/33457/comment/e1a013dd_12f608a6 PS7, Line 1271: oml_mo_rf_lock_chg(&trx->mo, fl1h->last_rf_mute, 0); > > did you check this is not sending StateChg before SW_ACT OML messages are sent? […] I meant call to the oml_mo_rf_lock_chg() function, which also happens in the success case. IIUC without looking in detail that should trigger a StateChg message on OML. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33457 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia1769f952fa787202a442a33db5ed4a1f7cbe9c3 Gerrit-Change-Number: 33457 Gerrit-PatchSet: 8 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jun 2023 16:21:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: osmo-bts-sysmo/l1_if: move mute_rf_compl_cb up
by pespin 26 Jun '23

26 Jun '23

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33463 ) Change subject: osmo-bts-sysmo/l1_if: move mute_rf_compl_cb up ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33463 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I19dbfbd595d3b42c0634a4c38e39cdb314a54266 Gerrit-Change-Number: 33463 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jun 2023 16:20:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: WIP: sgsn: Fix TC_attach_timeout_after_pdp_act failing
by fixeria 26 Jun '23

26 Jun '23

Attention is currently required from: arehbein. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33465 ) Change subject: WIP: sgsn: Fix TC_attach_timeout_after_pdp_act failing ...................................................................... Patch Set 2: (2 comments) File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33465/comment/10964bef_8b9c… PS2, Line 1067: setverdict(pass) There is already `setverdict(pass)` below, this one is redundant. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33465/comment/997b7833_1934… PS2, Line 1078: vc_conn.done Oh, this indeed looks like a bug. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33465 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibaf2134247153471bd45d7a7f91155294c6c6de5 Gerrit-Change-Number: 33465 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jun 2023 16:01:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: osmo-bts-sysmo: mute PHY until OML is ready
by osmith 26 Jun '23

26 Jun '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33457 ) Change subject: osmo-bts-sysmo: mute PHY until OML is ready ...................................................................... Patch Set 8: (1 comment) File src/osmo-bts-sysmo/l1_if.c: https://gerrit.osmocom.org/c/osmo-bts/+/33457/comment/2470eae4_d2b2e7fe PS6, Line 1305: int trx_rf_lock(struct gsm_bts_trx *trx, int locked, l1if_compl_cb *cb); > https://gerrit.osmocom. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33457 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia1769f952fa787202a442a33db5ed4a1f7cbe9c3 Gerrit-Change-Number: 33457 Gerrit-PatchSet: 8 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jun 2023 16:00:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-python-tests[master]: scripts/osmotestconfig.py: Fix tests failing due to attempted copy on...
by neels 26 Jun '23

26 Jun '23

Attention is currently required from: arehbein, fixeria, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/30980 ) Change subject: scripts/osmotestconfig.py: Fix tests failing due to attempted copy on socket files ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: ah, arehbein, you added a "Code Review +1", I was talking about a "Verified +1". You can remove your CR+1 and add a V+1 instead -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/30980 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: I3a3cc7ed135b60b97eb901cfc20fdcb924e4f664 Gerrit-Change-Number: 30980 Gerrit-PatchSet: 5 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jun 2023 15:59:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: lint: typedefs_osmo: add l1if_compl_cb
by osmith 26 Jun '23

26 Jun '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/33464 ) Change subject: lint: typedefs_osmo: add l1if_compl_cb ...................................................................... lint: typedefs_osmo: add l1if_compl_cb Fix for: > need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Related: https://gerrit.osmocom.org/c/osmo-bts/+/33457/7/src/osmo-bts-sysmo/l1_if.c#… Change-Id: If045d1734e918af9ce1e5c37cbd305deab848b56 --- M lint/checkpatch/typedefs_osmo.txt 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/lint/checkpatch/typedefs_osmo.txt b/lint/checkpatch/typedefs_osmo.txt index 48b42bc..1dae49a 100644 --- a/lint/checkpatch/typedefs_osmo.txt +++ b/lint/checkpatch/typedefs_osmo.txt @@ -1,3 +1,4 @@ A_SEQUENCE_OF A_SET_OF +l1if_compl_cb ranap_message -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/33464 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If045d1734e918af9ce1e5c37cbd305deab848b56 Gerrit-Change-Number: 33464 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ci[master]: lint: typedefs_osmo: add l1if_compl_cb
by osmith 26 Jun '23

26 Jun '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/33464 ) Change subject: lint: typedefs_osmo: add l1if_compl_cb ...................................................................... Patch Set 2: Code-Review+2 (2 comments) Patchset: PS1: > a bit of explanation why is this needed would be welcome. Done Patchset: PS2: merging, this is trivial and comments are addressed -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/33464 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If045d1734e918af9ce1e5c37cbd305deab848b56 Gerrit-Change-Number: 33464 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jun 2023 15:58:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0