June 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: lint: typedefs_osmo: add l1if_compl_cb
by pespin 26 Jun '23

26 Jun '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/33464 ) Change subject: lint: typedefs_osmo: add l1if_compl_cb ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: a bit of explanation why is this needed would be welcome. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/33464 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If045d1734e918af9ce1e5c37cbd305deab848b56 Gerrit-Change-Number: 33464 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jun 2023 15:25:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: osmo-bts-sysmo: mute PHY until OML is ready
by pespin 26 Jun '23

26 Jun '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33457 ) Change subject: osmo-bts-sysmo: mute PHY until OML is ready ...................................................................... Patch Set 7: Code-Review+1 (1 comment) File src/osmo-bts-sysmo/l1_if.c: https://gerrit.osmocom.org/c/osmo-bts/+/33457/comment/9b71c9e0_b4ff5f60 PS7, Line 1271: oml_mo_rf_lock_chg(&trx->mo, fl1h->last_rf_mute, 0); did you check this is not sending StateChg before SW_ACT OML messages are sent? How does it look right now? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33457 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia1769f952fa787202a442a33db5ed4a1f7cbe9c3 Gerrit-Change-Number: 33457 Gerrit-PatchSet: 7 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jun 2023 15:24:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: osmo-bts-sysmo/l1_if: move mute_rf_compl_cb up
by pespin 26 Jun '23

26 Jun '23

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33463 ) Change subject: osmo-bts-sysmo/l1_if: move mute_rf_compl_cb up ...................................................................... Patch Set 2: (1 comment) File src/osmo-bts-sysmo/l1_if.c: https://gerrit.osmocom.org/c/osmo-bts/+/33463/comment/07727ca8_aa12311d PS2, Line 1423: int l1if_mute_rf(struct femtol1_hdl *hdl, uint8_t mute[8], l1if_compl_cb *cb) You should move l1if_mute_rf too in order to stay in the same place relative to mute_rf_compl_cb(). -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33463 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I19dbfbd595d3b42c0634a4c38e39cdb314a54266 Gerrit-Change-Number: 33463 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jun 2023 15:20:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: osmo-bts-sysmo: mute PHY until OML is ready
by Jenkins Builder 26 Jun '23

26 Jun '23

Attention is currently required from: osmith, pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33457 ) Change subject: osmo-bts-sysmo: mute PHY until OML is ready ...................................................................... Patch Set 7: (1 comment) File src/osmo-bts-sysmo/l1_if.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-8606): https://gerrit.osmocom.org/c/osmo-bts/+/33457/comment/7c9eb9b0_4727a459 PS7, Line 1307: int trx_rf_lock(struct gsm_bts_trx *trx, int locked, l1if_compl_cb *cb); need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33457 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia1769f952fa787202a442a33db5ed4a1f7cbe9c3 Gerrit-Change-Number: 33457 Gerrit-PatchSet: 7 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jun 2023 15:17:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: osmo-bts-sysmo: mute PHY until OML is ready
by osmith 26 Jun '23

26 Jun '23

Attention is currently required from: osmith, pespin. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/33457 to look at the new patch set (#7). Change subject: osmo-bts-sysmo: mute PHY until OML is ready ...................................................................... osmo-bts-sysmo: mute PHY until OML is ready Connecting to OML and PHY is done in parallel. The PHY connection will always be done first, mute PHY until OML is also ready. As Pau suggested, move dispatch of NM_EV_SW_ACT to a callback of trx_rf_lock to have the events serialized and therefore deterministic. Fixes: SYS#6496 Change-Id: Ia1769f952fa787202a442a33db5ed4a1f7cbe9c3 --- M src/osmo-bts-sysmo/l1_if.c M src/osmo-bts-sysmo/oml.c 2 files changed, 38 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/57/33457/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33457 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia1769f952fa787202a442a33db5ed4a1f7cbe9c3 Gerrit-Change-Number: 33457 Gerrit-PatchSet: 7 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-bts[master]: osmo-bts-sysmo: mute PHY until OML is ready
by osmith 26 Jun '23

26 Jun '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33457 ) Change subject: osmo-bts-sysmo: mute PHY until OML is ready ...................................................................... Patch Set 6: (1 comment) File src/osmo-bts-sysmo/l1_if.c: https://gerrit.osmocom.org/c/osmo-bts/+/33457/comment/52cafb18_0b25c582 PS6, Line 1305: int trx_rf_lock(struct gsm_bts_trx *trx, int locked, l1if_compl_cb *cb); https://gerrit.osmocom.org/c/osmo-ci/+/33464 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33457 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia1769f952fa787202a442a33db5ed4a1f7cbe9c3 Gerrit-Change-Number: 33457 Gerrit-PatchSet: 6 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jun 2023 15:11:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-dev[master]: net/templates/run.sh: fix BSC_COUNT check
by osmith 26 Jun '23

26 Jun '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/33460 ) Change subject: net/templates/run.sh: fix BSC_COUNT check ...................................................................... net/templates/run.sh: fix BSC_COUNT check Use ${BSC_COUNT} instead of $BSC_COUNT, as otherwise the template code doesn't replace the variable. Without this patch it always went into the else code path. Change-Id: I2b880a8da51f96c16fb56d9d6e3994ecc1b47ae7 --- M net/templates/run.sh 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved osmith: Verified diff --git a/net/templates/run.sh b/net/templates/run.sh index 1954cfb..d4edbaa 100755 --- a/net/templates/run.sh +++ b/net/templates/run.sh @@ -244,7 +244,7 @@ term "${CMD_HNBGW}" HNBGW -if [ "$BSC_COUNT" = 1 ]; then +if [ "${BSC_COUNT}" = 1 ]; then term "${CMD_MGW} -c osmo-mgw-for-bsc-0.cfg" MGW4BSC term "${CMD_BSC} -c osmo-bsc-0.cfg" BSC else -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/33460 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I2b880a8da51f96c16fb56d9d6e3994ecc1b47ae7 Gerrit-Change-Number: 33460 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-dev[master]: net/templates/osmo-msc.conf: modernize
by osmith 26 Jun '23

26 Jun '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/33459 ) Change subject: net/templates/osmo-msc.conf: modernize ...................................................................... net/templates/osmo-msc.conf: modernize * Write explicit role & sctp-role fields in ASP * Use new mgw node Change-Id: Id77a579ff9315f2c6bf9d7f6d80b4b022e8d4963 --- M net/templates/osmo-msc.cfg 1 file changed, 18 insertions(+), 3 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved osmith: Verified diff --git a/net/templates/osmo-msc.cfg b/net/templates/osmo-msc.cfg index c018c78..166d408 100644 --- a/net/templates/osmo-msc.cfg +++ b/net/templates/osmo-msc.cfg @@ -3,6 +3,8 @@ point-code ${MSC_PC} asp asp-clnt-msc-0 2905 0 m3ua remote-ip ${STP_CN_IP} + role asp + sctp-role client network network country code ${MCC} mobile network code ${MNC} @@ -11,11 +13,12 @@ short name 35c3 long name 35c3 mm info 1 + mgw 0 + remote-ip ${MGW4MSC_IP} + remote-port ${MGW4MSC_PORT} + endpoint-domain msc msc mncc ${MSC_MNCC} - mgw remote-ip ${MGW4MSC_IP} - mgw remote-port ${MGW4MSC_PORT} - mgw endpoint-domain msc check-imei-rqd 1 # For nano3G: iu rab-assign-addr-enc x213 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/33459 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Id77a579ff9315f2c6bf9d7f6d80b4b022e8d4963 Gerrit-Change-Number: 33459 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-dev[master]: net/templates/run: fix prompts not working
by osmith 26 Jun '23

26 Jun '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/33458 ) Change subject: net/templates/run: fix prompts not working ...................................................................... net/templates/run: fix prompts not working Reset the terminal after tmux new-window and after killing programs during shutdown. Otherwise with tmux 3.2a the input prompts do not work. Change-Id: I7f14c364637f82699a5b935637222d5da977d67d --- M net/templates/run.sh 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved osmith: Verified diff --git a/net/templates/run.sh b/net/templates/run.sh index 6b8a324..1954cfb 100755 --- a/net/templates/run.sh +++ b/net/templates/run.sh @@ -141,6 +141,7 @@ case "$terminal" in tmux) tmux new-window -d -n "$title" "$launcher &; echo \$! > $pidfile_term; wait" + stty sane ;; *) sleep .2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/33458 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I7f14c364637f82699a5b935637222d5da977d67d Gerrit-Change-Number: 33458 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-dev[master]: net/config_2g3g: set a valid BTS1_ARFCN
by osmith 26 Jun '23

26 Jun '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/33461 ) Change subject: net/config_2g3g: set a valid BTS1_ARFCN ...................................................................... net/config_2g3g: set a valid BTS1_ARFCN Even if only one BTS is used, both ARFCNs are written to the osmo-bsc config and osmo-bsc refuses to start up if there is an invalid ARFCN. Change-Id: I569b407736713cefd46a1c927d9ee85f91332553 --- M net/config_2g3g 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved osmith: Verified diff --git a/net/config_2g3g b/net/config_2g3g index 8cf642d..21a2772 100644 --- a/net/config_2g3g +++ b/net/config_2g3g @@ -46,7 +46,7 @@ BTS1_DESCRIPTION="my test BTS 1" BTS1_IPA_UNIT="1 0" -BTS1_ARFCN=125 +BTS1_ARFCN=512 BTS1_CI=${BTSn} BTS1_BSIC=${BTSn} BTS1_GPRS_MODE=gprs -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/33461 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I569b407736713cefd46a1c927d9ee85f91332553 Gerrit-Change-Number: 33461 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0