June 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-pcu[master]: Derive FN from RFN once and cache it in struct rach_ind_params
by pespin 01 Jun '23

01 Jun '23

Attention is currently required from: pespin. Hello Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/33121 to look at the new patch set (#3). Change subject: Derive FN from RFN once and cache it in struct rach_ind_params ...................................................................... Derive FN from RFN once and cache it in struct rach_ind_params Change-Id: Iaefb9650dfc5083360a4a24b9c17fdbf3115e51f --- M src/bts.cpp M src/bts.h M src/pcu_l1_if.cpp M tests/tbf/TbfTest.cpp 4 files changed, 15 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/21/33121/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33121 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iaefb9650dfc5083360a4a24b9c17fdbf3115e51f Gerrit-Change-Number: 33121 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-pcu[master]: Use fn_valid() helper in pcu_rx_time_ind()
by pespin 01 Jun '23

01 Jun '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33138 ) Change subject: Use fn_valid() helper in pcu_rx_time_ind() ...................................................................... Use fn_valid() helper in pcu_rx_time_ind() Change-Id: I5b1f1d4cd621d81fb99b87761a878af242227a10 --- M src/pcu_l1_if.cpp 1 file changed, 10 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/38/33138/1 diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp index e675d86..3f881cf 100644 --- a/src/pcu_l1_if.cpp +++ b/src/pcu_l1_if.cpp @@ -1036,10 +1036,8 @@ static int pcu_rx_time_ind(struct gprs_rlcmac_bts *bts, struct gsm_pcu_if_time_ind *time_ind) { - uint8_t fn13 = time_ind->fn % 13; - /* omit frame numbers not starting at a MAC block */ - if (fn13 != 0 && fn13 != 4 && fn13 != 8) + if (!fn_valid(time_ind->fn)) return 0; LOGP(DL1IF, LOGL_DEBUG, "Time indication received: %d\n", time_ind->fn % 52); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33138 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I5b1f1d4cd621d81fb99b87761a878af242227a10 Gerrit-Change-Number: 33138 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests.TC_pcu_data_ind_lqual_cb: log lqual values
by fixeria 01 Jun '23

01 Jun '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33107 ) Change subject: BTS_Tests.TC_pcu_data_ind_lqual_cb: log lqual values ...................................................................... BTS_Tests.TC_pcu_data_ind_lqual_cb: log lqual values Change-Id: Ia8cb340005b58331e1e032a53c0a93163a517fb0 Related: OS#5954 --- M bts/BTS_Tests.ttcn 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index b1af138..817db71 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -5949,6 +5949,7 @@ ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, ts_TRXC_FAKE_CI(i)); /* FIXME: OsmoBTS may have different threshold (see MIN_QUAL_NORM) */ + log("Testing C/I=", i, " cB"); f_TC_pcu_data_ind_lqual_cb(i, thresh := 0); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33107 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia8cb340005b58331e1e032a53c0a93163a517fb0 Gerrit-Change-Number: 33107 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-ttcn3-hacks[master]: BTS_Tests.TC_pcu_data_ind_lqual_cb: properly send UL BLOCK.req
by fixeria 01 Jun '23

01 Jun '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33108 ) Change subject: BTS_Tests.TC_pcu_data_ind_lqual_cb: properly send UL BLOCK.req ...................................................................... BTS_Tests.TC_pcu_data_ind_lqual_cb: properly send UL BLOCK.req We must be using a valid TDMA Fn when scheduling UL BLOCK.req, so wait for a DL BLOCK.ind, take the current Fn from there and calculate a proper TDMA Fn for the next UL block. Change-Id: If0fb615a4136a76a939588af0131ddcfb7acd877 Related: OS#5954 --- M bts/BTS_Tests.ttcn 1 file changed, 79 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 817db71..344be1f 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -5326,6 +5326,66 @@ } } +/* Catch a L1CTL DL BLOCK.ind with the given parameters */ +private altstep as_l1ctl_dl_block_ind(out L1ctlGprsDlBlockInd block_ind, + template (present) GsmFrameNumber fn := ?, + template (present) uint3_t tn := ?, + template (present) uint3_t usf := ?, + template (present) octetstring data := ?) +runs on test_CT { + var L1ctlMessage l1_dl; + + [] L1CTL.receive(tr_L1CTL_GPRS_DL_BLOCK_IND(fn, tn, usf, data)) -> value l1_dl { + block_ind := l1_dl.payload.dl_block_ind; + } +} + +/* tuple of TDMA frame number and timeslot number */ +private type record TdmaFnTn { + GsmFrameNumber fn, + uint3_t tn +} + +/* Wait for a L1CTL DL BLOCK.ind and send an UL BLOCK.req */ +private function f_TC_pcu_tx_ul_block_req(octetstring data, + template (present) uint3_t tn := ?, + template (present) uint3_t usf := ?) +runs on test_CT return TdmaFnTn { + var L1ctlGprsDlBlockInd block_ind; + timer T; + + T.start(1.0); + alt { + [] as_l1ctl_dl_block_ind(block_ind, tn := tn, usf := usf) { + var integer fn := block_ind.hdr.fn; + + /* Ignore PTCCH/D blocks, their Fn is too far away */ + if (fn mod 104 == 12) { + repeat; + } + + /* Every fn % 13 == 12 we have either a PTCCH or an IDLE slot, thus + * every fn % 13 == 8 we add 5 frames, or 4 frames othrwise. The + * resulting value is first fn of the next block. */ + if (fn mod 13 == 8) { + fn := (fn + 5) mod (2048 * 51 * 26); + } else { + fn := (fn + 4) mod (2048 * 51 * 26); + } + + L1CTL.send(ts_L1CTL_GPRS_UL_BLOCK_REQ(fn, block_ind.hdr.tn, data)); + return {fn, block_ind.hdr.tn}; + } + [] L1CTL.receive { repeat; } + [] T.timeout { + setverdict(fail, "Timeout waiting for DL BLOCK.ind (RTS)"); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); + } + } + + return {0, 0}; /* make TITAN happy */ +} + /* Tune the L1 to PDCH on the given timeslot number */ private function f_TC_pcu_l1ctl_est_pdch(uint3_t tn) runs on test_CT { var ConnHdlrPars pars := valueof(t_Pars(ts_RslChanNr_PDCH(tn), ts_RSL_ChanMode_SIGN)); @@ -5890,9 +5950,11 @@ var int16_t lqual_cb; timer T := 1.0; - /* Send a random PDTCH frame over Um - * FIXME: we need to wait for a DL block and user Fn from there. */ - L1CTL.send(ts_L1CTL_GPRS_UL_BLOCK_REQ(0, 7, '0000'O & f_rnd_octstring(21))); + L1CTL.clear; + PCU.clear; + + /* Send a random Uplink block over the Um */ + f_TC_pcu_tx_ul_block_req('0000'O & f_rnd_octstring(21), tn := 7); T.start; alt { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If0fb615a4136a76a939588af0131ddcfb7acd877 Gerrit-Change-Number: 33108 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-ttcn3-hacks[master]: BTS_Tests: cosmetic: add as_pcuif_msg() for convenience
by fixeria 01 Jun '23

01 Jun '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33106 ) Change subject: BTS_Tests: cosmetic: add as_pcuif_msg() for convenience ...................................................................... BTS_Tests: cosmetic: add as_pcuif_msg() for convenience This altstep eliminates the need to wrap the actual PCUIF message template into another (port specific) template t_SD_PCUIF. Change-Id: Iabefddd54a4a2e2183feea04fdb8526e74efc7ac --- M bts/BTS_Tests.ttcn 1 file changed, 80 insertions(+), 59 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 8d02c40..b1af138 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -5315,6 +5315,17 @@ * PCU Socket related tests ***********************************************************************/ +/* Catch a PCUIF message (without having to use t_SD_PCUIF) */ +private altstep as_pcuif_msg(out PCUIF_Message msg, + template (present) PCUIF_Message tr_msg := ?) +runs on test_CT { + var PCUIF_send_data sd; + + [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_msg)) -> value sd { + msg := sd.data; + } +} + /* Tune the L1 to PDCH on the given timeslot number */ private function f_TC_pcu_l1ctl_est_pdch(uint3_t tn) runs on test_CT { var ConnHdlrPars pars := valueof(t_Pars(ts_RslChanNr_PDCH(tn), ts_RSL_ChanMode_SIGN)); @@ -5326,12 +5337,13 @@ /* Verify no RTS before ACT_REQ; verify RTS after ACT_REQ */ friend function f_TC_pcu_act_req(uint8_t bts_nr, uint8_t trx_nr, uint8_t ts_nr, boolean exp_success) runs on test_CT { + var PCUIF_Message msg; timer T := 3.0; /* we don't expect any RTS.req before PDCH are active */ T.start; alt { - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_RTS_REQ(bts_nr))) { + [] as_pcuif_msg(msg, tr_PCUIF_RTS_REQ(bts_nr)) { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "PCU RTS.req before PDCH active?"); } [] PCU.receive { repeat; } @@ -5344,14 +5356,13 @@ /* we now expect RTS.req for this timeslot (only) */ T.start; alt { - [exp_success] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_RTS_REQ(bts_nr, trx_nr, ts_nr))) { + [exp_success] as_pcuif_msg(msg, tr_PCUIF_RTS_REQ(bts_nr, trx_nr, ts_nr)) { setverdict(pass); } - [not exp_success] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, - tr_PCUIF_RTS_REQ(bts_nr, trx_nr, ts_nr))) { + [not exp_success] as_pcuif_msg(msg, tr_PCUIF_RTS_REQ(bts_nr, trx_nr, ts_nr)) { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Unexpected RTS.req for supposedly failing activation"); } - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_RTS_REQ)) { + [] as_pcuif_msg(msg, tr_PCUIF_RTS_REQ) { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "RTS.req for wrong TRX/TS"); } [] PCU.receive { repeat; } @@ -5367,6 +5378,7 @@ /* verify no more RTS after DEACT_REQ */ friend function f_TC_pcu_deact_req(uint8_t bts_nr, uint8_t trx_nr, uint8_t ts_nr) runs on test_CT { + var PCUIF_Message msg; timer T := 3.0; /* Send PDCH activate request for known PDCH timeslot */ @@ -5378,7 +5390,7 @@ /* we now expect no RTS.req for this timeslot */ T.start; alt { - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_RTS_REQ(bts_nr, trx_nr, ts_nr))) { + [] as_pcuif_msg(msg, tr_PCUIF_RTS_REQ(bts_nr, trx_nr, ts_nr)) { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Received unexpected PCU RTS.req"); } [] PCU.receive { repeat; } @@ -5443,8 +5455,9 @@ /* Test the PCU->BTS Version and BTS->PCU SI13 handshake */ function f_TC_pcu_ver_siXX(octetstring si, RSL_IE_SysinfoType rsl_si_type) runs on test_CT { - var PCUIF_send_data sd; - timer T:= 3.0; + var PCUIF_Message msg; + timer T := 3.0; + f_init_with_pcuif(); /* Set SI13 via RSL */ @@ -5452,8 +5465,8 @@ T.start; alt { - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_DATA_IND(0, 0, 0, ?, PCU_IF_SAPI_BCCH))) -> value sd { - if (substr(sd.data.u.data_ind.data, 0, lengthof(si)) == si) { + [] as_pcuif_msg(msg, tr_PCUIF_DATA_IND(0, 0, 0, sapi := PCU_IF_SAPI_BCCH)) { + if (substr(msg.u.data_ind.data, 0, lengthof(si)) == si) { setverdict(pass); } else { repeat; @@ -5500,15 +5513,14 @@ PCUIF_Sapi sapi, octetstring data) runs on test_CT { - var PCUIF_send_data sd; - + var PCUIF_Message msg; timer T := 3.0; + T.start; alt { - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, - tr_PCUIF_RTS_REQ(bts_nr, trx_nr, ts_nr, sapi))) -> value sd { - f_pcu_data_req(bts_nr, trx_nr, ts_nr, sd.data.u.rts_req.block_nr, - sd.data.u.rts_req.fn, sapi, data); + [] as_pcuif_msg(msg, tr_PCUIF_RTS_REQ(bts_nr, trx_nr, ts_nr, sapi)) { + f_pcu_data_req(bts_nr, trx_nr, ts_nr, msg.u.rts_req.block_nr, + msg.u.rts_req.fn, sapi, data); } [] PCU.receive { repeat; } [] T.timeout { @@ -5638,7 +5650,7 @@ private function f_TC_pcu_ptcch_ul(uint16_t ra) runs on test_CT { var template PCUIF_Message pcu_rach_ind; - var PCUIF_send_data sd; + var PCUIF_Message msg; var GsmFrameNumber fn; timer T; @@ -5653,8 +5665,8 @@ /* Expect a RACH.ind on the PCU interface (timeout is one multi-frame) */ T.start(52.0 * 4.615 / 1000.0); alt { - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, pcu_rach_ind)) -> value sd { - log("Rx an Access Burst on the PCU interface: ", sd.data); + [] as_pcuif_msg(msg, pcu_rach_ind) { + log("Rx an Access Burst on the PCU interface: ", msg); setverdict(pass); T.stop; } @@ -5787,6 +5799,7 @@ var GsmFrameNumber fn_last := 0; for (var integer i := 0; i < 1000; i := i+1) { + var PCUIF_Message msg; var OCT1 ra := f_rnd_ra_ps(); var GsmFrameNumber fn := f_L1CTL_RACH(L1CTL, oct2int(ra)); if (fn == fn_last) { @@ -5797,10 +5810,10 @@ timer T := 2.0; T.start; alt { - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_RACH_IND(0, 0, 0, oct2int(ra), 0, ?, fn))) { + [] as_pcuif_msg(msg, tr_PCUIF_RACH_IND(0, 0, 0, oct2int(ra), 0, ?, fn)) { T.stop; } - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_RACH_IND)) { + [] as_pcuif_msg(msg, tr_PCUIF_RACH_IND) { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Unexpected RACH IND"); } [] PCU.receive { repeat; } @@ -5819,7 +5832,7 @@ var GsmFrameNumber fn_last := 0; var L1ctlRachSynchSeq synch_seq; var PCUIF_BurstType pcu_bt; - var GsmFrameNumber fn; + var GsmFrameNumber fn var BIT11 ra11; f_init_with_pcuif(); @@ -5852,13 +5865,14 @@ burst_type := pcu_bt, fn := fn); + var PCUIF_Message msg; timer T := 2.0; T.start; alt { - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, pcu_rach_ind)) { + [] as_pcuif_msg(msg, pcu_rach_ind) { T.stop; } - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_RACH_IND)) { + [] as_pcuif_msg(msg, tr_PCUIF_RACH_IND) { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Unexpected RACH IND"); } [] PCU.receive { repeat; } @@ -5872,14 +5886,10 @@ private function f_TC_pcu_data_ind_lqual_cb(int16_t lqual_cb_exp, int16_t thresh) runs on test_CT { - var template PCUIF_send_data sdt; - var PCUIF_send_data sd; + var PCUIF_Message msg; var int16_t lqual_cb; timer T := 1.0; - /* PCUIF_DATA.ind is encapsulated into a supplementary record */ - sdt := t_SD_PCUIF_MSGT(g_pcu_conn_id, PCU_IF_MSG_DATA_IND); - /* Send a random PDTCH frame over Um * FIXME: we need to wait for a DL block and user Fn from there. */ L1CTL.send(ts_L1CTL_GPRS_UL_BLOCK_REQ(0, 7, '0000'O & f_rnd_octstring(21))); @@ -5887,8 +5897,8 @@ T.start; alt { /* If expected link quality is above the threshold */ - [lqual_cb_exp >= thresh] PCU.receive(sdt) -> value sd { - lqual_cb := sd.data.u.data_ind.lqual_cb; + [lqual_cb_exp >= thresh] as_pcuif_msg(msg, tr_PCUIF_DATA_IND) { + lqual_cb := msg.u.data_ind.lqual_cb; log("Rx PCUIF_DATA.ind (lqual_cb=", lqual_cb, ")"); /* Make sure the actual link quality matches the expected value */ @@ -5900,9 +5910,9 @@ } } /* If expected link quality is below the threshold */ - [lqual_cb_exp < thresh] PCU.receive(sdt) -> value sd { + [lqual_cb_exp < thresh] as_pcuif_msg(msg, tr_PCUIF_DATA_IND) { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, - log2str("Rx unexpected PCUIF_DATA.ind: ", sd.data)); + log2str("Rx unexpected PCUIF_DATA.ind: ", msg)); } /* Ignore PCUIF_RTS.req and PCUIF_TIME.ind */ [] PCU.receive { repeat; } @@ -5951,6 +5961,7 @@ var MobileIdentityLV mi_lv; var octetstring mi_lv_enc; var MobileIdentityV mi; + var PCUIF_Message msg; timer T := 3.0; if (i < 50) { @@ -5968,9 +5979,9 @@ RSL_CCHAN.send(ts_ASP_RSL_UD(ts_RSL_PAGING_CMD(mi, i mod 4))); T.start; alt { - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_PAG_REQ(0, mi_lv_enc))) { + [] as_pcuif_msg(msg, tr_PCUIF_PAG_REQ(0, mi_lv_enc)) { } - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_PAG_REQ)) { + [] as_pcuif_msg(msg, tr_PCUIF_PAG_REQ) { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Unexpected PAGING REQ"); } [] PCU.receive { repeat; } @@ -5984,10 +5995,10 @@ /* test for periodic TIME_IND; check number of FN expired and number of TIME_IND within frames */ testcase TC_pcu_time_ind() runs on test_CT { - var PCUIF_send_data pcu_sd; var integer num_time_ind := 0; var integer first_fn, last_fn; var float test_duration := 5.0; + var PCUIF_Message msg; timer T; f_init_with_pcuif(); @@ -5996,16 +6007,16 @@ PCU.clear; T.start(test_duration); alt { - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_TIME_IND(0, ?))) -> value pcu_sd { + [] as_pcuif_msg(msg, tr_PCUIF_TIME_IND(0, ?)) { num_time_ind := num_time_ind + 1; if (not isbound(first_fn)) { - first_fn := pcu_sd.data.u.time_ind.fn; + first_fn := msg.u.time_ind.fn; } - last_fn := pcu_sd.data.u.time_ind.fn; + last_fn := msg.u.time_ind.fn; repeat; } - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_TIME_IND(?, ?))) -> value pcu_sd { - setverdict(fail, "Received unexpected PCUIF_TIME_IND: ", pcu_sd.data); + [] as_pcuif_msg(msg, tr_PCUIF_TIME_IND(?, ?)) { + setverdict(fail, "Received unexpected PCUIF_TIME_IND: ", msg); repeat; } [] PCU.receive { @@ -6037,11 +6048,11 @@ /* test for periodic RTS_REQ; check number of FN expired and number of RTS_IND per SAPI */ testcase TC_pcu_rts_req() runs on test_CT { - var PCUIF_send_data pcu_sd; var integer first_fn, last_fn; var integer num_rts_pdtch := 0; var integer num_rts_ptcch := 0; var float test_duration := 5.0; + var PCUIF_Message msg; timer T; f_init_with_pcuif(); @@ -6050,26 +6061,24 @@ PCU.clear; T.start(test_duration); alt { - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_RTS_REQ(0, 0, 7, PCU_IF_SAPI_PDTCH, ?, ?))) - -> value pcu_sd { + [] as_pcuif_msg(msg, tr_PCUIF_RTS_REQ(0, 0, 7, PCU_IF_SAPI_PDTCH, ?, ?)) { num_rts_pdtch := num_rts_pdtch + 1; if (not isbound(first_fn)) { - first_fn := pcu_sd.data.u.rts_req.fn; + first_fn := msg.u.rts_req.fn; } - last_fn := pcu_sd.data.u.rts_req.fn; + last_fn := msg.u.rts_req.fn; repeat; } - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_RTS_REQ(0, 0, 7, PCU_IF_SAPI_PTCCH, ?, ?))) - -> value pcu_sd { + [] as_pcuif_msg(msg, tr_PCUIF_RTS_REQ(0, 0, 7, PCU_IF_SAPI_PTCCH, ?, ?)) { num_rts_ptcch := num_rts_ptcch + 1; if (not isbound(first_fn)) { - first_fn := pcu_sd.data.u.rts_req.fn; + first_fn := msg.u.rts_req.fn; } - last_fn := pcu_sd.data.u.rts_req.fn; + last_fn := msg.u.rts_req.fn; repeat; } - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_RTS_REQ)) -> value pcu_sd { - setverdict(fail, "Received unexpected PCUIF_RTS_REQ: ", pcu_sd.data); + [] as_pcuif_msg(msg, tr_PCUIF_RTS_REQ) { + setverdict(fail, "Received unexpected PCUIF_RTS_REQ: ", msg); repeat; } [] PCU.receive { @@ -6540,7 +6549,7 @@ var template PCUIF_Message tr_interf_ind; var integer interf_ind_num := 0; var boolean first := true; - var PCUIF_send_data sd; + var PCUIF_Message msg; timer T; /* Set the averaging/reporting period to 480ms */ @@ -6566,25 +6575,25 @@ T.start(0.480 * 1.5); alt { /* The first interference report may contain unreliable values, so we ignore it */ - [first] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_INTERF_IND(0, 0))) { + [first] as_pcuif_msg(msg, tr_PCUIF_INTERF_IND(0, 0)) { /* 4 SACCH periods => 4 reports (plus some guard time) */ T.start(0.480 * 4.0 + 0.480 / 2.0); first := false; repeat; } /* Subsequent interference reports shall match our expectations */ - [not first] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_interf_ind)) -> value sd { + [not first] as_pcuif_msg(msg, tr_interf_ind) { /* Check TDMA frame number period */ - if (sd.data.u.interf_ind.fn mod 104 != 0) { + if (msg.u.interf_ind.fn mod 104 != 0) { setverdict(fail, "Odd TDMA frame number := ", - sd.data.u.interf_ind.fn); + msg.u.interf_ind.fn); } interf_ind_num := interf_ind_num + 1; if (interf_ind_num < 4) { repeat; } } - [not first] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_INTERF_IND(0, 0))) -> value sd { - setverdict(fail, "Received unexpected interference report: ", sd.data); + [not first] as_pcuif_msg(msg, tr_PCUIF_INTERF_IND(0, 0)) { + setverdict(fail, "Received unexpected interference report: ", msg); } [] PCU.receive { repeat; } [] T.timeout { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33106 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iabefddd54a4a2e2183feea04fdb8526e74efc7ac Gerrit-Change-Number: 33106 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests.TC_pcu_data_ind_lqual_cb: remove lqual threshold
by fixeria 01 Jun '23

01 Jun '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33109 ) Change subject: BTS_Tests.TC_pcu_data_ind_lqual_cb: remove lqual threshold ...................................................................... BTS_Tests.TC_pcu_data_ind_lqual_cb: remove lqual threshold Since recently [1], osmo-bts does submit all PCUIF DATA.ind regardless of the Uplink link quality (C/I ratio in case of osmo-bts-trx). Change-Id: If801e9112c1207ccdc40f9e675c52fadccdd1411 Related: [1] osmo-bts.git I8f1856dd9061c1bfca8b15be30df7a51760231b0 --- M bts/BTS_Tests.ttcn 1 file changed, 20 insertions(+), 18 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 344be1f..5637f63 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -5944,23 +5944,22 @@ setverdict(pass); } -private function f_TC_pcu_data_ind_lqual_cb(int16_t lqual_cb_exp, int16_t thresh) +private function f_TC_pcu_data_ind_lqual_cb(int16_t lqual_cb_exp) runs on test_CT { var PCUIF_Message msg; - var int16_t lqual_cb; timer T := 1.0; L1CTL.clear; PCU.clear; /* Send a random Uplink block over the Um */ - f_TC_pcu_tx_ul_block_req('0000'O & f_rnd_octstring(21), tn := 7); + var octetstring data := '0000'O & f_rnd_octstring(21); + f_TC_pcu_tx_ul_block_req(data, tn := 7); T.start; alt { - /* If expected link quality is above the threshold */ - [lqual_cb_exp >= thresh] as_pcuif_msg(msg, tr_PCUIF_DATA_IND) { - lqual_cb := msg.u.data_ind.lqual_cb; + [] as_pcuif_msg(msg, tr_PCUIF_DATA_IND(data := data)) { + var integer lqual_cb := msg.u.data_ind.lqual_cb; log("Rx PCUIF_DATA.ind (lqual_cb=", lqual_cb, ")"); /* Make sure the actual link quality matches the expected value */ @@ -5971,18 +5970,9 @@ setverdict(pass); } } - /* If expected link quality is below the threshold */ - [lqual_cb_exp < thresh] as_pcuif_msg(msg, tr_PCUIF_DATA_IND) { - Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, - log2str("Rx unexpected PCUIF_DATA.ind: ", msg)); - } /* Ignore PCUIF_RTS.req and PCUIF_TIME.ind */ [] PCU.receive { repeat; } - [lqual_cb_exp < thresh] T.timeout { - log("Rx nothing, as expected"); - setverdict(pass); - } - [lqual_cb_exp >= thresh] T.timeout { + [] T.timeout { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for PCUIF_DATA.ind"); } @@ -6010,9 +6000,8 @@ ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, ts_TRXC_FAKE_CI(i)); - /* FIXME: OsmoBTS may have different threshold (see MIN_QUAL_NORM) */ log("Testing C/I=", i, " cB"); - f_TC_pcu_data_ind_lqual_cb(i, thresh := 0); + f_TC_pcu_data_ind_lqual_cb(i); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33109 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If801e9112c1207ccdc40f9e675c52fadccdd1411 Gerrit-Change-Number: 33109 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-ttcn3-hacks[master]: BTS_Tests: cosmetic: add as_pcuif_msg() for convenience
by fixeria 01 Jun '23

01 Jun '23

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33106 ) Change subject: BTS_Tests: cosmetic: add as_pcuif_msg() for convenience ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33106 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iabefddd54a4a2e2183feea04fdb8526e74efc7ac Gerrit-Change-Number: 33106 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Jun 2023 11:38:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests.TC_pcu_data_ind_lqual_cb: remove lqual threshold
by fixeria 01 Jun '23

01 Jun '23

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33109 ) Change subject: BTS_Tests.TC_pcu_data_ind_lqual_cb: remove lqual threshold ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33109 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If801e9112c1207ccdc40f9e675c52fadccdd1411 Gerrit-Change-Number: 33109 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Jun 2023 11:38:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: BTS_Tests.TC_pcu_data_ind_lqual_cb: properly send UL BLOCK.req
by fixeria 01 Jun '23

01 Jun '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33108 ) Change subject: BTS_Tests.TC_pcu_data_ind_lqual_cb: properly send UL BLOCK.req ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: re-applying CR+1 from Pau, combining. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If0fb615a4136a76a939588af0131ddcfb7acd877 Gerrit-Change-Number: 33108 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Jun 2023 11:38:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-remsim[master]: remsim_client: Fix custom ATR '-a' option
by fixeria 01 Jun '23

01 Jun '23

Attention is currently required from: laforge, daniel. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/33117 ) Change subject: remsim_client: Fix custom ATR '-a' option ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/33117 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I5deb0a432c05ab0bab5081a2812f6718d4a2ac33 Gerrit-Change-Number: 33117 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: steviehs <sskrodzki(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Jun 2023 10:30:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0