June 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-remsim[master]: remsim_client: Fix custom ATR '-a' option
by laforge 01 Jun '23

01 Jun '23

Attention is currently required from: daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/33117 ) Change subject: remsim_client: Fix custom ATR '-a' option ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/33117 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I5deb0a432c05ab0bab5081a2812f6718d4a2ac33 Gerrit-Change-Number: 33117 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: steviehs <sskrodzki(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Jun 2023 13:37:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: tests/{ctrl,vty}_test_runner.py: raise an exception if proc's rc != 0
by fixeria 01 Jun '23

01 Jun '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33140 ) Change subject: tests/{ctrl,vty}_test_runner.py: raise an exception if proc's rc != 0 ...................................................................... tests/{ctrl,vty}_test_runner.py: raise an exception if proc's rc != 0 Change-Id: I5fa3477979d41aef7b22464a925941ed0f115193 Depends: osmo-python-tests.git I1e11fcb6c5a587c27fc00920b6e157862d972fd9 Related: OS#5665 --- M tests/ctrl_test_runner.py M tests/vty_test_runner.py 2 files changed, 17 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/tests/ctrl_test_runner.py b/tests/ctrl_test_runner.py index e889992..7808426 100755 --- a/tests/ctrl_test_runner.py +++ b/tests/ctrl_test_runner.py @@ -63,7 +63,9 @@ def tearDown(self): self.disconnect() - osmoutil.end_proc(self.proc) + rc = osmoutil.end_proc(self.proc) + if rc is not None and rc != 0: + raise Exception("Process returned %d" % rc) def disconnect(self): if not (self.sock is None): diff --git a/tests/vty_test_runner.py b/tests/vty_test_runner.py index 34ddcc7..50bf6a0 100755 --- a/tests/vty_test_runner.py +++ b/tests/vty_test_runner.py @@ -65,7 +65,9 @@ if self.vty: self.vty._close_socket() self.vty = None - osmoutil.end_proc(self.proc) + rc = osmoutil.end_proc(self.proc) + if rc is not None and rc != 0: + raise Exception("Process returned %d" % rc) class TestVTYGenericBSC(TestVTYBase): -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33140 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5fa3477979d41aef7b22464a925941ed0f115193 Gerrit-Change-Number: 33140 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-bsc[master]: tests/{ctrl,vty}_test_runner.py: raise an exception if proc's rc != 0
by fixeria 01 Jun '23

01 Jun '23

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33140 ) Change subject: tests/{ctrl,vty}_test_runner.py: raise an exception if proc's rc != 0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33140 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5fa3477979d41aef7b22464a925941ed0f115193 Gerrit-Change-Number: 33140 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Jun 2023 13:37:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: tests/{ctrl,vty}_test_runner.py: raise an exception if proc's rc != 0
by fixeria 01 Jun '23

01 Jun '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33141 ) Change subject: tests/{ctrl,vty}_test_runner.py: raise an exception if proc's rc != 0 ...................................................................... tests/{ctrl,vty}_test_runner.py: raise an exception if proc's rc != 0 Change-Id: I4ed672d369bd379871a6a9fba5ff2da817e362d7 Depends: osmo-python-tests.git I1e11fcb6c5a587c27fc00920b6e157862d972fd9 Related: OS#5665 --- M tests/ctrl_test_runner.py M tests/vty_test_runner.py 2 files changed, 17 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/tests/ctrl_test_runner.py b/tests/ctrl_test_runner.py index d24cc00..16d1e7c 100755 --- a/tests/ctrl_test_runner.py +++ b/tests/ctrl_test_runner.py @@ -64,7 +64,9 @@ def tearDown(self): self.disconnect() - osmoutil.end_proc(self.proc) + rc = osmoutil.end_proc(self.proc) + if rc is not None and rc != 0: + raise Exception("Process returned %d" % rc) def disconnect(self): if not (self.sock is None): diff --git a/tests/vty_test_runner.py b/tests/vty_test_runner.py index 2421144..2dfa155 100755 --- a/tests/vty_test_runner.py +++ b/tests/vty_test_runner.py @@ -65,7 +65,9 @@ if self.vty: self.vty._close_socket() self.vty = None - osmoutil.end_proc(self.proc) + rc = osmoutil.end_proc(self.proc) + if rc is not None and rc != 0: + raise Exception("Process returned %d" % rc) class TestVTYMSC(TestVTYBase): -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33141 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I4ed672d369bd379871a6a9fba5ff2da817e362d7 Gerrit-Change-Number: 33141 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in ...osmo-python-tests[master]: osmoutil: return proc's return code from end_proc()
by fixeria 01 Jun '23

01 Jun '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/33139 ) Change subject: osmoutil: return proc's return code from end_proc() ...................................................................... osmoutil: return proc's return code from end_proc() Change-Id: I1e11fcb6c5a587c27fc00920b6e157862d972fd9 Related: OS#5665 --- M osmopy/osmoutil.py 1 file changed, 13 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/osmopy/osmoutil.py b/osmopy/osmoutil.py index ecd88f2..6ab16e7 100755 --- a/osmopy/osmoutil.py +++ b/osmopy/osmoutil.py @@ -42,9 +42,9 @@ If the process doesn't appear to exist (for instance, is None), do nothing""" -def end_proc(proc): +def end_proc(proc): # -> Optional[int] if not proc: - return + return None proc.terminate() time_to_wait_for_term = 5 @@ -70,6 +70,7 @@ print("Terminating took %.3fs" % waited_time) rc = proc.wait() print("Process returned code: %d" % rc) + return rc """Add a directory to sys.path, try to import a config file.""" -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/33139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: I1e11fcb6c5a587c27fc00920b6e157862d972fd9 Gerrit-Change-Number: 33139 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-msc[master]: tests/{ctrl,vty}_test_runner.py: raise an exception if proc's rc != 0
by laforge 01 Jun '23

01 Jun '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33141 ) Change subject: tests/{ctrl,vty}_test_runner.py: raise an exception if proc's rc != 0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33141 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I4ed672d369bd379871a6a9fba5ff2da817e362d7 Gerrit-Change-Number: 33141 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Jun 2023 13:34:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: tests/{ctrl,vty}_test_runner.py: raise an exception if proc's rc != 0
by laforge 01 Jun '23

01 Jun '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33140 ) Change subject: tests/{ctrl,vty}_test_runner.py: raise an exception if proc's rc != 0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33140 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5fa3477979d41aef7b22464a925941ed0f115193 Gerrit-Change-Number: 33140 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Jun 2023 13:33:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: libosmogsm: Support authentication with 256-bit K and/or OP/OPc
by laforge 01 Jun '23

01 Jun '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33087 ) Change subject: libosmogsm: Support authentication with 256-bit K and/or OP/OPc ...................................................................... Patch Set 5: (3 comments) File include/osmocom/crypt/auth.h: https://gerrit.osmocom.org/c/libosmocore/+/33087/comment/ac9ac0ef_d467dc6c PS4, Line 66: /* deprecated older structure without support for 32-byte K/OP[c] */ > BTW, you can attach `OSMO_DEPRECATED` to structures too. […] Done File src/gsm/auth_core.c: https://gerrit.osmocom.org/c/libosmocore/+/33087/comment/ff8bf97f_b8dd6093 PS4, Line 219: auth_data2auth_data2 > check return value? Done https://gerrit.osmocom.org/c/libosmocore/+/33087/comment/5f401068_72c33845 PS4, Line 285: auth_data2auth_data2 > check return value? Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie775fedba4a3fa12314c0f7c8a369662ef6a40df Gerrit-Change-Number: 33087 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Jun 2023 13:33:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: libosmogsm: Factor out the C2 derivation function
by laforge 01 Jun '23

01 Jun '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33092 ) Change subject: libosmogsm: Factor out the C2 derivation function ...................................................................... Patch Set 4: (2 comments) File src/gsm/auth_core.c: https://gerrit.osmocom.org/c/libosmocore/+/33092/comment/3d077674_ccf3807f PS4, Line 364: param[in] > missing param name (syntax error), please add `sres_deriv_func` Done https://gerrit.osmocom.org/c/libosmocore/+/33092/comment/8e92171c_0b1ab840 PS4, Line 372: memcpy(xres, res, res_len); > maybe do `OSMO_ASSERT(res_len <= sizeof(xres))` before calling `memcpy()`? […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33092 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0e7cd55f5578f891cb6cc1b0442920ba5beddae4 Gerrit-Change-Number: 33092 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Jun 2023 13:33:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: libosmogsm: Factor out the C2 derivation function
by laforge 01 Jun '23

01 Jun '23

Attention is currently required from: laforge. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/33092 to look at the new patch set (#5). Change subject: libosmogsm: Factor out the C2 derivation function ...................................................................... libosmogsm: Factor out the C2 derivation function 3GPP specifies the C2 derivation function (generating GSM SRES from UMTS XRES) independent of the MILENAGE algorithm. So instead of open-coding it in milenage.c:gsm_milenage(), let's create a separate public function osmo_auth_c2() similar to the already-existing osmo_auth_c3() function. gsm_milenage() can then simply use that function. Change-Id: I0e7cd55f5578f891cb6cc1b0442920ba5beddae4 --- M TODO-RELEASE M include/osmocom/crypt/auth.h M src/gsm/auth_core.c M src/gsm/libosmogsm.map M src/gsm/milenage/milenage.c 5 files changed, 49 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/92/33092/5 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33092 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0e7cd55f5578f891cb6cc1b0442920ba5beddae4 Gerrit-Change-Number: 33092 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0