June 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: BSSMAP_Templates: Add templates for UPLINK REQUEST
by pespin 01 Jun '23

01 Jun '23

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33148 ) Change subject: BSSMAP_Templates: Add templates for UPLINK REQUEST ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33148 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0b02be6a87899d5c9a2ef92011e09a8897328a05 Gerrit-Change-Number: 33148 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 01 Jun 2023 16:52:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: Add more parameters for ASCI tests to TestHdlrParams
by pespin 01 Jun '23

01 Jun '23

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33147 ) Change subject: Add more parameters for ASCI tests to TestHdlrParams ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: Let's please have this in the same commit where you actually use them. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33147 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5aaea5a92fcfa737624ef46b56dcfefb74266758 Gerrit-Change-Number: 33147 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 01 Jun 2023 16:50:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: Add codec list to *VGCS_VBS_AssignmentReq templates
by pespin 01 Jun '23

01 Jun '23

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33146 ) Change subject: Add codec list to *VGCS_VBS_AssignmentReq templates ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33146 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id3ce78ad795c418650ca924a953294c3380b8198 Gerrit-Change-Number: 33146 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 01 Jun 2023 16:50:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: BSSMAP_Templates: Add template to receive ChannelType IE
by pespin 01 Jun '23

01 Jun '23

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33145 ) Change subject: BSSMAP_Templates: Add template to receive ChannelType IE ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia6f283c17a1687ee65f8997bbeba0b09d1a462cf Gerrit-Change-Number: 33145 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 01 Jun 2023 16:49:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: BSSMAP_Templates: Add templates to receive CellID IE
by pespin 01 Jun '23

01 Jun '23

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33144 ) Change subject: BSSMAP_Templates: Add templates to receive CellID IE ...................................................................... Patch Set 1: (1 comment) File library/BSSMAP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33144/comment/af8d9e95_e914… PS1, Line 371: template BSSMAP_IE_CellIdentifier tr_CellId_CGI(hexstring mcc, hexstring mnc, BssmapLAC lac, BssmapCI ci) this looks really strange: a tr_* template having only value params, modifying another tr template, and the field inside in line 374 being a ts_* template. Sounds like you want params in line 371 to be "template (present) ...", and use a tr_* below in line 374. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33144 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I42d52d871c8011db7e0897dfe752afeefa6d9662 Gerrit-Change-Number: 33144 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 01 Jun 2023 16:49:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: Add RSL_Types for talker / listener detection
by pespin 01 Jun '23

01 Jun '23

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33143 ) Change subject: Add RSL_Types for talker / listener detection ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33143/comment/98668a23_cbb5… PS1, Line 7: Add RSL_Types for talker / listener detection not types, but templates. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibc936417fedf7dc663c6b7243090a91fc55c06a2 Gerrit-Change-Number: 33143 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 01 Jun 2023 16:45:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in osmocom-bb[master]: trxcon: get rid of the timer driven clock module
by pespin 01 Jun '23

01 Jun '23

Attention is currently required from: laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32575 ) Change subject: trxcon: get rid of the timer driven clock module ...................................................................... Patch Set 2: (3 comments) File src/host/trxcon/src/trx_if.c: https://gerrit.osmocom.org/c/osmocom-bb/+/32575/comment/2e884004_1a375bc8 PS2, Line 707: .fn = bi.fn, the trx_fn_advance may still make sense to be possible to apply it here? https://gerrit.osmocom.org/c/osmocom-bb/+/32575/comment/eeb00c21_8e774498 PS2, Line 711: trxcon_phyif_handle_rts_ind(trx->priv, &rts); does that mean that now if we don't receive DL data, we'll never to UL RTS.ind? Is that supposed to work because the BTS is expected to always send data? File src/host/trxcon/src/trxcon_main.c: https://gerrit.osmocom.org/c/osmocom-bb/+/32575/comment/b5451a18_8e6582d1 PS2, Line 244: XXX: no-op > TODO: print a no-op warning Ack -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32575 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic8a5b6277c6b16392026e0557376257d71c9d230 Gerrit-Change-Number: 32575 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Jun 2023 16:43:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: modem_atcmd: make card reset cards.py compatible
by dexter 01 Jun '23

01 Jun '23

Attention is currently required from: tobias. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33080 ) Change subject: modem_atcmd: make card reset cards.py compatible ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File pySim/transport/modem_atcmd.py: https://gerrit.osmocom.org/c/pysim/+/33080/comment/170b8f52_bb5aa2ff PS1, Line 39: self._atr = [] serial.py initializes this with None. Is there a specific reason to change this? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33080 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I79d0fc87919efae4ee89881b7840c0e809bd7918 Gerrit-Change-Number: 33080 Gerrit-PatchSet: 1 Gerrit-Owner: tobias <t-osmocom.org(a)tobias.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: tobias <t-osmocom.org(a)tobias.org> Gerrit-Comment-Date: Thu, 01 Jun 2023 16:08:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: serial: return a return code in reset_card()
by dexter 01 Jun '23

01 Jun '23

Attention is currently required from: tobias. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33152 ) Change subject: serial: return a return code in reset_card() ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I came across this while reviewing I79d0fc87919efae4ee89881b7840c0e809bd7918 - Since it only affects the serial transport code it is probably irrelevant these days. I also didn't test this. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33152 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I658dd6857580652696b4a77e7d6cfe5778f09eff Gerrit-Change-Number: 33152 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: tobias <t-osmocom.org(a)tobias.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: tobias <t-osmocom.org(a)tobias.org> Gerrit-Comment-Date: Thu, 01 Jun 2023 16:05:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: serial: return a return code in reset_card()
by dexter 01 Jun '23

01 Jun '23

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/33152 ) Change subject: serial: return a return code in reset_card() ...................................................................... serial: return a return code in reset_card() The method reset_card does not return a return code, while the coresponding pcsc implementation does return 1 on success. Change-Id: I658dd6857580652696b4a77e7d6cfe5778f09eff --- M pySim/transport/serial.py 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/52/33152/1 diff --git a/pySim/transport/serial.py b/pySim/transport/serial.py index 924df9e..3313a5e 100644 --- a/pySim/transport/serial.py +++ b/pySim/transport/serial.py @@ -104,6 +104,7 @@ raise NoCardError() elif rv < 0: raise ProtocolError() + return rv def _reset_card(self): self._atr = None -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33152 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I658dd6857580652696b4a77e7d6cfe5778f09eff Gerrit-Change-Number: 33152 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0