June 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bts[master]: osmo-bts-trx: alloc/free burst buffers in trx_sched_set_lchan()
by pespin 01 Jun '23

01 Jun '23

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31672 ) Change subject: osmo-bts-trx: alloc/free burst buffers in trx_sched_set_lchan() ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: this patch broke completely osmo-bts-trx + osmo-trx-uhd here. Please fix ASAP, or revert. I bisected the change since current master was in a situation where regular mobile phones were unable to find the network most of the time. Then, once it found it and it started using PDCH (using osmo-pcu master), I can see osmo-pcu receiving the same PKT CTRL ACK block in every new block.... -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31672 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6a5f76023fc492786076a63016f81285b3576c33 Gerrit-Change-Number: 31672 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Jun 2023 18:00:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: Log MS information in error message using usual MS API
by pespin 01 Jun '23

01 Jun '23

pespin has uploaded a new patch set (#3). ( https://gerrit.osmocom.org/c/osmo-pcu/+/33153 ) Change subject: Log MS information in error message using usual MS API ...................................................................... Log MS information in error message using usual MS API Also, drop duplicated TRX+TS info which is already displayed as part of LOGPDCH. Change-Id: I66211f4fa8a139ddd109623d90a926a53f180cfd --- M src/pdch.cpp 1 file changed, 15 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/53/33153/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33153 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I66211f4fa8a139ddd109623d90a926a53f180cfd Gerrit-Change-Number: 33153 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-pcu[master]: Log MS information in error message using usual MS API
by pespin 01 Jun '23

01 Jun '23

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-pcu/+/33153 ) Change subject: Log MS information in error message using usual MS API ...................................................................... Log MS information in error message using usual MS API Change-Id: I66211f4fa8a139ddd109623d90a926a53f180cfd --- M src/pdch.cpp 1 file changed, 10 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/53/33153/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33153 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I66211f4fa8a139ddd109623d90a926a53f180cfd Gerrit-Change-Number: 33153 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-pcu[master]: Log MS information in error message using usual MS API
by pespin 01 Jun '23

01 Jun '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33153 ) Change subject: Log MS information in error message using usual MS API ...................................................................... Log MS information in error message using usual MS API Change-Id: I66211f4fa8a139ddd109623d90a926a53f180cfd --- M src/pdch.cpp 1 file changed, 10 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/53/33153/1 diff --git a/src/pdch.cpp b/src/pdch.cpp index a8becca..b98a65d 100644 --- a/src/pdch.cpp +++ b/src/pdch.cpp @@ -350,13 +350,7 @@ ms = bts_get_ms_by_tlli(bts(), tlli, GSM_RESERVED_TMSI); if (ms) LOGPDCH(this, DRLCMAC, LOGL_NOTICE, "PACKET CONTROL ACK with " - "unknown TBF corresponds to MS with IMSI %s, TA %d, " - "uTBF (TFI=%d, state=%s), dTBF (TFI=%d, state=%s)\n", - ms_imsi(ms), ms_ta(ms), - ms_ul_tbf(ms) ? ms_ul_tbf(ms)->tfi() : 0, - ms_ul_tbf(ms) ? ms_ul_tbf(ms)->state_name() : "None", - ms_dl_tbf(ms) ? ms_dl_tbf(ms)->tfi() : 0, - ms_dl_tbf(ms) ? ms_dl_tbf(ms)->state_name() : "None"); + "unknown TBF corresponds to MS %s\n", ms_name(ms)); return; } OSMO_ASSERT(poll->tbf_poll.poll_tbf); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33153 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I66211f4fa8a139ddd109623d90a926a53f180cfd Gerrit-Change-Number: 33153 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-gprs[master]: gmm: Avoid submitting GMMSM-Release.ind if no session was requested
by pespin 01 Jun '23

01 Jun '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33113 ) Change subject: gmm: Avoid submitting GMMSM-Release.ind if no session was requested ...................................................................... gmm: Avoid submitting GMMSM-Release.ind if no session was requested Change-Id: I2fecfd122fc4be863be184f1ff08d9a31e07b956 --- M src/gmm/gmm_ms_fsm.c M tests/gmm/gmm_prim_test.ok 2 files changed, 12 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/gmm/gmm_ms_fsm.c b/src/gmm/gmm_ms_fsm.c index ff26dfa..770ede7 100644 --- a/src/gmm/gmm_ms_fsm.c +++ b/src/gmm/gmm_ms_fsm.c @@ -97,8 +97,9 @@ gprs_gmm_gmme_t3312_stop(ctx->gmme); gprs_gmm_gmme_t3316_stop(ctx->gmme); - /* TS 24.007 9.5.1.4: informs SM layerthat the MS has been GPRS detached, e.g. by timer expiry */ - if (prev_state != GPRS_GMM_MS_ST_NULL) + /* TS 24.007 9.5.1.4: informs SM layer that the MS has been GPRS detached, e.g. by timer expiry */ + if (prev_state != GPRS_GMM_MS_ST_NULL && + ctx->gmme->sess_id != GPRS_GMM_SESS_ID_UNASSIGNED) gprs_gmm_submit_gmmsm_release_ind(ctx->gmme); } diff --git a/tests/gmm/gmm_prim_test.ok b/tests/gmm/gmm_prim_test.ok index 2ff27f6..6cf672a 100644 --- a/tests/gmm/gmm_prim_test.ok +++ b/tests/gmm/gmm_prim_test.ok @@ -23,7 +23,6 @@ test_gmm_prim_llc_down_cb(): Rx LL-UNITDATA.request TLLI=0xec999002 SAPI=GMM l3=[08 05 20 0a 00 05 f4 ec 99 90 02 ] test_gmm_prim_llc_down_cb(): Rx LLGMM-ASSIGN.request old_TLLI=0xec999002 new_TLLI=0xffffffff test_gmm_prim_up_cb(): Rx GMMREG-DETACH.confirm detach_type='GPRS detach' -test_gmm_prim_up_cb(): Rx GMMSM-RELEASE.indication sess_id=4294967295 ==== test_gmm_prim_ms_gmmreg() [end] ==== ==== test_gmm_prim_ms_gmmsm() [start] ==== sys={0.000000}, mono={0.000000}: clock_override_set -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33113 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I2fecfd122fc4be863be184f1ff08d9a31e07b956 Gerrit-Change-Number: 33113 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in libosmo-gprs[master]: sm: Handle GMMSM-Release.ind
by pespin 01 Jun '23

01 Jun '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33112 ) Change subject: sm: Handle GMMSM-Release.ind ...................................................................... sm: Handle GMMSM-Release.ind Change-Id: Ia2ac9dbffe29c3509f1088ceb327569a331ec598 --- M include/osmocom/gprs/sm/sm_ms_fsm.h M include/osmocom/gprs/sm/sm_prim.h M src/sm/sm_ms_fsm.c M src/sm/sm_prim.c 4 files changed, 54 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/include/osmocom/gprs/sm/sm_ms_fsm.h b/include/osmocom/gprs/sm/sm_ms_fsm.h index d1d4689..2ea9bd8 100644 --- a/include/osmocom/gprs/sm/sm_ms_fsm.h +++ b/include/osmocom/gprs/sm/sm_ms_fsm.h @@ -29,6 +29,7 @@ GPRS_SM_MS_EV_TX_MOD_PDP_CTX_REQ, GPRS_SM_MS_EV_RX_MOD_PDP_CTX_REJ, GPRS_SM_MS_EV_RX_MOD_PDP_CTX_ACC, + GPRS_SM_MS_EV_GMM_RELEASE_IND, /* TS 24.007 9.5.1.4 GMMSM-RELEASE-IND */ }; struct gprs_sm_ms_fsm_ctx { diff --git a/include/osmocom/gprs/sm/sm_prim.h b/include/osmocom/gprs/sm/sm_prim.h index d4e17a4..127dd35 100644 --- a/include/osmocom/gprs/sm/sm_prim.h +++ b/include/osmocom/gprs/sm/sm_prim.h @@ -128,7 +128,7 @@ uint8_t pco[OSMO_GPRS_SM_PCO_MAXLEN]; uint8_t pco_len; /* TODO: MBMS protocol configuration options*/ - } deact_req; + } pdp_deact_req; /* OSMO_GPRS_SM_SMREG_PDP_DEACTIVATE | Cnf, 6.5.1.6 */ @@ -138,7 +138,7 @@ uint8_t pco[OSMO_GPRS_SM_PCO_MAXLEN]; uint8_t pco_len; /* TODO: MBMS protocol configuration options*/ - } deact_cnf; + } pdp_deact_cnf; /* OSMO_GPRS_SM_SMREG_PDP_DEACTIVATE | Ind, 6.5.1.7 */ struct { @@ -149,7 +149,7 @@ uint8_t pco[OSMO_GPRS_SM_PCO_MAXLEN]; uint8_t pco_len; /* TODO: MBMS protocol configuration options */ - } deact_ind; + } pdp_deact_ind; /* OSMO_GPRS_SM_SMREG_PDP_MODIFY | Ind, 6.5.1.8 */ struct { diff --git a/src/sm/sm_ms_fsm.c b/src/sm/sm_ms_fsm.c index aaaa008..dc063b9 100644 --- a/src/sm/sm_ms_fsm.c +++ b/src/sm/sm_ms_fsm.c @@ -98,6 +98,9 @@ sm_ms_fsm_state_chg(fi, GPRS_SM_MS_ST_PDP_ACTIVE); gprs_sm_submit_smreg_pdp_act_cnf(ctx->sme, (enum gsm48_gsm_cause)0); break; + case GPRS_SM_MS_EV_GMM_RELEASE_IND: + sm_ms_fsm_state_chg(fi, GPRS_SM_MS_ST_PDP_INACTIVE); + break; default: OSMO_ASSERT(0); } @@ -116,6 +119,9 @@ case GPRS_SM_MS_EV_TX_MOD_PDP_CTX_REQ: sm_ms_fsm_state_chg(fi, GPRS_SM_MS_ST_PDP_MODIFY_PENDING); break; + case GPRS_SM_MS_EV_GMM_RELEASE_IND: + sm_ms_fsm_state_chg(fi, GPRS_SM_MS_ST_PDP_INACTIVE); + break; default: OSMO_ASSERT(0); } @@ -134,6 +140,9 @@ case GPRS_SM_MS_EV_RX_MOD_PDP_CTX_ACC: sm_ms_fsm_state_chg(fi, GPRS_SM_MS_ST_PDP_ACTIVE); break; + case GPRS_SM_MS_EV_GMM_RELEASE_IND: + sm_ms_fsm_state_chg(fi, GPRS_SM_MS_ST_PDP_INACTIVE); + break; default: OSMO_ASSERT(0); } @@ -145,6 +154,9 @@ case GPRS_SM_MS_EV_RX_DEACT_PDP_CTX_ACC: sm_ms_fsm_state_chg(fi, GPRS_SM_MS_ST_PDP_INACTIVE); break; + case GPRS_SM_MS_EV_GMM_RELEASE_IND: + sm_ms_fsm_state_chg(fi, GPRS_SM_MS_ST_PDP_INACTIVE); + break; default: OSMO_ASSERT(0); } @@ -201,7 +213,8 @@ X(GPRS_SM_MS_EV_RX_GMM_ESTABLISH_REJ) | X(GPRS_SM_MS_EV_RX_ACT_PDP_CTX_REJ) | X(GPRS_SM_MS_EV_RX_ACT_PDP_CTX_ACC) | - X(GPRS_SM_MS_EV_NSAPI_ACTIVATED), + X(GPRS_SM_MS_EV_NSAPI_ACTIVATED) | + X(GPRS_SM_MS_EV_GMM_RELEASE_IND), .out_state_mask = X(GPRS_SM_MS_ST_PDP_INACTIVE) | X(GPRS_SM_MS_ST_PDP_ACTIVE_PENDING) | @@ -214,7 +227,8 @@ .in_event_mask = X(GPRS_SM_MS_EV_RX_DEACT_PDP_CTX_REQ) | X(GPRS_SM_MS_EV_TX_DEACT_PDP_CTX_REQ)| - X(GPRS_SM_MS_EV_TX_MOD_PDP_CTX_REQ), + X(GPRS_SM_MS_EV_TX_MOD_PDP_CTX_REQ) | + X(GPRS_SM_MS_EV_GMM_RELEASE_IND), .out_state_mask = X(GPRS_SM_MS_ST_PDP_INACTIVE) | X(GPRS_SM_MS_ST_PDP_INACTIVE_PENDING) | @@ -226,7 +240,8 @@ .in_event_mask = X(GPRS_SM_MS_EV_RX_DEACT_PDP_CTX_REQ) | X(GPRS_SM_MS_EV_RX_MOD_PDP_CTX_REJ) | - X(GPRS_SM_MS_EV_RX_MOD_PDP_CTX_ACC), + X(GPRS_SM_MS_EV_RX_MOD_PDP_CTX_ACC) | + X(GPRS_SM_MS_EV_GMM_RELEASE_IND), .out_state_mask = X(GPRS_SM_MS_ST_PDP_INACTIVE) | X(GPRS_SM_MS_ST_PDP_ACTIVE) | @@ -236,7 +251,8 @@ }, [GPRS_SM_MS_ST_PDP_INACTIVE_PENDING] = { .in_event_mask = - X(GPRS_SM_MS_EV_RX_DEACT_PDP_CTX_ACC), + X(GPRS_SM_MS_EV_RX_DEACT_PDP_CTX_ACC) | + X(GPRS_SM_MS_EV_GMM_RELEASE_IND), .out_state_mask = X(GPRS_SM_MS_ST_PDP_INACTIVE), .name = "PDP_INACTIVE_PENDING", @@ -257,6 +273,7 @@ { GPRS_SM_MS_EV_TX_MOD_PDP_CTX_REQ, "TX_MOD_PDP_CTX_REQ" }, { GPRS_SM_MS_EV_RX_MOD_PDP_CTX_REJ, "RX_MOD_PDP_CTX_REJ" }, { GPRS_SM_MS_EV_RX_MOD_PDP_CTX_ACC, "RX_MOD_PDP_CTX_ACC" }, + { GPRS_SM_MS_EV_GMM_RELEASE_IND, "GMM_RELEASE_IND"}, { 0, NULL } }; diff --git a/src/sm/sm_prim.c b/src/sm/sm_prim.c index 158959e..b513aa7 100644 --- a/src/sm/sm_prim.c +++ b/src/sm/sm_prim.c @@ -493,6 +493,23 @@ return rc; } +/* TS 24.007 9.5.1.2 GMMSM-RELEASE-IND */ +static int gprs_sm_prim_handle_gmmsm_release_ind(struct osmo_gprs_gmm_prim *gmm_prim) +{ + struct osmo_gprs_gmm_gmmsm_prim *gmmsm = &gmm_prim->gmmsm; + struct gprs_sm_entity *sme; + int rc; + + sme = gprs_sm_find_sme_by_sess_id(gmmsm->sess_id); + if (!sme) { + LOGSM(LOGL_ERROR, "Rx GMMSM-RELEASE.ind for non existing SM Entity sess_id=%u\n", gmmsm->sess_id); + return -EINVAL; + } + rc = osmo_fsm_inst_dispatch(sme->ms_fsm.fi, GPRS_SM_MS_EV_GMM_RELEASE_IND, NULL); + + return rc; +} + /* TS 24.007 9.5.1.6 GMMSM-UNITDATA-IND */ static int gprs_sm_prim_handle_gmmsm_unitdata_ind(struct osmo_gprs_gmm_prim *gmm_prim) { @@ -520,6 +537,9 @@ case OSMO_PRIM(OSMO_GPRS_GMM_GMMSM_ESTABLISH, PRIM_OP_CONFIRM): rc = gprs_sm_prim_handle_gmmsm_establish_cnf(gmm_prim); break; + case OSMO_PRIM(OSMO_GPRS_GMM_GMMSM_RELEASE, PRIM_OP_INDICATION): + rc = gprs_sm_prim_handle_gmmsm_release_ind(gmm_prim); + break; case OSMO_PRIM(OSMO_GPRS_GMM_GMMSM_UNITDATA, PRIM_OP_INDICATION): rc = gprs_sm_prim_handle_gmmsm_unitdata_ind(gmm_prim); break; -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33112 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ia2ac9dbffe29c3509f1088ceb327569a331ec598 Gerrit-Change-Number: 33112 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-gprs[master]: gmm: Avoid submitting GMMSM-Release.ind if no session was requested
by pespin 01 Jun '23

01 Jun '23

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33113 ) Change subject: gmm: Avoid submitting GMMSM-Release.ind if no session was requested ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33113 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I2fecfd122fc4be863be184f1ff08d9a31e07b956 Gerrit-Change-Number: 33113 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Jun 2023 17:02:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmo-gprs[master]: sm: Handle GMMSM-Release.ind
by pespin 01 Jun '23

01 Jun '23

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33112 ) Change subject: sm: Handle GMMSM-Release.ind ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33112 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ia2ac9dbffe29c3509f1088ceb327569a331ec598 Gerrit-Change-Number: 33112 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Jun 2023 17:02:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmo-ttcn3-hacks[master]: Added BSC tests for terminating voice group calls
by pespin 01 Jun '23

01 Jun '23

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150 ) Change subject: Added BSC tests for terminating voice group calls ...................................................................... Patch Set 1: (7 comments) File bsc/BSC_Tests_ASCI.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/ab8cbccf_e46e… PS1, Line 38: const charstring VGCS_CALL_EST := "VGCS_CALL_EST"; what about prefixing them with COORD_ or VGCS_COORD_MSG to quicjlt understand those are coordination messages? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/5bff433a_e691… PS1, Line 98: var boolean uplink_free := false; I have the feeling you actually want to have some sort of enum containing states, and then update the stat einstead of having N booleans. Furthermore, you can add conditions to the alt step to limit where those messages are expected based on that state value (between the [] in each alt step). https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/80f5d964_4ea5… PS1, Line 106: if (true) { /* VGCS/VBS ASS REQ in SCCP CR */ sounds like this needs fixing ;) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/bd0ab794_52d2… PS1, Line 187: [] T.timeout { iiuc the timeout happens at the end, so you can move all this code block after the alt? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/34556ca2_1ca2… PS1, Line 382: f_sleep(2.0); why is this needed? it shouldn't? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/73465db8_86ce… PS1, Line 494: f_sleep(1.0); check all this sleeps, I don't see a need for them? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/ad5af8f7_bfd9… PS1, Line 507: connect(call_conn:COORD, chan_conn:COORD); smells like race condition if this connect takes to much and some of them already sent a message. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6762e8adfb7d5f77df837c698ff70cd7fd715ffe Gerrit-Change-Number: 33150 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 01 Jun 2023 17:01:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: Fixes for I949f731de794b22292b01d0ddf9a75a9e7e7e71d
by pespin 01 Jun '23

01 Jun '23

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33149 ) Change subject: Fixes for I949f731de794b22292b01d0ddf9a75a9e7e7e71d ...................................................................... Patch Set 1: Code-Review-2 (1 comment) Patchset: PS1: That patch has not been merged yet. Please fixup the original commit and resubmit. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33149 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I147454b10c8f3127172ae84dd31003a7d299f24c Gerrit-Change-Number: 33149 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 01 Jun 2023 16:53:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0